Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
clean-platform
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • clean-and-itasks
  • clean-platform
  • Merge Requests
  • !262

Merged
Opened Aug 06, 2019 by Camil Staps@cstaps🚀Owner3 of 3 tasks completed3/3 tasks

Don't let Text.GenJSON mess up UTF-8 strings

  • Overview 8
  • Commits 2
  • Pipelines 4
  • Changes 2

Closes #69 (closed)

If I understand the spec correctly, UTF-8 sequences are either a single printable ASCII character or a sequence of only non-printable non-control ASCII characters. So we can safely escape control characters without worrying that they can occur in a UTF-8 sequence.

To do:

  • Check that iTasks doesn't rely on being able to transmit binary data in JSON (→ iTasks-SDK!294 (merged)).
  • Update documentation.
  • Try if a separate constructor next to JSONString which is guaranteed to not need escaping speeds up encoding significantly. This could be used in places where the data has already been encoded, for example with base64.
Edited Aug 07, 2019 by Camil Staps
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: clean-and-itasks/clean-platform!262
Source branch: 69-json-and-utf-8

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.