Verified Commit 7bc70f42 authored by Camil Staps's avatar Camil Staps
Browse files

Don't redirect compiler stderr to stdout on Windows

It is not clear to me why this would be useful, except a slight
performance enhancement because you need one less thread. This causes a
problem in `testproperties`, which calls `clm` and passes stdout and
stderr through. When `testproperties` is called by `cleantest`,
`cleantest` expects only JSON test events on stdout, while stderr may be
used for warnings. So if the compiler warnings are all on stderr and clm
provides no extra output on stdout (as is the case after this commit),
the `cleantest` user will get information about compilation
errors/warnings while the tests continue to work.
parent a41dee14
Pipeline #45965 passed with stage
in 47 seconds
......@@ -1512,7 +1512,7 @@ static int start_compiler_process
int r;
int redirect_stderr_to_stdout;
redirect_stderr_to_stdout = 1;
redirect_stderr_to_stdout = 0;
a process cannot inherit a console handle on windows, therefore we create copies using pipes
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment