Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
I
iTasks-SDK
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 83
    • Issues 83
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • clean-and-itasks
  • iTasks-SDK
  • Merge Requests
  • !533

Merged
Opened Jan 05, 2021 by Camil Staps@cstaps🚀Owner

Fix MemoryLeaks test

  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 1

Previously, we measured the size of the entire IWorld to check if memory usage increased. This gives flaky results, because it includes share names. Share names in these examples include TaskIds, which are incremented, so slowly the share names become bigger. Using copy_to_string, strings are padded to 4 or 8 bytes, depending on the platform (32-bit or 64-bit). Because the share names also include the path, the tests could fail on some systems in some paths, but not on others (although the tests were always more likely to fail on 32-bit systems).

With this commit, we measure the size of the share values ignoring their names. Because Map is fully strict, the fold does not alter evaluation order and this is safe.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: clean-and-itasks/iTasks-SDK!533
Source branch: fix-memoryleaks-test

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.