I now see this is probably not enough. Since you still need to link libsodium explicitly, and if you do that, you can also point to it's include files, and this change doesn´t really add much.
Hans Harmannij (6bc0c68f) at 01 Sep 16:25
Merge branch 'remove-external-sodium-dependency'
... and 2 more commits
This merge requests makes sure that not only libpepcli, but also the libpep library and the header files are installed by cmake --install
Hans Harmannij (13ab5171) at 30 Aug 15:47
Install library and header files
This merge requests moves some implementation details to the cpp, such that we no longer need to include sodium/crypto_hash_sha512.h
in the header file.
It now allocates the sha512 context on the heap, instead of the stack. Not calling _SHA512Final
, will result in the context not being cleaned up, and thus a memory leak. But I think that's OK, since the _SHA512Init, and _SHA512Final functions are not part of the public API, and we only use them in one place, were both of them are called. It also wouldn't make sense to call _SHA512Init without calling _SHA512Final, so I don't expect errors with this in the future.
Hans Harmannij (c26a3934) at 30 Aug 12:11
Remove the sha512 libsodium include from base.h