Merge branch 'feature/sentry-integration' into 'master'

Add Sentry React Native SDK

See merge request !181

.babelrc

 {
-  "presets": ["react-native"],
+  "presets": ["react-native", "module:react-native-dotenv"],
   "plugins": ["@babel/plugin-proposal-object-rest-spread", "@babel/transform-regenerator"]
 }
\ No newline at end of file

.gitignore

@@ -60,3 +60,5 @@ buck-out/
 *.jsbundle
 
 bundle.js
+sentry.properties
+.env
\ No newline at end of file

.gitlab-ci.yml

@@ -61,6 +61,8 @@ build android:
           - $CI_PROJECT_DIR/.gradle/wrapper/
           - $CI_PROJECT_DIR/.gradle/caches/
     script:
+        - echo $SENTRY_PROPS | base64 -d > ./android/sentry.properties
+        - echo $PROD_ENV | base64 -d > .env
         - cd $CI_PROJECT_DIR/android/
         - ./gradlew --no-daemon ":app:assemble"
     artifacts:

__tests__/sagas/login.spec.js

@@ -3,6 +3,7 @@ import * as matchers from 'redux-saga-test-plan/matchers';
 import { throwError } from 'redux-saga-test-plan/providers';
 import Snackbar from 'react-native-snackbar';
 import { AsyncStorage } from 'react-native';
+import { Sentry } from 'react-native-sentry';
 
 import loginSaga, { DISPLAYNAMEKEY, PHOTOKEY, TOKENKEY, USERNAMEKEY } from '../../app/sagas/login';
 import { apiRequest } from '../../app/utils/url';
@@ -27,6 +28,13 @@ jest.mock('../../app/utils/url', () => ({
   tokenSelector: () => 'token',
 }));
 
+jest.mock('react-native-sentry', () => ({
+  Sentry: {
+    setUserContext: () => {},
+    captureException: () => {},
+  },
+}));
+
 describe('login saga', () => {
   const error = new Error('error');
 
@@ -42,6 +50,7 @@ describe('login saga', () => {
     it('should put the result data when the request succeeds', () => expectSaga(loginSaga)
       .provide([
         [matchers.call.like({ fn: apiRequest, args: ['token-auth'] }), { token: 'abc123' }],
+        [matchers.call.like({ fn: Sentry.setUserContext }), {}],
       ])
       .put(loginActions.success('username', 'abc123'))
       .put(loginActions.profile('abc123'))
@@ -51,6 +60,7 @@ describe('login saga', () => {
     it('should show a snackbar when the request succeeds', () => expectSaga(loginSaga)
       .provide([
         [matchers.call.like({ fn: apiRequest, args: ['token-auth'] }), { token: 'abc123' }],
+        [matchers.call.like({ fn: Sentry.setUserContext }), {}],
       ])
       .dispatch(loginActions.login('username', 'password'))
       .silentRun()
@@ -64,6 +74,7 @@ describe('login saga', () => {
       expectSaga(loginSaga)
       .provide([
         [matchers.call.like({ fn: apiRequest, args: ['token-auth'] }), { token: 'abc123' }],
+        [matchers.call.like({ fn: Sentry.setUserContext }), {}],
       ])
       .dispatch(loginActions.login('username', 'password'))
       .silentRun()

android/app/build.gradle

@@ -78,6 +78,8 @@ project.ext.react = [
 ]
 
 apply from: "../../node_modules/react-native/react.gradle"
+// Disabled because of https://github.com/getsentry/react-native-sentry/issues/326
+// apply from: "../../node_modules/react-native-sentry/sentry.gradle"
 
 /**
  * Set this to true to create two separate APKs instead of one:
@@ -145,6 +147,7 @@ android {
 }
 
 dependencies {
+    implementation project(':react-native-sentry')
     implementation project(':react-native-locale-detector')
     implementation project(':react-native-vector-icons')
     implementation project(':react-native-snackbar')

android/app/src/main/java/com/thaliapp/MainApplication.java

@@ -3,6 +3,7 @@ package com.thaliapp;
 import android.app.Application;
 
 import com.facebook.react.ReactApplication;
+import io.sentry.RNSentryPackage;
 import com.azendoo.reactnativesnackbar.SnackbarPackage;
 import com.i18n.reactnativei18n.ReactNativeI18n;
 import com.evollu.react.fcm.FIRMessagingPackage;
@@ -28,6 +29,7 @@ public class MainApplication extends Application implements ReactApplication {
     protected List<ReactPackage> getPackages() {
       return Arrays.<ReactPackage>asList(
             new MainReactPackage(),
+            new RNSentryPackage(),
             new SnackbarPackage(),
             new ReactNativeI18n(),
             new FIRMessagingPackage(),

android/settings.gradle

 rootProject.name = 'ThaliApp'
+include ':react-native-sentry'
+project(':react-native-sentry').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-sentry/android')
 include ':react-native-snackbar'
 project(':react-native-snackbar').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-snackbar/android')
 include ':react-native-locale-detector'

app/sagas/calendar.js

 import {
   call, put, select, takeEvery,
 } from 'redux-saga/effects';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest, tokenSelector } from '../utils/url';
 import * as navigationActions from '../actions/navigation';
@@ -30,10 +31,11 @@ const calendar = function* calendar() {
         partner: true,
       }));
     } catch (error) {
-      // Swallow the error
+      Sentry.captureException(error);
     }
     yield put(calendarActions.success(events.concat(partnerEvents)));
   } catch (error) {
+    Sentry.captureException(error);
     yield put(calendarActions.failure());
   }
 };

app/sagas/event.js

 import {
   call, put, takeEvery, select,
 } from 'redux-saga/effects';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest, tokenSelector } from '../utils/url';
 import * as eventActions from '../actions/event';
@@ -36,6 +37,7 @@ const event = function* event(action) {
       eventRegistrations,
     ));
   } catch (error) {
+    Sentry.captureException(error);
     yield put(eventActions.failure());
   }
 };

app/sagas/login.js

 import { call, takeEvery, put } from 'redux-saga/effects';
 import { AsyncStorage } from 'react-native';
 import Snackbar from 'react-native-snackbar';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest } from '../utils/url';
 import * as loginActions from '../actions/login';
@@ -78,15 +79,22 @@ const profile = function* profile(action) {
     ]);
     yield put(loginActions.profileSuccess(userProfile.display_name, userProfile.avatar.medium));
   } catch (error) {
+    Sentry.captureException(error);
     // Swallow error
   }
 };
 
+function* success({ payload }) {
+  const { username } = payload;
+  yield call(Sentry.setUserContext, { username });
+}
+
 const loginSaga = function* loginSaga() {
   yield takeEvery(loginActions.LOGIN, login);
   yield takeEvery(loginActions.LOGOUT, logout);
   yield takeEvery(loginActions.PROFILE, profile);
   yield takeEvery(loginActions.TOKEN_INVALID, tokenInvalid);
+  yield takeEvery(loginActions.SUCCESS, success);
 };
 
 export default loginSaga;

app/sagas/members.js

@@ -2,6 +2,7 @@ import { Dimensions } from 'react-native';
 import {
   call, put, select, takeEvery,
 } from 'redux-saga/effects';
+import { Sentry } from 'react-native-sentry';
 
 import { TOTAL_BAR_HEIGHT } from '../ui/components/standardHeader/style/StandardHeader';
 import { memberSize } from '../ui/screens/memberList/style/MemberList';
@@ -38,6 +39,7 @@ const members = function* members(action) {
     const response = yield call(apiRequest, 'members', data, params);
     yield put(memberActions.success(response.results, response.next, keywords));
   } catch (error) {
+    Sentry.captureException(error);
     yield put(memberActions.failure());
   }
 };
@@ -61,6 +63,7 @@ const more = function* more(action) {
     const responseJson = yield fetch(url, data).then(response => response.json());
     yield put(memberActions.moreSuccess(responseJson.results, responseJson.next));
   } catch (error) {
+    Sentry.captureException(error);
     yield put(memberActions.moreSuccess([], null));
   }
 };

app/sagas/pizza.js

 import {
   call, put, takeEvery, select,
 } from 'redux-saga/effects';
+import { Sentry } from 'react-native-sentry';
 import { apiRequest, tokenSelector } from '../utils/url';
 
 import * as pizzaActions from '../actions/pizza';
@@ -33,6 +34,7 @@ const retrievePizzaInfo = function* retrievePizzaInfo() {
       if (error.response !== null && error.response.status === NOT_FOUND) {
         yield put(pizzaActions.success(event, null, pizzaList));
       } else {
+        Sentry.captureException(error);
         yield put(pizzaActions.failure());
       }
     }
@@ -40,6 +42,7 @@ const retrievePizzaInfo = function* retrievePizzaInfo() {
     if (error.response !== null && error.response.status === NOT_FOUND) {
       yield put(pizzaActions.success(null, null, []));
     } else {
+      Sentry.captureException(error);
       yield put(pizzaActions.failure());
     }
   }
@@ -60,6 +63,7 @@ const cancel = function* cancel() {
     yield call(apiRequest, 'pizzas/orders/me', data);
     yield put(pizzaActions.cancelSuccess());
   } catch (error) {
+    Sentry.captureException(error);
     yield put(pizzaActions.failure());
   }
 };
@@ -84,6 +88,7 @@ const order = function* order(action) {
     const orderData = yield call(apiRequest, route, data);
     yield put(pizzaActions.orderSuccess(orderData));
   } catch (error) {
+    Sentry.captureException(error);
     yield put(pizzaActions.failure());
   }
 };

app/sagas/profile.js

 import { call, put, takeEvery } from 'redux-saga/effects';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest } from '../utils/url';
 import * as profileActions from '../actions/profile';
@@ -23,6 +24,7 @@ const profile = function* profile(action) {
     const profileData = yield call(apiRequest, `members/${member}`, data);
     yield put(profileActions.success(profileData));
   } catch (error) {
+    Sentry.captureException(error);
     yield put(profileActions.failure());
   }
 };

app/sagas/pushNotifications.js

 import { call, takeEvery, select } from 'redux-saga/effects';
 import { Platform } from 'react-native';
 import FCM from 'react-native-fcm';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest, tokenSelector } from '../utils/url';
 import * as pushNotificationsActions from '../actions/pushNotifications';
@@ -43,6 +44,7 @@ const register = function* register() {
   try {
     yield call(apiRequest, 'devices', data);
   } catch (err) {
+    Sentry.captureException(err);
     // eat error, om nom nom
   }
 };

app/sagas/registration.js

@@ -3,6 +3,7 @@ import {
   call, put, select, takeEvery,
 } from 'redux-saga/effects';
 import Snackbar from 'react-native-snackbar';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest, tokenSelector } from '../utils/url';
 
@@ -38,6 +39,7 @@ const register = function* register(action) {
     }
     Snackbar.show({ title: 'Registration successful!' });
   } catch (error) {
+    Sentry.captureException(error);
     yield put(eventActions.failure());
   }
 };
@@ -71,6 +73,7 @@ const update = function* update(action) {
     yield delay(50);
     Snackbar.show({ title: 'Successfully updated registration' });
   } catch (error) {
+    Sentry.captureException(error);
     yield put(registrationActions.failure());
   }
 };
@@ -95,6 +98,7 @@ const cancel = function* cancel(action) {
     yield call(apiRequest, `registrations/${registration}`, data);
     Snackbar.show({ title: 'Successfully cancelled registration' });
   } catch (error) {
+    Sentry.captureException(error);
     // Swallow error for now
   }
 
@@ -122,6 +126,7 @@ const fields = function* fields(action) {
     yield put(registrationActions.showFields(registration, response.fields));
     yield put(eventActions.done());
   } catch (error) {
+    Sentry.captureException(error);
     yield put(eventActions.failure());
   }
 };

app/sagas/welcome.js

 import {
   call, put, select, takeEvery,
 } from 'redux-saga/effects';
+import { Sentry } from 'react-native-sentry';
 
 import { apiRequest, tokenSelector } from '../utils/url';
 import * as welcomeActions from '../actions/welcome';
@@ -29,6 +30,7 @@ const welcome = function* welcome() {
     if (error.name === 'TokenInvalidError') {
       yield put(loginActions.tokenInvalid());
     }
+    Sentry.captureException(error);
     yield put(welcomeActions.failure());
   }
 };

index.js

 import { AppRegistry } from 'react-native';
+import { Sentry } from 'react-native-sentry';
+import { SENTRY_DSN } from 'react-native-dotenv';
 import App from './app/app';
 
+Sentry.config(SENTRY_DSN).install();
+
 AppRegistry.registerComponent('ThaliApp', () => App);

ios/BuddyBuildSDK.framework/Headers/BuddyBuildSDK.h

-//  Copyright (c) 2015 Doe Pics Hit, Inc. All rights reserved.
-
-#import <Foundation/Foundation.h>
-#import <UIKit/UIApplication.h>
-
-typedef NSString*(^BBReturnNSStringCallback)(void);
-typedef BOOL (^BBReturnBooleanCallback)(void);
-typedef void (^BBCallback)(void);
-
-@interface BuddyBuildSDK : NSObject
-
-// Deprecated
-+ (void)setup:(id<UIApplicationDelegate>)bbAppDelegate;
-
-/**
- * Initialize the SDK
- *
- * This should be called at (or near) the start of the appdelegate
- */
-+ (void)setup;
-
-/*
- * Associate arbitrary key/value pairs with your crash reports and user feedback
- * which will be visible from the buddybuild dashboard
- */
-+ (void)setMetadataObject:(id)object forKey:(NSString*)key;
-
-/*
- * Programatically trigger the screenshot feedback UI without pressing the screenshot buttons
- * If you have screenshot feedback disabled through the buddybuild setting,
- * you can still trigger it by calling this method
- */
-
-+ (void)takeScreenshotAndShowFeedbackScreen;
-
-/*
- * If you distribute a build to someone with their email address, buddybuild can
- * figure out who they are and attach their info to feedback and crash reports.
- *
- * However, if you send out a build to a mailing list, or through TestFlight or
- * the App Store we are unable to infer who they are. If you see 'Unknown User'
- * this is likely the cause.
- 
- * Often you'll know the identity of your user, for example, after they've
- * logged in. You can provide buddybuild a callback to identify the current user.
- */
-
-+ (void)setUserDisplayNameCallback:(BBReturnNSStringCallback)bbCallback;
-
-/*
- * You might have API keys and other secrets that your app needs to consume.
- * However, you may not want to check these secrets into the source code.
- *
- * You can provide your secrets to buddybuild. Buddybuild can then expose them
- * to you at build time through environment variables. These secrets can also be
- * configured to be included into built app. We obfuscate the device keys to
- * prevent unauthorized access.
- */
-+ (NSString*)valueForDeviceKey:(NSString*)bbKey;
-
-/*
- * To temporarily disable screenshot interception you can provide a callback
- * here.
- *
- * When screenshotting is turned on through a buddybuild setting, and no
- * callback is provided then screenshotting is by default on.
- *
- * If screenshotting is disabled through the buddybuild setting, then this
- * callback has no effect
- *
- */
-+ (void)setScreenshotAllowedCallback:(BBReturnBooleanCallback)bbCallback;
-
-/*
- * Once a piece of feedback is sent this callback will be called
- * so you can take additional actions if necessary
- */
-+ (void)setScreenshotFeedbackSentCallback:(BBCallback)bbCallback;
-
-/*