test_services.py 20.3 KB
Newer Older
1
2
3
from datetime import timedelta
from unittest import mock

4
from django.conf import settings
5
6
7
8
from django.contrib.auth import get_user_model
from django.core import mail
from django.test import TestCase
from django.utils import timezone
9
from freezegun import freeze_time
10
11

from members.models import Member, Membership
12
from payments.models import Payment
13
from registrations import services
14
from registrations.models import Entry, Registration, Renewal
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
from utils.snippets import datetime_to_lectureyear


class ServicesTest(TestCase):
    fixtures = ['members.json']

    @classmethod
    def setUpTestData(cls):
        cls.e0 = Entry.objects.create(
            length=Entry.MEMBERSHIP_YEAR,
            membership_type=Membership.MEMBER,
            status=Entry.STATUS_REVIEW,
        )
        cls.e1 = Registration.objects.create(
            first_name='John',
            last_name='Doe',
            email='johndoe@example.com',
            programme='computingscience',
            student_number='s1234567',
            starting_year=2014,
            address_street='Heyendaalseweg 135',
            address_street2='',
            address_postal_code='6525AJ',
            address_city='Nijmegen',
            phone_number='06123456789',
            birthday=timezone.now().replace(year=1990, day=1).date(),
            language='en',
            length=Entry.MEMBERSHIP_YEAR,
            membership_type=Membership.MEMBER,
            status=Entry.STATUS_CONFIRM,
        )
        cls.e2 = Registration.objects.create(
            first_name='Paula',
            last_name='Test',
            email='ptest@example.com',
            programme='computingscience',
            student_number='s2345678',
            starting_year=2015,
            address_street='Heyendaalseweg 136',
            address_street2='',
            address_postal_code='6525AJ',
            address_city='Nijmegen',
            phone_number='06098765432',
            birthday=timezone.now().replace(year=1992, day=2).date(),
            language='nl',
            length=Entry.MEMBERSHIP_STUDY,
            membership_type=Membership.MEMBER,
            status=Entry.STATUS_CONFIRM,
        )
        cls.e3 = Renewal.objects.create(
            member=Member.objects.get(pk=2),
            length=Entry.MEMBERSHIP_STUDY,
            membership_type=Membership.MEMBER,
            status=Entry.STATUS_CONFIRM,
        )
        cls.e4 = Renewal.objects.create(
            member=Member.objects.get(pk=3),
            length=Entry.MEMBERSHIP_YEAR,
            membership_type=Membership.MEMBER,
            status=Entry.STATUS_ACCEPTED,
        )
        cls.e4.status = Entry.STATUS_ACCEPTED
        cls.e4.save()
        cls.e5 = Renewal.objects.create(
            member=Member.objects.get(pk=4),
            length=Entry.MEMBERSHIP_STUDY,
            membership_type=Membership.MEMBER,
            status=Entry.STATUS_ACCEPTED,
            created_at=timezone.now() - timedelta(days=10)
        )
        cls.e5.status = Entry.STATUS_ACCEPTED
        cls.e5.save()

    def setUp(self):
        self.e1.refresh_from_db()
        self.e2.refresh_from_db()
        self.e3.refresh_from_db()
        self.e4.refresh_from_db()

    def test_generate_username(self):
        username = services._generate_username(self.e1)
        self.assertEqual(username, 'jdoe')

        self.e1.last_name = ('famgtjbblvpcxpebclsjfamgtjbblvpcxpebcl'
                             'sjfamgtjbblvpcxpebclsjfamgtjbblvpcxpeb'
                             'clsjfamgtjbblvpcxpebclsjfamgtjbblvpcxp'
                             'ebclsjfamgtjbblvpcxpebclsjfamgtjbblvpc'
                             'xpebclsj')

        username = services._generate_username(self.e1)
        self.assertEqual(username, 'jfamgtjbblvpcxpebclsjfamgtjbblvpcxpebclsjf'
                                   'amgtjbblvpcxpebclsjfamgtjbblvpcxpebclsjfam'
                                   'gtjbblvpcxpebclsjfamgtjbblvpcxpebclsjfamgt'
                                   'jbblvpcxpebclsjfamgtjbbl')

        possibilities = [
            ('Bram', 'in \'t Zandt', 'bintzandt'),
            ('Astrid', 'van der Jagt', 'avanderjagt'),
            ('Bart', 'van den Boom', 'bvandenboom'),
            ('Richard', 'van Ginkel', 'rvanginkel'),
            ('Edwin', 'de Koning', 'edekoning'),
            ('Martijn', 'de la Cosine', 'mdelacosine'),
            ('Robert', 'Hissink Muller', 'rhissinkmuller'),
            ('Robert', 'Al-Malak', 'ralmalak'),
            ('Arthur', 'Domelé', 'adomele'),
            ('Ben', 'Brücker', 'bbrucker'),
        ]

        for pos in possibilities:
            username = services._generate_username(Registration(
                first_name=pos[0],
                last_name=pos[1]
            ))
            self.assertEqual(username, pos[2])

    def test_check_unique_user(self):
        user = get_user_model().objects.create_user('johnnydoe',
                                                    'johnnydoe@example.com')

        self.assertEqual(services.check_unique_user(self.e1), True)

        user.username = 'jdoe'
        user.save()

        self.assertEqual(services.check_unique_user(self.e1), False)

        user.username = 'johnnydoe'
        user.email = 'johndoe@example.com'
        user.save()

        self.assertEqual(services.check_unique_user(self.e1), False)

        user.username = 'jdoe'
        user.email = 'unique@example.com'
        user.save()
        self.e1.registration.username = 'unique_username'

        self.assertEqual(services.check_unique_user(self.e1), True)

    def test_confirm_entry(self):
        self.e3.status = Entry.STATUS_REVIEW
        self.e3.save()

        rows_updated = services.confirm_entry(Entry.objects.all())

        self.assertEqual(rows_updated, 2)
        self.assertEqual(Entry.objects
                         .filter(status=Entry.STATUS_REVIEW).count(), 4)

    def test_reject_entries(self):
        self.e2.status = Entry.STATUS_REVIEW
        self.e2.save()
        self.e3.status = Entry.STATUS_REVIEW
        self.e3.save()

        rows_updated = services.reject_entries(Entry.objects.all())

        self.assertEqual(rows_updated, 3)
        self.assertEqual(Entry.objects
                         .filter(status=Entry.STATUS_REJECTED).count(), 3)
        self.assertEqual(len(mail.outbox), 2)

    def test_accept_entries(self):
        self.e2.status = Entry.STATUS_REVIEW
        self.e2.save()
        self.e3.status = Entry.STATUS_REVIEW
        self.e3.save()

        rows_updated = services.accept_entries(Entry.objects.all())

        self.e2.refresh_from_db()
186
187
188
189
190
        self.e3.refresh_from_db()

        self.assertNotEqual(self.e2.payment, None)
        self.assertNotEqual(self.e3.payment, None)

191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
        self.assertEqual(self.e2.username, 'ptest')

        self.assertEqual(rows_updated, 3)
        self.assertEqual(Entry.objects.filter(
            status=Entry.STATUS_ACCEPTED).count(), 5)
        self.assertEqual(len(mail.outbox), 2)

    def test_accept_entries_manual_username(self):
        self.e2.status = Entry.STATUS_REVIEW
        self.e2.username = 'manual_username'
        self.e2.save()
        self.e3.status = Entry.STATUS_REVIEW
        self.e3.save()

        rows_updated = services.accept_entries(Entry.objects.all())

        self.e2.refresh_from_db()
        self.assertEqual(self.e2.username, 'manual_username')

        self.assertEqual(rows_updated, 3)
        self.assertEqual(Entry.objects.filter(
            status=Entry.STATUS_ACCEPTED).count(), 5)
        self.assertEqual(len(mail.outbox), 2)

    @mock.patch('registrations.services.check_unique_user')
    def test_accept_entries_user_not_unique(self, check_unique_user):
        check_unique_user.return_value = False

        self.e2.status = Entry.STATUS_REVIEW
        self.e2.save()
        self.e3.status = Entry.STATUS_REVIEW
        self.e3.save()

        rows_updated = services.accept_entries(Entry.objects.all())

        self.assertEqual(rows_updated, 0)
        self.assertEqual(Entry.objects.filter(
            status=Entry.STATUS_ACCEPTED).count(), 2)
        self.assertEqual(len(mail.outbox), 0)

    def test_create_payment_for_entry(self):
        self.e1.username = 'jdoe'
        self.e1.save()
        self.e2.username = 'ptest'
        self.e2.save()

        p1 = services._create_payment_for_entry(self.e1)  # 'year' payment
        p2 = services._create_payment_for_entry(self.e2)  # 'study' payment

        lecture_year = datetime_to_lectureyear(timezone.now())
        Membership.objects.create(
            type=Membership.MEMBER,
            since=timezone.datetime(year=lecture_year, month=9, day=1),
            until=timezone.datetime(year=lecture_year + 1, month=9, day=1),
            user=self.e3.member
        )
        Membership.objects.create(
            type=Membership.MEMBER,
            since=timezone.datetime(year=lecture_year, month=9, day=1),
            until=timezone.datetime(year=lecture_year + 1, month=9, day=1),
            user=self.e4.member
        )
        Membership.objects.create(
            type=Membership.MEMBER,
            since=timezone.now() - timedelta(days=31),
            until=timezone.now() - timedelta(days=2),
            user=self.e5.member
        )

        # upgrade 'study'
        p3 = services._create_payment_for_entry(self.e3)
        # upgrade 'year'
        p4 = services._create_payment_for_entry(self.e4)
        # upgrade 'study' after membership end
        p5 = services._create_payment_for_entry(self.e5)

        self.assertEqual(p1.amount, settings.MEMBERSHIP_PRICES['year'])
268
        self.assertEqual(p1.registrations_entry, self.e1)
269
270
        self.assertEqual(p1.processed, False)
        self.assertEqual(p2.amount, settings.MEMBERSHIP_PRICES['study'])
271
        self.assertEqual(p2.registrations_entry, self.e2)
272
273
274
        self.assertEqual(p2.processed, False)
        self.assertEqual(p3.amount, settings.MEMBERSHIP_PRICES['study'] -
                         settings.MEMBERSHIP_PRICES['year'])
275
        self.assertEqual(p3.registrations_entry, self.e3)
276
277
        self.assertEqual(p3.processed, False)
        self.assertEqual(p4.amount, settings.MEMBERSHIP_PRICES['year'])
278
        self.assertEqual(p4.registrations_entry, self.e4)
279
280
281
        self.assertEqual(p4.processed, False)
        self.assertEqual(p5.amount, settings.MEMBERSHIP_PRICES['study'] -
                         settings.MEMBERSHIP_PRICES['year'])
282
        self.assertEqual(p5.registrations_entry, self.e5)
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
        self.assertEqual(p5.processed, False)

    @mock.patch('registrations.services.check_unique_user')
    def test_create_member_from_registration(self, check_unique_user):
        self.e1.username = 'jdoe'
        self.e1.save()

        check_unique_user.return_value = False
        with self.assertRaises(ValueError):
            services._create_member_from_registration(self.e1)

        check_unique_user.return_value = True
        member = services._create_member_from_registration(self.e1)

        self.assertEqual(member.username, 'jdoe')
        self.assertEqual(member.first_name, 'John')
        self.assertEqual(member.last_name, 'Doe')
        self.assertEqual(member.email, 'johndoe@example.com')
        self.assertEqual(member.email, 'johndoe@example.com')

        self.assertEqual(member.profile.programme, 'computingscience')
        self.assertEqual(member.profile.student_number, 's1234567')
        self.assertEqual(member.profile.starting_year, 2014)
        self.assertEqual(member.profile.address_street, 'Heyendaalseweg 135')
        self.assertEqual(member.profile.address_street2, '')
        self.assertEqual(member.profile.address_postal_code, '6525AJ')
        self.assertEqual(member.profile.address_city, 'Nijmegen')
        self.assertEqual(member.profile.phone_number, '06123456789')
        self.assertEqual(member.profile.birthday, timezone.now()
                         .replace(year=1990, day=1).date())
        self.assertEqual(member.profile.language, 'en')

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].subject,
                         'Welcome to Study Association Thalia')

    def test_create_membership_from_entry(self):
        self.e1.username = 'jdoe'
        self.e1.save()
        self.e2.username = 'ptest'
        self.e2.save()

325
        with freeze_time("2017-01-12"):
326
            lecture_year = datetime_to_lectureyear(timezone.now())
Thom Wiggers's avatar
Thom Wiggers committed
327
            self.assertEqual(lecture_year, 2016)
328
329
330
331
332
333
334
335
336

            m1 = services._create_member_from_registration(self.e1)
            m2 = services._create_member_from_registration(self.e2)

            # Registration to new 'year' membership starting today
            membership1 = services._create_membership_from_entry(self.e1, m1)

            self.assertEqual(membership1.since, timezone.now().date())
            self.assertEqual(membership1.until, timezone.datetime(
Thom Wiggers's avatar
Thom Wiggers committed
337
                year=2017, month=9, day=1).date())
338
339
340
341
342
343
344
345
346
347
348
349
350
            self.assertEqual(membership1.user, m1)
            self.assertEqual(membership1.type, self.e1.membership_type)

            # Registration to new 'study' membership starting today
            membership2 = services._create_membership_from_entry(self.e2, m2)

            self.assertEqual(membership2.since, timezone.now().date())
            self.assertEqual(membership2.until, None)
            self.assertEqual(membership2.user, m2)
            self.assertEqual(membership2.type, self.e2.membership_type)

            membership2.delete()

351
        with freeze_time("2017-08-12"):
352
353
354
            # Check if since is new lecture year in august
            membership2 = services._create_membership_from_entry(self.e2, m2)

Thom Wiggers's avatar
Thom Wiggers committed
355
356
            self.assertEqual(membership2.since, timezone.datetime(
                year=2017, month=9, day=1).date())
357
358
359
360
            self.assertEqual(membership2.until, None)
            self.assertEqual(membership2.user, m2)
            self.assertEqual(membership2.type, self.e2.membership_type)

361
        with freeze_time("2017-01-12"):
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
            # Renewal to new 'study' membership starting today
            self.e3.length = Entry.MEMBERSHIP_STUDY
            membership3 = services._create_membership_from_entry(self.e3)

            self.assertEqual(membership3.since, timezone.now().date())
            self.assertEqual(membership3.until, None)
            self.assertEqual(membership3.user, self.e3.member)
            self.assertEqual(membership3.type, self.e3.membership_type)

            membership3.delete()

            # Renewal to new 'year' membership starting today
            self.e3.length = Entry.MEMBERSHIP_YEAR
            membership3 = services._create_membership_from_entry(self.e3)

            self.assertEqual(membership3.since, timezone.now().date())
            self.assertEqual(membership3.until, timezone.datetime(
Thom Wiggers's avatar
Thom Wiggers committed
379
                month=9, day=1, year=2017).date())
380
381
382
383
384
385
386
387
            self.assertEqual(membership3.user, self.e3.member)
            self.assertEqual(membership3.type, self.e3.membership_type)

            membership3.delete()

            self.e3.length = Entry.MEMBERSHIP_YEAR
            existing_membership = Membership.objects.create(
                type=Membership.MEMBER,
Thom Wiggers's avatar
Thom Wiggers committed
388
                since=timezone.datetime(year=2016,
389
                                        month=9, day=1).date(),
Thom Wiggers's avatar
Thom Wiggers committed
390
                until=timezone.datetime(year=2017,
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
                                        month=1, day=31).date(),
                user=self.e3.member
            )

            # Renewal without length
            self.e3.length = None
            membership3 = services._create_membership_from_entry(
                self.e3, self.e3.member)
            self.assertEqual(membership3, None)

            # Renewal to new 'year' membership starting 1 day after
            # end of the previous membership
            self.e3.length = Entry.MEMBERSHIP_YEAR
            membership3 = services._create_membership_from_entry(self.e3)
            self.assertEqual(membership3.since,
                             existing_membership.until + timedelta(days=1))
            self.assertEqual(membership3.until, timezone.datetime(
Thom Wiggers's avatar
Thom Wiggers committed
408
                year=2017, month=9, day=1).date())
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
            self.assertEqual(membership3.user, self.e3.member)
            self.assertEqual(membership3.type, self.e3.membership_type)

            membership3.delete()
            self.e3.length = Entry.MEMBERSHIP_STUDY

            # Renewal (aka upgrade) existing membership to 'study' membership
            # It doesn't work when the entry was made after the renewal
            # was due, so this is a new membership
            membership3 = services._create_membership_from_entry(self.e3)
            self.assertEqual(membership3.since, timezone.now().date())
            self.assertEqual(membership3.until, None)
            self.assertEqual(membership3.user, self.e3.member)
            self.assertEqual(membership3.type, self.e3.membership_type)

            membership3.delete()

            # But it does work when the entry was created before the renewal
            # was actually due. This modifies the existing membership
Thom Wiggers's avatar
Thom Wiggers committed
428
429
            self.e3.created_at = timezone.make_aware(
                timezone.datetime(2017, 1, 30))
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
            self.e3.save()
            membership3 = services._create_membership_from_entry(self.e3)
            self.assertEqual(membership3.since, existing_membership.since)
            self.assertEqual(membership3.until, None)
            self.assertEqual(membership3.user, self.e3.member)
            self.assertEqual(membership3.type, self.e3.membership_type)

            # Fail 'study' renewal of existing 'study' membership
            existing_membership.until = None
            existing_membership.save()
            with self.assertRaises(ValueError):
                services._create_membership_from_entry(self.e3)

            # Fail 'year' renewal of existing 'study' membership
            self.e3.length = Entry.MEMBERSHIP_YEAR
            existing_membership.until = None
            existing_membership.save()
            with self.assertRaises(ValueError):
                services._create_membership_from_entry(self.e3)

    def test_process_payment(self):
        self.e1.username = 'jdoe'
        self.e1.save()
        self.e2.username = 'ptest'
        self.e2.save()

456
457
458
459
460
461
462
        # Check that the DoesNotExist is caught
        p = Payment(
            amount=10,
            processed=True,
        )
        services.process_payment(p)

463
464
465
466
467
        p0 = services._create_payment_for_entry(self.e0)
        p1 = services._create_payment_for_entry(self.e1)
        p2 = services._create_payment_for_entry(self.e2)
        p3 = services._create_payment_for_entry(self.e3)

468
469
470
471
472
473
        Entry.objects.filter(
            pk__in=[self.e1.pk, self.e2.pk, self.e3.pk]
        ).update(status=Entry.STATUS_ACCEPTED)

        payments = Payment.objects.filter(pk__in=[p0.pk, p2.pk, p3.pk])
        payments.update(processed=True)
474

475
476
477
478
479
480
        for payment in Payment.objects.filter(pk__in=[p0.pk, p1.pk, p2.pk]):
            services.process_payment(payment)

        self.e0.refresh_from_db()
        self.e1.refresh_from_db()
        self.e2.refresh_from_db()
481

482
483
484
        self.assertEqual(self.e0.status, Entry.STATUS_REVIEW)
        self.assertEqual(self.e1.status, Entry.STATUS_ACCEPTED)
        self.assertEqual(self.e2.status, Entry.STATUS_COMPLETED)
485

486
487
488
489
490
        p0.processed = True
        p0.save()
        self.e0.status = Entry.STATUS_ACCEPTED
        self.e0.save()
        services.process_payment(p0)
491

492
493
494
495
496
497
498
499
        self.assertEqual(self.e0.status, Entry.STATUS_ACCEPTED)

        p3.refresh_from_db()
        services.process_payment(p3)
        self.e3.refresh_from_db()

        self.assertEqual(self.e3.status, Entry.STATUS_COMPLETED)
        self.assertEqual(len(mail.outbox), 2)
500
501
502
503
504

    def test_process_payment_no_member_created(self):
        p1 = services._create_payment_for_entry(self.e1)
        p2 = services._create_payment_for_entry(self.e2)

505
506
507
508
509
510
511
        Entry.objects.filter(
            pk__in=[self.e1.pk, self.e2.pk]
        ).update(status=Entry.STATUS_ACCEPTED)

        payments = Payment.objects.filter(pk__in=[p1.pk, p2.pk])
        payments.update(processed=True)

512
513
514
515
516
        with mock.patch('registrations.services.'
                        '_create_member_from_registration') as create_member:
            with mock.patch('registrations.services._create_membership_'
                            'from_entry') as create_membership:
                create_member.return_value = None
517
518
519
                for payment in Payment.objects.filter(pk__in=[p1.pk, p2.pk]):
                    services.process_payment(payment)
                    self.assertFalse(create_membership.called)