From 8c1414da96360ecd8c64ae05188009fb21c8a33a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastiaan=20Versteeg?= Date: Sun, 27 Oct 2019 11:16:17 +0100 Subject: [PATCH] Fix valid property output to always be an boolean --- website/payments/models.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/website/payments/models.py b/website/payments/models.py index c90c964e..4ebaf01f 100644 --- a/website/payments/models.py +++ b/website/payments/models.py @@ -219,9 +219,10 @@ class BankAccount(models.Model): @property def valid(self): - if self.valid_from and self.valid_until: + if self.valid_from is not None and self.valid_until is not None: return self.valid_from <= timezone.now().date() < self.valid_until - return self.valid_from and self.valid_from <= timezone.now().date() + return (self.valid_from is not None + and self.valid_from <= timezone.now().date()) def __str__(self): return f'{self.iban} - {self.name}' -- GitLab