concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-08-28T19:10:53+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/872Pizza orders reachable for people not in the organising member group2019-08-28T19:10:53+02:00Sébastiaan VersteegPizza orders reachable for people not in the organising member group### One-sentence description
Pizza orders reachable for people not in the organising member group
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to m...### One-sentence description
Pizza orders reachable for people not in the organising member group
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected behaviour
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. The orders page is permission denied26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/879Update fullcalendar to v42019-06-20T14:16:37+02:00Sébastiaan VersteegUpdate fullcalendar to v4### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v3### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v326Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/877Remove vacancy expiration mails2020-02-04T14:40:33+01:00Joren VranckenRemove vacancy expiration mails<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Remove vacancy expiration mails.
### Why?
<!-- Please motivate why we should invest into this change -->
The vacancy expiration mails are a bit feature creep. They are not really helpful, because the commissioner of external affairs has their own administration with expiration dates (including the vacancies). Furthermore, the emails also don't help because they arrive either too late or too soon. Some partners have a lot longer negotiating time than one month, while others can be handled within a few days.
Besides that, it is also a bit weird that we are only sending mails about vacancies. What about the partner profiles? Why are we not tracking expiration dates for those?
### Suggested implementation
I suggest we remove this functionality altogether which will result in less code to maintain and less useless emails to be sent.26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/869Improve categories2019-08-28T20:01:52+02:00Sébastiaan VersteegImprove categories### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
...### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
- Party
- Other
### Suggested implementation
- Alumni (old: Alumni)
- Education (old: Workshop + Lunch Lecture)
- Career (some workshops should go here, manual intervention)
- Leisure (old: Drinks + Party, now also: paintball + lasertag etc)
- Association Affairs (old: GM, now also: SNIC info meeting, board interest meetings) (Verenigingszaken)
- Other (old: Other + Activity)
Important: this requires migrations to changes the categories of existing events to the new ones!26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/898Start / end datetime for events is inconsistent between event list and other ...2019-08-13T13:07:29+02:00Ward TheunisseStart / end datetime for events is inconsistent between event list and other views.### One-sentence description
Datetime for events is inconsistent between event list and event page.
### Current behaviour / Reproducing the bug
When you inspect an event you will see the correct datetime:
![Screenshot_from_2019-07-19_...### One-sentence description
Datetime for events is inconsistent between event list and event page.
### Current behaviour / Reproducing the bug
When you inspect an event you will see the correct datetime:
![Screenshot_from_2019-07-19_12-49-32](/uploads/d05add0af39f6f3ede38fb5065d982e7/Screenshot_from_2019-07-19_12-49-32.png)
However, in the main event list this time is shifted 2 hours for every event.
![Screenshot_from_2019-07-19_12-49-41](/uploads/814ce04b84b483429848913629f4cb33/Screenshot_from_2019-07-19_12-49-41.png)
In the "week" and "month" views this bug does not occur.
It is also independent of chosen language.
### Expected behaviour
The start & end datetime of events to be the same for every view.26Sébastiaan VersteegSébastiaan Versteeg