concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-23T15:15:36+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/924Add the real name of members to profiles2019-09-17T12:10:21+02:00Ward TheunisseAdd the real name of members to profiles/label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add.../label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add the real name of members to profiles.
### Suggested implementation
Some text.
27https://gitlab.science.ru.nl/thalia/concrexit/-/issues/882Cannot upload minutes2019-06-04T20:08:35+02:00Ayala HoeksCannot upload minutes### One-sentence description
Error message when uploading GM minutes
### Current behaviour / Reproducing the bug
Error message:
>File extension 'pdf' is not allowed. Allowed extensions are: '.txt, .pdf, .jpg, .jpeg, .png'.
1. Select...### One-sentence description
Error message when uploading GM minutes
### Current behaviour / Reproducing the bug
Error message:
>File extension 'pdf' is not allowed. Allowed extensions are: '.txt, .pdf, .jpg, .jpeg, .png'.
1. Select file to upload
2. Save
3. Error
### Expected behaviour
I expect no problems when uploading a file (filename: MinutesDate.pdf)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/821Ability to mark too-late unregistration as 'valid reason'2019-10-23T21:40:59+02:00Job DoesburgAbility to mark too-late unregistration as 'valid reason'<!--
You want something new.
-->
### One-sentence description
The ability to mark too-late unregistration as 'valid reason'
### Motivation
Currently there is a separate sheet where we register the fines for absence at activities...<!--
You want something new.
-->
### One-sentence description
The ability to mark too-late unregistration as 'valid reason'
### Motivation
Currently there is a separate sheet where we register the fines for absence at activities or unregistering after the deadline. Sometimes people have a valid reason for this. It would be nice to mark this on the website as well, so a separate administration is unnecessary.
### Desired functionality
For people that unregistered too late or were not present during an activity, it should be able to mark their absence as 'valid reason'.
### Suggested implementation
A checkbox or something?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/809Make the 'related organisations' page dynamic2019-09-18T21:54:34+02:00Rico te WechelMake the 'related organisations' page dynamic### One-sentence description
Make the 'related organisations' page dynamic
### Motivation
The board wants regular changes to the related organisations pages. So instead of trying to keep this up-to-date in updates we can make this dyn...### One-sentence description
Make the 'related organisations' page dynamic
### Motivation
The board wants regular changes to the related organisations pages. So instead of trying to keep this up-to-date in updates we can make this dynamic.
### Desired functionality
We want one overview page with all organisation Thalia is related too.
That overview page can link to individual pages.
### Suggested implementation
New app 'contacts'. With a model 'Contact' that contains the name, email address and description. Maybe also logos for awesome designs. Other possibilities include adding connections between contacts, but that is not a real requirement and can be further investigated.
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/748Multiple food-lists2018-11-06T08:52:48+01:00Job DoesburgMultiple food-lists<!--
You want something new.
-->
### One-sentence description
For pizza-events, be able to choose from multiple lists of food.
### Motivation
Some day, we might want to order other food rather than pizzas every time (GM's for exa...<!--
You want something new.
-->
### One-sentence description
For pizza-events, be able to choose from multiple lists of food.
### Motivation
Some day, we might want to order other food rather than pizzas every time (GM's for example). In that case, it would be very nice to be able to use pizza.thalia.nu (which might needs the alias order.thalia.nu then).
### Desired functionality
In the backend, one should be able to enter multiple lists with items ('pizzas'). For each pizza-event, one should choose which list to use. This way we could have a list 'Dominos' and a different list 'Cafetaria Heyendaal' for example.
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/743"BHV-er" status, borrelbrevet license and camera license properties for members2018-11-07T19:37:42+01:00Job Doesburg"BHV-er" status, borrelbrevet license and camera license properties for members<!--
You want something new.
-->
### One-sentence description
"BHV-er" status, borrelbrevet license and camera license properties for members
### Motivation
Currently it's a bit of a mess to keep track of which people have a "BHV...<!--
You want something new.
-->
### One-sentence description
"BHV-er" status, borrelbrevet license and camera license properties for members
### Motivation
Currently it's a bit of a mess to keep track of which people have a "BHV" license, borrelbrevet license or camera license. The board keeps all kinds of lists (sometimes even .docx bleh) that get outdated in no time. It would be very nice to have this administration on the website, THE place for this kind of things.
### Desired functionality
There are multiple possibilities.
The first is just to add checkboxes to a members' profile (editable by the board). For camera license and borrelbrevet license, this would suffice. However, a date would be better (so you can register the date they received it.
For BHV status, also some invalidation would be nice. Because a BHV license needs renewal after a year, it would be nice to somewhere show that someones BHV status is not active anymore.
Of course, many features can be added. You could say you only store the date of the last BHV course, or keep a whole history. You could add e-mails for BHV stating that someone's status is about to invalidate, and that they should contact the board in case they did 'update' their BHV.
You could maybe even extend this to just arbitrary information fields, just as for event registration. This is up to you. If you feel like this is very nice to implement, please do so. However a regular checkbox is fine as well ;)
### Suggested implementation
Actually this is described under 'desired functionality'https://gitlab.science.ru.nl/thalia/concrexit/-/issues/715Add note to phone number about reachability2018-10-22T18:52:34+02:00Job DoesburgAdd note to phone number about reachability### One-sentence description
We would like to add a note on the website contact page that we can be reached by phone or in person in the board room on weekdays between 12:15 and 13:30 (or more often if you are lucky). Maybe you can figur...### One-sentence description
We would like to add a note on the website contact page that we can be reached by phone or in person in the board room on weekdays between 12:15 and 13:30 (or more often if you are lucky). Maybe you can figure out a nice way of mentioning this, otherwise we'll think with you ;)
### Why?
So people know when to reach us
### Current implementation
There is no note on the contactpage of the site
### Desired implementation
There is a note on the contactpage of the sitehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/689Automatically execute data minimisation on accepted/rejected registrations af...2019-05-08T19:50:33+02:00Sébastiaan VersteegAutomatically execute data minimisation on accepted/rejected registrations after 1 month### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be mi...### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be minimalised to just the created membership. This will minimalise the places where user data is stored.
- Once registrations are rejected the data should be removed from our system.
- **This should not deleted accepted *and* non-paid registrations**. So those that are waiting for payment.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/685Improve privacy policy regarding server data2020-01-30T13:36:32+01:00Sébastiaan VersteegImprove privacy policy regarding server data@twiggers:
>If you want to write something about explicit and implicit data collected on the website, I'd call this section "Data collected on the website" and write "Certain actions on the website may cause data to be collected (such as...@twiggers:
>If you want to write something about explicit and implicit data collected on the website, I'd call this section "Data collected on the website" and write "Certain actions on the website may cause data to be collected (such as ordering a pizza on the website or registering to attend an event). We additionally may collect logs on anything happening on the site and app to ensure the correct functioning of the services provided. The Technicie tries to only collect data when errors occur."Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/632Thalia Pay2019-10-03T16:58:43+02:00Aucke BosThalia PayThis is the general overview issue for Thalia Pay. The work has been split in multiple subissues that all begin with 'Thalia Pay'
### One-sentence description
Members can pay for things by keeping a tab using their account.
### Desire...This is the general overview issue for Thalia Pay. The work has been split in multiple subissues that all begin with 'Thalia Pay'
### One-sentence description
Members can pay for things by keeping a tab using their account.
### Desired behaviour
A member has a virtual wallet with a maximum balance of 0 euro. This wallet can be used to pay for things.
Once a member registers for an event or orders a pizza an option will appear to pay using the wallet. Such a payment is registered in the ~payments app. The amount of the payment will be deducted from the wallet.
At the end of the month all the payments of that month will be collected by direct debit.
Before these direct debits can take place we need to collect information from members:
- Bank account
- Initials and last name of the bank account holder
- The member has to sign a SEPA mandate
Then the treasurer has to be able to create an export that contains all the information for a direct debit. The overview only has to contain members that made a payment. It should have the following fields:
- Relationnumber
- First name
- Last name
- IBAN
- Initials + last name of holder
- Amount
- Overview of all payments in this row
The treasurer will send a mail before the direct debit will be executed. But an overview in the frontend of the website would be desirable.
---
## What has been done
- The Payment model introduced in !533 was moved to it's own app in !704.
- The event payments were refactored to use the Payment model in !1112.
- We're syncing member information and mandates to Conscribo, first introduced in !1132.
- The pizza payments were refactored to use the Payment model in !1225.
- We added digital SEPA mandates in !1241.
- We added a user-facing payment overview in !1350.
## What we should do next
Mostly taken from https://gitlab.science.ru.nl/thalia/concrexit/issues/632#note_74956 and responses.
1. Add a direct debit payment method to the payment model. (#930)
2. Export payment batches for ING (the bank). (#931)
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit.
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.
3. Export financial information that can be imported to Conscribo.
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.
4. We should investigate how we are going to notify members of an upcoming direct debit.
- Could be on export noted in (1).
5. Add an option to ~events for users to mark their registration as paid using direct debit.
- Do not forget the app.
- Needs check for a valid mandate.
6. Add an option to ~pizzas for users to mark their order as paid using direct debit.
- See (5).Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/558Make payments via Mollie possible2018-05-31T14:00:31+02:00Sébastiaan VersteegMake payments via Mollie possible### One-sentence description
Make payments via Mollie possible
### Desired behaviour
- Make it possible to pay for your membership via Mollie next to cash and pin.
- Make it possible to pay for events via Mollie next to cash and pin.
...### One-sentence description
Make payments via Mollie possible
### Desired behaviour
- Make it possible to pay for your membership via Mollie next to cash and pin.
- Make it possible to pay for events via Mollie next to cash and pin.
@mstiphout will communicate with the rest of the board about policy rules that will affect this issue. For example: events with a price under €5 can't be paid using iDEAL.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/523Make partner events optin2018-10-29T15:54:11+01:00Joren VranckenMake partner events optin### One-sentence description
Only show partner events to members who have the optin checkbox checked.
### Why?
Like the optin mails, not every member wants to see partner related content.
### Current implementation
The partner e...### One-sentence description
Only show partner events to members who have the optin checkbox checked.
### Why?
Like the optin mails, not every member wants to see partner related content.
### Current implementation
The partner events are shown to everyone in the calendar.
### Desired implementation
Change the optin checkbox from optin for mailing to mailing and partner events.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/509Give existing boards default description texts2018-11-21T23:02:40+01:00Joost Rijneveldjoost@joostrijneveld.nlGive existing boards default description textsAs #502 introduces description fields and #478 hides member images, it is probably desirable to provide default descriptions for the legacy boards. Either some manual work, or an automatic migration. See also https://gitlab.science.ru.nl...As #502 introduces description fields and #478 hides member images, it is probably desirable to provide default descriptions for the legacy boards. Either some manual work, or an automatic migration. See also https://gitlab.science.ru.nl/thalia/concrexit/issues/478#note_35279
Bijv. 'The board of xxxx-yyyy was formed by John Doe (position), Jane Doe (position), etc.'https://gitlab.science.ru.nl/thalia/concrexit/-/issues/495Leden zonder geboortedatum2018-03-03T20:26:34+01:00Kirsten KingmaLeden zonder geboortedatumEr zijn huidige leden zonder geboortedatum. Die moeten gefixt worden.Er zijn huidige leden zonder geboortedatum. Die moeten gefixt worden.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/474Booksale to freshmen before 01-092018-01-17T20:01:39+01:00Frank GerlingsBooksale to freshmen before 01-09### One-sentence description
Booksale should be possible to freshmen before the first of September.
### Desired behaviour
At the moment, a freshman has to wait until the first of September in order to buy books through our site. Taken th...### One-sentence description
Booksale should be possible to freshmen before the first of September.
### Desired behaviour
At the moment, a freshman has to wait until the first of September in order to buy books through our site. Taken the delivery time in to account, freshman can have their books at it's earliest in week 2.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/450Exporteren adresgegevens voor stickeren Thabloids door Thabloidcommissie2017-09-13T20:43:18+02:00Ghost UserExporteren adresgegevens voor stickeren Thabloids door ThabloidcommissieHet probleem:
We werken nu al een aantal Thabloids met verouderde adresgegevens voor de stickers. Het zou erg fijn zijn als we (lees: (een selectie van) de Thabloidcommissie) voor het stickeren zelf een .csv konden exporteren van de adre...Het probleem:
We werken nu al een aantal Thabloids met verouderde adresgegevens voor de stickers. Het zou erg fijn zijn als we (lees: (een selectie van) de Thabloidcommissie) voor het stickeren zelf een .csv konden exporteren van de adressen die we nodig hebben.
Het gaat om de volgende units:
* Alle leden
* Alle begunstigers
* Alle ereleden
Idealiter zouden daaraan kunnen worden toegevoegd:
* Alle zusterverenigingen<br>
Al staan die misschien niet op de site, het zijn er dusdanig weinig dat hier misschien iets voor geregeld kan worden
* De sponsoren waar een Thabloid naartoe moet<br>
Een lijst die de commissaris extern bij zou moeten houdenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/391Mogelijkheid doen ledenenquêtes via website2017-12-28T20:00:16+01:00Ivar DerksenMogelijkheid doen ledenenquêtes via websiteVoor het doen van de enquêtes van de ledeninvulling leek het ons als EVC wel handig als dit ooit via de website zou kunnen. Als een openstaande enquete vanaf de homepage snel te zien is, kun je gemakkelijk op borrels en in Mercator zegge...Voor het doen van de enquêtes van de ledeninvulling leek het ons als EVC wel handig als dit ooit via de website zou kunnen. Als een openstaande enquete vanaf de homepage snel te zien is, kun je gemakkelijk op borrels en in Mercator zeggen dat ze hem daar in moeten vullen. Het heeft als voordeel dat ook leden die niet op een bepaalde borrel zijn of in Mercator zitten op dat moment de enquête ook in kunnen vullen. Ook voorkomen we zo mensen die dubbel stemmen zonder moeilijke administratie.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/352API toevoegen zodat phocabby photos automatisch geupload kunnen worden2019-05-27T22:17:39+02:00Luuk ScholtenAPI toevoegen zodat phocabby photos automatisch geupload kunnen wordenNils stuurde het volgende:
> Zoals jullie wellicht weten, wordt mijn phocabby gedoneerd aan Thalia. Het zou erg handig zijn als de website een REST-api krijgt waar de foto's naartoe gepost kunnen worden. Dan kan ik de facebook-uploade...Nils stuurde het volgende:
> Zoals jullie wellicht weten, wordt mijn phocabby gedoneerd aan Thalia. Het zou erg handig zijn als de website een REST-api krijgt waar de foto's naartoe gepost kunnen worden. Dan kan ik de facebook-uploader aanpassen, zodat gemaakte foto's niet meteen publiek te bezichtigen zijn. Staat er al zoiets in de planning, en zo ja, wanneer is dat af?
> Mijn doe-het-zelfie bepaalt zelf hoe een album gaat heten en maakt die dan aan als die nog niet bestaat. Dat album heeft als naam bv 'donderdag 2 maart' en bevat in dat geval de foto's van 2-3-2017 06.00 - 3-3-2017 06.00. Die functionaliteit kunnen jullie indien gewenst ook zelf inbouwen, zodat het apparaat alleen nog maar foto's hoeft te bufferen en posten als er een netwerkverbinding is. Eventueel kan ik zelf ook wel iets bijdragen in het bouwen van een dergelijke api.
> Een andere optie is het posten naar een besloten facebook-groep. De foto's kunnen dan niet meer op de website geplaatst worden door reeds bestaande policies.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/168IBAN export in members2017-09-08T13:08:40+02:00Thom WiggersIBAN export in membersExport IBAN in membersExport IBAN in members