concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-23T15:15:36+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1031Topic should be visible in https://thalia.nu/user/finance/payments/2020-03-11T23:54:58+01:00Job DoesburgTopic should be visible in https://thalia.nu/user/finance/payments/### One-sentence description
Topic should be visible in https://thalia.nu/user/finance/payments/
### Current behaviour / Reproducing the bug
The topic field is not visible
### Expected behaviour
Be visible### One-sentence description
Topic should be visible in https://thalia.nu/user/finance/payments/
### Current behaviour / Reproducing the bug
The topic field is not visible
### Expected behaviour
Be visiblehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1029Payment fields not translated in admin2020-03-11T19:53:43+01:00Job DoesburgPayment fields not translated in admin### One-sentence description
Payment fields not translated in admin
### Current behaviour / Reproducing the bug
At (staging.)thalia.nu/admin/payments/payment/*/change, the field names are not translated
### Expected behaviour
They ...### One-sentence description
Payment fields not translated in admin
### Current behaviour / Reproducing the bug
At (staging.)thalia.nu/admin/payments/payment/*/change, the field names are not translated
### Expected behaviour
They should be translatedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1028Original images in photo albums are saved and downloaded2020-03-11T23:56:39+01:00Gijs HendriksenOriginal images in photo albums are saved and downloaded### One-sentence description
<!-- What breaks -->
When downloading a photo album, both the original and downscaled images are downloaded, even though we're not supposed to save the original image.
### Current behaviour / Reproducing t...### One-sentence description
<!-- What breaks -->
When downloading a photo album, both the original and downscaled images are downloaded, even though we're not supposed to save the original image.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Download a photo album
2. Notice the original images are saved and included in the album (`*.JPG`), alongside the downscaled images (`*.jpg`)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
1. Download a photo album
2. Only the downscaled images are saved and includedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1027Website starts up in the wrong language2020-03-09T15:45:44+01:00Leon van den BoogaardWebsite starts up in the wrong language<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
To have a language preference in your profile so that the website starts up in your prefered language
<!-- Why should we care? -->
Every ti...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
To have a language preference in your profile so that the website starts up in your prefered language
<!-- Why should we care? -->
Every time I start up the website or click on a link in the newsletter it starts up in English. I don't speak English so I would like it to start up in Dutch.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
Have a cookie or something with a long time to live so that we shouldn't click on the flag every time we use the website
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
Cookies
Thank you in advance!
Love you!https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1024ProgrammingError: more than one row returned by a subquery used as an expression2020-03-01T16:38:36+01:00Thalia TechnicieProgrammingError: more than one row returned by a subquery used as an expressionSentry Issue: [CONCREXIT-27](https://sentry.io/organizations/thalia/issues/1540717591/?referrer=gitlab_integration)
```
CardinalityViolation: more than one row returned by a subquery used as an expression
File "django/db/backends/uti...Sentry Issue: [CONCREXIT-27](https://sentry.io/organizations/thalia/issues/1540717591/?referrer=gitlab_integration)
```
CardinalityViolation: more than one row returned by a subquery used as an expression
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
ProgrammingError: more than one row returned by a subquery used as an expression
(11 additional frame(s) were not displayed)
...
File "django/db/backends/utils.py", line 68, in execute
return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
File "django/db/backends/utils.py", line 77, in _execute_with_wrappers
return executor(sql, params, many, context)
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
File "django/db/utils.py", line 90, in __exit__
raise dj_exc_value.with_traceback(traceback) from exc_value
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1016Event looks like registered for though on waiting list2020-02-17T21:55:37+01:00Job DoesburgEvent looks like registered for though on waiting list### One-sentence description
When on the waiting list for an event, it still looks like you are registered for that event.
### Current behaviour / Reproducing the bug
- In the calendar stream, the event does appear in your calendar
- ...### One-sentence description
When on the waiting list for an event, it still looks like you are registered for that event.
### Current behaviour / Reproducing the bug
- In the calendar stream, the event does appear in your calendar
- Cancelling your registration does show the warning that you have to pay a fine, if after the unregistration deadline
- In the event overview calendar, the dot in front of the event is colored as if you are registered.
### Expected behaviour
- Do not appear in the calendar stream
- Do not show a message that you cannot unregister without having to pay a fine, but something different more fit to the situation
- In the event overview, show some other, pending-ish, colored dot.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/990Style guide links are broken2020-01-29T18:49:21+01:00Jelle Besselingjelle@pingiun.comStyle guide links are broken### One-sentence description
Download links in the style guide, e.g. https://cloud.thalia.nu/s/NP6T7cpfiAHqBXb, don't work anymore.
### Current behaviour / Reproducing the bug
In the style guide there are some links that link to the Tha...### One-sentence description
Download links in the style guide, e.g. https://cloud.thalia.nu/s/NP6T7cpfiAHqBXb, don't work anymore.
### Current behaviour / Reproducing the bug
In the style guide there are some links that link to the Thalia cloud, these downloads have either been expired or have been removed.
### Expected behaviour
The links download the suggested file
<!-- Please write how what happened did not meet your expectations -->Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/984Guest registrations can not be marked paid2020-02-12T19:53:44+01:00Luko van der MaasGuest registrations can not be marked paid### One-sentence description
When there is a guest registration for an event that has a price. If this person is marked as paid, an error occurs.
Associated sentry error: [https://sentry.io/organizations/thalia/issues/1372921592/?proje...### One-sentence description
When there is a guest registration for an event that has a price. If this person is marked as paid, an error occurs.
Associated sentry error: [https://sentry.io/organizations/thalia/issues/1372921592/?project=1463433&referrer=slack](https://sentry.io/organizations/thalia/issues/1372921592/?project=1463433)
### Current behaviour / Reproducing the bug
1. Create an event with registrations and a price
2. Register a guest user for this event
3. Try to mark this guest user as paid
4. Breakage
### Expected behaviour
1. Create an event with registrations and a price
2. Register a guest user for this event
3. Try to mark this guest user as paid
4. either you can't mark their payment status at all or you can. However marking a guest user as paid creates a lot more complication in the payments module.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/972Hyperlink of "display [event] on website" button always refers to thalia.nu (...2020-01-25T22:36:53+01:00Job DoesburgHyperlink of "display [event] on website" button always refers to thalia.nu (also on staging)### One-sentence description
Hyperlink of "display [event] on website" button <s>is hardcoded</s> always refers to thalia.nu (also on staging)
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we c...### One-sentence description
Hyperlink of "display [event] on website" button <s>is hardcoded</s> always refers to thalia.nu (also on staging)
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
At staging.thalia.nu, the action button "display on website" (in the events admin) refers to thalia.nu
### Expected behaviour
Be a relative url (to staging.thalia.nu)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/971Missing translations in information check email2020-02-19T21:13:59+01:00Jelle Besselingjelle@pingiun.comMissing translations in information check email### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check ma...### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check mail contains correct translations
<!-- Please write how what happened did not meet your expectations -->Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/969Thabloids are crawable by Google2019-12-05T12:02:06+01:00Job DoesburgThabloids are crawable by Google### One-sentence description
Thabloids are crawable by Google, and we discussed that we rather not have that.
### Current behaviour / Reproducing the bug
Google crawls our Thabloids. You can search for text fragments
### Expected beh...### One-sentence description
Thabloids are crawable by Google, and we discussed that we rather not have that.
### Current behaviour / Reproducing the bug
Google crawls our Thabloids. You can search for text fragments
### Expected behaviour
Not have them appear in Google.
We do not necessarily have them only available on login, but add them to robots.txt to disallow search machines to display them would be nicehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/967sync_mailinglists errors2019-12-18T19:40:53+01:00Joren Vranckensync_mailinglists errors### One-sentence description
The `sync_mailinglists` generates many errors.
### Description
Currently, the `sync_mailinglists` generates many errors (see the [server sentry issues](https://sentry.io/organizations/thalia/issues/?project...### One-sentence description
The `sync_mailinglists` generates many errors.
### Description
Currently, the `sync_mailinglists` generates many errors (see the [server sentry issues](https://sentry.io/organizations/thalia/issues/?project=1470866)).
These should either be caught or the underlying bug should be fixed.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/966Renewals not processed correctly on uniqueness constraint for membership id2020-01-25T22:45:59+01:00Job DoesburgRenewals not processed correctly on uniqueness constraint for membership id### One-sentence description
Renewals not processed correctly on uniqueness constraint for membership id
### Current behaviour / Reproducing the bug
1. Do a renewal for 1 year
2. Approve it, add a payment, finish it fully etc
3. Do a ...### One-sentence description
Renewals not processed correctly on uniqueness constraint for membership id
### Current behaviour / Reproducing the bug
1. Do a renewal for 1 year
2. Approve it, add a payment, finish it fully etc
3. Do a renewal for the rest of your study
4. Approve it
5. Process a payment
6. Breakage
(the payment gets processed, the membership is correctly added to the user, but the renewal does stick at 'approved' (with a processed payment attached))
### Expected behaviour
Do not crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/955Events cannot be edited when guest registrations were added2020-01-25T22:45:12+01:00Sébastiaan VersteegEvents cannot be edited when guest registrations were added### One-sentence description
Events cannot be edited when guest registrations were added
### Current behaviour / Reproducing the bug
1. Create an event and publish
2. Add a guest registration
3. Edit the event
4. Crashes on the save o...### One-sentence description
Events cannot be edited when guest registrations were added
### Current behaviour / Reproducing the bug
1. Create an event and publish
2. Add a guest registration
3. Edit the event
4. Crashes on the save of the push notification, the guest registration is `null`
### Expected behaviour
The guest registration should be filtered out of the list of members when the event is saved.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/885ValidationError when saving completed membership registration2020-03-04T17:07:01+01:00Thalia TechnicieValidationError when saving completed membership registration
### One-sentence description
<!-- What breaks -->
### Current behaviour / Reproducing the bug
Click save while observing a completed registration.
Sentry Issue: [CONCREXIT-4](https://sentry.io/organizations/thalia/issues/1057927495/...
### One-sentence description
<!-- What breaks -->
### Current behaviour / Reproducing the bug
Click save while observing a completed registration.
Sentry Issue: [CONCREXIT-4](https://sentry.io/organizations/thalia/issues/1057927495/?referrer=gitlab_integration)
```
ValueError: 'RegistrationForm' has no field named 'email'.
(14 additional frame(s) were not displayed)
...
File "django/forms/forms.py", line 180, in errors
self.full_clean()
File "django/forms/forms.py", line 383, in full_clean
self._post_clean()
File "django/forms/models.py", line 405, in _post_clean
self._update_errors(e)
File "django/forms/models.py", line 379, in _update_errors
self.add_error(None, errors)
File "django/forms/forms.py", line 353, in add_error
"'%s' has no field named '%s'." % (self.__class__.__name__, field))
ValidationError: {'email': ['A user with that email address already exists. Login using the existing account and renew the membership by visiting the account settings.'], 'student_number': ['A user with that student number already exists. Login using the existing account and renew the membership by visiting the account settings.'], 'username': ['A user with that username already exists.']}
File "django/forms/models.py", line 403, in _post_clean
self.instance.full_clean(exclude=exclude, validate_unique=False)
File "django/db/models/base.py", line 1152, in full_clean
raise ValidationError(errors)
```
### Expected behaviour
No crash, maybe even no save button available.