concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-08-13T14:18:34+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1027Website starts up in the wrong language2020-03-09T15:45:44+01:00Leon van den BoogaardWebsite starts up in the wrong language<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
To have a language preference in your profile so that the website starts up in your prefered language
<!-- Why should we care? -->
Every ti...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
To have a language preference in your profile so that the website starts up in your prefered language
<!-- Why should we care? -->
Every time I start up the website or click on a link in the newsletter it starts up in English. I don't speak English so I would like it to start up in Dutch.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
Have a cookie or something with a long time to live so that we shouldn't click on the flag every time we use the website
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
Cookies
Thank you in advance!
Love you!https://gitlab.science.ru.nl/thalia/concrexit/-/issues/802Weird behavior of thabloid-filters2019-01-03T12:34:53+01:00Job DoesburgWeird behavior of thabloid-filters### One-sentence description
The filter on the thabloid-page does not behave as expected.
### Current behaviour / Reproducing the bug
1. Try to open [https://thalia.nu/thabloid/#year-2017](https://thalia.nu/thabloid/)
2. Filter on tha...### One-sentence description
The filter on the thabloid-page does not behave as expected.
### Current behaviour / Reproducing the bug
1. Try to open [https://thalia.nu/thabloid/#year-2017](https://thalia.nu/thabloid/)
2. Filter on thabloids for a certain year (not all thabloids)
3. Look at the way the thabloids are lay out (empty blocks)![Schermafbeelding_2019-01-03_om_00.45.23](/uploads/13af331bc8d92242b76c94af347d4a27/Schermafbeelding_2019-01-03_om_00.45.23.png)
4. Profit
### Expected behaviour
I think it is clear.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/619Word "Notulen" on the documents page is not translated2018-03-31T21:14:39+02:00Luko van der MaasWord "Notulen" on the documents page is not translated### One-sentence description
At the general meeting section, the button "notulen" is dutch on the English website
### Current behaviour
At the general meeting section, the button "notulen" is dutch on the English website
### Expected b...### One-sentence description
At the general meeting section, the button "notulen" is dutch on the English website
### Current behaviour
At the general meeting section, the button "notulen" is dutch on the English website
### Expected behaviour
At the general meeting section, the button that downloads the minutes should say "minutes" on the English website
### Steps to reproduce
1. Tell the website to use English
2. Go to /documents/
3. Find the general meeting section
4. See that the button is in dutch.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/564WYSIWYG editor allows setting underline, but this is stripped out by Bleach2018-02-08T14:06:31+01:00Thom WiggersWYSIWYG editor allows setting underline, but this is stripped out by Bleach### One-sentence description
In the admin, the WYSIWYG editor allows setting underline, but this is stripped out by Bleach
### Current behaviour
No underline
### Expected behaviour
underline
### Steps to reproduce
1. Create e.g. an a...### One-sentence description
In the admin, the WYSIWYG editor allows setting underline, but this is stripped out by Bleach
### Current behaviour
No underline
### Expected behaviour
underline
### Steps to reproduce
1. Create e.g. an announcement
2. Use the U button
3. Save
4. See that there's no `text-decoration: underline` in the output.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/85Zoeken in /members gooit exception als iemand NULL als nickname heeft2016-10-05T23:28:25+02:00Jelle Besselingjelle@pingiun.comZoeken in /members gooit exception als iemand NULL als nickname heeftSearch zoekt in de database op first_name, last_name, username en nickname. Nicknames zijn echter niet verplicht, dus de lijn `keywords in obj.nickname.lower() or` werkt niet als iemand NULL heeft als username.
In een echt scenario z...Search zoekt in de database op first_name, last_name, username en nickname. Nicknames zijn echter niet verplicht, dus de lijn `keywords in obj.nickname.lower() or` werkt niet als iemand NULL heeft als username.
In een echt scenario zullen mensen '' hebben als nickname en niet NULL, maar geautomatiseerde tools (zoals createfixtures) zetten lege velden op NULL.
Informatie over de exception:
```
Exception Type: AttributeError
Exception Value:
'NoneType' object has no attribute 'lower'
Exception Location: /home/pingiun/Documents/jbconcrexit/website/members/views.py in <listcomp>, line 55
```
De lijnen waar het om gaat:
```python
53 if keywords:
54 members = [obj for obj in members if
55 keywords in obj.nickname.lower() or
56 keywords in obj.user.first_name.lower() or
57 keywords in obj.user.last_name.lower() or
58 keywords in obj.user.username.lower()]
```LaunchSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/86Zoeken in members werkt alleen als de keywords lowercase zijn2016-10-05T23:28:25+02:00Jelle Besselingjelle@pingiun.comZoeken in members werkt alleen als de keywords lowercase zijnBij het zoeken worden de keywords vergeleken met de lowercase namen, usernames en nicknames. Dus als gebruikers hoofdletters gebruiken in zoektermen komen er nooit resultaten. Keywords moeten ook lowercase gemaakt worden om search te lat...Bij het zoeken worden de keywords vergeleken met de lowercase namen, usernames en nicknames. Dus als gebruikers hoofdletters gebruiken in zoektermen komen er nooit resultaten. Keywords moeten ook lowercase gemaakt worden om search te laten werken.LaunchSébastiaan VersteegSébastiaan Versteeg