concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-04-10T20:32:05+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/849Banner Dimensions Not in Styleguide2019-04-10T20:32:05+02:00Thijs de JongBanner Dimensions Not in Styleguide### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/680Batch accepting registrations doesn't create payment2018-09-12T16:23:08+02:00Sébastiaan VersteegBatch accepting registrations doesn't create payment### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch o...### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch of registrationshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/551'become a member' forms not present on website2018-01-11T23:05:45+01:00Thom Wiggers'become a member' forms not present on website### One-sentence description
They're not on https://thalia.nu/admin/members/becomeamemberdocument/ / https://thalia.nu/become-a-member/### One-sentence description
They're not on https://thalia.nu/admin/members/becomeamemberdocument/ / https://thalia.nu/become-a-member/https://gitlab.science.ru.nl/thalia/concrexit/-/issues/415Besturen maken en bewerken is defect als er geen einddatum is ingevuld2017-12-10T21:29:47+01:00Thom WiggersBesturen maken en bewerken is defect als er geen einddatum is ingevuld**[bug]**
### One-sentence description
Het maken van besturen is stuk als je geen einddatum invult, `validate_unique` kan niet handelen dat `until` `None` is.
### Current behaviour
Crash
### Expected behaviour
Gemaakt bestuu...**[bug]**
### One-sentence description
Het maken van besturen is stuk als je geen einddatum invult, `validate_unique` kan niet handelen dat `until` `None` is.
### Current behaviour
Crash
### Expected behaviour
Gemaakt bestuur
### Steps to reproduce
1. Probeer een bestuur te maken met alleen een begindatum of geen van beide
2. Huil.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/927Birthday not visible on profile edit page2019-10-02T20:36:22+02:00Thom WiggersBirthday not visible on profile edit page### One-sentence description
There is a button that shows that your birthday can be visible, but you can’t check it’s value. For comparison, the name (which is also not editable) _is_ visible.
### Current behaviour / Reproducing the ...### One-sentence description
There is a button that shows that your birthday can be visible, but you can’t check it’s value. For comparison, the name (which is also not editable) _is_ visible.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
![Schermfoto_2019-09-30_om_08.17.18](/uploads/57f7cd21332560ac6cf1ac24d39dd74f/Schermfoto_2019-09-30_om_08.17.18)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
![Schermfoto_2019-09-30_om_08.14.23](/uploads/54c419fd361ba123bd23f34b79b8ad32/Schermfoto_2019-09-30_om_08.14.23)Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/764Birthdays not showing up2018-11-08T14:45:26+01:00Freek van de Venfreek@freekvandeven.nlBirthdays not showing up### One-sentence description
Birthdays are not shown in the Calendar
<!-- What breaks -->
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
When you go to th...### One-sentence description
Birthdays are not shown in the Calendar
<!-- What breaks -->
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
When you go to the calendar and click the show birthdays button, birthdays are not shown
1. go to https://thalia.nu/events
2. click the show birthdays button
3. birthdays don't show up
4. click on month to reload the calendar, now birthdays will show up
### Expected behaviour
When you click the show birthdays button, the calendar will reload with the birthday information.
<!-- Please write how what happened did not meet your expectations -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/958Block changing your email address in the administration to members.thalia.nu2019-11-27T19:49:53+01:00Sébastiaan VersteegBlock changing your email address in the administration to members.thalia.nu### One-sentence description
Block changing your email address in the administration to members.thalia.nu
### Current behaviour / Reproducing the bug
Users can change their email address to members.thalia.nu.
### Expected behaviour
...### One-sentence description
Block changing your email address in the administration to members.thalia.nu
### Current behaviour / Reproducing the bug
Users can change their email address to members.thalia.nu.
### Expected behaviour
No changing to addresses using this domain. Since we do not want these addresses in the administration. We cannot rely on them to stay active.29Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/416Board membership cannot have end dates2019-04-12T23:42:09+02:00Thom WiggersBoard membership cannot have end dates### One-sentence description
Board members are currently not allowed to have an end date for their group membership even though we might want them to have one. Examples are the boards of 2012-2013 and 2017-2018.
### Current behaviour
1...### One-sentence description
Board members are currently not allowed to have an end date for their group membership even though we might want them to have one. Examples are the boards of 2012-2013 and 2017-2018.
### Current behaviour
1. Try to enter an end date for a board membership.
2. Does not work
### Expected behaviour
Should workTobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/664Bug on registering as member with incomplete form2018-08-08T10:34:17+02:00Sébastiaan VersteegBug on registering as member with incomplete form### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`...### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`/registration/register`)
2. Enter the form and leave the starting year _empty_.
3. Submit
4. Error!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/779Buttons in event are ugly2018-11-21T19:44:18+01:00Sébastiaan VersteegButtons in event are ugly### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected beh...### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected behaviour
Space between the buttons20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/789Calendar listview should be 'all future events'2018-12-12T21:00:19+01:00Sébastiaan VersteegCalendar listview should be 'all future events'### One-sentence description
Calendar listview should be 'all future events'
### Current behaviour / Reproducing the bug
Shows events in one week
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
### Expected behaviour
Shows all futu...### One-sentence description
Calendar listview should be 'all future events'
### Current behaviour / Reproducing the bug
Shows events in one week
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
### Expected behaviour
Shows all future events
### Why?
Multiple people have expressed their discontent with the new workings of the listview on the website, in their eyes this is a bug.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/565Cancelling event registrations is broken2018-02-07T19:48:37+01:00Thom WiggersCancelling event registrations is broken### One-sentence description
Cancelling is broken
### Current behaviour
Crash
```
Traceback:
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
41. response = get_response(request)
...### One-sentence description
Cancelling is broken
### Current behaviour
Crash
```
Traceback:
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
41. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
187. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
185. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
68. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in _wrapper
67. return bound_func(*args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
23. return view_func(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in bound_func
63. return func.__get__(self, type(self))(*args2, **kwargs2)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
88. return handler(request, *args, **kwargs)
File "./events/views.py" in post
88. services.cancel_registration(request, request.member, event)
File "./events/services.py" in cancel_registration
110. emails.notify_first_waiting(request, event)
File "./events/emails.py" in notify_first_waiting
25. language = first_waiting_member.member.language
Exception Type: AttributeError at /events/246/registration/cancel/
Exception Value: 'Member' object has no attribute 'member'
Request information:
```
### Expected behaviour
no crash.
### Steps to reproduce
1.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/525Cancel registration in 'registration information fields' not canceling2017-10-14T13:22:13+02:00Job DoesburgCancel registration in 'registration information fields' not canceling### One-sentence description
See title
### Current behaviour
See title
### Expected behaviour
Does cancel
### Steps to reproduce
1. Try to register for an event that does have extra 'registration information fields', like the pub craw...### One-sentence description
See title
### Current behaviour
See title
### Expected behaviour
Does cancel
### Steps to reproduce
1. Try to register for an event that does have extra 'registration information fields', like the pub crawl.
2. After hitting the register button, a new page is loaded with the extra information fields.
3. Hit cancel.
4. You're still enrolled for the event :(1.12Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/465Cannot fill in event fields when registering2017-12-10T21:29:27+01:00Luuk ScholtenCannot fill in event fields when registeringIntroduced in !477
### One-sentence description
Cannot fill in event fields when registering for an event with registration fields.
### Current behaviour
When you register for an event with fields, you must fill in the fields and press ...Introduced in !477
### One-sentence description
Cannot fill in event fields when registering for an event with registration fields.
### Current behaviour
When you register for an event with fields, you must fill in the fields and press submit.
This does not save the fields, but you are registered.
### Expected behaviour
The fields are saved and you are registered.
### Steps to reproduce
1. Go to an event with fields
2. Make sure you are not registered
3. Press the register button, your registration should be submitted
4. Fill in the required fields
5. Get redirected to the events page, with the error "you were already registered"
6. Press 'update registration'
7. See that your submitted fields have not been savedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/925Cannot fill in field for guest registration2019-12-02T22:39:00+01:00Ayala HoeksCannot fill in field for guest registration### One-sentence description
It is not possible to enter data in a event registration field
### Current behaviour / Reproducing the bug
1. Go to event
2. Click on a guest registration (I did not try what happens if I try to change thi...### One-sentence description
It is not possible to enter data in a event registration field
### Current behaviour / Reproducing the bug
1. Go to event
2. Click on a guest registration (I did not try what happens if I try to change this field for a member registration)
3. Click 'edit registration field'
4. Enter the data
5. Hit enter (as there is no save button).
5a. get the banner 'data has been saved'
6. Close the registration
7. Go to the event
8. Data is not saved, the registration field is still emty :(
### Expected behaviour
Data can be added to the registration fieldsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/119Cannot open event detail page when not logged in2018-11-25T01:46:13+01:00Luuk ScholtenCannot open event detail page when not logged inLaunchhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/797Cannot open unpublished events in admin2018-12-12T18:52:49+01:00Sébastiaan VersteegCannot open unpublished events in admin### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview20https://gitlab.science.ru.nl/thalia/concrexit/-/issues/819Cannot order for a pizza event without notification2019-02-13T20:54:35+01:00Sébastiaan VersteegCannot order for a pizza event without notification### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder...### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder
2. Order a pizza
3. Crash
### Expected behaviour
No crash22Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/822Cannot register payment of external event registration2019-02-13T20:52:46+01:00Job DoesburgCannot register payment of external event registration### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration ...### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration - not a member but fill in a empty name
3. Save
4. In the overview, change the payment from 'not paid' to 'pin' or 'cash'
5. Reload the page, the payment is not registered
6. profit
### Expected behaviour
Should be clear I guess22Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/915Cannot update pizza order status with event override permission2019-10-23T19:03:54+02:00Sébastiaan VersteegCannot update pizza order status with event override permission### One-sentence description
Cannot update pizza order status with event override permission
### Current behaviour / Reproducing the bug
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have overri...### One-sentence description
Cannot update pizza order status with event override permission
### Current behaviour / Reproducing the bug
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have override event permission
3. Try to change the payment status of an order of said pizza event
4. Unable to change, 404 from API
### Expected behaviour
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have override event permission
3. Try to change the payment status of an order of said pizza event
4. Working28