concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-02-13T20:54:35+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/819Cannot order for a pizza event without notification2019-02-13T20:54:35+01:00Sébastiaan VersteegCannot order for a pizza event without notification### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder...### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder
2. Order a pizza
3. Crash
### Expected behaviour
No crash22Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/797Cannot open unpublished events in admin2018-12-12T18:52:49+01:00Sébastiaan VersteegCannot open unpublished events in admin### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview20https://gitlab.science.ru.nl/thalia/concrexit/-/issues/567Marking pizzas as paid is broken2018-02-12T16:22:57+01:00Thom WiggersMarking pizzas as paid is broken### One-sentence description
Marking pizzas as paid is broken via pizza interface (not admin)
### Current behaviour
### Expected behaviour
### Steps to reproduce
1.### One-sentence description
Marking pizzas as paid is broken via pizza interface (not admin)
### Current behaviour
### Expected behaviour
### Steps to reproduce
1.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/562Newsletter uses old is_active2018-01-28T20:48:57+01:00Thom WiggersNewsletter uses old is_active### One-sentence description
Newsletter sending breaks due to old `members` api.
https://thalia-www.slack.com/archives/C3RSHV4S0/p1516575117000059### One-sentence description
Newsletter sending breaks due to old `members` api.
https://thalia-www.slack.com/archives/C3RSHV4S0/p1516575117000059Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1028Original images in photo albums are saved and downloaded2020-03-11T23:56:39+01:00Gijs HendriksenOriginal images in photo albums are saved and downloaded### One-sentence description
<!-- What breaks -->
When downloading a photo album, both the original and downscaled images are downloaded, even though we're not supposed to save the original image.
### Current behaviour / Reproducing t...### One-sentence description
<!-- What breaks -->
When downloading a photo album, both the original and downscaled images are downloaded, even though we're not supposed to save the original image.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Download a photo album
2. Notice the original images are saved and included in the album (`*.JPG`), alongside the downscaled images (`*.jpg`)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
1. Download a photo album
2. Only the downscaled images are saved and includedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1024ProgrammingError: more than one row returned by a subquery used as an expression2020-03-01T16:38:36+01:00Thalia TechnicieProgrammingError: more than one row returned by a subquery used as an expressionSentry Issue: [CONCREXIT-27](https://sentry.io/organizations/thalia/issues/1540717591/?referrer=gitlab_integration)
```
CardinalityViolation: more than one row returned by a subquery used as an expression
File "django/db/backends/uti...Sentry Issue: [CONCREXIT-27](https://sentry.io/organizations/thalia/issues/1540717591/?referrer=gitlab_integration)
```
CardinalityViolation: more than one row returned by a subquery used as an expression
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
ProgrammingError: more than one row returned by a subquery used as an expression
(11 additional frame(s) were not displayed)
...
File "django/db/backends/utils.py", line 68, in execute
return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
File "django/db/backends/utils.py", line 77, in _execute_with_wrappers
return executor(sql, params, many, context)
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
File "django/db/utils.py", line 90, in __exit__
raise dj_exc_value.with_traceback(traceback) from exc_value
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1002Superuser cannot edit/view events as if organizer2020-01-29T21:54:48+01:00Job DoesburgSuperuser cannot edit/view events as if organizer### One-sentence description
Superuser cannot edit/view events as if organizer
### Current behaviour / Reproducing the bug
Superusers cannot view events as if organizer
### Expected behaviour
Superusers are almighty### One-sentence description
Superuser cannot edit/view events as if organizer
### Current behaviour / Reproducing the bug
Superusers cannot view events as if organizer
### Expected behaviour
Superusers are almightyhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/992KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Thalia TechnicieKeyError: 'delete_selected'Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line...Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line 45, in _wrapper
return bound_method(*args, **kwargs)
File "django/utils/decorators.py", line 142, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/options.py", line 1685, in changelist_view
cl = self.get_changelist_instance(request)
File "django/contrib/admin/options.py", line 727, in get_changelist_instance
if self.get_actions(request):
File "events/admin.py", line 205, in get_actions
del actions['delete_selected']
```30Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/955Events cannot be edited when guest registrations were added2020-01-25T22:45:12+01:00Sébastiaan VersteegEvents cannot be edited when guest registrations were added### One-sentence description
Events cannot be edited when guest registrations were added
### Current behaviour / Reproducing the bug
1. Create an event and publish
2. Add a guest registration
3. Edit the event
4. Crashes on the save o...### One-sentence description
Events cannot be edited when guest registrations were added
### Current behaviour / Reproducing the bug
1. Create an event and publish
2. Add a guest registration
3. Edit the event
4. Crashes on the save of the push notification, the guest registration is `null`
### Expected behaviour
The guest registration should be filtered out of the list of members when the event is saved.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/941event registration terms and conditions link broken2019-10-24T19:17:38+02:00Nick van Oersevent registration terms and conditions link broken### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/905Unpublished events end up in the newsletter agenda2019-08-28T19:20:58+02:00Sébastiaan VersteegUnpublished events end up in the newsletter agenda### One-sentence description
<!-- What breaks -->
### Current behaviour / Reproducing the bug
When you create a newsletter and there are unpublished events in the next two weeks they will be included in the newsletter.
### Expected ...### One-sentence description
<!-- What breaks -->
### Current behaviour / Reproducing the bug
When you create a newsletter and there are unpublished events in the next two weeks they will be included in the newsletter.
### Expected behaviour
Unpublished events should not be included.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/899Society memberships shown twice on profile page2019-09-04T13:05:10+02:00Joren VranckenSociety memberships shown twice on profile page### One-sentence description
<!-- What breaks -->
Society memberships shown twice on profile page.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1....### One-sentence description
<!-- What breaks -->
Society memberships shown twice on profile page.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to [my profile page](https://thalia.nu/members/profile/1239).
2. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
Society memberships are only shown under "SOCIETIES".26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/870CSV export does not contain payment values2019-05-15T19:33:27+02:00Job DoesburgCSV export does not contain payment values### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible...### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible in the admin24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/861End date not copied correctly into newsletter2019-04-17T19:35:40+02:00Ayala HoeksEnd date not copied correctly into newsletter### One-sentence description
End date not copied correctly into newsletter
### Current behaviour / Reproducing the bug
1. Select an event in a newsletter item of a new newsletter
2. The end date does not match the end date of the even...### One-sentence description
End date not copied correctly into newsletter
### Current behaviour / Reproducing the bug
1. Select an event in a newsletter item of a new newsletter
2. The end date does not match the end date of the event, it is the start date
### Expected behaviour
1. Select an event in a newsletter item of a new newsletter
2. The end date matches the end date of the event
24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/860Warning about costs not in newsletter if event price = 02019-11-03T12:54:58+01:00Ayala HoeksWarning about costs not in newsletter if event price = 0### One-sentence description
The warning about the costs and registration/un-registration deadline is not shown when the price of the event is 0.
### Current behaviour / Reproducing the bug
1. Add an event without a price
2. The 'Show...### One-sentence description
The warning about the costs and registration/un-registration deadline is not shown when the price of the event is 0.
### Current behaviour / Reproducing the bug
1. Add an event without a price
2. The 'Show warnings about costs' checkbox is checked
3. Show preview of the newsletter
4. The warning is not in the newsletter
### Expected behaviour
The warning should be there if the checkbox is checked24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/859Event terms has point 6 double2019-04-17T20:30:27+02:00Sébastiaan VersteegEvent terms has point 6 double### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/848Remove duplicates from activemembers mailinglist2019-04-10T19:29:26+02:00Sébastiaan VersteegRemove duplicates from activemembers mailinglist### One-sentence description
Remove duplicates from activemembers mailinglist
### Current behaviour / Reproducing the bug
The activemembers output for the mailinglists currently contains an email address per MemberGroupMembership. It'...### One-sentence description
Remove duplicates from activemembers mailinglist
### Current behaviour / Reproducing the bug
The activemembers output for the mailinglists currently contains an email address per MemberGroupMembership. It's not distinct.
### Expected behaviour
Distinct list.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/846Name of programme at registration page is "Informatica" instead of "Computing...2019-04-03T20:10:10+02:00Job DoesburgName of programme at registration page is "Informatica" instead of "Computing Science"### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this conf...### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this confusing since in their opinion they study "Computing Science"
### Current behaviour / Reproducing the bug
Go to the registration page, check out the dropdown menu
### Expected behaviour
Display something like "Informatica (Computing Science)"
P.S: a 'won't fix' would be a pretty good solution here in my opinion but I thought it could be nice to mentionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/839Update event registration of non-member does not work2019-03-27T20:33:33+01:00Sébastiaan VersteegUpdate event registration of non-member does not work### One-sentence description
Update event registration of non-member does not work
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/443/
### Expected behaviour
It should work.### One-sentence description
Update event registration of non-member does not work
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/443/
### Expected behaviour
It should work.23