concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-04-10T22:11:45+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/853Prevent double email addresses appearing in all the mailinglists2019-05-22T20:49:47+02:00Julian van der HorstPrevent double email addresses appearing in all the mailinglists### One-sentence description
Mailingslist can have duplicate emails.
### Current behaviour / Reproducing the bug
Steps to reproduce:
1. Create 2 users with duplicate email addresses in list for each membership
2. Check API Mailinglist...### One-sentence description
Mailingslist can have duplicate emails.
### Current behaviour / Reproducing the bug
Steps to reproduce:
1. Create 2 users with duplicate email addresses in list for each membership
2. Check API Mailinglists
3. You two times the email
### Expected behaviour
It should contain only distinct emailadresses24Julian van der HorstJulian van der Horsthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/851Set restraints on start year at user creation2019-09-18T21:29:48+02:00Bart HofmanSet restraints on start year at user creation### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behav...### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behaviour
Make a dropdown and be able to only select actually existing cohortsBart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/850Dataminimisation deletes website profile2019-10-03T16:37:53+02:00Luko van der MaasDataminimisation deletes website profile
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removed
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removedLuna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/849Banner Dimensions Not in Styleguide2019-04-10T20:32:05+02:00Thijs de JongBanner Dimensions Not in Styleguide### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/848Remove duplicates from activemembers mailinglist2019-04-10T19:29:26+02:00Sébastiaan VersteegRemove duplicates from activemembers mailinglist### One-sentence description
Remove duplicates from activemembers mailinglist
### Current behaviour / Reproducing the bug
The activemembers output for the mailinglists currently contains an email address per MemberGroupMembership. It'...### One-sentence description
Remove duplicates from activemembers mailinglist
### Current behaviour / Reproducing the bug
The activemembers output for the mailinglists currently contains an email address per MemberGroupMembership. It's not distinct.
### Expected behaviour
Distinct list.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/846Name of programme at registration page is "Informatica" instead of "Computing...2019-04-03T20:10:10+02:00Job DoesburgName of programme at registration page is "Informatica" instead of "Computing Science"### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this conf...### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this confusing since in their opinion they study "Computing Science"
### Current behaviour / Reproducing the bug
Go to the registration page, check out the dropdown menu
### Expected behaviour
Display something like "Informatica (Computing Science)"
P.S: a 'won't fix' would be a pretty good solution here in my opinion but I thought it could be nice to mentionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/845Some pages are only available in English2019-04-01T15:08:19+02:00Job DoesburgSome pages are only available in English### One-sentence description
Some pages are only available in English
### Current behaviour / Reproducing the bug
For example https://thalia.nu/boards/ or https://thalia.nu/societies/
### Expected behaviour
Be available in 2 languages### One-sentence description
Some pages are only available in English
### Current behaviour / Reproducing the bug
For example https://thalia.nu/boards/ or https://thalia.nu/societies/
### Expected behaviour
Be available in 2 languageshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/842Mailing lists api fails without boards2019-10-03T17:23:45+02:00Joren VranckenMailing lists api fails without boards### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/Wouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/841Race condition in registration approve + save2019-03-27T20:52:50+01:00Job DoesburgRace condition in registration approve + save### One-sentence description
I'm not able to register a payment for an automatically approved registration of membership.
### Current behaviour / Reproducing the bug
1. Somebody registers as a member for Thalia and completes all steps...### One-sentence description
I'm not able to register a payment for an automatically approved registration of membership.
### Current behaviour / Reproducing the bug
1. Somebody registers as a member for Thalia and completes all steps
2. Approve registration
3. Save registration within a couple of seconds
3. There is no button for payment
4. I hit the 're-evaluate' button and again approve the registration
5. Now there are buttons
### Expected behaviour
Buttons immediately, or members not being approved automaticallyhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/839Update event registration of non-member does not work2019-03-27T20:33:33+01:00Sébastiaan VersteegUpdate event registration of non-member does not work### One-sentence description
Update event registration of non-member does not work
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/443/
### Expected behaviour
It should work.### One-sentence description
Update event registration of non-member does not work
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/443/
### Expected behaviour
It should work.23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/835Use correct language attribute in html tag2019-03-27T19:18:56+01:00Jelle Besselingjelle@pingiun.comUse correct language attribute in html tag<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The `lang` attribute of the root html element is hardcoded to "en", this can be set to the LANGUAGE_CODE
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
The [specification recommends it](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Specifications).
<!-- Please motivate why we should invest into this change -->
### Current implementation
The value is hardcoded to `"en"`
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Set the lang attribute to the current language code
<!-- Provide (a) suggestion(s) for how we could approach this -->Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/834Photo albums not greyed out when outside membership period2019-03-27T19:18:01+01:00Sébastiaan VersteegPhoto albums not greyed out when outside membership period### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos pa...### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos package.
3. All albums are in colours
### Expected behaviour
The albums that the user cannot access should be grayscale.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/828Committee/Society Names on Profile Page Should be Clickable2019-02-13T21:24:43+01:00Thijs de JongCommittee/Society Names on Profile Page Should be Clickable### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievem...### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievements for Thalia. At this moment, if you click on the committees/societies, nothing happens.
### Expected behaviour
When you click on a committee/society underneath the Achievements for Thalia, it sends you to the Page of the corresponding committee/society.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/827Improve Createfixtures Command2019-02-27T20:13:20+01:00Thijs de JongImprove Createfixtures CommandAt this point, the Createfixtures command does not work optimal.
For instance:
-When you try to create random events, most of the time, those events are in the past.
-We you try to create a committee, you need at least 20 users, so it...At this point, the Createfixtures command does not work optimal.
For instance:
-When you try to create random events, most of the time, those events are in the past.
-We you try to create a committee, you need at least 20 users, so it does not do anything.
Expected behaviour:
Being able to use the createfixtures command without any trouble, so that everything works quick and flawless.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/824Members overview already shows the 2019 cohort in filters2019-02-13T19:06:34+01:00Sébastiaan VersteegMembers overview already shows the 2019 cohort in filters### One-sentence description
Members overview already shows the 2019 cohort
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/
2. See the tab for 2019
### Expected behaviour
1. Go to https://thalia.nu/memb...### One-sentence description
Members overview already shows the 2019 cohort
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/
2. See the tab for 2019
### Expected behaviour
1. Go to https://thalia.nu/members/
2. No tab for 2019 yet22Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/823Date formatting in agenda listview2019-02-13T19:51:08+01:00Leon van den BoogaardDate formatting in agenda listview<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dat...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dates are rendered in the formatting YYYY/MM/DD. Could you change the Dutch version of the output follow the Dutch standard (DD/MM/YYYY).
### Why?
Because it is logical.
### Current implementation
YYYY/MM/DD
### Suggested implementation
DD/MM/YYY22Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/822Cannot register payment of external event registration2019-02-13T20:52:46+01:00Job DoesburgCannot register payment of external event registration### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration ...### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration - not a member but fill in a empty name
3. Save
4. In the overview, change the payment from 'not paid' to 'pin' or 'cash'
5. Reload the page, the payment is not registered
6. profit
### Expected behaviour
Should be clear I guess22Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/819Cannot order for a pizza event without notification2019-02-13T20:54:35+01:00Sébastiaan VersteegCannot order for a pizza event without notification### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder...### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder
2. Order a pizza
3. Crash
### Expected behaviour
No crash22Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/816Dates entered in newsletter cannot handle NL -> EN2019-01-30T19:38:02+01:00Ayala HoeksDates entered in newsletter cannot handle NL -> EN### One-sentence description
Dutch dateformat cannot switch to English
### Current behaviour / Reproducing the bug
When making the newsletter, dates are entered, during in-between saving the language the site is in changes. If the lan...### One-sentence description
Dutch dateformat cannot switch to English
### Current behaviour / Reproducing the bug
When making the newsletter, dates are entered, during in-between saving the language the site is in changes. If the language (in another tab) changes from English to Dutch, the format the dates are in is changed accordingly. The other way around, from Dutch date format to English, does not work. The newsletter cannot change them and sees them as invalid
1. Enter a date
2. Change language from Dutch to English
3. Invalid date
### Expected behaviour
I expected the date to change back to the English format, or not to change at all, or maybe that both get accepted.