concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-02-13T19:51:08+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/823Date formatting in agenda listview2019-02-13T19:51:08+01:00Leon van den BoogaardDate formatting in agenda listview<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dat...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dates are rendered in the formatting YYYY/MM/DD. Could you change the Dutch version of the output follow the Dutch standard (DD/MM/YYYY).
### Why?
Because it is logical.
### Current implementation
YYYY/MM/DD
### Suggested implementation
DD/MM/YYY22Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/822Cannot register payment of external event registration2019-02-13T20:52:46+01:00Job DoesburgCannot register payment of external event registration### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration ...### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration - not a member but fill in a empty name
3. Save
4. In the overview, change the payment from 'not paid' to 'pin' or 'cash'
5. Reload the page, the payment is not registered
6. profit
### Expected behaviour
Should be clear I guess22Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/819Cannot order for a pizza event without notification2019-02-13T20:54:35+01:00Sébastiaan VersteegCannot order for a pizza event without notification### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder...### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder
2. Order a pizza
3. Crash
### Expected behaviour
No crash22Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/816Dates entered in newsletter cannot handle NL -> EN2019-01-30T19:38:02+01:00Ayala HoeksDates entered in newsletter cannot handle NL -> EN### One-sentence description
Dutch dateformat cannot switch to English
### Current behaviour / Reproducing the bug
When making the newsletter, dates are entered, during in-between saving the language the site is in changes. If the lan...### One-sentence description
Dutch dateformat cannot switch to English
### Current behaviour / Reproducing the bug
When making the newsletter, dates are entered, during in-between saving the language the site is in changes. If the language (in another tab) changes from English to Dutch, the format the dates are in is changed accordingly. The other way around, from Dutch date format to English, does not work. The newsletter cannot change them and sees them as invalid
1. Enter a date
2. Change language from Dutch to English
3. Invalid date
### Expected behaviour
I expected the date to change back to the English format, or not to change at all, or maybe that both get accepted.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/808Switching language redirects to calendar of current week2019-06-20T14:16:36+02:00Joren VranckenSwitching language redirects to calendar of current week### One-sentence description
<!-- What breaks -->
Because the calendar date is set by using an anchor (`#`), switching the language redirects to the events page without the date.
### Current behaviour / Reproducing the bug
<!-- Pleas...### One-sentence description
<!-- What breaks -->
Because the calendar date is set by using an anchor (`#`), switching the language redirects to the events page without the date.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to the [calendar](https://thalia.nu/events/).
2. Observe the calendar is on the current week.
2. Go to a specific week.
3. Switch language.
4. Redirect to current week (this may redirect to the homepage if #806 is not fixed yet).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
When switching the language, the calendar does not reset to the current week.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/807automatic pizza save fix2019-01-23T20:12:59+01:00Luko van der Maasautomatic pizza save fix### One-sentence description
Saving of pizza events
### Current behaviour / Reproducing the bug
1. create a pizza event
2. Breakage
### Expected behaviour
no break plz### One-sentence description
Saving of pizza events
### Current behaviour / Reproducing the bug
1. create a pizza event
2. Breakage
### Expected behaviour
no break plzLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/806Switching language redirects to homepage2019-01-19T19:20:39+01:00Joren VranckenSwitching language redirects to homepage### One-sentence description
<!-- What breaks -->
Switching language redirects to homepage.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step ...### One-sentence description
<!-- What breaks -->
Switching language redirects to homepage.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to a page on the website. For example the [boards page](https://thalia.nu/boards/).
2. Change the language by clicking the flag in the top right corner.
3. Be redirected to the homepage (the language is changed correctly).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
1. Go to a page on the website. For example the [boards page](https://thalia.nu/boards/).
2. Change the language by clicking the flag in the top right corner.
3. Be redirected to the same page in the different language.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/805Scheduled messages are not deleted if events are deleted2019-01-23T20:02:51+01:00Sébastiaan VersteegScheduled messages are not deleted if events are deleted### One-sentence description
Scheduled messages are not deleted if events are deleted
### Current behaviour / Reproducing the bug
You still get scheduled messages for deleted events.
### Expected behaviour
No more messages for that eve...### One-sentence description
Scheduled messages are not deleted if events are deleted
### Current behaviour / Reproducing the bug
You still get scheduled messages for deleted events.
### Expected behaviour
No more messages for that event
This may be the case for the scheduled messages of pizza eventshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/803Newsletter week starts on sunday2019-01-06T16:38:38+01:00Joren VranckenNewsletter week starts on sunday### One-sentence description
<!-- What breaks -->
Newsletter week starts on sunday instead of monday.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--...### One-sentence description
<!-- What breaks -->
Newsletter week starts on sunday instead of monday.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
On sunday 06-01-2019 the newsletter said the week number is 2.
In the Netherlands weeks starting on monday and not sunday is the norm.
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
Weeks start on monday in the newsletter.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/802Weird behavior of thabloid-filters2019-01-03T12:34:53+01:00Job DoesburgWeird behavior of thabloid-filters### One-sentence description
The filter on the thabloid-page does not behave as expected.
### Current behaviour / Reproducing the bug
1. Try to open [https://thalia.nu/thabloid/#year-2017](https://thalia.nu/thabloid/)
2. Filter on tha...### One-sentence description
The filter on the thabloid-page does not behave as expected.
### Current behaviour / Reproducing the bug
1. Try to open [https://thalia.nu/thabloid/#year-2017](https://thalia.nu/thabloid/)
2. Filter on thabloids for a certain year (not all thabloids)
3. Look at the way the thabloids are lay out (empty blocks)![Schermafbeelding_2019-01-03_om_00.45.23](/uploads/13af331bc8d92242b76c94af347d4a27/Schermafbeelding_2019-01-03_om_00.45.23.png)
4. Profit
### Expected behaviour
I think it is clear.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/801Thumbnails of partner images2019-01-05T19:12:03+01:00Sébastiaan VersteegThumbnails of partner images### One-sentence description
Partner images do not have thumbnails
### Current behaviour / Reproducing the bug
Check all partner images
### Expected behaviour
Originals are not used### One-sentence description
Partner images do not have thumbnails
### Current behaviour / Reproducing the bug
Check all partner images
### Expected behaviour
Originals are not used21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/797Cannot open unpublished events in admin2018-12-12T18:52:49+01:00Sébastiaan VersteegCannot open unpublished events in admin### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview20https://gitlab.science.ru.nl/thalia/concrexit/-/issues/795Search button on photos page not responsive2018-12-16T16:08:24+01:00Sébastiaan VersteegSearch button on photos page not responsiveJust like #773
### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
Visit photos page on mobile
### Expected behaviour
Not ugly.Just like #773
### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
Visit photos page on mobile
### Expected behaviour
Not ugly.21https://gitlab.science.ru.nl/thalia/concrexit/-/issues/794Can still add `oudbesturen` as manual mailinglist2019-01-05T19:14:49+01:00Sébastiaan VersteegCan still add `oudbesturen` as manual mailinglistRelated to !1079 and !1071
### One-sentence description
Can still add `oudbesturen` as manual mailinglist
### Current behaviour / Reproducing the bug
1. Create a mailinglist or alias with the name 'oudbesturen'/'oldboards'.
### Expe...Related to !1079 and !1071
### One-sentence description
Can still add `oudbesturen` as manual mailinglist
### Current behaviour / Reproducing the bug
1. Create a mailinglist or alias with the name 'oudbesturen'/'oldboards'.
### Expected behaviour
Block creation.21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/793Thabloid filtering keeps items that should be hidden2018-12-16T16:09:32+01:00Sébastiaan VersteegThabloid filtering keeps items that should be hidden### One-sentence description
Thabloid filtering keeps items that should be hidden
### Current behaviour / Reproducing the bug
1. Go to the Thabloid page
2. Filter on a year
3. Notice that all the whitespace
### Expected behaviour
No...### One-sentence description
Thabloid filtering keeps items that should be hidden
### Current behaviour / Reproducing the bug
1. Go to the Thabloid page
2. Filter on a year
3. Notice that all the whitespace
### Expected behaviour
No whitespace, nice grid.
### Solution
The `col` items for the grid are not connected to the filter plugin, the content is hidden but the container is not resulting in the visible whitespace.21https://gitlab.science.ru.nl/thalia/concrexit/-/issues/791Committee-names are not nicely aligned in their box.2019-02-13T21:00:26+01:00Bram in 't ZandtCommittee-names are not nicely aligned in their box.### One-sentence description
The committee-names are not totally visible on smaller screens.
### Current behaviour / Reproducing the bug
Visit the committee-page on a mobile device (or turn on responsive-mode on your laptop). See screen...### One-sentence description
The committee-names are not totally visible on smaller screens.
### Current behaviour / Reproducing the bug
Visit the committee-page on a mobile device (or turn on responsive-mode on your laptop). See screenshots attached.
### Expected behaviour
Committee-names are nicely alligned in their respective box.
![image](/uploads/20c1eee8e268167f924ad366675525ef/image.png)
![image](/uploads/ab8c6541350708fb2b9043a6149920f0/image.png)Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/789Calendar listview should be 'all future events'2018-12-12T21:00:19+01:00Sébastiaan VersteegCalendar listview should be 'all future events'### One-sentence description
Calendar listview should be 'all future events'
### Current behaviour / Reproducing the bug
Shows events in one week
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
### Expected behaviour
Shows all futu...### One-sentence description
Calendar listview should be 'all future events'
### Current behaviour / Reproducing the bug
Shows events in one week
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
### Expected behaviour
Shows all future events
### Why?
Multiple people have expressed their discontent with the new workings of the listview on the website, in their eyes this is a bug.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/788Event price can change after registration start2018-12-18T15:56:21+01:00Sébastiaan VersteegEvent price can change after registration start### One-sentence description
Event price can change after registration start
### Current behaviour / Reproducing the bug
1. I register for an event accepting the costs etc
2. The costs change
3. I pay more than what I accepted
4. I'm ...### One-sentence description
Event price can change after registration start
### Current behaviour / Reproducing the bug
1. I register for an event accepting the costs etc
2. The costs change
3. I pay more than what I accepted
4. I'm angry :angry:
5. Problems
### Expected behaviour
Event prices cannot change after registration start!
---
This is also important for #632, since payments are made using the price in the event and if the price changes the payments cannot reflect that.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/784No Registration Needed Text is in English2018-11-28T21:02:16+01:00Thijs de JongNo Registration Needed Text is in English### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there ...### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there is no registration (NL), it says the default message in English, where it should be Dutch.
<!-- Please write what is happening and how we could reproduce it, if relevant -->
### Expected behaviour
The given text should be in Dutch.
<!-- Please write how what happened did not meet your expectations -->Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/783Always set rel="noopener" with target="_blank" for external domains2018-12-16T16:06:32+01:00Joren VranckenAlways set rel="noopener" with target="_blank" for external domains### One-sentence description
<!-- What breaks -->
Always set `rel="noopener"` with `target = "_blank"` for external domains.
### Why
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2...### One-sentence description
<!-- What breaks -->
Always set `rel="noopener"` with `target = "_blank"` for external domains.
### Why
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
Using `target="_blank"` without `rel="noopener"` for external domains is a security vulnerability.
* [source](https://www.tutorialdocs.com/article/html-opener-blank.html)
* [source](https://developers.google.com/web/tools/lighthouse/audits/noopener)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
`a` tags containing `target="_blank"` should also contain `rel="noopener noreferrer nofollow"`.21