concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-11-16T17:22:59+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/949Production build executes tests2019-11-16T17:22:59+01:00Sébastiaan VersteegProduction build executes tests### One-sentence description
Production build executes tests
### Current behaviour / Reproducing the bug
During production build the tests are executed, but the tests contain dev dependencies so the build fails.
### Expected behaviou...### One-sentence description
Production build executes tests
### Current behaviour / Reproducing the bug
During production build the tests are executed, but the tests contain dev dependencies so the build fails.
### Expected behaviour
No testshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/927Birthday not visible on profile edit page2019-10-02T20:36:22+02:00Thom WiggersBirthday not visible on profile edit page### One-sentence description
There is a button that shows that your birthday can be visible, but you can’t check it’s value. For comparison, the name (which is also not editable) _is_ visible.
### Current behaviour / Reproducing the ...### One-sentence description
There is a button that shows that your birthday can be visible, but you can’t check it’s value. For comparison, the name (which is also not editable) _is_ visible.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
![Schermfoto_2019-09-30_om_08.17.18](/uploads/57f7cd21332560ac6cf1ac24d39dd74f/Schermfoto_2019-09-30_om_08.17.18)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
![Schermfoto_2019-09-30_om_08.14.23](/uploads/54c419fd361ba123bd23f34b79b8ad32/Schermfoto_2019-09-30_om_08.14.23)Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/925Cannot fill in field for guest registration2019-12-02T22:39:00+01:00Ayala HoeksCannot fill in field for guest registration### One-sentence description
It is not possible to enter data in a event registration field
### Current behaviour / Reproducing the bug
1. Go to event
2. Click on a guest registration (I did not try what happens if I try to change thi...### One-sentence description
It is not possible to enter data in a event registration field
### Current behaviour / Reproducing the bug
1. Go to event
2. Click on a guest registration (I did not try what happens if I try to change this field for a member registration)
3. Click 'edit registration field'
4. Enter the data
5. Hit enter (as there is no save button).
5a. get the banner 'data has been saved'
6. Close the registration
7. Go to the event
8. Data is not saved, the registration field is still emty :(
### Expected behaviour
Data can be added to the registration fieldsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/917Vacancies overview is broken2019-09-06T16:55:58+02:00Sébastiaan VersteegVacancies overview is broken### One-sentence description
Vacancies overview is broken
### Current behaviour / Reproducing the bug
1. Go to the vacancies page
2. Doesn't work
### Expected behaviour
It should work### One-sentence description
Vacancies overview is broken
### Current behaviour / Reproducing the bug
1. Go to the vacancies page
2. Doesn't work
### Expected behaviour
It should work2019-09-11https://gitlab.science.ru.nl/thalia/concrexit/-/issues/915Cannot update pizza order status with event override permission2019-10-23T19:03:54+02:00Sébastiaan VersteegCannot update pizza order status with event override permission### One-sentence description
Cannot update pizza order status with event override permission
### Current behaviour / Reproducing the bug
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have overri...### One-sentence description
Cannot update pizza order status with event override permission
### Current behaviour / Reproducing the bug
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have override event permission
3. Try to change the payment status of an order of said pizza event
4. Unable to change, 404 from API
### Expected behaviour
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have override event permission
3. Try to change the payment status of an order of said pizza event
4. Working28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/912get_thumbnail_url crashes when image is missing2019-10-05T13:06:41+02:00Thalia Technicieget_thumbnail_url crashes when image is missingSentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additi...Sentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additional frame(s) were not displayed)
...
File "django/template/library.py", line 214, in render
_dict = self.func(*resolved_args, **resolved_kwargs)
File "activemembers/templatetags/activemembers_cards.py", line 47, in membergroup_member_card
ribbon=ribbon
File "members/templatetags/member_card.py", line 22, in member_card
settings.THUMBNAIL_SIZES['medium'])
File "utils/media/services.py", line 90, in get_thumbnail_url
os.path.getmtime(full_original_path)
File "genericpath.py", line 55, in getmtime
return os.stat(filename).st_mtime
```27Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/910A group membership can be added without filling in the group2019-11-13T21:59:18+01:00Luko van der MaasA group membership can be added without filling in the group### One-sentence description
A group membership can be added without filling in the group.
### Current behaviour / Reproducing the bug
1. Create a group membership for a user but don't fill in a group even though it is bold
2. breakag...### One-sentence description
A group membership can be added without filling in the group.
### Current behaviour / Reproducing the bug
1. Create a group membership for a user but don't fill in a group even though it is bold
2. breakage
### Expected behaviour
1. Create a group membership for a user but don't fill in a group even though it is bold
2. a error message that is more helpfullMarthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/908Registration student number field unclear2019-10-02T19:11:46+02:00Job DoesburgRegistration student number field unclear### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an e...### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an error
### Expected behaviour
Either accept it and add the s prefix automatically, or already show the prefix as standard value or example value of the field so people understand it betterSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/907Google Maps autofill during registration broken2019-08-30T11:37:56+02:00Job DoesburgGoogle Maps autofill during registration broken### One-sentence description
Google Maps autofill during registration is broken
### Current behaviour / Reproducing the bug
Try to use Google Maps autofill during registration. It is broken :(
### Expected behaviour
It should work### One-sentence description
Google Maps autofill during registration is broken
### Current behaviour / Reproducing the bug
Try to use Google Maps autofill during registration. It is broken :(
### Expected behaviour
It should workhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/906Push notifications don't show content only title twice2019-08-28T20:15:19+02:00Job DoesburgPush notifications don't show content only title twice### One-sentence description
At least on iOS, a push notifications show the title both as content and title of the notification.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduc...### One-sentence description
At least on iOS, a push notifications show the title both as content and title of the notification.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Send a push notification
2. Receive it
3. You see that on the phone, the title and content are the same (the title). The content is not visible
### Expected behaviour
Show the content as contenthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/904Photos show rotated2019-09-04T19:19:28+02:00Sébastiaan VersteegPhotos show rotated### One-sentence description
Photos show rotated
### Current behaviour / Reproducing the bug
https://thalia.nu/members/photos/2019-05-24-thalia-weekend/#gallery-268
### Expected behaviour
This picture should be right side up.### One-sentence description
Photos show rotated
### Current behaviour / Reproducing the bug
https://thalia.nu/members/photos/2019-05-24-thalia-weekend/#gallery-268
### Expected behaviour
This picture should be right side up.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/903Members can give references for registrations that start after their membersh...2019-08-28T19:57:40+02:00Sébastiaan VersteegMembers can give references for registrations that start after their membership ends### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a regi...### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Works
### Expected behaviour
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Does not workhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/901Existing benefactors can create registration references2019-08-28T19:57:42+02:00Sébastiaan VersteegExisting benefactors can create registration references### One-sentence description
Existing benefactors can create registration references
### Current behaviour / Reproducing the bug
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the n...### One-sentence description
Existing benefactors can create registration references
### Current behaviour / Reproducing the bug
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the new benefactor
4. Works
### Expected behaviour
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the new benefactor
4. Errorhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/900Societies frontend "this group does not have any members?"2019-08-14T20:16:43+02:00Job DoesburgSocieties frontend "this group does not have any members?"### One-sentence description
The societies page shows societies not having any members, while in the admin they do have members.
### Current behaviour / Reproducing the bug
Check a society at https://thalia.nu/societies/ they don't h...### One-sentence description
The societies page shows societies not having any members, while in the admin they do have members.
### Current behaviour / Reproducing the bug
Check a society at https://thalia.nu/societies/ they don't have any members?
### Expected behaviour
They should show members26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/895Pizza payments don't show processor of payment2019-06-25T16:47:34+02:00Job DoesburgPizza payments don't show processor of payment### One-sentence description
Pizza payments don't show processor of payment
### Current behaviour / Reproducing the bug
Check the payments overview. The pizza payments don't have a processor
### Expected behaviour
Show the person th...### One-sentence description
Pizza payments don't show processor of payment
### Current behaviour / Reproducing the bug
Check the payments overview. The pizza payments don't have a processor
### Expected behaviour
Show the person that processed the payment, just as for contribution and event paymentshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/891Use "Rules and Regulations" instead of "HR"2019-06-19T19:17:51+02:00Jelle Besselingjelle@pingiun.comUse "Rules and Regulations" instead of "HR"### One-sentence description
The [registration docs](https://gitlab.science.ru.nl/thalia/concrexit/blob/30c47a28110ab968497e059bd08fd3f44f994989/website/registrations/README.rst#L6) talk about "the HR", but the translation "Rules and Reg...### One-sentence description
The [registration docs](https://gitlab.science.ru.nl/thalia/concrexit/blob/30c47a28110ab968497e059bd08fd3f44f994989/website/registrations/README.rst#L6) talk about "the HR", but the translation "Rules and Regulations" should be used.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Read [the docs](https://docs.technicie.nl/master/registrations.html)
2. Dutch version of "HR" is used in an English text
### Expected behaviour
Use the translation which is used in the actual document: https://thalia.nu/documents/document/65/
<!-- Please write how what happened did not meet your expectations -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/883Changing GM minutes is confusing2019-06-26T20:13:17+02:00Ayala HoeksChanging GM minutes is confusing### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error th...### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error that Minutes are a required field.
### Expected behaviour
I expect to be able to make changes to the information without having to upload minutes.
### Suggested solution
Set the `extra` field of the InlineModelAdmin to 0. https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.InlineModelAdmin.extra
This way the default minutes form will be hidden and a user will be required to add it manually.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/882Cannot upload minutes2019-06-04T20:08:35+02:00Ayala HoeksCannot upload minutes### One-sentence description
Error message when uploading GM minutes
### Current behaviour / Reproducing the bug
Error message:
>File extension 'pdf' is not allowed. Allowed extensions are: '.txt, .pdf, .jpg, .jpeg, .png'.
1. Select...### One-sentence description
Error message when uploading GM minutes
### Current behaviour / Reproducing the bug
Error message:
>File extension 'pdf' is not allowed. Allowed extensions are: '.txt, .pdf, .jpg, .jpeg, .png'.
1. Select file to upload
2. Save
3. Error
### Expected behaviour
I expect no problems when uploading a file (filename: MinutesDate.pdf)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/872Pizza orders reachable for people not in the organising member group2019-08-28T19:10:53+02:00Sébastiaan VersteegPizza orders reachable for people not in the organising member group### One-sentence description
Pizza orders reachable for people not in the organising member group
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to m...### One-sentence description
Pizza orders reachable for people not in the organising member group
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected behaviour
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. The orders page is permission denied26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/871Events in iCal feed have incorrect links2019-05-07T15:25:11+02:00Jelle Besselingjelle@pingiun.comEvents in iCal feed have incorrect links### One-sentence description
![image](/uploads/06c69b0e476796c95fb61604d554c7a9/image.png)
Notice the double https://https://
I believe the html only shows because my calendar (macOS calendar) doesn't support it
### Current behaviour...### One-sentence description
![image](/uploads/06c69b0e476796c95fb61604d554c7a9/image.png)
Notice the double https://https://
I believe the html only shows because my calendar (macOS calendar) doesn't support it
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Have an event in the calendar
2. Look at the event in an external calendar application (via iCal feed)
3. The link to more information on the website does not work as it is malformed
### Expected behaviour
Links in the iCal feed have the correct https:// prefix
<!-- Please write how what happened did not meet your expectations -->