concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-21T19:24:54+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/780"Submit Exam" and "Submit Summary" buttons not aligned2018-11-21T19:24:54+01:00Joren Vrancken"Submit Exam" and "Submit Summary" buttons not aligned### One-sentence description
<!-- What breaks -->
"Submit Exam" and "Submit Summary" buttons not aligned on course pages.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, ...### One-sentence description
<!-- What breaks -->
"Submit Exam" and "Submit Summary" buttons not aligned on course pages.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to a course page (e.g. [Academic Writing for CS](https://thalia.nu/education/courses/72/)).
![2018_11_16_16_26_07](/uploads/966e201933628d873effc3e510b8f1f3/2018_11_16_16_26_07.png)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
"Submit Exam" and "Submit Summary" buttons are aligned on course pages.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/779Buttons in event are ugly2018-11-21T19:44:18+01:00Sébastiaan VersteegButtons in event are ugly### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected beh...### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected behaviour
Space between the buttons20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/774Member group photos are not scaled to aspect ratio in Chrome2018-11-18T15:12:08+01:00Sébastiaan VersteegMember group photos are not scaled to aspect ratio in Chrome### One-sentence description
Member group photos are not scaled to aspect ratio in Chrome
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.25.43](/uploads/8ae04d86405c19898eb1cae074ee595d/Screenshot_2018-11-15...### One-sentence description
Member group photos are not scaled to aspect ratio in Chrome
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.25.43](/uploads/8ae04d86405c19898eb1cae074ee595d/Screenshot_2018-11-15_at_11.25.43.png)
### Expected behaviour
Scale by aspect ratiohttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/773Search button on members page not responsive2018-12-10T16:41:50+01:00Sébastiaan VersteegSearch button on members page not responsive### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.23.44](/uploads/981102e2c7572b8071444c1dc5b16161/Screenshot_2018-11-15_at_11.23.44.png...### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.23.44](/uploads/981102e2c7572b8071444c1dc5b16161/Screenshot_2018-11-15_at_11.23.44.png)
### Expected behaviour
Not ugly.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/764Birthdays not showing up2018-11-08T14:45:26+01:00Freek van de Venfreek@freekvandeven.nlBirthdays not showing up### One-sentence description
Birthdays are not shown in the Calendar
<!-- What breaks -->
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
When you go to th...### One-sentence description
Birthdays are not shown in the Calendar
<!-- What breaks -->
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
When you go to the calendar and click the show birthdays button, birthdays are not shown
1. go to https://thalia.nu/events
2. click the show birthdays button
3. birthdays don't show up
4. click on month to reload the calendar, now birthdays will show up
### Expected behaviour
When you click the show birthdays button, the calendar will reload with the birthday information.
<!-- Please write how what happened did not meet your expectations -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/762New navbar hinders usability2018-11-08T15:10:03+01:00Ward TheunisseNew navbar hinders usabilityThe new navbar styling is a bit large. This is especially apparent on mobile, where it occupies about a third of the screen, making navigation harder than it used to be.
These screenshots were taken using an iphone 5s:
![photo598797508...The new navbar styling is a bit large. This is especially apparent on mobile, where it occupies about a third of the screen, making navigation harder than it used to be.
These screenshots were taken using an iphone 5s:
![photo5987975080199695786](/uploads/8da2de814e106202235592f4d1c4d09d/photo5987975080199695786.jpg)
![photo5987975080199695787](/uploads/ada8c46155b6e05d80d87b26979245d7/photo5987975080199695787.jpg)20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/756Account membership not translated2018-10-28T21:15:09+01:00Job DoesburgAccount membership not translated### One-sentence description
On https://thalia.nu/registration/renew/, the text is half English half Dutch (while Dutch is set as preferred language)
### Current behaviour / Reproducing the bug
1. Set account to Dutch.
2. Visit htt...### One-sentence description
On https://thalia.nu/registration/renew/, the text is half English half Dutch (while Dutch is set as preferred language)
### Current behaviour / Reproducing the bug
1. Set account to Dutch.
2. Visit https://thalia.nu/registration/renew/
3. Profit.
### Expected behaviour
Be fully dutch.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/755Split societies from 'Achievements for Thalia' to different header on profile2018-11-14T20:35:09+01:00Sébastiaan VersteegSplit societies from 'Achievements for Thalia' to different header on profile### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https:...### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https://thalia.nu/members/profile/2.
### Expected behaviour
Societies are in a different section, at least not displayed in the previously mentioned section.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/753Translation for 'show only nicknames' is incorrect2018-10-25T08:24:57+02:00Bram in 't ZandtTranslation for 'show only nicknames' is incorrect### One-sentence description
If a user selects 'only initials' as their display name this displays their nickname. When editing a user in admin selecting 'only initials' and not filling out the nickname produces an error.
### Current be...### One-sentence description
If a user selects 'only initials' as their display name this displays their nickname. When editing a user in admin selecting 'only initials' and not filling out the nickname produces an error.
### Current behaviour / Reproducing the bug 1
1. Select 'initials only' as display name in admin
2. Delete the nickname
3. Try to save the user
4. This produces the error that a nickname should be entered
### Current behaviour / Reproducing the bug 2
1. Select 'initials only' as display name in admin
2. Go to profile page
3. Only your nickname is displayed
### Expected behaviour
1. Select 'initials only' as display name in admin
2. Delete nickname but enter something for the initials
3. Try to save the user
4. This should work
### Expected behaviour 2
1. Select 'initials only' as display name
2. Go to profile page
3. Only initials should be displayedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/751Photos in shared albums aren't showing2018-10-24T15:17:27+02:00Luko van der MaasPhotos in shared albums aren't showing### One-sentence description
Photos in shared albums aren't showing
### Current behaviour / Reproducing the bug
View a shared photo album, all pictures are white.
### Expected behaviour
The pictures do show.### One-sentence description
Photos in shared albums aren't showing
### Current behaviour / Reproducing the bug
View a shared photo album, all pictures are white.
### Expected behaviour
The pictures do show.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/750Assert that the newsletter doesn't contain relative urls2018-11-10T17:13:09+01:00Sébastiaan VersteegAssert that the newsletter doesn't contain relative urls### One-sentence description
The newsletter contains relative urls and thus is linking to the admin
### Current behaviour / Reproducing the bug
1. Create a newsletter
2. Enter a url without http(s):// in content
3. Send newsletter
4. ...### One-sentence description
The newsletter contains relative urls and thus is linking to the admin
### Current behaviour / Reproducing the bug
1. Create a newsletter
2. Enter a url without http(s):// in content
3. Send newsletter
4. Open said url
5. Links to django admin
### Expected behaviour
No relative url in the newsletter. Thus checking for non-relative urls by checking if there are no mentions of the django admin in the eventual contents.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/737Links to user profiles on society page link to society.2018-10-22T19:07:32+02:00Joren VranckenLinks to user profiles on society page link to society.### One-sentence description
<!-- What breaks -->
Links to user profiles on society page link to society.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
...### One-sentence description
<!-- What breaks -->
Links to user profiles on society page link to society.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go the page of the [Cook's Guild](https://thalia.nu/societies/56/).
2. Click on a member.
3. You are redirected to the page of the [Cook's Guild](https://thalia.nu/societies/56/).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
1. Go the page of the [Cook's Guild](https://thalia.nu/societies/56/).
2. Click on a member.
3. You are redirected to the profile page of the member.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/736Csrf token is not always set on beta.thalia.nu2018-10-21T20:46:00+02:00Yannick HogewindCsrf token is not always set on beta.thalia.nu### One-sentence description
The CSRF token for the beta site is not always set, resulting in a 403 for requests that require a CSRF token.
### Current behaviour
The CSRF token is not set on every page, possibly only on the login page.
...### One-sentence description
The CSRF token for the beta site is not always set, resulting in a 403 for requests that require a CSRF token.
### Current behaviour
The CSRF token is not set on every page, possibly only on the login page.
### Expected behaviour
The CSRF token is set on every page.
### Steps to reproduce
1. Clear cookies for thalia.nu or start an incognito browser session.
2. Visit beta.thalia.nu
3. Click the flag in the top right to change the language.
This will result in a 403.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/726Not able to approve renewals2018-10-11T14:35:00+02:00Job DoesburgNot able to approve renewals### One-sentence description
The 'approve' button on the renewals page is dead
### Current behaviour
When hitting the 'approve' button, nothing happens and the page deadlocks. When doing it from the renewals overview (selecting and acti...### One-sentence description
The 'approve' button on the renewals page is dead
### Current behaviour
When hitting the 'approve' button, nothing happens and the page deadlocks. When doing it from the renewals overview (selecting and action via the dropdown menu) everything works fine luckily.
### Expected behaviour
A working button the renewal.
### Steps to reproduce
1. Look for an open renewal that needs approval.
2. Try to approve it by hitting the green button
3. Profit!https://gitlab.science.ru.nl/thalia/concrexit/-/issues/719Pipenv is pinned to 18.02018-10-12T17:46:13+02:00Joren VranckenPipenv is pinned to 18.0### One-sentence description
The CI builds were failing
### Current behaviour
```
$ tox -e ${PYTHON_VERSION}-${DJANGO_VERSION}
py36-django20 create: /builds/thalia/concrexit/.tox/py36-django20
py36-django20 installdeps: pipenv
py36-djan...### One-sentence description
The CI builds were failing
### Current behaviour
```
$ tox -e ${PYTHON_VERSION}-${DJANGO_VERSION}
py36-django20 create: /builds/thalia/concrexit/.tox/py36-django20
py36-django20 installdeps: pipenv
py36-django20 installed: certifi==2018.8.24,pipenv==2018.7.1,virtualenv==16.0.0,virtualenv-clone==0.3.0
py36-django20 runtests: PYTHONHASHSEED='2413802468'
py36-django20 runtests: commands[0] | pipenv --bare install --dev --ignore-pipfile
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead.
Installing dependencies from Pipfile.lock (731cb2)...
Traceback (most recent call last):
File "/builds/thalia/concrexit/.tox/py36-django20/bin/pipenv", line 11, in <module>
sys.exit(cli())
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
return self.main(*args, **kwargs)
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/cli.py", line 435, in install
selective_upgrade=selective_upgrade,
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/core.py", line 1943, in do_install
pypi_mirror=pypi_mirror,
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/core.py", line 1322, in do_init
pypi_mirror=pypi_mirror,
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/core.py", line 807, in do_install_dependencies
pypi_mirror=pypi_mirror,
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/core.py", line 1375, in pip_install
package_name.split('--hash')[0].split('--trusted-host')[0]
File "/builds/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 704, in from_line
line, extras = _strip_extras(line)
TypeError: 'module' object is not callable
ERROR: InvocationError for command '/builds/thalia/concrexit/.tox/py36-django20/bin/pipenv --bare install --dev --ignore-pipfile' (exited with code 1)
```
### Expected behaviour
The builds work.
### Steps to reproduce
1. Create a pipeline.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/703Prevent manual creation of automatically generated mailinglists2018-11-28T17:49:15+01:00Sébastiaan VersteegPrevent manual creation of automatically generated mailinglists### One-sentence description
Prevent manual creation of automatically generated mailinglists
### Desired behaviour
We have a lot of automatically created mailinglists, but it is still possible to create mailinglists with the same name...### One-sentence description
Prevent manual creation of automatically generated mailinglists
### Desired behaviour
We have a lot of automatically created mailinglists, but it is still possible to create mailinglists with the same name in the backend. This should be prevented.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/674sendexpirationnotification.py crashed2018-08-16T08:44:24+02:00Joren Vranckensendexpirationnotification.py crashed### One-sentence description
`sendexpirationnotification.py` crashed while being run by `cron`.
### Current behaviour
```
Cron <root@virtueleivo> /var/docker-compose/concrexit/manage.py.sh sendexpirationnotification 2>&1 > /var/www/co...### One-sentence description
`sendexpirationnotification.py` crashed while being run by `cron`.
### Current behaviour
```
Cron <root@virtueleivo> /var/docker-compose/concrexit/manage.py.sh sendexpirationnotification 2>&1 > /var/www/concrexit/log/cron_sendexpirationnotification.log
```
```
Traceback (most recent call last):
File "/usr/src/app/website/manage.py", line 19, in <module>
execute_from_command_line(sys.argv)
File "/usr/local/lib/python3.5/site-packages/django/core/management/__init__.py", line 371, in execute_from_command_line
utility.execute()
File "/usr/local/lib/python3.5/site-packages/django/core/management/__init__.py", line 365, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/usr/local/lib/python3.5/site-packages/django/core/management/base.py", line 288, in run_from_argv
self.execute(*args, **cmd_options)
File "/usr/local/lib/python3.5/site-packages/django/core/management/base.py", line 335, in execute
output = self.handle(*args, **options)
File "/usr/src/app/website/members/management/commands/sendexpirationnotification.py", line 18, in handle
emails.send_expiration_announcement(bool(options['dry-run']))
File "/usr/src/app/website/members/emails.py", line 90, in send_expiration_announcement
with translation.override(member.language):
AttributeError: 'Member' object has no attribute 'language'
```
### Expected behaviour
No crash
### Steps to reproduce
1. run `sendexpirationnotification.py` command.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/666Registration with same username causes problems on payment process2018-08-27T17:37:09+02:00Sébastiaan VersteegRegistration with same username causes problems on payment process### One-sentence description
Registration with same username causes problems on payment process
### Current behaviour
If two registrations exist with the same entered/generated username and the first is fully processed while the secon...### One-sentence description
Registration with same username causes problems on payment process
### Current behaviour
If two registrations exist with the same entered/generated username and the first is fully processed while the second is in the accepted stage the payment for that second registration will not be able to fully succeed since the username is taken. However, the payment is marked processed. Thus the registration will be in limbo, forever.
### Expected behaviour
No limbo!
### Steps to reproduce
1. Create two registrations with the same first and last name
2. Accept them both
3. Process payment for 1
4. Try to process payment for 2
5. Erreur! :boom:https://gitlab.science.ru.nl/thalia/concrexit/-/issues/665Crash on confirming non-existing email address2018-08-07T12:34:00+02:00Sébastiaan VersteegCrash on confirming non-existing email address### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stac...### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stacktrace
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
69. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
89. return handler(request, *args, **kwargs)
File "./registrations/views.py" in get
100. emails.send_new_registration_board_message(entry.get())
File "/usr/local/lib/python3.5/site-packages/django/db/models/query.py" in get
403. self.model._meta.object_name
Exception Type: DoesNotExist at /registration/confirm-email/33c721a7-c032-407b-82a0-2f81c4061804/
Exception Value: Entry matching query does not exist.
```1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/664Bug on registering as member with incomplete form2018-08-08T10:34:17+02:00Sébastiaan VersteegBug on registering as member with incomplete form### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`...### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`/registration/register`)
2. Enter the form and leave the starting year _empty_.
3. Submit
4. Error!1.16.2