concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-03-04T21:13:45+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1015RecursionError: maximum recursion depth exceeded while calling a Python object2020-03-04T21:13:45+01:00Thalia TechnicieRecursionError: maximum recursion depth exceeded while calling a Python objectThe below error occurs when trying to delete or unpublish an event from the event details page. @jdusseljee says the error doesn't happen if the unpublish action is used from the overview page.
Sentry Issue: [CONCREXIT-22](https://sentr...The below error occurs when trying to delete or unpublish an event from the event details page. @jdusseljee says the error doesn't happen if the unpublish action is used from the overview page.
Sentry Issue: [CONCREXIT-22](https://sentry.io/organizations/thalia/issues/1516920010/?referrer=gitlab_integration)
```
RecursionError: maximum recursion depth exceeded while calling a Python object
(245 additional frame(s) were not displayed)
...
File "django/db/models/query_utils.py", line 139, in __get__
instance.refresh_from_db(fields=[field_name])
File "django/db/models/base.py", line 627, in refresh_from_db
db_instance = db_instance_qs.get()
File "django/db/models/query.py", line 411, in get
num = len(clone)
File "django/db/models/query.py", line 258, in __len__
self._fetch_all()
File "django/utils/deconstruct.py", line 16, in __new__
obj = super(klass, cls).__new__(cls)
```Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1018Saving event crashes when registration start is placed before current date2020-03-04T21:13:44+01:00Jelle Besselingjelle@pingiun.comSaving event crashes when registration start is placed before current date### One-sentence description
Saving event crashes when registration start is placed before current date
<!-- What breaks -->
### Current behaviour / Reproducing the bug
1. Create an event
2. Set registration start date in the future
3....### One-sentence description
Saving event crashes when registration start is placed before current date
<!-- What breaks -->
### Current behaviour / Reproducing the bug
1. Create an event
2. Set registration start date in the future
3. Save event
4. Change registration date before current date
5. Crash (locally I get a `Fatal Python error: Cannot recover from stack overflow.`, which looks like infinite recursion
### Expected behaviour
Setting registration start date before current date opens registrationsJelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1008Show deregistration disclaimer text even if not registered for event2020-02-23T16:53:09+01:00Job DoesburgShow deregistration disclaimer text even if not registered for event### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how ...### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
Currently, the website does not show the deregistration disclaimer if you are not registered. This is undesirable, as it allows users to register for the event, without realising that they cannot deregister without paying a fine.
### Expected behaviour
Always state the disclaimer (just like in the app).
![IMG_753FFE892ACD-1](/uploads/fa6db1596eb92b1e2d5bbaa7a07ae4dd/IMG_753FFE892ACD-1.jpeg)Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/975/api/v1/token-auth does not return json on login failure2020-02-20T08:45:46+01:00Jelle Besselingjelle@pingiun.com/api/v1/token-auth does not return json on login failure### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expect...### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expected behaviour
Json object should be returnedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/981Missing translations in statistics page2020-02-19T23:46:54+01:00Job DoesburgMissing translations in statistics page### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right ch...### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right chart
### Expected behaviour
be translatedMark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/980Thalia Pay process button enabled in payments widget even though TPAY_ENABLED...2020-02-19T21:48:26+01:00Sébastiaan VersteegThalia Pay process button enabled in payments widget even though TPAY_ENABLED=False### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
#...### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
### Expected behaviour
1. I cannot click it
2. If I should be able to click it, it should not crash.Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/968Login message visible for events without registration2020-02-19T21:47:59+01:00Luna-Elise SchernthanerLogin message visible for events without registration### One-sentence description
A message and button are shown to log in to register for an event even when it is not possible to register for the event
### Current behaviour / Reproducing the bug
1. Visit the Thalia website without logg...### One-sentence description
A message and button are shown to log in to register for an event even when it is not possible to register for the event
### Current behaviour / Reproducing the bug
1. Visit the Thalia website without logging in
2. Find an event for which you cannot register (e.g. a borrel)
3. You see "You have to log in before you can register for this event." and a login button
### Expected behaviour
1. Visit the Thalia website without logging in
2. Find an event for which you cannot register (e.g. a borrel)
3. You do not see a message and button to log in to registerLuc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/978Event admin view does not include 'user-tools' like other admin templates2020-02-19T19:38:58+01:00Job DoesburgEvent admin view does not include 'user-tools' like other admin templates### One-sentence description
Event admin view does not include 'user-tools' like other admin templates
### Current behaviour / Reproducing the bug
Check an event admin details page. It does not contain the 'Welcome user, view website,...### One-sentence description
Event admin view does not include 'user-tools' like other admin templates
### Current behaviour / Reproducing the bug
Check an event admin details page. It does not contain the 'Welcome user, view website, change password, log out' user tools that all other admin pages do contain.
### Expected behaviour
Correctly extend the templates, so it is similar to the other admin viewsSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/999No favicon for the admin site2020-02-05T21:24:49+01:00Luko van der MaasNo favicon for the admin siteThe admin site has no favicon, not the development grayscale favicon and not the normal thalia favicon. This increases the risk of changing something on the wrong site.The admin site has no favicon, not the development grayscale favicon and not the normal thalia favicon. This increases the risk of changing something on the wrong site.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/979Login page visible when logged-in2020-02-05T21:24:02+01:00Sébastiaan VersteegLogin page visible when logged-in### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page s...### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page should redirect to home or something.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1004'All members' in members directory not marked as active2020-02-05T21:18:38+01:00Sébastiaan Versteeg'All members' in members directory not marked as active### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected ...### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected behaviour
1. Go to https://thalia.nu/members/directory/
2. The item is selectedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/685Improve privacy policy regarding server data2020-01-30T13:36:32+01:00Sébastiaan VersteegImprove privacy policy regarding server data@twiggers:
>If you want to write something about explicit and implicit data collected on the website, I'd call this section "Data collected on the website" and write "Certain actions on the website may cause data to be collected (such as...@twiggers:
>If you want to write something about explicit and implicit data collected on the website, I'd call this section "Data collected on the website" and write "Certain actions on the website may cause data to be collected (such as ordering a pizza on the website or registering to attend an event). We additionally may collect logs on anything happening on the site and app to ensure the correct functioning of the services provided. The Technicie tries to only collect data when errors occur."Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1002Superuser cannot edit/view events as if organizer2020-01-29T21:54:48+01:00Job DoesburgSuperuser cannot edit/view events as if organizer### One-sentence description
Superuser cannot edit/view events as if organizer
### Current behaviour / Reproducing the bug
Superusers cannot view events as if organizer
### Expected behaviour
Superusers are almighty### One-sentence description
Superuser cannot edit/view events as if organizer
### Current behaviour / Reproducing the bug
Superusers cannot view events as if organizer
### Expected behaviour
Superusers are almightyhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1001Fix styleguide link2020-01-27T16:10:04+01:00Jelle Besselingjelle@pingiun.comFix styleguide link### One-sentence description
The styleguide link on the website is broken.
### Current behaviour / Reproducing the bug
Try to download the styleguide, get a nextcloud error page.
### Expected behaviour
The link downloads a zip with the...### One-sentence description
The styleguide link on the website is broken.
### Current behaviour / Reproducing the bug
Try to download the styleguide, get a nextcloud error page.
### Expected behaviour
The link downloads a zip with the styleguide.
I know that sharing a folder from a shared drive in GSuite is not possible, but the link has been broken for a while and will be even more broken when NextCloud goes offline.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/919Event information is public2020-01-23T11:31:49+01:00Thomas Klein BretelerEvent information is publicEvent information is public
### Current behaviour / Reproducing the bug
Everyone on the internet can see the location and number of registration of events. Partners etc can follow the status and that might be undesirable.
You can chec...Event information is public
### Current behaviour / Reproducing the bug
Everyone on the internet can see the location and number of registration of events. Partners etc can follow the status and that might be undesirable.
You can check this by opening an event in incognito mode.
### Expected behaviour
Information should be only visible for members.Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/996Review Host DNS records are not removed when the review remove CI job is run2020-01-19T16:48:29+01:00Joren VranckenReview Host DNS records are not removed when the review remove CI job is run### One-sentence description
Review Host DNS records are not removed when the review remove CI job is run.
### Current behaviour / Reproducing the bug
The [command that removes the record](https://gitlab.science.ru.nl/thalia/concrexit/...### One-sentence description
Review Host DNS records are not removed when the review remove CI job is run.
### Current behaviour / Reproducing the bug
The [command that removes the record](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/.gitlab-ci.yml#L311) returns the following error:
```
Parameter validation failed:
Invalid length for parameter ChangeBatch.Changes, value: 0, valid range: 1-inf
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/982Missing colors in statistics committee chart2020-01-08T23:00:26+01:00Job DoesburgMissing colors in statistics committee chart### One-sentence description
We ran out of colors for all our committees
### Current behaviour / Reproducing the bug
Check the middle graph in https://thalia.nu/members/statistics/
### Expected behaviour
We can just reuse other colo...### One-sentence description
We ran out of colors for all our committees
### Current behaviour / Reproducing the bug
Check the middle graph in https://thalia.nu/members/statistics/
### Expected behaviour
We can just reuse other colors in my opinion. Or decide on which colors to use based on the total number of colors required (if 1 → magenta, is 2 → magenta and black, 3 or more → generate a list of shades ranging from full black to magenta to white).Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/992KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Thalia TechnicieKeyError: 'delete_selected'Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line...Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line 45, in _wrapper
return bound_method(*args, **kwargs)
File "django/utils/decorators.py", line 142, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/options.py", line 1685, in changelist_view
cl = self.get_changelist_instance(request)
File "django/contrib/admin/options.py", line 727, in get_changelist_instance
if self.get_actions(request):
File "events/admin.py", line 205, in get_actions
del actions['delete_selected']
```30Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/988internal server error on adding slide to event2019-12-12T13:48:15+01:00Job Doesburginternal server error on adding slide to event### One-sentence description
Adding a slide to an event produces an internal server error
### Current behaviour / Reproducing the bug
1. Add a slide
2. Try to select the slide in the event
3. Profit
### Expected behaviour
Do not crash### One-sentence description
Adding a slide to an event produces an internal server error
### Current behaviour / Reproducing the bug
1. Add a slide
2. Try to select the slide in the event
3. Profit
### Expected behaviour
Do not crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/925Cannot fill in field for guest registration2019-12-02T22:39:00+01:00Ayala HoeksCannot fill in field for guest registration### One-sentence description
It is not possible to enter data in a event registration field
### Current behaviour / Reproducing the bug
1. Go to event
2. Click on a guest registration (I did not try what happens if I try to change thi...### One-sentence description
It is not possible to enter data in a event registration field
### Current behaviour / Reproducing the bug
1. Go to event
2. Click on a guest registration (I did not try what happens if I try to change this field for a member registration)
3. Click 'edit registration field'
4. Enter the data
5. Hit enter (as there is no save button).
5a. get the banner 'data has been saved'
6. Close the registration
7. Go to the event
8. Data is not saved, the registration field is still emty :(
### Expected behaviour
Data can be added to the registration fieldsLuko van der MaasLuko van der Maas