concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-03-11T21:19:39+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1032Think of a way to improve partner logo's in dark mode2020-03-11T21:19:39+01:00Job DoesburgThink of a way to improve partner logo's in dark mode<!--
You want something new.
-->
### One-sentence description
Think of a way to improve partner logo's in dark mode
### Motivation
With current dark mode, some partner logo's look a bit weird
### Desired functionality
They shou...<!--
You want something new.
-->
### One-sentence description
Think of a way to improve partner logo's in dark mode
### Motivation
With current dark mode, some partner logo's look a bit weird
### Desired functionality
They should look good both in dark mode and light mode.
**Both in the banner, and in the vacancy pages**
### Suggested implementation
It is hard to do this correctly for all logo's. One way is to add a css filter in dark mode that makes the logo's more white. Another way could be to just support a dark mode and light mode logo.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1030Dark mode in newsletter2020-03-12T00:03:20+01:00Job DoesburgDark mode in newsletter### One-sentence description
Dark mode in newsletter
### Motivation
More dark is more better
### Desired functionality
A dark mode in newsletters, just as in the regular site
### Suggested implementation
Use the same stylesheets (...### One-sentence description
Dark mode in newsletter
### Motivation
More dark is more better
### Desired functionality
A dark mode in newsletters, just as in the regular site
### Suggested implementation
Use the same stylesheets (and svg images as well for that matter)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1014Add weekday to newsletter events2020-03-09T22:45:22+01:00Wouter DoelandAdd weekday to newsletter eventsIn the current newsletter, there is only a date and time next to the event. It would be nice if there also was a (week)day there, because most people plan activities based on what day they are.
### One-sentence description
Add the even...In the current newsletter, there is only a date and time next to the event. It would be nice if there also was a (week)day there, because most people plan activities based on what day they are.
### One-sentence description
Add the event day to events in the newsletter.
### Motivation
This change would make it more easy to plan events if you just read the newsletter from time to time.
### Desired functionality
Add the (week)day to the event info in the newsletter.
### Suggested implementation
WHERE
HG00.307
WHEN
Feb. 11, 2020, 12:15 p.m. - 13:15
PRICE
Free
->
WHERE
HG00.307
WHEN
Tue, Feb. 11, 2020, 12:15 p.m. - 13:15
PRICE
FreeWouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1012Export payment batch per topic / event2020-02-12T20:42:04+01:00Job DoesburgExport payment batch per topic / event### One-sentence description
Export payment batch per topic / event
### Motivation
Required for bookkeeping of Thalia Pay
### Desired functionality
Use the `payment_topic` from Payments, provided by `Payable` models
### Suggested i...### One-sentence description
Export payment batch per topic / event
### Motivation
Required for bookkeeping of Thalia Pay
### Desired functionality
Use the `payment_topic` from Payments, provided by `Payable` models
### Suggested implementation
Extend #932 with a second way of exportinghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1007Expiration date on partner pages2020-02-04T14:40:33+01:00Jen Dusseljeejendusseljee@gmail.comExpiration date on partner pages<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Can you add a functionality to set an expiration date on profile pages of partners.
### Motivation
<!-- Why should we care? -->
Because it ...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Can you add a functionality to set an expiration date on profile pages of partners.
### Motivation
<!-- Why should we care? -->
Because it is pretty annoying to have to memorise the duration of all contracts. It would be way easier to just be able to set an expiration date when the contract enters.
### Desired functionality
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
An extra date field in the admin page when editing/creating a partner page. When this date has passed, the profile page should automatically be set to inactive (maybe send a mail to extern@ to let the extern know when this happens).
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
-https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1006Miscellaneous annual files on document page2020-02-04T16:04:53+01:00Nick van OersMiscellaneous annual files on document page
<!--
You want something new.
-->
### One-sentence description
The ability to add more yearly files on the document page.
### Motivation
Normally things like the half year report are added as GM documents, but now we want to add ...
<!--
You want something new.
-->
### One-sentence description
The ability to add more yearly files on the document page.
### Motivation
Normally things like the half year report are added as GM documents, but now we want to add yearly documents that are not necessarily discussed at a GM. We want to add a report from the societies on how well everything worked that year, as the society rules state that they should publish this.
<!-- Why should we care? -->
### Desired functionality
A new section underneath the GMs, where miscellaneous or other documents can be added.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
### Suggested implementation
See picture in the comments.
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1003Create more kinds of fixtures2020-02-19T22:57:03+01:00Job DoesburgCreate more kinds of fixtures<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should b...<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should be created for courses. But also maybe for photos and albums, documents, payments, registrations?, etc...
### Suggested implementationSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/993Add face recognition to photos2020-02-21T14:34:56+01:00Sébastiaan VersteegAdd face recognition to photos### One-sentence description
Add face recognition to photos
### Motivation
Because it is really nice to be able to easily see all the photos taken of yourself.
### Desired functionality
I think there are two ways to implement this:
...### One-sentence description
Add face recognition to photos
### Motivation
Because it is really nice to be able to easily see all the photos taken of yourself.
### Desired functionality
I think there are two ways to implement this:
1. A single 'album' that shows all the pictures taken of you in reverse chronological order (oldest last).
2. An option to only show photos of you in every photo album
My preference would be option 1. This is what I implemented as [proof-of-concept](https://github.com/se-bastiaan/face-detect-app).
### Suggested implementation
Doing face recognition without GPU is really easy when using the [`face_recognition`](https://github.com/ageitgey/face_recognition) library. It is written in Python, has good documentation and an easy API. We would only need to change our docker images to include dlib somehow. An example of a Dockerfile to do this is in the PoC.
You might already have wondered how to do this without having to do an expensive operation every time you want to obtain the photos with your face.
In my PoC I indexed all faces on the 'large' image size using the API, which is a bit slow. But that is to be expected when you're loading images from a remote server. We can do the same, save the face encodings in a database and connect them to the photos they belong to. Then a user can upload images (no real need to save those, but it is possible) from which we will extract face encodings which we can compare using a SQL query to get similar faces. That should be a fast way to compare hundreds of encodings and option 1 is done!
Getting the face encodings from uploaded images is possible either when we're resizing and uploading or we can run a cronjob of some sorts to get those encodings.
If we really want to make this fancy we could include the face boxes (location of faces) in the images and add a possibility to tag people. That would assign the face encodings we extracted. But that's not ~"easy and fun" anymore probably.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/986Automatically send email with G Suite calendar id invite to member on joining...2020-02-19T20:27:12+01:00Job DoesburgAutomatically send email with G Suite calendar id invite to member on joining committee<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -→
Automatically send email with G Suite calendar id invite to member on joining committee
### Motivation
<!-- Why should we care? -->
To prev...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -→
Automatically send email with G Suite calendar id invite to member on joining committee
### Motivation
<!-- Why should we care? -->
To prevent ourselves from explaining this over and over
### Desired functionality
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
If a members joins a committee they will receive an email from Thalia stating 'hey you have joined committee x, fun times, here you also have the calendar stream for this committee'
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
Probably we will need to introduce a field in the active member group model that contains the id for their calendar. And then we can use that one to send an email to the new membershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/974Improve navigation between admin views for event admin2019-12-18T19:14:35+01:00Job DoesburgImprove navigation between admin views for event admin<!--
You want something new.
-->
### One-sentence description
Improve navigation between admin views for event admin
### Motivation
Currently it works terrible.
### Desired functionality
On save, go to the view that makes sens...<!--
You want something new.
-->
### One-sentence description
Improve navigation between admin views for event admin
### Motivation
Currently it works terrible.
### Desired functionality
On save, go to the view that makes sense instead of very often go back to the event overview.
Also maybe provide buttons that take you to the event detail overview page, or to the frontend view, etc etc
I don't yet have clear suggestions but I think everyone can think of their own what makes sense.
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/973Automatically set referral event-slide hyperlink to event page2019-12-04T20:13:17+01:00Job DoesburgAutomatically set referral event-slide hyperlink to event page<!--
You want something new.
-->
### One-sentence description
Automatically set referral event-slide hyperlink to event page
### Motivation
Usability
### Desired functionality
If you set a slide to be an event slide, automatic...<!--
You want something new.
-->
### One-sentence description
Automatically set referral event-slide hyperlink to event page
### Motivation
Usability
### Desired functionality
If you set a slide to be an event slide, automatically fill in the hyperlink field with a URL to the event page (and maybe also auto fill in the title to be the event title?)
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/965Make mailinglist deletion safer/better informed2019-11-20T13:12:51+01:00Jelle Besselingjelle@pingiun.comMake mailinglist deletion safer/better informed### Motivation
Currently deleting a mailinglist will disable the group on gsuite, but delete the list on the website. This means that the name can be added as an alias for another list on the website, but gsuite will not support his, so ...### Motivation
Currently deleting a mailinglist will disable the group on gsuite, but delete the list on the website. This means that the name can be added as an alias for another list on the website, but gsuite will not support his, so we have a syncing error.
We could do an actual deletion on gsuite, and preserve archives another way. Or make sure the name cannot be used anymore after deletion, except when recreating the same list. If this method is chosen, the user should be informed on deletion.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/951Thalia Pay: Add user-instructions for activating in bankaccounts2019-11-03T20:34:15+01:00Job DoesburgThalia Pay: Add user-instructions for activating in bankaccounts### One-sentence description
Add information about Thalia Pay to bankaccounts
### Motivation
People should know what Thalia Pay is and how to activate it.
### Desired functionality
Something about that if you sign a direct debit, it...### One-sentence description
Add information about Thalia Pay to bankaccounts
### Motivation
People should know what Thalia Pay is and how to activate it.
### Desired functionality
Something about that if you sign a direct debit, it will be used for Thalia Pay etc.
### Suggested implementation
Maybe ask the board? Or just come up with something ourselves. It should not be too extensive in my opinion, just something short.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/944Thalia Pay: also enable late-cancellation fines to happen with Thalia Pay2019-11-27T17:00:39+01:00Job DoesburgThalia Pay: also enable late-cancellation fines to happen with Thalia Pay### One-sentence description
Also enable late-cancellation fines to happen with Thalia Pay
### Motivation
Because it is weird to do let this happen via invoices if people normally can pay with Thalia Pay
### Desired functionality
Cu...### One-sentence description
Also enable late-cancellation fines to happen with Thalia Pay
### Motivation
Because it is weird to do let this happen via invoices if people normally can pay with Thalia Pay
### Desired functionality
Currently if somebody wants has said to pay with Thalia Pay, but cancels, we delete the payment.
After the event, the treasurer should be able to determine the real amount of the fine and have some action available to add TPAY payments for everyone that was too late and deserves a fine (now we will probably need to reopen #821 heheheheh)
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/943Thalia Pay: Only allow revocation of mandates if all payments were processed2020-03-09T17:59:50+01:00Job DoesburgThalia Pay: Only allow revocation of mandates if all payments were processed### One-sentence description
Only allow revocation of mandates if all Thalia Pay payments were processed (the batch were all payments are in should be processed)
### Motivation
Because legally from the moment a mandate is revoked, we ...### One-sentence description
Only allow revocation of mandates if all Thalia Pay payments were processed (the batch were all payments are in should be processed)
### Motivation
Because legally from the moment a mandate is revoked, we cannot use it anymore. And users of course cannot revoke their mandate if they still have open amounts (or actually they can, but then the treasurer should be notified of this and discuss with that person he/she should pay another way - I suggest we do not add that flow in the website).
### Desired functionality
When a user tries to revoke a mandate, but there are still Thalia Pay payments in batches that are not fully processed yet, the user should receive a message that he/she should contact the board by email to revoke the mandate because there are still open amounts to be paid.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/939Thalia Pay: Add an option to membership renewals to pay with Thalia Pay2020-03-12T00:18:27+01:00Job DoesburgThalia Pay: Add an option to membership renewals to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals to pay with Thalia Pay
### Motivation
Because everyone wants to pay their contribution remotely via Thalia Pay and not come to a ...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals to pay with Thalia Pay
### Motivation
Because everyone wants to pay their contribution remotely via Thalia Pay and not come to a bbq
### Desired functionality
Just a 'Pay with Thalia Pay' button while requesting membership renewal (if a bank account is added, otherwise show a message that if they do add a bank account they can pay with Thalia Pay).
### Suggested implementationJob DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/938Thalia Pay: Add an option to membership registrations to pay with Thalia Pay2019-11-27T17:01:11+01:00Job DoesburgThalia Pay: Add an option to membership registrations to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functiona...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functionality
During registration (or after registration is approved, which is easier to build but less user friendly) people should have the possibility to immediately add a bank account and select payment via Thalia Pay.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/932Thalia Pay: Export financial information that can be imported to Conscribo2020-02-12T20:41:09+01:00Sébastiaan VersteegThalia Pay: Export financial information that can be imported to Conscribo### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment informati...### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment information that can be imported in Conscribo. We currently have an export option but the use format cannot be used with Conscribo. If we add the format Conscribo wants the work to process direct debits (which might be a lot) will be decreased a lot.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/931Thalia Pay: Export payment batches for ING2020-02-12T20:39:14+01:00Sébastiaan VersteegThalia Pay: Export payment batches for INGSubtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the ...Subtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the right format. These batches can be used to execute a direct debit batch.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit (#930).
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/920Guest registration for events2019-10-30T22:17:14+01:00Thomas Klein BretelerGuest registration for events<!--
You want something new.
-->
### One-sentence description
Guest registration for events
### Motivation
Workshops have bad visitor numbers. So as solution we have asked the R&VO (R&BO) coordinator to invite non-Thalia members....<!--
You want something new.
-->
### One-sentence description
Guest registration for events
### Motivation
Workshops have bad visitor numbers. So as solution we have asked the R&VO (R&BO) coordinator to invite non-Thalia members. There is however no easy way for them to register.
### Desired functionality
Add an option to make non-member registration possible.
### Suggested implementation
Create a form that creates a non-member registration for someone with an email confirmation.