concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-11-27T17:01:49+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/881Data minimization on payments and event registrations after 7 years.2019-11-27T17:01:49+01:00Job DoesburgData minimization on payments and event registrations after 7 years.### One-sentence description
Data minimization on payments and event registrations after 7 years.
### Motivation
The privacy office of the RU has indicated that there are no grounds for Thalia to keep data of payments or event partici...### One-sentence description
Data minimization on payments and event registrations after 7 years.
### Motivation
The privacy office of the RU has indicated that there are no grounds for Thalia to keep data of payments or event participation after 7 years (the legal obligatory time to keep this information). So in order to be fully compliant to the AVG/GDPR we should maybe delete this information after 7 years.
### Desired functionality
7 years after an event, information of who attended what activity should be removed and whether they paid, and how.
It would be nice if we can keep track of the amount of participants at that activity.
### Suggested implementation
Apart from that I can imagine this is not quite easy, I have no idea.
Note that this request is only based on information provided by the Radboud University privacy office. But the Technicie I'm sure also have an grounded opinion about this. So if you guys think it is unnecessary to remove this data because of reasons, and you think it is compliant to the AVG/GDPR that is fine as well! This is just passing on information actually.2022-06-01https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1031Topic should be visible in https://thalia.nu/user/finance/payments/2020-03-11T23:54:58+01:00Job DoesburgTopic should be visible in https://thalia.nu/user/finance/payments/### One-sentence description
Topic should be visible in https://thalia.nu/user/finance/payments/
### Current behaviour / Reproducing the bug
The topic field is not visible
### Expected behaviour
Be visible### One-sentence description
Topic should be visible in https://thalia.nu/user/finance/payments/
### Current behaviour / Reproducing the bug
The topic field is not visible
### Expected behaviour
Be visiblehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1013Prevent payment cancellation when payment in batch2020-03-09T17:59:50+01:00Job DoesburgPrevent payment cancellation when payment in batch### One-sentence description
Prevent payment cancellation / changes when payment in batch
### Why?
When a payment is added to a payment batch (#932), it must stay in there and may not be changed or deleted anymore.
### Current implem...### One-sentence description
Prevent payment cancellation / changes when payment in batch
### Why?
When a payment is added to a payment batch (#932), it must stay in there and may not be changed or deleted anymore.
### Current implementation
This might be possible
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1012Export payment batch per topic / event2020-02-12T20:42:04+01:00Job DoesburgExport payment batch per topic / event### One-sentence description
Export payment batch per topic / event
### Motivation
Required for bookkeeping of Thalia Pay
### Desired functionality
Use the `payment_topic` from Payments, provided by `Payable` models
### Suggested i...### One-sentence description
Export payment batch per topic / event
### Motivation
Required for bookkeeping of Thalia Pay
### Desired functionality
Use the `payment_topic` from Payments, provided by `Payable` models
### Suggested implementation
Extend #932 with a second way of exportinghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1011Use create_payment everywhere2020-03-09T17:59:50+01:00Job DoesburgUse create_payment everywhere### One-sentence description
Use create_payment (from #1010 ) everywhere where we use payments
### Why?
Prevent code duplication
### Current implementation
Shitty, chaotic, anarchy, tears
### Suggested implementation
Make models P...### One-sentence description
Use create_payment (from #1010 ) everywhere where we use payments
### Why?
Prevent code duplication
### Current implementation
Shitty, chaotic, anarchy, tears
### Suggested implementation
Make models Payable (implement the interface / abstract class from #1010) and use `create_payment` as the only way to interact with / create payments.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1009Improve tests for Payments app2020-02-12T20:39:44+01:00Luko van der MaasImprove tests for Payments app### One-sentence description
A lot of tests for payments are either not consistent or do some weird stuff.
### Why?
Better tests helps stability### One-sentence description
A lot of tests for payments are either not consistent or do some weird stuff.
### Why?
Better tests helps stabilitySébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/951Thalia Pay: Add user-instructions for activating in bankaccounts2019-11-03T20:34:15+01:00Job DoesburgThalia Pay: Add user-instructions for activating in bankaccounts### One-sentence description
Add information about Thalia Pay to bankaccounts
### Motivation
People should know what Thalia Pay is and how to activate it.
### Desired functionality
Something about that if you sign a direct debit, it...### One-sentence description
Add information about Thalia Pay to bankaccounts
### Motivation
People should know what Thalia Pay is and how to activate it.
### Desired functionality
Something about that if you sign a direct debit, it will be used for Thalia Pay etc.
### Suggested implementation
Maybe ask the board? Or just come up with something ourselves. It should not be too extensive in my opinion, just something short.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/944Thalia Pay: also enable late-cancellation fines to happen with Thalia Pay2019-11-27T17:00:39+01:00Job DoesburgThalia Pay: also enable late-cancellation fines to happen with Thalia Pay### One-sentence description
Also enable late-cancellation fines to happen with Thalia Pay
### Motivation
Because it is weird to do let this happen via invoices if people normally can pay with Thalia Pay
### Desired functionality
Cu...### One-sentence description
Also enable late-cancellation fines to happen with Thalia Pay
### Motivation
Because it is weird to do let this happen via invoices if people normally can pay with Thalia Pay
### Desired functionality
Currently if somebody wants has said to pay with Thalia Pay, but cancels, we delete the payment.
After the event, the treasurer should be able to determine the real amount of the fine and have some action available to add TPAY payments for everyone that was too late and deserves a fine (now we will probably need to reopen #821 heheheheh)
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/943Thalia Pay: Only allow revocation of mandates if all payments were processed2020-03-09T17:59:50+01:00Job DoesburgThalia Pay: Only allow revocation of mandates if all payments were processed### One-sentence description
Only allow revocation of mandates if all Thalia Pay payments were processed (the batch were all payments are in should be processed)
### Motivation
Because legally from the moment a mandate is revoked, we ...### One-sentence description
Only allow revocation of mandates if all Thalia Pay payments were processed (the batch were all payments are in should be processed)
### Motivation
Because legally from the moment a mandate is revoked, we cannot use it anymore. And users of course cannot revoke their mandate if they still have open amounts (or actually they can, but then the treasurer should be notified of this and discuss with that person he/she should pay another way - I suggest we do not add that flow in the website).
### Desired functionality
When a user tries to revoke a mandate, but there are still Thalia Pay payments in batches that are not fully processed yet, the user should receive a message that he/she should contact the board by email to revoke the mandate because there are still open amounts to be paid.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/939Thalia Pay: Add an option to membership renewals to pay with Thalia Pay2020-03-12T00:18:27+01:00Job DoesburgThalia Pay: Add an option to membership renewals to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals to pay with Thalia Pay
### Motivation
Because everyone wants to pay their contribution remotely via Thalia Pay and not come to a ...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals to pay with Thalia Pay
### Motivation
Because everyone wants to pay their contribution remotely via Thalia Pay and not come to a bbq
### Desired functionality
Just a 'Pay with Thalia Pay' button while requesting membership renewal (if a bank account is added, otherwise show a message that if they do add a bank account they can pay with Thalia Pay).
### Suggested implementationJob DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/938Thalia Pay: Add an option to membership registrations to pay with Thalia Pay2019-11-27T17:01:11+01:00Job DoesburgThalia Pay: Add an option to membership registrations to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functiona...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functionality
During registration (or after registration is approved, which is easier to build but less user friendly) people should have the possibility to immediately add a bank account and select payment via Thalia Pay.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/932Thalia Pay: Export financial information that can be imported to Conscribo2020-02-12T20:41:09+01:00Sébastiaan VersteegThalia Pay: Export financial information that can be imported to Conscribo### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment informati...### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment information that can be imported in Conscribo. We currently have an export option but the use format cannot be used with Conscribo. If we add the format Conscribo wants the work to process direct debits (which might be a lot) will be decreased a lot.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/931Thalia Pay: Export payment batches for ING2020-02-12T20:39:14+01:00Sébastiaan VersteegThalia Pay: Export payment batches for INGSubtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the ...Subtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the right format. These batches can be used to execute a direct debit batch.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit (#930).
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/632Thalia Pay2019-10-03T16:58:43+02:00Aucke BosThalia PayThis is the general overview issue for Thalia Pay. The work has been split in multiple subissues that all begin with 'Thalia Pay'
### One-sentence description
Members can pay for things by keeping a tab using their account.
### Desire...This is the general overview issue for Thalia Pay. The work has been split in multiple subissues that all begin with 'Thalia Pay'
### One-sentence description
Members can pay for things by keeping a tab using their account.
### Desired behaviour
A member has a virtual wallet with a maximum balance of 0 euro. This wallet can be used to pay for things.
Once a member registers for an event or orders a pizza an option will appear to pay using the wallet. Such a payment is registered in the ~payments app. The amount of the payment will be deducted from the wallet.
At the end of the month all the payments of that month will be collected by direct debit.
Before these direct debits can take place we need to collect information from members:
- Bank account
- Initials and last name of the bank account holder
- The member has to sign a SEPA mandate
Then the treasurer has to be able to create an export that contains all the information for a direct debit. The overview only has to contain members that made a payment. It should have the following fields:
- Relationnumber
- First name
- Last name
- IBAN
- Initials + last name of holder
- Amount
- Overview of all payments in this row
The treasurer will send a mail before the direct debit will be executed. But an overview in the frontend of the website would be desirable.
---
## What has been done
- The Payment model introduced in !533 was moved to it's own app in !704.
- The event payments were refactored to use the Payment model in !1112.
- We're syncing member information and mandates to Conscribo, first introduced in !1132.
- The pizza payments were refactored to use the Payment model in !1225.
- We added digital SEPA mandates in !1241.
- We added a user-facing payment overview in !1350.
## What we should do next
Mostly taken from https://gitlab.science.ru.nl/thalia/concrexit/issues/632#note_74956 and responses.
1. Add a direct debit payment method to the payment model. (#930)
2. Export payment batches for ING (the bank). (#931)
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit.
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.
3. Export financial information that can be imported to Conscribo.
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.
4. We should investigate how we are going to notify members of an upcoming direct debit.
- Could be on export noted in (1).
5. Add an option to ~events for users to mark their registration as paid using direct debit.
- Do not forget the app.
- Needs check for a valid mandate.
6. Add an option to ~pizzas for users to mark their order as paid using direct debit.
- See (5).Sébastiaan VersteegSébastiaan Versteeg