concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2017-10-03T15:47:57+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/490Pizza API2017-10-03T15:47:57+02:00Gijs HendriksenPizza API### One-sentence description
Add the pizza module to the API (V2 I guess?)
### Desired behaviour
Add functionality to the API to view products, order pizza, change order, etc. from the ThaliApp. It is probably also nice to include admin...### One-sentence description
Add the pizza module to the API (V2 I guess?)
### Desired behaviour
Add functionality to the API to view products, order pizza, change order, etc. from the ThaliApp. It is probably also nice to include admin actions in the API, in case we want to perform admin actions through the app. Would be nice to implement this as soon as possible, both here and on the app side, so it can be used on one of the next drinks.
### Suggestion
I've thought a bit about how to make this as RESTful as possible. Thoughts are welcome.
* `GET https://thalia.nu/api/v2/pizzas/` to view pizzas (only if there is currently a PizzaEvent or if admin)
* `GET https://thalia.nu/api/v2/pizzas/event/` to view the current PizzaEvent (if there is one)
* `GET https://thalia.nu/api/v2/pizzas/orders/` to view all orders for the current event (only if admin)
* `GET https://thalia.nu/api/v2/pizzas/orders/[<id>|me]/` to view a specific order (only if yours or admin)
* `POST https://thalia.nu/api/v2/pizzas/orders/` to create a new order (with an optional body containing a name, for adding an order for non-members)
* `PUT https://thalia.nu/api/v2/pizzas/orders/[<id>|me]/` to edit a specific order, with a product id in the body, and (for admins) a paid field in the body (only if yours or admin)
* `DELETE https://thalia.nu/api/v2/pizzas/orders/[<id>|me]/` to cancel a specific order (only if yours or admin)
This is what I came up with, but maybe there is a better way?1.11Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/934Thalia Pay: Add an option to pizzas for users to mark their order as paid usi...2019-11-06T19:31:18+01:00Sébastiaan VersteegThalia Pay: Add an option to pizzas for users to mark their order as paid using direct debit.Subtask of #632, partially blocked by #930.
### One-sentence description
Add an option to pizzas for users to mark their order as paid using direct debit.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
...Subtask of #632, partially blocked by #930.
### One-sentence description
Add an option to pizzas for users to mark their order as paid using direct debit.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Payment option on the user side. And option to see the value in the admin.
### Suggested implementation
Have a button on the pizzas page that has the user confirm their payment or redirect to information about direct debits.
Also provide an API for the app!Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/915Cannot update pizza order status with event override permission2019-10-23T19:03:54+02:00Sébastiaan VersteegCannot update pizza order status with event override permission### One-sentence description
Cannot update pizza order status with event override permission
### Current behaviour / Reproducing the bug
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have overri...### One-sentence description
Cannot update pizza order status with event override permission
### Current behaviour / Reproducing the bug
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have override event permission
3. Try to change the payment status of an order of said pizza event
4. Unable to change, 404 from API
### Expected behaviour
1. Create a pizza event for a committee you're not a member of
2. Be no superuser but have override event permission
3. Try to change the payment status of an order of said pizza event
4. Working28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/872Pizza orders reachable for people not in the organising member group2019-08-28T19:10:53+02:00Sébastiaan VersteegPizza orders reachable for people not in the organising member group### One-sentence description
Pizza orders reachable for people not in the organising member group
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to m...### One-sentence description
Pizza orders reachable for people not in the organising member group
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected behaviour
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. The orders page is permission denied26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/840Use the payments app to register pizza payments2019-04-17T20:16:34+02:00Sébastiaan VersteegUse the payments app to register pizza payments<!--
You want something new.
-->
### One-sentence description
Use the payments app to register pizza payments
### Motivation
Because of #632
### Desired functionality
Use the payments app to register pizza payments
### Suggest...<!--
You want something new.
-->
### One-sentence description
Use the payments app to register pizza payments
### Motivation
Because of #632
### Desired functionality
Use the payments app to register pizza payments
### Suggested implementation
Save payment in a payment object of the payments app.24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/776Automatic notification before end of pizza ordering2019-01-17T13:09:05+01:00Sébastiaan VersteegAutomatic notification before end of pizza ordering### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left ...### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left to order your pizzas. If the pizza event is attached to an event with registrations only registered members will get the notification, instead of everyone.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/748Multiple food-lists2018-11-06T08:52:48+01:00Job DoesburgMultiple food-lists<!--
You want something new.
-->
### One-sentence description
For pizza-events, be able to choose from multiple lists of food.
### Motivation
Some day, we might want to order other food rather than pizzas every time (GM's for exa...<!--
You want something new.
-->
### One-sentence description
For pizza-events, be able to choose from multiple lists of food.
### Motivation
Some day, we might want to order other food rather than pizzas every time (GM's for example). In that case, it would be very nice to be able to use pizza.thalia.nu (which might needs the alias order.thalia.nu then).
### Desired functionality
In the backend, one should be able to enter multiple lists with items ('pizzas'). For each pizza-event, one should choose which list to use. This way we could have a list 'Dominos' and a different list 'Cafetaria Heyendaal' for example.
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/582Improve documentation for the pizzas module2019-11-20T20:38:02+01:00Thom WiggersImprove documentation for the pizzas moduleThe ~pizzas module could use improved docs.The ~pizzas module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/136Default-sortering pizza order overview2018-11-25T01:45:50+01:00Ko StoffelenDefault-sortering pizza order overviewKlein detail, maar kan het overzicht op /pizzas/admin/activity/orders/overview/x by default alfabetisch gesorteerd worden op product? Je kunt klikken, maar dat is wel heel veel moeite. ;)
Misschien dat voor /pizzas/admin/activity/orders...Klein detail, maar kan het overzicht op /pizzas/admin/activity/orders/overview/x by default alfabetisch gesorteerd worden op product? Je kunt klikken, maar dat is wel heel veel moeite. ;)
Misschien dat voor /pizzas/admin/activity/orders/x een default-sortering op voornaam ook wel praktischer is dan op timestamp/locatie-in-de-db.Tom van BusselTom van Bussel