concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-01-28T20:48:57+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/562Newsletter uses old is_active2018-01-28T20:48:57+01:00Thom WiggersNewsletter uses old is_active### One-sentence description
Newsletter sending breaks due to old `members` api.
https://thalia-www.slack.com/archives/C3RSHV4S0/p1516575117000059### One-sentence description
Newsletter sending breaks due to old `members` api.
https://thalia-www.slack.com/archives/C3RSHV4S0/p1516575117000059Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/567Marking pizzas as paid is broken2018-02-12T16:22:57+01:00Thom WiggersMarking pizzas as paid is broken### One-sentence description
Marking pizzas as paid is broken via pizza interface (not admin)
### Current behaviour
### Expected behaviour
### Steps to reproduce
1.### One-sentence description
Marking pizzas as paid is broken via pizza interface (not admin)
### Current behaviour
### Expected behaviour
### Steps to reproduce
1.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/797Cannot open unpublished events in admin2018-12-12T18:52:49+01:00Sébastiaan VersteegCannot open unpublished events in admin### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview20https://gitlab.science.ru.nl/thalia/concrexit/-/issues/819Cannot order for a pizza event without notification2019-02-13T20:54:35+01:00Sébastiaan VersteegCannot order for a pizza event without notification### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder...### One-sentence description
Cannot order for a pizza event without notification
https://sentry.thalia.nu/sentry/concrexit/issues/364/?referrer=slack
### Current behaviour / Reproducing the bug
1. Create a pizza event without reminder
2. Order a pizza
3. Crash
### Expected behaviour
No crash22Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/822Cannot register payment of external event registration2019-02-13T20:52:46+01:00Job DoesburgCannot register payment of external event registration### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration ...### One-sentence description
I cannot register a payment of someone that is manually registered for an event, but is not a member of Thalia.
### Current behaviour / Reproducing the bug
1. Open an event
2. Manually add an registration - not a member but fill in a empty name
3. Save
4. In the overview, change the payment from 'not paid' to 'pin' or 'cash'
5. Reload the page, the payment is not registered
6. profit
### Expected behaviour
Should be clear I guess22Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/864Update Poetry.lock and check urllib3 version2019-04-24T21:25:11+02:00Sébastiaan VersteegUpdate Poetry.lock and check urllib3 version### One-sentence description
Update Poetry.lock and check urllib3 version
### Why?
https://nvd.nist.gov/vuln/detail/CVE-2019-11324
If you want to know why this is so important, we really only use requests (which uses urllib3) in one p...### One-sentence description
Update Poetry.lock and check urllib3 version
### Why?
https://nvd.nist.gov/vuln/detail/CVE-2019-11324
If you want to know why this is so important, we really only use requests (which uses urllib3) in one place: Conscribo sync.24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/940AttributeError: module 'firebase_admin.messaging' has no attribute 'ApiCallEr...2019-10-19T09:21:52+02:00Thalia TechnicieAttributeError: module 'firebase_admin.messaging' has no attribute 'ApiCallError'Sentry Issue: [CONCREXIT-12](https://sentry.io/organizations/thalia/issues/1279980295/?referrer=gitlab_integration)
```
HTTPError: 401 Client Error: Unauthorized for url: https://fcm.googleapis.com/v1/projects/thalia-493a0/messages:send...Sentry Issue: [CONCREXIT-12](https://sentry.io/organizations/thalia/issues/1279980295/?referrer=gitlab_integration)
```
HTTPError: 401 Client Error: Unauthorized for url: https://fcm.googleapis.com/v1/projects/thalia-493a0/messages:send
File "firebase_admin/messaging.py", line 349, in send
timeout=self._timeout
File "firebase_admin/_http_client.py", line 117, in body
resp = self.request(method, url, **kwargs)
File "firebase_admin/_http_client.py", line 105, in request
resp.raise_for_status()
File "requests/models.py", line 940, in raise_for_status
raise HTTPError(http_error_msg, response=self)
ThirdPartyAuthError: Auth error from APNS or Web Push Service
File "pushnotifications/models.py", line 175, in send
'dry_run', False))
File "firebase_admin/messaging.py", line 114, in send
return _get_messaging_service(app).send(message, dry_run)
File "firebase_admin/messaging.py", line 352, in send
raise self._handle_fcm_error(error)
AttributeError: module 'firebase_admin.messaging' has no attribute 'ApiCallError'
(2 additional frame(s) were not displayed)
...
File "django/core/management/__init__.py", line 375, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "django/core/management/base.py", line 323, in run_from_argv
self.execute(*args, **cmd_options)
File "django/core/management/base.py", line 364, in execute
output = self.handle(*args, **options)
File "pushnotifications/management/commands/send_scheduled_messages.py", line 44, in handle
message.send(dry_run=bool(options['dry-run']))
File "pushnotifications/models.py", line 177, in send
except messaging.ApiCallError as e:
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/989Cannot save events with participants2019-12-13T15:41:54+01:00Thalia TechnicieCannot save events with participantsSentry Issue: [CONCREXIT-1P](https://sentry.io/organizations/thalia/issues/1375339372/?referrer=gitlab_integration)
```
AssertionError: Cannot filter a query once a slice has been taken.
(11 additional frame(s) were not displayed)
...
...Sentry Issue: [CONCREXIT-1P](https://sentry.io/organizations/thalia/issues/1375339372/?referrer=gitlab_integration)
```
AssertionError: Cannot filter a query once a slice has been taken.
(11 additional frame(s) were not displayed)
...
File "django/contrib/admin/options.py", line 1561, in _changeform_view
self.save_model(request, new_object, form, not add)
File "django/contrib/admin/options.py", line 1088, in save_model
obj.save()
File "events/models.py", line 398, in save
self.participants.filter(member__isnull=False)
File "django/db/models/query.py", line 892, in filter
return self._filter_or_exclude(False, *args, **kwargs)
File "django/db/models/query.py", line 904, in _filter_or_exclude
"Cannot filter a query once a slice has been taken."
```