concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-03-11T21:19:39+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1032Think of a way to improve partner logo's in dark mode2020-03-11T21:19:39+01:00Job DoesburgThink of a way to improve partner logo's in dark mode<!--
You want something new.
-->
### One-sentence description
Think of a way to improve partner logo's in dark mode
### Motivation
With current dark mode, some partner logo's look a bit weird
### Desired functionality
They shou...<!--
You want something new.
-->
### One-sentence description
Think of a way to improve partner logo's in dark mode
### Motivation
With current dark mode, some partner logo's look a bit weird
### Desired functionality
They should look good both in dark mode and light mode.
**Both in the banner, and in the vacancy pages**
### Suggested implementation
It is hard to do this correctly for all logo's. One way is to add a css filter in dark mode that makes the logo's more white. Another way could be to just support a dark mode and light mode logo.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1028Original images in photo albums are saved and downloaded2020-03-11T23:56:39+01:00Gijs HendriksenOriginal images in photo albums are saved and downloaded### One-sentence description
<!-- What breaks -->
When downloading a photo album, both the original and downscaled images are downloaded, even though we're not supposed to save the original image.
### Current behaviour / Reproducing t...### One-sentence description
<!-- What breaks -->
When downloading a photo album, both the original and downscaled images are downloaded, even though we're not supposed to save the original image.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Download a photo album
2. Notice the original images are saved and included in the album (`*.JPG`), alongside the downscaled images (`*.jpg`)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
1. Download a photo album
2. Only the downscaled images are saved and includedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1024ProgrammingError: more than one row returned by a subquery used as an expression2020-03-01T16:38:36+01:00Thalia TechnicieProgrammingError: more than one row returned by a subquery used as an expressionSentry Issue: [CONCREXIT-27](https://sentry.io/organizations/thalia/issues/1540717591/?referrer=gitlab_integration)
```
CardinalityViolation: more than one row returned by a subquery used as an expression
File "django/db/backends/uti...Sentry Issue: [CONCREXIT-27](https://sentry.io/organizations/thalia/issues/1540717591/?referrer=gitlab_integration)
```
CardinalityViolation: more than one row returned by a subquery used as an expression
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
ProgrammingError: more than one row returned by a subquery used as an expression
(11 additional frame(s) were not displayed)
...
File "django/db/backends/utils.py", line 68, in execute
return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
File "django/db/backends/utils.py", line 77, in _execute_with_wrappers
return executor(sql, params, many, context)
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
File "django/db/utils.py", line 90, in __exit__
raise dj_exc_value.with_traceback(traceback) from exc_value
File "django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/955Events cannot be edited when guest registrations were added2020-01-25T22:45:12+01:00Sébastiaan VersteegEvents cannot be edited when guest registrations were added### One-sentence description
Events cannot be edited when guest registrations were added
### Current behaviour / Reproducing the bug
1. Create an event and publish
2. Add a guest registration
3. Edit the event
4. Crashes on the save o...### One-sentence description
Events cannot be edited when guest registrations were added
### Current behaviour / Reproducing the bug
1. Create an event and publish
2. Add a guest registration
3. Edit the event
4. Crashes on the save of the push notification, the guest registration is `null`
### Expected behaviour
The guest registration should be filtered out of the list of members when the event is saved.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31