concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-05-15T20:37:10+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/560Register as benefactor via the website2019-05-15T20:37:10+02:00Sébastiaan VersteegRegister as benefactor via the website### One-sentence description
Register as benefactor via the website
### Desired behaviour
Supporters should be able to register via the website too.### One-sentence description
Register as benefactor via the website
### Desired behaviour
Supporters should be able to register via the website too.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/584Improve documentation for the registrations module2018-09-21T15:10:04+02:00Thom WiggersImprove documentation for the registrations moduleThe ~registrations module could use improved docs.The ~registrations module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/608Opnieuw lid worden2018-05-16T15:47:28+02:00Simone RuijsOpnieuw lid worden### One-sentence description
Als je al ooit lid bent geweest van Thalia, dan kun je je niet opnieuw aanmelden met hetzelfde e-mailadres via de website.
### Current behaviour
Je email wordt niet geaccepteerd
### Expected behaviour
Ondan...### One-sentence description
Als je al ooit lid bent geweest van Thalia, dan kun je je niet opnieuw aanmelden met hetzelfde e-mailadres via de website.
### Current behaviour
Je email wordt niet geaccepteerd
### Expected behaviour
Ondanks dat je ooit eerder lid bent geweest via het zelfde e-mailadres, zou je nu opnieuw lid kunnen moeten worden.
### Steps to reproduce
1. Proberen aan te melden voor Thalia met een e-mailadres dat al bij een lid hoort.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/622Crash on registration renew page2018-05-08T13:50:50+02:00Sébastiaan VersteegCrash on registration renew page### One-sentence description
Crash on registration renew page
### Current behaviour
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "...### One-sentence description
Crash on registration renew page
### Current behaviour
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
69. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in _wrapper
62. return bound_func(*args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
21. return view_func(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in bound_func
58. return func.__get__(self, type(self))(*args2, **kwargs2)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
89. return handler(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/edit.py" in get
133. return self.render_to_response(self.get_context_data())
File "./registrations/views.py" in get_context_data
143. c[1] for c in Membership.MEMBERSHIP_TYPES
File "./registrations/views.py" in <listcomp>
144. if c[0] == context['membership'].type
Exception Type: AttributeError at /registration/renew/
Exception Value: 'NoneType' object has no attribute 'type'
Request information:
USER: azijlstra
```
### Expected behaviour
No crash
### Steps to reproduce
Unknownhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/657Add privacy policy checkbox to renewal form2018-07-11T14:36:26+02:00Sébastiaan VersteegAdd privacy policy checkbox to renewal form### One-sentence description
Add privacy policy checkbox to renewal form
### Desired behaviour
Have people accept the privacy policy on renewal.### One-sentence description
Add privacy policy checkbox to renewal form
### Desired behaviour
Have people accept the privacy policy on renewal.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/658Add birthday calendar opt-in to registration form2018-07-11T19:18:25+02:00Sébastiaan VersteegAdd birthday calendar opt-in to registration form### One-sentence description
Add birthday calendar opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in.### One-sentence description
Add birthday calendar opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/659Add mailinglist opt-in to registration form.2018-07-11T19:38:52+02:00Sébastiaan VersteegAdd mailinglist opt-in to registration form.### One-sentence description
Add mailinglist opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in to the mailinglist.### One-sentence description
Add mailinglist opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in to the mailinglist.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/660Make phone number optional during registration2018-07-11T18:48:17+02:00Sébastiaan VersteegMake phone number optional during registration### One-sentence description
Make phone number optional during registration
### Why?
Because GDPR and it should not be required
### Current implementation
It's required
### Desired implementation
Not required### One-sentence description
Make phone number optional during registration
### Why?
Because GDPR and it should not be required
### Current implementation
It's required
### Desired implementation
Not required1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/issues/664Bug on registering as member with incomplete form2018-08-08T10:34:17+02:00Sébastiaan VersteegBug on registering as member with incomplete form### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`...### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`/registration/register`)
2. Enter the form and leave the starting year _empty_.
3. Submit
4. Error!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/665Crash on confirming non-existing email address2018-08-07T12:34:00+02:00Sébastiaan VersteegCrash on confirming non-existing email address### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stac...### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stacktrace
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
69. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
89. return handler(request, *args, **kwargs)
File "./registrations/views.py" in get
100. emails.send_new_registration_board_message(entry.get())
File "/usr/local/lib/python3.5/site-packages/django/db/models/query.py" in get
403. self.model._meta.object_name
Exception Type: DoesNotExist at /registration/confirm-email/33c721a7-c032-407b-82a0-2f81c4061804/
Exception Value: Entry matching query does not exist.
```1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/666Registration with same username causes problems on payment process2018-08-27T17:37:09+02:00Sébastiaan VersteegRegistration with same username causes problems on payment process### One-sentence description
Registration with same username causes problems on payment process
### Current behaviour
If two registrations exist with the same entered/generated username and the first is fully processed while the secon...### One-sentence description
Registration with same username causes problems on payment process
### Current behaviour
If two registrations exist with the same entered/generated username and the first is fully processed while the second is in the accepted stage the payment for that second registration will not be able to fully succeed since the username is taken. However, the payment is marked processed. Thus the registration will be in limbo, forever.
### Expected behaviour
No limbo!
### Steps to reproduce
1. Create two registrations with the same first and last name
2. Accept them both
3. Process payment for 1
4. Try to process payment for 2
5. Erreur! :boom:https://gitlab.science.ru.nl/thalia/concrexit/-/issues/667Make the starting year field in the registration form a dropdown2018-08-07T12:34:14+02:00Sébastiaan VersteegMake the starting year field in the registration form a dropdown### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/679Make it possible to correct an acception or rejection in registrations2018-10-18T11:30:37+02:00Sébastiaan VersteegMake it possible to correct an acception or rejection in registrations### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to corr...### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to correct this. For example if it was a mistake or if the payment object was not created.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/680Batch accepting registrations doesn't create payment2018-09-12T16:23:08+02:00Sébastiaan VersteegBatch accepting registrations doesn't create payment### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch o...### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch of registrationshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/681Make re-sending the email confirmation possible for registrations2018-10-03T19:56:43+02:00Sébastiaan VersteegMake re-sending the email confirmation possible for registrations### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it....### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it. Correcting the email address in the admin should be possibly too, if someone made a typo. This way we can correct the values without having to delete the whole registration and let new members do it all over.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/683Email subject renewal is wrong2018-08-27T17:14:09+02:00Sébastiaan VersteegEmail subject renewal is wrong### One-sentence description
Email subject renewal is wrong
### Current behaviour
Dutch translation says 'afgekeurd'
### Expected behaviour
should be 'goedgekeurd'
### Steps to reproduce
1. Accept a renewal
2. Check the email subject### One-sentence description
Email subject renewal is wrong
### Current behaviour
Dutch translation says 'afgekeurd'
### Expected behaviour
should be 'goedgekeurd'
### Steps to reproduce
1. Accept a renewal
2. Check the email subjecthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/684Make it possible to renew supportership for old members via the website2018-09-26T18:56:20+02:00Sébastiaan VersteegMake it possible to renew supportership for old members via the website### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the web...### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/689Automatically execute data minimisation on accepted/rejected registrations af...2019-05-08T19:50:33+02:00Sébastiaan VersteegAutomatically execute data minimisation on accepted/rejected registrations after 1 month### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be mi...### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be minimalised to just the created membership. This will minimalise the places where user data is stored.
- Once registrations are rejected the data should be removed from our system.
- **This should not deleted accepted *and* non-paid registrations**. So those that are waiting for payment.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/690Registrations should not be editable after completion2018-09-26T18:59:06+02:00Sébastiaan VersteegRegistrations should not be editable after completion### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/691Investigate double registrations2018-10-18T11:30:20+02:00Sébastiaan VersteegInvestigate double registrations### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrati...### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrations/registration/dd814d82-1a53-40a7-9b1c-19ee9b82ed18/change/
2. Check https://thalia.nu/admin/registrations/registration/ed857356-e362-4493-bb0d-f546c9ffcacb/change/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/693Study programme is required during model save of Registration2018-09-19T11:44:35+02:00Sébastiaan VersteegStudy programme is required during model save of Registration### One-sentence description
Study programme is required during model save of Registration
### Current behaviour
A registration should always contain a study programme, even for supporters.
### Expected behaviour
Supporters should n...### One-sentence description
Study programme is required during model save of Registration
### Current behaviour
A registration should always contain a study programme, even for supporters.
### Expected behaviour
Supporters should not be forced to have a study programme in their profiles
### Steps to reproduce
1. Add a new registration in the admin, make sure the type is 'supporter'
2. Save the registration
3. Error for the programme field1.18https://gitlab.science.ru.nl/thalia/concrexit/-/issues/721Report correct membership status / history on renewal page2018-10-18T11:30:19+02:00Joost Rijneveldjoost@joostrijneveld.nlReport correct membership status / history on renewal page### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
...### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the _last_ membership (since it's not my _current_ membership), or display _all_ historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
### Current behaviour
```
## MEMBERSHIP INFORMATION
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Active: no
You're a supporter. Contact the board to renew your membership.
```
### Expected behaviour
```
## MEMBERSHIP INFORMATION
### Current membership:
No active membership. Contact the board to renew your membership.
### Former memberships:
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Membership type: Supporter
Since: Sept. 1, 2016
Until: Sept. 1, 2017
[..]
```
### Steps to reproduce
1. Don't have an active membership
2. Go to https://thalia.nu/registration/renew/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/727Accepted registration had no username2018-11-13T19:35:52+01:00Sébastiaan VersteegAccepted registration had no username### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/739Change dropdown menu in front-end for user registration/enrollment with amount2018-11-14T21:53:41+01:00Job DoesburgChange dropdown menu in front-end for user registration/enrollment with amount<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the price of membership type in the dropdown menu of front-end registration page.
### Why?
People are lazy. They don't read the whole text and only fill in the form. They select 'study membership' and when they want to pay, they see it is more expensive. That's annoying because you have to change data afterwards (which can't be done a.t.m. after approval).
### Current implementation
The dropdown menu only shows 'one year membership' and 'study membership'
### Suggested implementation
The dropdown menu shows 'one year membership (€ 7,50)' and 'study membership (€ 30,00)'Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/746Registration front-end notice for address formatting2018-11-05T11:54:03+01:00Job DoesburgRegistration front-end notice for address formatting<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Show notice f...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Show notice for address formatting on thalia registrations page in front end.
### Why?
For international student from, i.e. Great-Britain, address formatting is weird. They put the house number in front. Now this produces an unclear error message.
### Current implementation
An unclear error message
### Suggested implementation
Either a clear error message (or example how you should format your address), or acceptance of more ways of formatting.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/901Existing benefactors can create registration references2019-08-28T19:57:42+02:00Sébastiaan VersteegExisting benefactors can create registration references### One-sentence description
Existing benefactors can create registration references
### Current behaviour / Reproducing the bug
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the n...### One-sentence description
Existing benefactors can create registration references
### Current behaviour / Reproducing the bug
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the new benefactor
4. Works
### Expected behaviour
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the new benefactor
4. Errorhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/902Add membership type and reference count to renewal/registration admin overviews2019-08-28T19:57:42+02:00Sébastiaan VersteegAdd membership type and reference count to renewal/registration admin overviews<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
...<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
Columns in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/903Members can give references for registrations that start after their membersh...2019-08-28T19:57:40+02:00Sébastiaan VersteegMembers can give references for registrations that start after their membership ends### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a regi...### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Works
### Expected behaviour
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Does not workhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/908Registration student number field unclear2019-10-02T19:11:46+02:00Job DoesburgRegistration student number field unclear### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an e...### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an error
### Expected behaviour
Either accept it and add the s prefix automatically, or already show the prefix as standard value or example value of the field so people understand it betterSébastiaan VersteegSébastiaan Versteeg