concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-07-11T18:48:17+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/660Make phone number optional during registration2018-07-11T18:48:17+02:00Sébastiaan VersteegMake phone number optional during registration### One-sentence description
Make phone number optional during registration
### Why?
Because GDPR and it should not be required
### Current implementation
It's required
### Desired implementation
Not required### One-sentence description
Make phone number optional during registration
### Why?
Because GDPR and it should not be required
### Current implementation
It's required
### Desired implementation
Not required1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/issues/659Add mailinglist opt-in to registration form.2018-07-11T19:38:52+02:00Sébastiaan VersteegAdd mailinglist opt-in to registration form.### One-sentence description
Add mailinglist opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in to the mailinglist.### One-sentence description
Add mailinglist opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in to the mailinglist.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/658Add birthday calendar opt-in to registration form2018-07-11T19:18:25+02:00Sébastiaan VersteegAdd birthday calendar opt-in to registration form### One-sentence description
Add birthday calendar opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in.### One-sentence description
Add birthday calendar opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/657Add privacy policy checkbox to renewal form2018-07-11T14:36:26+02:00Sébastiaan VersteegAdd privacy policy checkbox to renewal form### One-sentence description
Add privacy policy checkbox to renewal form
### Desired behaviour
Have people accept the privacy policy on renewal.### One-sentence description
Add privacy policy checkbox to renewal form
### Desired behaviour
Have people accept the privacy policy on renewal.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/693Study programme is required during model save of Registration2018-09-19T11:44:35+02:00Sébastiaan VersteegStudy programme is required during model save of Registration### One-sentence description
Study programme is required during model save of Registration
### Current behaviour
A registration should always contain a study programme, even for supporters.
### Expected behaviour
Supporters should n...### One-sentence description
Study programme is required during model save of Registration
### Current behaviour
A registration should always contain a study programme, even for supporters.
### Expected behaviour
Supporters should not be forced to have a study programme in their profiles
### Steps to reproduce
1. Add a new registration in the admin, make sure the type is 'supporter'
2. Save the registration
3. Error for the programme field1.18https://gitlab.science.ru.nl/thalia/concrexit/-/issues/721Report correct membership status / history on renewal page2018-10-18T11:30:19+02:00Joost Rijneveldjoost@joostrijneveld.nlReport correct membership status / history on renewal page### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
...### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the _last_ membership (since it's not my _current_ membership), or display _all_ historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
### Current behaviour
```
## MEMBERSHIP INFORMATION
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Active: no
You're a supporter. Contact the board to renew your membership.
```
### Expected behaviour
```
## MEMBERSHIP INFORMATION
### Current membership:
No active membership. Contact the board to renew your membership.
### Former memberships:
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Membership type: Supporter
Since: Sept. 1, 2016
Until: Sept. 1, 2017
[..]
```
### Steps to reproduce
1. Don't have an active membership
2. Go to https://thalia.nu/registration/renew/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/691Investigate double registrations2018-10-18T11:30:20+02:00Sébastiaan VersteegInvestigate double registrations### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrati...### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrations/registration/dd814d82-1a53-40a7-9b1c-19ee9b82ed18/change/
2. Check https://thalia.nu/admin/registrations/registration/ed857356-e362-4493-bb0d-f546c9ffcacb/change/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/679Make it possible to correct an acception or rejection in registrations2018-10-18T11:30:37+02:00Sébastiaan VersteegMake it possible to correct an acception or rejection in registrations### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to corr...### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to correct this. For example if it was a mistake or if the payment object was not created.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/706Handle re-registrations after data minimisation2020-02-04T16:22:58+01:00Sébastiaan VersteegHandle re-registrations after data minimisation### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired impleme...### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired implementation
Handle renewals of members of whom data was minimised by allowing them to re-enter the data.31Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/667Make the starting year field in the registration form a dropdown2018-08-07T12:34:14+02:00Sébastiaan VersteegMake the starting year field in the registration form a dropdown### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/665Crash on confirming non-existing email address2018-08-07T12:34:00+02:00Sébastiaan VersteegCrash on confirming non-existing email address### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stac...### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stacktrace
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
69. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
89. return handler(request, *args, **kwargs)
File "./registrations/views.py" in get
100. emails.send_new_registration_board_message(entry.get())
File "/usr/local/lib/python3.5/site-packages/django/db/models/query.py" in get
403. self.model._meta.object_name
Exception Type: DoesNotExist at /registration/confirm-email/33c721a7-c032-407b-82a0-2f81c4061804/
Exception Value: Entry matching query does not exist.
```1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/664Bug on registering as member with incomplete form2018-08-08T10:34:17+02:00Sébastiaan VersteegBug on registering as member with incomplete form### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`...### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`/registration/register`)
2. Enter the form and leave the starting year _empty_.
3. Submit
4. Error!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/584Improve documentation for the registrations module2018-09-21T15:10:04+02:00Thom WiggersImprove documentation for the registrations moduleThe ~registrations module could use improved docs.The ~registrations module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/966Renewals not processed correctly on uniqueness constraint for membership id2020-01-25T22:45:59+01:00Job DoesburgRenewals not processed correctly on uniqueness constraint for membership id### One-sentence description
Renewals not processed correctly on uniqueness constraint for membership id
### Current behaviour / Reproducing the bug
1. Do a renewal for 1 year
2. Approve it, add a payment, finish it fully etc
3. Do a ...### One-sentence description
Renewals not processed correctly on uniqueness constraint for membership id
### Current behaviour / Reproducing the bug
1. Do a renewal for 1 year
2. Approve it, add a payment, finish it fully etc
3. Do a renewal for the rest of your study
4. Approve it
5. Process a payment
6. Breakage
(the payment gets processed, the membership is correctly added to the user, but the renewal does stick at 'approved' (with a processed payment attached))
### Expected behaviour
Do not crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/938Thalia Pay: Add an option to membership registrations to pay with Thalia Pay2019-11-27T17:01:11+01:00Job DoesburgThalia Pay: Add an option to membership registrations to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functiona...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functionality
During registration (or after registration is approved, which is easier to build but less user friendly) people should have the possibility to immediately add a bank account and select payment via Thalia Pay.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/908Registration student number field unclear2019-10-02T19:11:46+02:00Job DoesburgRegistration student number field unclear### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an e...### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an error
### Expected behaviour
Either accept it and add the s prefix automatically, or already show the prefix as standard value or example value of the field so people understand it betterSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/903Members can give references for registrations that start after their membersh...2019-08-28T19:57:40+02:00Sébastiaan VersteegMembers can give references for registrations that start after their membership ends### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a regi...### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Works
### Expected behaviour
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Does not work