concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-01-25T22:45:59+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/966Renewals not processed correctly on uniqueness constraint for membership id2020-01-25T22:45:59+01:00Job DoesburgRenewals not processed correctly on uniqueness constraint for membership id### One-sentence description
Renewals not processed correctly on uniqueness constraint for membership id
### Current behaviour / Reproducing the bug
1. Do a renewal for 1 year
2. Approve it, add a payment, finish it fully etc
3. Do a ...### One-sentence description
Renewals not processed correctly on uniqueness constraint for membership id
### Current behaviour / Reproducing the bug
1. Do a renewal for 1 year
2. Approve it, add a payment, finish it fully etc
3. Do a renewal for the rest of your study
4. Approve it
5. Process a payment
6. Breakage
(the payment gets processed, the membership is correctly added to the user, but the renewal does stick at 'approved' (with a processed payment attached))
### Expected behaviour
Do not crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/938Thalia Pay: Add an option to membership registrations to pay with Thalia Pay2019-11-27T17:01:11+01:00Job DoesburgThalia Pay: Add an option to membership registrations to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functiona...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functionality
During registration (or after registration is approved, which is easier to build but less user friendly) people should have the possibility to immediately add a bank account and select payment via Thalia Pay.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/908Registration student number field unclear2019-10-02T19:11:46+02:00Job DoesburgRegistration student number field unclear### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an e...### One-sentence description
Apparently people find it unclear whether their student number should be entered with the s prefix.
### Current behaviour / Reproducing the bug
If you fill in only the number without prefix, it gives an error
### Expected behaviour
Either accept it and add the s prefix automatically, or already show the prefix as standard value or example value of the field so people understand it betterSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/903Members can give references for registrations that start after their membersh...2019-08-28T19:57:40+02:00Sébastiaan VersteegMembers can give references for registrations that start after their membership ends### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a regi...### One-sentence description
Members can give references for registrations that start after their membership ends
### Current behaviour / Reproducing the bug
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Works
### Expected behaviour
1. Create a member with a membership that ends on 31-08-2019
2. Start a registration for the next lecture year (1 Sept)
3. Use the previously created member to create a reference
4. Does not workhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/902Add membership type and reference count to renewal/registration admin overviews2019-08-28T19:57:42+02:00Sébastiaan VersteegAdd membership type and reference count to renewal/registration admin overviews<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
...<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
Columns in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/901Existing benefactors can create registration references2019-08-28T19:57:42+02:00Sébastiaan VersteegExisting benefactors can create registration references### One-sentence description
Existing benefactors can create registration references
### Current behaviour / Reproducing the bug
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the n...### One-sentence description
Existing benefactors can create registration references
### Current behaviour / Reproducing the bug
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the new benefactor
4. Works
### Expected behaviour
1. Create a registration or renewal for a benefactor
2. Login as benefactor
3. Create reference for the new benefactor
4. Errorhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/746Registration front-end notice for address formatting2018-11-05T11:54:03+01:00Job DoesburgRegistration front-end notice for address formatting<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Show notice f...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Show notice for address formatting on thalia registrations page in front end.
### Why?
For international student from, i.e. Great-Britain, address formatting is weird. They put the house number in front. Now this produces an unclear error message.
### Current implementation
An unclear error message
### Suggested implementation
Either a clear error message (or example how you should format your address), or acceptance of more ways of formatting.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/727Accepted registration had no username2018-11-13T19:35:52+01:00Sébastiaan VersteegAccepted registration had no username### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/721Report correct membership status / history on renewal page2018-10-18T11:30:19+02:00Joost Rijneveldjoost@joostrijneveld.nlReport correct membership status / history on renewal page### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
...### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the _last_ membership (since it's not my _current_ membership), or display _all_ historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
### Current behaviour
```
## MEMBERSHIP INFORMATION
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Active: no
You're a supporter. Contact the board to renew your membership.
```
### Expected behaviour
```
## MEMBERSHIP INFORMATION
### Current membership:
No active membership. Contact the board to renew your membership.
### Former memberships:
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Membership type: Supporter
Since: Sept. 1, 2016
Until: Sept. 1, 2017
[..]
```
### Steps to reproduce
1. Don't have an active membership
2. Go to https://thalia.nu/registration/renew/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/706Handle re-registrations after data minimisation2020-02-04T16:22:58+01:00Sébastiaan VersteegHandle re-registrations after data minimisation### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired impleme...### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired implementation
Handle renewals of members of whom data was minimised by allowing them to re-enter the data.31Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/693Study programme is required during model save of Registration2018-09-19T11:44:35+02:00Sébastiaan VersteegStudy programme is required during model save of Registration### One-sentence description
Study programme is required during model save of Registration
### Current behaviour
A registration should always contain a study programme, even for supporters.
### Expected behaviour
Supporters should n...### One-sentence description
Study programme is required during model save of Registration
### Current behaviour
A registration should always contain a study programme, even for supporters.
### Expected behaviour
Supporters should not be forced to have a study programme in their profiles
### Steps to reproduce
1. Add a new registration in the admin, make sure the type is 'supporter'
2. Save the registration
3. Error for the programme field1.18https://gitlab.science.ru.nl/thalia/concrexit/-/issues/691Investigate double registrations2018-10-18T11:30:20+02:00Sébastiaan VersteegInvestigate double registrations### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrati...### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrations/registration/dd814d82-1a53-40a7-9b1c-19ee9b82ed18/change/
2. Check https://thalia.nu/admin/registrations/registration/ed857356-e362-4493-bb0d-f546c9ffcacb/change/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/690Registrations should not be editable after completion2018-09-26T18:59:06+02:00Sébastiaan VersteegRegistrations should not be editable after completion### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/689Automatically execute data minimisation on accepted/rejected registrations af...2019-05-08T19:50:33+02:00Sébastiaan VersteegAutomatically execute data minimisation on accepted/rejected registrations after 1 month### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be mi...### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be minimalised to just the created membership. This will minimalise the places where user data is stored.
- Once registrations are rejected the data should be removed from our system.
- **This should not deleted accepted *and* non-paid registrations**. So those that are waiting for payment.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/684Make it possible to renew supportership for old members via the website2018-09-26T18:56:20+02:00Sébastiaan VersteegMake it possible to renew supportership for old members via the website### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the web...### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/683Email subject renewal is wrong2018-08-27T17:14:09+02:00Sébastiaan VersteegEmail subject renewal is wrong### One-sentence description
Email subject renewal is wrong
### Current behaviour
Dutch translation says 'afgekeurd'
### Expected behaviour
should be 'goedgekeurd'
### Steps to reproduce
1. Accept a renewal
2. Check the email subject### One-sentence description
Email subject renewal is wrong
### Current behaviour
Dutch translation says 'afgekeurd'
### Expected behaviour
should be 'goedgekeurd'
### Steps to reproduce
1. Accept a renewal
2. Check the email subjecthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/681Make re-sending the email confirmation possible for registrations2018-10-03T19:56:43+02:00Sébastiaan VersteegMake re-sending the email confirmation possible for registrations### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it....### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it. Correcting the email address in the admin should be possibly too, if someone made a typo. This way we can correct the values without having to delete the whole registration and let new members do it all over.