concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-11-20T21:16:14+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/950Statistics names are shown wrong2019-11-20T21:16:14+01:00Thijs de JongStatistics names are shown wrong### One-sentence description
The statistics for ``number of members per committee`` shows the names wrong.
### Current behaviour / Reproducing the bug
The statistics for ``number of members per committee`` shows names of the committee u...### One-sentence description
The statistics for ``number of members per committee`` shows the names wrong.
### Current behaviour / Reproducing the bug
The statistics for ``number of members per committee`` shows names of the committee underneath the bars, but not underneath every bar. Only per 2 bars, and when there are more committees, there are less and less committee names.
### Expected behaviour
Every bar has a name underneath it.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/849Banner Dimensions Not in Styleguide2019-04-10T20:32:05+02:00Thijs de JongBanner Dimensions Not in Styleguide### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/795Search button on photos page not responsive2018-12-16T16:08:24+01:00Sébastiaan VersteegSearch button on photos page not responsiveJust like #773
### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
Visit photos page on mobile
### Expected behaviour
Not ugly.Just like #773
### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
Visit photos page on mobile
### Expected behaviour
Not ugly.21https://gitlab.science.ru.nl/thalia/concrexit/-/issues/781Page Alignment incorrect2018-11-21T19:32:57+01:00Thijs de JongPage Alignment incorrect### One-sentence description
The bottom does not reach the bottom of the screen at some pages.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
When, for instance, on this page;https://thalia.nu/education/courses/72/
You...### One-sentence description
The bottom does not reach the bottom of the screen at some pages.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
When, for instance, on this page;https://thalia.nu/education/courses/72/
You can see that the purple block at the bottom does not reach the bottom of your screen (unless your screen is smaller)
![Page_Alignment](/uploads/dffd9dc6bfc82d46aa23e960b6f3d268/Page_Alignment.png)
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
### Expected behaviour
For the purple block to touch the lower bound of the screen.
<!-- Please write how what happened did not meet your expectations -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/779Buttons in event are ugly2018-11-21T19:44:18+01:00Sébastiaan VersteegButtons in event are ugly### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected beh...### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected behaviour
Space between the buttons20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/774Member group photos are not scaled to aspect ratio in Chrome2018-11-18T15:12:08+01:00Sébastiaan VersteegMember group photos are not scaled to aspect ratio in Chrome### One-sentence description
Member group photos are not scaled to aspect ratio in Chrome
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.25.43](/uploads/8ae04d86405c19898eb1cae074ee595d/Screenshot_2018-11-15...### One-sentence description
Member group photos are not scaled to aspect ratio in Chrome
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.25.43](/uploads/8ae04d86405c19898eb1cae074ee595d/Screenshot_2018-11-15_at_11.25.43.png)
### Expected behaviour
Scale by aspect ratiohttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/773Search button on members page not responsive2018-12-10T16:41:50+01:00Sébastiaan VersteegSearch button on members page not responsive### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.23.44](/uploads/981102e2c7572b8071444c1dc5b16161/Screenshot_2018-11-15_at_11.23.44.png...### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_11.23.44](/uploads/981102e2c7572b8071444c1dc5b16161/Screenshot_2018-11-15_at_11.23.44.png)
### Expected behaviour
Not ugly.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/694Replace main photo header by slider2018-10-22T08:52:10+02:00Sébastiaan VersteegReplace main photo header by slider### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/568Set Thalia's theme colour on the address bar2018-03-28T20:19:05+02:00Thom WiggersSet Thalia's theme colour on the address bar### One-sentence description
Set Thalia's theme colour: https://developers.google.com/web/tools/lighthouse/audits/address-bar### One-sentence description
Set Thalia's theme colour: https://developers.google.com/web/tools/lighthouse/audits/address-barhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/539Thumbnails committees page too much compressed2018-10-14T20:20:19+02:00Job DoesburgThumbnails committees page too much compressedThe committee thumbnails are too much compressed as can be seen on this screenshot:
![compressed](/uploads/339506de39d8fc4bdc6af2ae7f86b02c/compressed.png)
Maybe it has something to do with the fact that I'm visiting this page on a retin...The committee thumbnails are too much compressed as can be seen on this screenshot:
![compressed](/uploads/339506de39d8fc4bdc6af2ae7f86b02c/compressed.png)
Maybe it has something to do with the fact that I'm visiting this page on a retina-screen device? Or it's just too much compressionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/459Add part about committee merchandise to the styleguide2017-10-12T12:15:00+02:00Sébastiaan VersteegAdd part about committee merchandise to the styleguide### One-sentence description
Add part about committee merchandise to the styleguide### One-sentence description
Add part about committee merchandise to the styleguide1.11Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/430Include Oswald in Style guide2018-02-07T19:48:39+01:00Thom WiggersInclude Oswald in Style guideWe should use oswald for cases where we need to distribute the font files, such as the app and the website
https://gitlab.science.ru.nl/thalia/ThaliApp/tree/master/www/fonts/oswaldWe should use oswald for cases where we need to distribute the font files, such as the app and the website
https://gitlab.science.ru.nl/thalia/ThaliApp/tree/master/www/fonts/oswald1.14Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/220CSS refactoren en kleine issues fixen2018-11-25T01:45:54+01:00Sébastiaan VersteegCSS refactoren en kleine issues fixen* [x] Fotos lopen over elkaar bij kleiner scherm, bijvoorbeeld in de ledenlijst (#207)
* [x] De taal-knop staat op mobiel over het logo (#202)
* [x] Thumbnails respecteren rotatie niet (#186)
* [ ] Meer SCSS, minder standaard CSS
* [...* [x] Fotos lopen over elkaar bij kleiner scherm, bijvoorbeeld in de ledenlijst (#207)
* [x] De taal-knop staat op mobiel over het logo (#202)
* [x] Thumbnails respecteren rotatie niet (#186)
* [ ] Meer SCSS, minder standaard CSS
* [ ] Nutteloze onderdelen van de template weghalen zodat het style bestand minder groot en complex wordt.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/155Huisstijlbijbel publiekelijk maken2019-09-04T14:20:24+02:00Jelle Besselingjelle@pingiun.comHuisstijlbijbel publiekelijk makenMoet de huisstijlbijbel openbaar gemaakt worden?
We zouden ook enkel de kleuren en logo's openbaar kunnen maken, en downloads van templates achter een login.Moet de huisstijlbijbel openbaar gemaakt worden?
We zouden ook enkel de kleuren en logo's openbaar kunnen maken, en downloads van templates achter een login.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/133Newsletter is not responsive2020-03-11T23:58:51+01:00Lennart JansenNewsletter is not responsive### One-sentence description
When opening the Thalia newsletter via email on a narrow screen, the email clips at the right side.
### Current behaviour
See capture below. While a scrollbar is being displayed at the bottom of the mail, y...### One-sentence description
When opening the Thalia newsletter via email on a narrow screen, the email clips at the right side.
### Current behaviour
See capture below. While a scrollbar is being displayed at the bottom of the mail, you can't expect readers to scroll down and up again to read both parts of each sentence.
![Capture](/uploads/055b923e42161c0ee7846d9cd080e3b6/Capture.PNG)
### Expected behaviour
The width of the email scales with the width of the container in a responsive way.
### Steps to reproduce
1. Open the Thalia newsletter in a mail client, or open the online version in a browser.
2. Narrow the screen down. The scrollbar should appear at 744 pixels. Readability issues start at ~720 pixels.
---
Als je de view breder maakt, blijft de container mooi gecentreerd, maar als je view wat kleiner is, moet je horizontaal scrollen, wat flink irritant is.
De 'most-outer' container past zich wel aan, maar deze blijkt geen effect te hebben op de content-container.Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/127Responsiveness onderwijsmodule detailpagina's2018-11-25T01:45:51+01:00Sébastiaan VersteegResponsiveness onderwijsmodule detailpagina's![Schermafbeelding_2016-01-18_om_16.34.14](/uploads/b9ca2cc74540cb6eb8c415d4540b3409/Schermafbeelding_2016-01-18_om_16.34.14.png)![Schermafbeelding_2016-01-18_om_16.34.14](/uploads/b9ca2cc74540cb6eb8c415d4540b3409/Schermafbeelding_2016-01-18_om_16.34.14.png)Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/74Default profielafbeelding maken voor vrouwelijke leden2017-12-10T21:24:13+01:00Lennart JansenDefault profielafbeelding maken voor vrouwelijke ledenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/72Sluitknop van meldingen is kapot2017-02-07T14:24:48+01:00Sébastiaan VersteegSluitknop van meldingen is kapotHet is niet mooi, vond @mknoopHet is niet mooi, vond @mknoopSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/51Customise error pages2017-12-10T21:33:58+01:00Joost Rijneveldjoost@joostrijneveld.nlCustomise error pagesE.g. restore the 404 'something went terribly wrong' pageE.g. restore the 404 'something went terribly wrong' pageLaunchThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/43Display Thabloid pages in a fancy Javascript viewer2017-12-10T21:19:14+01:00Joost Rijneveldjoost@joostrijneveld.nlDisplay Thabloid pages in a fancy Javascript viewerWe have all the back-end materials we need (i.e. a collection of accessible JPGs for every page). Find a nice Javascript viewer to display the Thabloids in a lightbox. URLs and model hooks are available since !26.
I've looked at [turn...We have all the back-end materials we need (i.e. a collection of accessible JPGs for every page). Find a nice Javascript viewer to display the Thabloids in a lightbox. URLs and model hooks are available since !26.
I've looked at [turn.js](http://www.turnjs.com/#) but could not get it to play nicely - I got annoyed with Javascript and CSS. Might still be worth a shot for someone more perseverant.Gijs HendriksenGijs Hendriksen