concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-10-18T13:38:35+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/713Migrate to new UI template2018-10-18T13:38:35+02:00Sébastiaan VersteegMigrate to new UI templateBootstrap 4, FontAwesome 4, jQuery 3, FullCalendar 3 etc etc.
Much awesome.
Done:
- [x] activemembers
- [x] announcements (still needs removal of old template)
- [x] documents
- [x] education (remove shortnames using migration)
- [x] ev...Bootstrap 4, FontAwesome 4, jQuery 3, FullCalendar 3 etc etc.
Much awesome.
Done:
- [x] activemembers
- [x] announcements (still needs removal of old template)
- [x] documents
- [x] education (remove shortnames using migration)
- [x] events
- [x] members
- [x] merchandise
- [x] partners (still needs removal of code when removing old template)
- [x] photos
- [x] pizzas
- [x] registrations
- [x] templates
- [x] thabloid
- [x] thaliawebsite
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/697Change mentions of 'supporter' to 'benefactor'2018-10-18T11:31:34+02:00Sébastiaan VersteegChange mentions of 'supporter' to 'benefactor'### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use ...### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use several different names for the 'begunstiger' membership type.
### Desired implementation
Always use 'benefactor' as translation.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/692Remove voicemailbox from contact page2018-10-18T11:31:31+02:00Job DoesburgRemove voicemailbox from contact page### One-sentence description
Remove voicemailbox from contact page
### Desired behaviour
The voicemailbox phone number isn't really a thing anymore, so it can be removed from the website.### One-sentence description
Remove voicemailbox from contact page
### Desired behaviour
The voicemailbox phone number isn't really a thing anymore, so it can be removed from the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/695Styleguide documents via Google Drive2018-10-18T11:30:19+02:00Job DoesburgStyleguide documents via Google Drive### One-sentence description
Styleguide documents via Google Drive
### Why?
We want to replace the styleguide downloads by a URL to a subfolder in our drive so new files are always directly available and up-to-date.
### Current imple...### One-sentence description
Styleguide documents via Google Drive
### Why?
We want to replace the styleguide downloads by a URL to a subfolder in our drive so new files are always directly available and up-to-date.
### Current implementation
Files are hosted from the Thalia servers
### Desired implementation
Google Drive folders that can be accessed by members
19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/721Report correct membership status / history on renewal page2018-10-18T11:30:19+02:00Joost Rijneveldjoost@joostrijneveld.nlReport correct membership status / history on renewal page### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
...### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the _last_ membership (since it's not my _current_ membership), or display _all_ historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
### Current behaviour
```
## MEMBERSHIP INFORMATION
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Active: no
You're a supporter. Contact the board to renew your membership.
```
### Expected behaviour
```
## MEMBERSHIP INFORMATION
### Current membership:
No active membership. Contact the board to renew your membership.
### Former memberships:
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Membership type: Supporter
Since: Sept. 1, 2016
Until: Sept. 1, 2017
[..]
```
### Steps to reproduce
1. Don't have an active membership
2. Go to https://thalia.nu/registration/renew/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/670There are no installation instructions for Ubuntu 18.04 in the README2018-10-14T20:43:50+02:00Joren VranckenThere are no installation instructions for Ubuntu 18.04 in the README### One-sentence description
Add installation instructions for Ubuntu 18.04
### Why?
Ubuntu 18.04 is the newest version.
### Current implementation
There are no installation instructions for Ubuntu 18.04 in the README.
### Desired im...### One-sentence description
Add installation instructions for Ubuntu 18.04
### Why?
Ubuntu 18.04 is the newest version.
### Current implementation
There are no installation instructions for Ubuntu 18.04 in the README.
### Desired implementation
There are installation instructions for Ubuntu 18.04 in the README.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/539Thumbnails committees page too much compressed2018-10-14T20:20:19+02:00Job DoesburgThumbnails committees page too much compressedThe committee thumbnails are too much compressed as can be seen on this screenshot:
![compressed](/uploads/339506de39d8fc4bdc6af2ae7f86b02c/compressed.png)
Maybe it has something to do with the fact that I'm visiting this page on a retin...The committee thumbnails are too much compressed as can be seen on this screenshot:
![compressed](/uploads/339506de39d8fc4bdc6af2ae7f86b02c/compressed.png)
Maybe it has something to do with the fact that I'm visiting this page on a retina-screen device? Or it's just too much compressionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/676APIs action decorator replaces list_route and detail_route2018-09-26T20:27:08+02:00Sébastiaan VersteegAPIs action decorator replaces list_route and detail_route/label ~"technical change" ~"priority: low"
### One-sentence description
APIs `action` decorator replaces `list_route` and `detail_route`
http://www.django-rest-framework.org/topics/3.8-announcement/#action-decorator-replaces-list_rou.../label ~"technical change" ~"priority: low"
### One-sentence description
APIs `action` decorator replaces `list_route` and `detail_route`
http://www.django-rest-framework.org/topics/3.8-announcement/#action-decorator-replaces-list_route-and-detail_route
### Why?
Deprecated
1.18https://gitlab.science.ru.nl/thalia/concrexit/-/issues/584Improve documentation for the registrations module2018-09-21T15:10:04+02:00Thom WiggersImprove documentation for the registrations moduleThe ~registrations module could use improved docs.The ~registrations module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/704Change default language to English2018-09-19T20:31:26+02:00Sébastiaan VersteegChange default language to English### One-sentence description
Change default language to English
### Why?
Because we have international members now and we shouldn't force them to switch to English.
### Current implementation
https://gitlab.science.ru.nl/thalia/conc...### One-sentence description
Change default language to English
### Why?
Because we have international members now and we shouldn't force them to switch to English.
### Current implementation
https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/thaliawebsite/settings/settings.py#L197
The default language is Dutch, so this means that devices set to a non-Dutch/English language automatically select it as fallback.
### Desired implementation
The default language should be English, so this means that devices set to a non-Dutch/English language automatically select it as fallback.1.18Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/583Improve documentation for the pushnotifications module2018-09-12T16:22:39+02:00Thom WiggersImprove documentation for the pushnotifications moduleThe ~"push notifications" module could use improved docs.The ~"push notifications" module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/580Improve documentation for payments module2018-09-10T14:08:25+02:00Thom WiggersImprove documentation for payments moduleThe ~payments module could use improved docs.The ~payments module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/586Improve documentation for the thaliawebsite module2018-08-29T21:26:02+02:00Thom WiggersImprove documentation for the thaliawebsite moduleThe `thaliawebsite` module could use improved docs.The `thaliawebsite` module could use improved docs.Improve documentationThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/648Nieuwe versie privacyvoorwaarden op de site zetten2018-08-29T19:49:45+02:00Thom WiggersNieuwe versie privacyvoorwaarden op de site zetten### One-sentence description
Nieuwe versie privacyvoorwaarden op de site zetten
### Current behaviour
https://thalia.nu/privacy-policy/ is nog de oude versie.
### Expected behaviour
https://thalia.nu/privacy-policy/ is de nieuwe ver...### One-sentence description
Nieuwe versie privacyvoorwaarden op de site zetten
### Current behaviour
https://thalia.nu/privacy-policy/ is nog de oude versie.
### Expected behaviour
https://thalia.nu/privacy-policy/ is de nieuwe versie.1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/677Make sure users have email addresses2018-08-28T16:59:10+02:00Sébastiaan VersteegMake sure users have email addresses### One-sentence description
Make sure users have email addresses
### Why?
Because the management commands could crash
### Current implementation
No checks for empty email addresses
### Desired implementation
Checks for empty emai...### One-sentence description
Make sure users have email addresses
### Why?
Because the management commands could crash
### Current implementation
No checks for empty email addresses
### Desired implementation
Checks for empty email addresses1.172018-10-15https://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/672Use pipenv instead of requirements.txt2018-08-15T15:06:16+02:00Thom WiggersUse pipenv instead of requirements.txt### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfil...### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfile.lock`.
https://github.com/pypa/pipenvThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/631pipconflictchecker is broken2018-08-08T20:23:06+02:00Thom Wiggerspipconflictchecker is broken### One-sentence description
https://github.com/ambitioninc/pip-conflict-checker/issues/9 will cause builds to fail
### Workaround
Disable `pipconflictchecker` for now (!790, c24dfde4), re-enable it when it starts working again.### One-sentence description
https://github.com/ambitioninc/pip-conflict-checker/issues/9 will cause builds to fail
### Workaround
Disable `pipconflictchecker` for now (!790, c24dfde4), re-enable it when it starts working again.1.17Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/667Make the starting year field in the registration form a dropdown2018-08-07T12:34:14+02:00Sébastiaan VersteegMake the starting year field in the registration form a dropdown### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/462Include version number in rendered HTML2018-07-25T14:22:12+02:00Joost Rijneveldjoost@joostrijneveld.nlInclude version number in rendered HTML### One-sentence description
Include version number in rendered HTML.
### Why?
This makes it more fool-proof to test and compare beta and production.
### Current implementation
Currently there is no such thing.
### Desired implemen...### One-sentence description
Include version number in rendered HTML.
### Why?
This makes it more fool-proof to test and compare beta and production.
### Current implementation
Currently there is no such thing.
### Desired implementation
During the CI build of the docker image, expose some environment variable that contains the version number. This can then be rendered in some comment in the top-most HTML template.