concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-06-13T19:12:58+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/575Improve events module documentation2018-06-13T19:12:58+02:00Thom WiggersImprove events module documentationThe ~events module could use improved docs.The ~events module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/574Improve documentation for education module2018-06-13T18:59:02+02:00Thom WiggersImprove documentation for education moduleThe ~education module could use improved docs.The ~education module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/573Improve documentation for documents2018-06-13T19:05:01+02:00Thom WiggersImprove documentation for documentsThe ~documents module could use improved docs.The ~documents module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/572Improve documentation for activemembers2018-06-13T18:55:15+02:00Thom WiggersImprove documentation for activemembersThe ~activemembers module could use improved docs.The ~activemembers module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/571we can delete ci-requirements.txt2018-02-21T19:14:33+01:00Thom Wiggerswe can delete ci-requirements.txt### Why?
I don't think it's used anywhere.### Why?
I don't think it's used anywhere.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/570Improve documentation2018-02-13T11:50:42+01:00Thom WiggersImprove documentation### One-sentence description and why
Improve documentation so that we:
* Have something to show on [docs pages](https://thalia.nu/docs/).
* Have (tested) examples for relevant functions (doctests)
* Provide better reference to our newb...### One-sentence description and why
Improve documentation so that we:
* Have something to show on [docs pages](https://thalia.nu/docs/).
* Have (tested) examples for relevant functions (doctests)
* Provide better reference to our newbies and "future generations".https://gitlab.science.ru.nl/thalia/concrexit/-/issues/569Improve test coverage2019-09-11T20:01:49+02:00Sébastiaan VersteegImprove test coverage### One-sentence description
Improve test coverage
### Why?
It will make our lives easier.
### Current implementation
There are a couple of tests.
### Desired implementation
100% coverage.
### Tasks
- [ ] events
- [x] registrati...### One-sentence description
Improve test coverage
### Why?
It will make our lives easier.
### Current implementation
There are a couple of tests.
### Desired implementation
100% coverage.
### Tasks
- [ ] events
- [x] registrations
- [ ] photos
- [ ] members
- [ ] activemembers
- [ ] pizzas
- [ ] documents
etc.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/561Automatically lowercase usernames posted to the token-auth endpoint2018-01-28T20:48:57+01:00Sébastiaan VersteegAutomatically lowercase usernames posted to the token-auth endpoint### One-sentence description
Automatically lowercase usernames posted to the token-auth endpoint
### Why?
Because the login form does the same.
### Current implementation
We use the `ObtainAuthToken` from Django Rest Framework (DRF)...### One-sentence description
Automatically lowercase usernames posted to the token-auth endpoint
### Why?
Because the login form does the same.
### Current implementation
We use the `ObtainAuthToken` from Django Rest Framework (DRF).
### Desired implementation
Extend the view and make sure usernames are converted to lowercase.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/545Change the way we do board permissions2018-01-16T22:20:57+01:00Sébastiaan VersteegChange the way we do board permissionsRelated to #479:
>twiggers: Somewhat related: I'd rather attach the board to a regular Django group than edit their (committee)group's permissions each year: it's much more error-prone to re-add those permissions than it is to add and r...Related to #479:
>twiggers: Somewhat related: I'd rather attach the board to a regular Django group than edit their (committee)group's permissions each year: it's much more error-prone to re-add those permissions than it is to add and remove some members from a Django Group.
> sversteeg: We could create a connection between committees and groups? I don't believe opening 12 user profiles and changing the groups is less error-prone than removing and re-adding the permissions. Maybe continue this is another issue, since I finished this one.
> twiggers: The difference is the kind of mistakes you make. When opening/changing 12 user profiles, you may forget one. When manually adding the tens of permissions we need to give to boards, we're bound to forget one. This is followed by a board member then trying to do something they need to do, and then assigning themselves superuser privileges, and then later perhaps breaking the site.
Good point, needs discussion1.13https://gitlab.science.ru.nl/thalia/concrexit/-/issues/542Partner events require a partner2018-01-17T20:01:39+01:00Joren VranckenPartner events require a partner### One-sentence description
Partner events requires a partner.
### Why?
Some partners do not want a partner page, but do want a partner event.
### Current implementation
It is required to select a partner to create a partner event.
#...### One-sentence description
Partner events requires a partner.
### Why?
Some partners do not want a partner page, but do want a partner event.
### Current implementation
It is required to select a partner to create a partner event.
### Desired implementation
On the vacancy page it is possible to select a partner or enter the name of an "Other partner"
It would be great if that would also be possible on the partner events.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/539Thumbnails committees page too much compressed2018-10-14T20:20:19+02:00Job DoesburgThumbnails committees page too much compressedThe committee thumbnails are too much compressed as can be seen on this screenshot:
![compressed](/uploads/339506de39d8fc4bdc6af2ae7f86b02c/compressed.png)
Maybe it has something to do with the fact that I'm visiting this page on a retin...The committee thumbnails are too much compressed as can be seen on this screenshot:
![compressed](/uploads/339506de39d8fc4bdc6af2ae7f86b02c/compressed.png)
Maybe it has something to do with the fact that I'm visiting this page on a retina-screen device? Or it's just too much compressionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/531Remove obsolete JSON response views in pizzas app2017-12-10T21:12:10+01:00Sébastiaan VersteegRemove obsolete JSON response views in pizzas app### One-sentence description
Remove obsolete JSON response views in pizzas app
### Why?
Because we have an API now
### Current implementation
https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/pizzas/views.py#L73
###...### One-sentence description
Remove obsolete JSON response views in pizzas app
### Why?
Because we have an API now
### Current implementation
https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/pizzas/views.py#L73
### Desired implementation
Use the API for these kind of requests.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/529Resize profile pictures upon upload2017-10-28T13:49:18+02:00Gijs HendriksenResize profile pictures upon upload### One-sentence description
Resize profile pictures upon upload
### Why?
Because it is not necessary to keep profile pictures in their original size. Just like the pictures in the `photos` app, it should be enough to store them in 1920...### One-sentence description
Resize profile pictures upon upload
### Why?
Because it is not necessary to keep profile pictures in their original size. Just like the pictures in the `photos` app, it should be enough to store them in 1920x1080 resolution.
### Current implementation
Uploaded pictures are immediately stored on the site.
### Desired implementation
Uploaded pictures that are too large are resized to a smaller resolution when the picture is uploaded.Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/527MemberListSerializer stuurt full-size foto URIs2018-01-02T16:35:51+01:00Thom WiggersMemberListSerializer stuurt full-size foto URIs### One-sentence description
MemberListSerializer stuurt full-size foto's, dat kunnen beter thumbnails zijn.
### Why?
* Scheelt MBs op mijn databundel
* Als de implementatie van thumbs verandert breekt de app.
### Current implem...### One-sentence description
MemberListSerializer stuurt full-size foto's, dat kunnen beter thumbnails zijn.
### Why?
* Scheelt MBs op mijn databundel
* Als de implementatie van thumbs verandert breekt de app.
### Current implementation
het stuurt de absolute uri naar de foto zelf naar de app toe, de app maakt daar thumbnails van
### Desired implementation
Stuur een thumbnail uri, eventueel als een bepaalde parameter is geset?
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/523Make partner events optin2018-10-29T15:54:11+01:00Joren VranckenMake partner events optin### One-sentence description
Only show partner events to members who have the optin checkbox checked.
### Why?
Like the optin mails, not every member wants to see partner related content.
### Current implementation
The partner e...### One-sentence description
Only show partner events to members who have the optin checkbox checked.
### Why?
Like the optin mails, not every member wants to see partner related content.
### Current implementation
The partner events are shown to everyone in the calendar.
### Desired implementation
Change the optin checkbox from optin for mailing to mailing and partner events.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/521Django 2.02018-01-17T20:01:38+01:00Thom WiggersDjango 2.0### One-sentence description
Klaarmaken voor Django 2.0
### Why?
Hippe nieuwe features: https://docs.djangoproject.com/en/2.0/releases/2.0/
### Current implementation
Django 1.11
### Desired implementation
Django 2.0
### Showstopp...### One-sentence description
Klaarmaken voor Django 2.0
### Why?
Hippe nieuwe features: https://docs.djangoproject.com/en/2.0/releases/2.0/
### Current implementation
Django 1.11
### Desired implementation
Django 2.0
### Showstoppers
* [x] rest_framework
* [x] django-tinymce4-lite
* [x] ???
Zie ook de django-2 branchThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/509Give existing boards default description texts2018-11-21T23:02:40+01:00Joost Rijneveldjoost@joostrijneveld.nlGive existing boards default description textsAs #502 introduces description fields and #478 hides member images, it is probably desirable to provide default descriptions for the legacy boards. Either some manual work, or an automatic migration. See also https://gitlab.science.ru.nl...As #502 introduces description fields and #478 hides member images, it is probably desirable to provide default descriptions for the legacy boards. Either some manual work, or an automatic migration. See also https://gitlab.science.ru.nl/thalia/concrexit/issues/478#note_35279
Bijv. 'The board of xxxx-yyyy was formed by John Doe (position), Jane Doe (position), etc.'https://gitlab.science.ru.nl/thalia/concrexit/-/issues/508Header fields in event export are not being translated2017-12-10T21:12:06+01:00Bram in 't ZandtHeader fields in event export are not being translated### One-sentence description
If you export an event the headers of the export are not translated whereas some of the fields in the export are.
### Why?
Some fields are now in English while others are in Dutch. This looks messy.
### Cur...### One-sentence description
If you export an event the headers of the export are not translated whereas some of the fields in the export are.
### Why?
Some fields are now in English while others are in Dutch. This looks messy.
### Current implementation
Header fields in the export are not translated.
### Desired implementation
Header fields are also translated depending on the chosen language.Bram in 't ZandtBram in 't Zandthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/503Members with no membership are 'Former member' on profile2017-09-23T13:40:29+02:00Joost Rijneveldjoost@joostrijneveld.nlMembers with no membership are 'Former member' on profileCurrently users that do not have a membership at all are marked as `Former member` on their profile. Perhaps it's more accurate to describe those as `Unknown membership history`, given that we are now able to distinguish actual 'former m...Currently users that do not have a membership at all are marked as `Former member` on their profile. Perhaps it's more accurate to describe those as `Unknown membership history`, given that we are now able to distinguish actual 'former members' from e.g. 'former supporters' based on the existence of expired Membership objects.1.11Bram in 't ZandtBram in 't Zandthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/501Old boards on separate page2017-09-20T20:24:39+02:00Sébastiaan VersteegOld boards on separate page### One-sentence description
Old boards on separate page
### Why?
We want to show a description on the board page. This means that the page will get fuller (again) so we need to make some improvements.
### Current implementation
One...### One-sentence description
Old boards on separate page
### Why?
We want to show a description on the board page. This means that the page will get fuller (again) so we need to make some improvements.
### Current implementation
One page showing the current and old boards.
### Desired implementation
Two pages, the current one showing a the current board and one containing a list with all the old boards. The link to the second page can be on the first one, no need for a new menu-item.
The current board page should probably also show the members of the current board for logged-in users.