concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2017-12-10T21:12:55+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/458API information leakage2017-12-10T21:12:55+01:00Joren VranckenAPI information leakage### One-sentence description
Some private information is leaked from the database through the API.
### Why?
When the ThaliApp requests events information from the website, private information is revealed.
For example, the registra...### One-sentence description
Some private information is leaked from the database through the API.
### Why?
When the ThaliApp requests events information from the website, private information is revealed.
For example, the registration dates of every participant of an event and their member ids.
### Current implementation
When querying the API, data is returned that is private and seemingly unnecessary.
### Desired implementation
The API should only return necessary data.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/437Boete niet verplicht bij evenementen zonder inschrijvingen2017-12-13T12:44:17+01:00Thom WiggersBoete niet verplicht bij evenementen zonder inschrijvingen### One-sentence description
De boete bij het afmelden voor een evenement niet meer verplicht hoeven invullen / op nul kunnen laten staan bij evenementen waarvoor je je niet hoeft aan te melden.
### Why?
Ik krijg steeds foutmeldingen a...### One-sentence description
De boete bij het afmelden voor een evenement niet meer verplicht hoeven invullen / op nul kunnen laten staan bij evenementen waarvoor je je niet hoeft aan te melden.
### Why?
Ik krijg steeds foutmeldingen als ik mijn borrels bewerk.
### Current implementation
Ik krijg als ik een borrel maak dan klaagt de site dat ik `5.0` moet invullen.
### Desired implementation
Niet meer `5.0` hoeven invullen als ik ook geen aanmeldingen accepteer.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/422Zoeken naar mailinglijsten op basis van aliassen is lastig2017-12-10T21:12:52+01:00Joost Rijneveldjoost@joostrijneveld.nlZoeken naar mailinglijsten op basis van aliassen is lastig### One-sentence description
Het is lastig om een mailinglijst te vinden op basis van een alias (ctlr+F in het overzicht werkt dan natuurlijk niet). Dit kwam ik tegen tijdens #388.
### Why?
Dat is onhandig als je iemand wil toevoegen ...### One-sentence description
Het is lastig om een mailinglijst te vinden op basis van een alias (ctlr+F in het overzicht werkt dan natuurlijk niet). Dit kwam ik tegen tijdens #388.
### Why?
Dat is onhandig als je iemand wil toevoegen aan een lijst op basis van de naam.
### Current implementation
Het overzicht in /admin toont alleen de lijst met lijstnamen.
### Desired implementation
Een zoekveld toevoegen dat aliassen doorzoekt, of de aliassen in een kolommetje in het overzicht weergeven zodat ctrl+f genoeg is.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/420Small mistakes in board memberships on profile pages2017-12-10T21:12:52+01:00Joren VranckenSmall mistakes in board memberships on profile pages### One-sentence description
There are translation mistakes, a date format mistake and confusing end dates in the board membership on profile pages.
### Why?
In the case that the board member did not stop before the end of the year,...### One-sentence description
There are translation mistakes, a date format mistake and confusing end dates in the board membership on profile pages.
### Why?
In the case that the board member did not stop before the end of the year, the start and end date are redundant, because the relevant year is stated in bold.
In the case that the board member did stop before the end of the year, the end date is a bit confusing.
For example, [the profile of Simon Brugman](https://thalia.nu/members/profile/884) says:
> **Secretaris [tot 2015-02-13]**: Sept. 1, 2012 - Aug. 31, 2013 `
Which contains two different end dates: `2015-02-13` and `Aug. 31, 2013`.
### Current implementation
Two end dates, one for the end of the board itself (`Aug. 31, 2013` in the example) and one for the end of the board membership (`2015-02-13` in the example).
The words `tot` and `bestuur` are not translated on the page.
In the example the format of `2015-02-13` is wrong and should (presumably) be `15-02-2013`
### Desired implementation
- Remove the start and end date for boards.
- Fix the end date format for board memberships that ended before the end of the year.
- Fix the translation of the words `bestuur` and `tot`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/321Write newsletter HTML to database on sending2019-03-27T20:38:47+01:00Joost Rijneveldjoost@joostrijneveld.nlWrite newsletter HTML to database on sending### One-sentence description
Write newsletter HTML to database or static document after sending
### Why?
To make sure it stays the same over time.
### Current implementation
It's generated when the web preview is opened
### Desired...### One-sentence description
Write newsletter HTML to database or static document after sending
### Why?
To make sure it stays the same over time.
### Current implementation
It's generated when the web preview is opened
### Desired implementation
Save the email to the database and serve that HTML
---
De sortering is anders (dat is misschien opgelost met #179), maar bovendien bevat de online versie een extra stukje tekst onderaan; (_"Is this email not in your preferred language? [..] in the language you selected."_)
Ik stel voor die tekst een paar letterpuntjes kleiner te maken (en misschien iets minder langdradig te maken door de laatste zin weg te laten), en dan ook in de nieuwsbrief mee te sturen.
Verder lijkt er inconsistentie te zitten tussen de boete-bedragen; in de mail van week 6 die ik ontving wordt expliciet een boete van 5 euro genoemd bij het symposium, maar dat is in de online-versie niet terug te vinden.
**Essentie van het verhaal:** ik weet niet goed hoe die online preview tot stand komt, maar het lijkt me belangrijk om 'm te "bevriezen" zodra de nieuwsbrief daadwerkelijk verstuurd is, door gewoon ergens wat statische HTML weg te schrijven. Dan voorkom je dit soort gedoe fundamenteel, ipv door de individuele dingen te moeten tackelen.Michiel KraanMichiel Kraanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/310Set is_staff to False for old board members2019-09-11T20:14:01+02:00Joost Rijneveldjoost@joostrijneveld.nlSet is_staff to False for old board members### One-sentence description
Set is_staff to False for old board members
### Why?
This follows from the dicussion in !335 but it is not clear how and if this should be solved.
This issue was created so that we could think about this a...### One-sentence description
Set is_staff to False for old board members
### Why?
This follows from the dicussion in !335 but it is not clear how and if this should be solved.
This issue was created so that we could think about this and discuss this with everyone.
### Current implementation
`is_staff` is set to True for everyone who becomes a board member and is never set to False because board memberships don't end. This is also the reason why committee membership end dates cannot be in the future, since it sets `is_staff` to False if applicable.
### Desired implementation
Do nothing
or
Set it to False using a Celery task or cronjob for examplehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/291Test sitemap in unit tests2019-02-10T17:20:33+01:00Joost Rijneveldjoost@joostrijneveld.nlTest sitemap in unit testsThe sitemap is quite vulnerable to `NoReverseMatch` exceptions when the URL scheme changes. A test case that tries to access the sitemap would likely reveal these errors preemptively (but it would require fixtures to be fairly complete, ...The sitemap is quite vulnerable to `NoReverseMatch` exceptions when the URL scheme changes. A test case that tries to access the sitemap would likely reveal these errors preemptively (but it would require fixtures to be fairly complete, as such errors might not trigger when parts of the database are empty).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/142Separate build settings from defaults2019-09-04T14:20:24+02:00Joost Rijneveldjoost@joostrijneveld.nlSeparate build settings from defaultsCurrently we depend on `django_template_check` for the build, as it runs a test we would like to run during CI. This application provides a management command when installed. However, this means that it is installed in production (and de...Currently we depend on `django_template_check` for the build, as it runs a test we would like to run during CI. This application provides a management command when installed. However, this means that it is installed in production (and development) environments as well, needlessly cluttering `requirements.txt` and `INSTALLED_APPS`. This may be a more general problem that can be fixed by re-thinking the way we manage settings (without introducing duplication).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/829Switch to Poetry2019-02-27T19:29:01+01:00Sébastiaan VersteegSwitch to Poetry<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Switch to Poetry
### Why?
Because we're hipsters. (no we think it is better)
### Current implementation
Pipenv
### Suggested implementation
PoetryJelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/745Thalia Identity guidelines applied in Django backend2019-12-04T19:25:32+01:00Job DoesburgThalia Identity guidelines applied in Django backend<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Thalia Identi...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Thalia Identity guidelines applied in Django backend
### Why?
More 'huisstijl' more better
### Current implementation
Thalia admin is ugly blue-ish.
### Suggested implementation
This could be nice magenta #E62272 and black. Just a CSS thingy I think.Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/715Add note to phone number about reachability2018-10-22T18:52:34+02:00Job DoesburgAdd note to phone number about reachability### One-sentence description
We would like to add a note on the website contact page that we can be reached by phone or in person in the board room on weekdays between 12:15 and 13:30 (or more often if you are lucky). Maybe you can figur...### One-sentence description
We would like to add a note on the website contact page that we can be reached by phone or in person in the board room on weekdays between 12:15 and 13:30 (or more often if you are lucky). Maybe you can figure out a nice way of mentioning this, otherwise we'll think with you ;)
### Why?
So people know when to reach us
### Current implementation
There is no note on the contactpage of the site
### Desired implementation
There is a note on the contactpage of the sitehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/701Squash migrations2019-09-11T20:11:31+02:00Sébastiaan VersteegSquash migrations### One-sentence description
Squash migrations
### Why?
Some apps have really large migration sets, we could decrease the amount of files drastically and make new installs have easier migrations
### Current implementation
Lots of mi...### One-sentence description
Squash migrations
### Why?
Some apps have really large migration sets, we could decrease the amount of files drastically and make new installs have easier migrations
### Current implementation
Lots of migration files
### Desired implementation
Less migration fileshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/588Improve docs for the announcements module2018-02-21T19:14:33+01:00Thom WiggersImprove docs for the announcements moduleThe ~announcements events module could use improved docs.The ~announcements events module could use improved docs.Improve documentationThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/587Improve documentation for the utils module2018-02-21T19:14:33+01:00Thom WiggersImprove documentation for the utils moduleThe `utils` module could use improved docs.The `utils` module could use improved docs.Improve documentationThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/586Improve documentation for the thaliawebsite module2018-08-29T21:26:02+02:00Thom WiggersImprove documentation for the thaliawebsite moduleThe `thaliawebsite` module could use improved docs.The `thaliawebsite` module could use improved docs.Improve documentationThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/585Improve documentation for the thabloid module2018-02-13T12:01:00+01:00Thom WiggersImprove documentation for the thabloid moduleThe ~thabloid module could use improved docs.The ~thabloid module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/584Improve documentation for the registrations module2018-09-21T15:10:04+02:00Thom WiggersImprove documentation for the registrations moduleThe ~registrations module could use improved docs.The ~registrations module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/583Improve documentation for the pushnotifications module2018-09-12T16:22:39+02:00Thom WiggersImprove documentation for the pushnotifications moduleThe ~"push notifications" module could use improved docs.The ~"push notifications" module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/582Improve documentation for the pizzas module2019-11-20T20:38:02+01:00Thom WiggersImprove documentation for the pizzas moduleThe ~pizzas module could use improved docs.The ~pizzas module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/581Improve documentation for photos module2019-02-16T23:02:53+01:00Thom WiggersImprove documentation for photos moduleThe ~photos module could use improved docs.The ~photos module could use improved docs.Improve documentation