concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-04T16:22:58+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/706Handle re-registrations after data minimisation2020-02-04T16:22:58+01:00Sébastiaan VersteegHandle re-registrations after data minimisation### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired impleme...### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired implementation
Handle renewals of members of whom data was minimised by allowing them to re-enter the data.31Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/585Improve documentation for the thabloid module2018-02-13T12:01:00+01:00Thom WiggersImprove documentation for the thabloid moduleThe ~thabloid module could use improved docs.The ~thabloid module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/581Improve documentation for photos module2019-02-16T23:02:53+01:00Thom WiggersImprove documentation for photos moduleThe ~photos module could use improved docs.The ~photos module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1034Missing singlepages translations2020-03-13T16:29:15+01:00Joren VranckenMissing singlepages translations### Description
Add all missing singlepages translations.
After I run `../manage.py makemessages --locale nl --no-obsolete` in `website/singlepages` 170+ translations seem to be missing.### Description
Add all missing singlepages translations.
After I run `../manage.py makemessages --locale nl --no-obsolete` in `website/singlepages` 170+ translations seem to be missing.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1022Add wiki page about Renovate2020-02-28T12:10:47+01:00Joren VranckenAdd wiki page about Renovate### One-sentence description
Add wiki page about Renovate.
### Why?
It is important to have documentation about the third-party applications we use.### One-sentence description
Add wiki page about Renovate.
### Why?
It is important to have documentation about the third-party applications we use.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1021Replace Docker image used by Renovate2020-02-28T12:09:51+01:00Joren VranckenReplace Docker image used by Renovate### One-sentence description
Replace Docker image used by Renovate.
### Why?
Apparently Renovate still uses [`thalia/python-thalia`](https://hub.docker.com/r/thalia/python-thalia). `thalia/python-thalia` is outdated and not automaticall...### One-sentence description
Replace Docker image used by Renovate.
### Why?
Apparently Renovate still uses [`thalia/python-thalia`](https://hub.docker.com/r/thalia/python-thalia). `thalia/python-thalia` is outdated and not automatically updated.
### Suggested implementation
Either [`renovate/python`](https://hub.docker.com/r/renovate/python) or [`thalia/concrexit-dependencies`](https://hub.docker.com/r/thalia/concrexit-dependencies).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1020Do not use hardcoded colors for calendar API2020-03-04T17:06:42+01:00Job DoesburgDo not use hardcoded colors for calendar API<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Do not use hardcoded colors for calendar API in `website/members/api/serializers.py` r42-49 and `website/events/api/serializers.py`
### Why?
We shouldn't hardcode these things at the API level but provide them using CSS.
### Current implementation
The API provides a `backgroundColor` and `textColor` in the event sources APIs that is used by FullCalendar via https://fullcalendar.io/docs/events-json-feed. Every item in the feed is an event source object: https://fullcalendar.io/docs/event-source-object.
### Suggested implementation
Provide a `className` attribute instead and determine the background color and text color based on the class using CSS.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1019Move business logic of notifications out of models2020-02-23T16:30:42+01:00Sébastiaan VersteegMove business logic of notifications out of models<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Move business logic of notifications out of models
### Why?
Clean up the models
### Current implementation
Code in the models (mostly events)
### Suggested implementation
Use signalsSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1017Remove redundant html templates from `/thaliawebsite/templates/singlepages/`2020-03-13T16:29:15+01:00Job DoesburgRemove redundant html templates from `/thaliawebsite/templates/singlepages/`<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove redundant html templates from `/thaliawebsite/templates/singlepages/`
### Why?
They are redundant, since they are also in `/singlepages/templates` and these are the ones that are used.
### Current implementation
It appears as if the translations are still in `/thaliawebsite` though, so it would probably be nice to move these.
### Suggested implementationMarthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1013Prevent payment cancellation when payment in batch2020-03-09T17:59:50+01:00Job DoesburgPrevent payment cancellation when payment in batch### One-sentence description
Prevent payment cancellation / changes when payment in batch
### Why?
When a payment is added to a payment batch (#932), it must stay in there and may not be changed or deleted anymore.
### Current implem...### One-sentence description
Prevent payment cancellation / changes when payment in batch
### Why?
When a payment is added to a payment batch (#932), it must stay in there and may not be changed or deleted anymore.
### Current implementation
This might be possible
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1011Use create_payment everywhere2020-03-09T17:59:50+01:00Job DoesburgUse create_payment everywhere### One-sentence description
Use create_payment (from #1010 ) everywhere where we use payments
### Why?
Prevent code duplication
### Current implementation
Shitty, chaotic, anarchy, tears
### Suggested implementation
Make models P...### One-sentence description
Use create_payment (from #1010 ) everywhere where we use payments
### Why?
Prevent code duplication
### Current implementation
Shitty, chaotic, anarchy, tears
### Suggested implementation
Make models Payable (implement the interface / abstract class from #1010) and use `create_payment` as the only way to interact with / create payments.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1009Improve tests for Payments app2020-02-12T20:39:44+01:00Luko van der MaasImprove tests for Payments app### One-sentence description
A lot of tests for payments are either not consistent or do some weird stuff.
### Why?
Better tests helps stability### One-sentence description
A lot of tests for payments are either not consistent or do some weird stuff.
### Why?
Better tests helps stabilitySébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1000Internet required to run tests2020-01-26T22:07:58+01:00Joren VranckenInternet required to run tests### Description
Internet required to run tests, because [`activemembers/signals.py` always initializes the G Suite API](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/signals.py#L15). This is not (and sho...### Description
Internet required to run tests, because [`activemembers/signals.py` always initializes the G Suite API](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/signals.py#L15). This is not (and should not be) always necessary (e.g. when running tests).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/995Deliver sliders or other large images as webp2020-01-15T22:41:46+01:00Jelle Besselingjelle@pingiun.comDeliver sliders or other large images as webp<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### Why?
According to [Google PageSpeed](https://developers.google.com/speed/pagespeed/insights/?hl=nl&url=thalia.nu&tab=mobile), we can speed up our site by a lot by converting slider images to webp.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Large pictures are all served as png, this is a good image format for things that need to be compressed lossless.
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Supply images as `<picture>` [with multiple sources](https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images#Use_modern_image_formats_boldly)
<!-- Provide (a) suggestion(s) for how we could approach this -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/977Remove obsolete permissions2019-12-04T21:29:10+01:00Sébastiaan VersteegRemove obsolete permissions### One-sentence description
Remove obsolete permissions that are left from removed things
### Why?
They're obsolete!
### Current implementation
We have the sentry backend, access to the board wiki and soon the nextcloud admin permi...### One-sentence description
Remove obsolete permissions that are left from removed things
### Why?
They're obsolete!
### Current implementation
We have the sentry backend, access to the board wiki and soon the nextcloud admin permissions.
### Suggested implementation
Should be removed.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/976Use html email template for all emails we send2020-02-19T21:13:30+01:00Job DoesburgUse html email template for all emails we send### One-sentence description
Use html email template for all emails we send
### Why?
It looks nice
### Current implementation
We only send plaintext mails, except for the information check emails
### Suggested implementation
Use t...### One-sentence description
Use html email template for all emails we send
### Why?
It looks nice
### Current implementation
We only send plaintext mails, except for the information check emails
### Suggested implementation
Use the information check email templatehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/961Remove Payment type None2020-03-09T17:59:50+01:00Job DoesburgRemove Payment type None<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove Payment type None
### Why?
It is weird to have payment objects for payments that not yet have taken place. It makes much more sense to just have no payment then.
### Current implementation
For registrations, we now make payments for every accepted registration, and change the type when it really is paid.
### Suggested implementation
Make a payment object upon payment.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/745Thalia Identity guidelines applied in Django backend2019-12-04T19:25:32+01:00Job DoesburgThalia Identity guidelines applied in Django backend<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Thalia Identi...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Thalia Identity guidelines applied in Django backend
### Why?
More 'huisstijl' more better
### Current implementation
Thalia admin is ugly blue-ish.
### Suggested implementation
This could be nice magenta #E62272 and black. Just a CSS thingy I think.Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/569Improve test coverage2019-09-11T20:01:49+02:00Sébastiaan VersteegImprove test coverage### One-sentence description
Improve test coverage
### Why?
It will make our lives easier.
### Current implementation
There are a couple of tests.
### Desired implementation
100% coverage.
### Tasks
- [ ] events
- [x] registrati...### One-sentence description
Improve test coverage
### Why?
It will make our lives easier.
### Current implementation
There are a couple of tests.
### Desired implementation
100% coverage.
### Tasks
- [ ] events
- [x] registrations
- [ ] photos
- [ ] members
- [ ] activemembers
- [ ] pizzas
- [ ] documents
etc.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/310Set is_staff to False for old board members2019-09-11T20:14:01+02:00Joost Rijneveldjoost@joostrijneveld.nlSet is_staff to False for old board members### One-sentence description
Set is_staff to False for old board members
### Why?
This follows from the dicussion in !335 but it is not clear how and if this should be solved.
This issue was created so that we could think about this a...### One-sentence description
Set is_staff to False for old board members
### Why?
This follows from the dicussion in !335 but it is not clear how and if this should be solved.
This issue was created so that we could think about this and discuss this with everyone.
### Current implementation
`is_staff` is set to True for everyone who becomes a board member and is never set to False because board memberships don't end. This is also the reason why committee membership end dates cannot be in the future, since it sets `is_staff` to False if applicable.
### Desired implementation
Do nothing
or
Set it to False using a Celery task or cronjob for example