concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-12-19T22:46:18+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/257Add documents to event page2018-12-19T22:46:18+01:00Luuk ScholtenAdd documents to event page
### One-sentence description
Add documents to event page
### Desired behaviour
Have a list with documents on the event page.
### One-sentence description
Add documents to event page
### Desired behaviour
Have a list with documents on the event page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/700Alphabetically order Miscellaneous Association Documents2018-11-07T19:14:40+01:00Sébastiaan VersteegAlphabetically order Miscellaneous Association Documents### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically19Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/339Update pagina "Documenten"2018-09-12T19:53:31+02:00Ghost UserUpdate pagina "Documenten"Zoals de documenten (beleidsplannen, jaarverslagen, notulen, etc.) nu op de pagina staan, raak ik persoonlijk erg gemakkelijk het overzicht kwijt.
Het is bijvoorbeeld niet goed zichtbaar of de versie van een jaarverslag die van vóór de a...Zoals de documenten (beleidsplannen, jaarverslagen, notulen, etc.) nu op de pagina staan, raak ik persoonlijk erg gemakkelijk het overzicht kwijt.
Het is bijvoorbeeld niet goed zichtbaar of de versie van een jaarverslag die van vóór de alv is, of van erna.
Vaak zegt een afbeelding meer dan duizend woorden. Ik heb dan ook even met InDesign aan zitten klooien.
De bijgevoegde PDF is hoe ik de indeling van de pagina "Documenten" graag zou zien, natuurlijk modulo wat aanpassingen/toevoegingen/etc.
Ik ben vanzelfsprekend beschikbaar voor vragen.
[Nieuwe_design.pdf](/uploads/d294187931a0fe893636e4344e176699/Nieuwe_design.pdf)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/49Hook the GeneralMeetings model (used in documents package) into events2018-09-12T19:23:41+02:00Joost Rijneveldjoost@joostrijneveld.nlHook the GeneralMeetings model (used in documents package) into eventsCurrently these are stored completely separately. We could instead create a `ForeignKey` relation to the relevant event to derive the date and location.Currently these are stored completely separately. We could instead create a `ForeignKey` relation to the relevant event to derive the date and location.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/642Document link in the backend broken2018-07-04T19:24:25+02:00Joren VranckenDocument link in the backend broken### One-sentence description
The document link in the backend is broken.
### Current behaviour
When clicking on a link to download a document in the backend, you a re directed to 404 page instead of the document.
### Expected behaviou...### One-sentence description
The document link in the backend is broken.
### Current behaviour
When clicking on a link to download a document in the backend, you a re directed to 404 page instead of the document.
### Expected behaviour
Either a redirect to the document or no link to the document.
### Steps to reproduce
1. Go to the [backend page of the bylaws](https://thalia.nu/admin/documents/associationdocument/57/change/)
2. Click on the the link [`documents/miscellaneous/statuten_xImuGrw.pdf`](https://thalia.nu/media/documents/miscellaneous/statuten_xImuGrw.pdf)Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/641It is unclear if the year field on documents in the backend refers to the fir...2018-06-13T22:01:01+02:00Joren VranckenIt is unclear if the year field on documents in the backend refers to the first or last year of the academic year.### One-sentence description
It is unclear if the year field on documents in the backend refers to the first or last year for that document.
### Why?
A document for an academic year has two years (e.g. the policy document for 2017-2018)...### One-sentence description
It is unclear if the year field on documents in the backend refers to the first or last year for that document.
### Why?
A document for an academic year has two years (e.g. the policy document for 2017-2018).
### Current implementation
It is possible to select only one year.
### Desired implementation
It is possible to select the academic year for documents.Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/573Improve documentation for documents2018-06-13T19:05:01+02:00Thom WiggersImprove documentation for documentsThe ~documents module could use improved docs.The ~documents module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/626Display order of documents2018-05-28T12:50:46+02:00Gerdriaan MulderDisplay order of documents### One-sentence description
The display order of the documents can be configured.
### Desired behaviour
At the moment, there does not seem to be a logical order in the documents page. For example, the document "Huishoudelijk Reglement ...### One-sentence description
The display order of the documents can be configured.
### Desired behaviour
At the moment, there does not seem to be a logical order in the documents page. For example, the document "Huishoudelijk Reglement (26-08-2014)" is mentioned earlier than the more recent document "Huishoudelijk Reglement (04-10-2017)". This is confusing.
What I would like to see is that a more recent document is shown earlier on when multiple versions of that document exist.
It is also acceptable if an admin can configure this (ideally, the "Statuten" and "Huishoudelijk Reglement" would be mentioned first, before all other documents).Jeremy GuijtJeremy Guijthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/620Pressing the minutes button on a general meeting does not download the minutes2018-04-05T14:08:48+02:00Joren VranckenPressing the minutes button on a general meeting does not download the minutes### One-sentence description
Pressing the minutes button on a general meeting does not download the minutes
### Current behaviour
When downloading minutes of a general meeting, the sites returns another document.
### Expected behavio...### One-sentence description
Pressing the minutes button on a general meeting does not download the minutes
### Current behaviour
When downloading minutes of a general meeting, the sites returns another document.
### Expected behaviour
When downloading minutes of a general meeting, the sites returns the minutes.
### Steps to reproduce
1. Go to the [document page]()
2. Download the minutes of the general meeting of the 4th of october.
3. Observe that the `huishoudelijk-reglement-26-08-2014.pdf` is downloaded.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/618General meeting document names are tuples2018-03-29T15:13:43+02:00Joren VranckenGeneral meeting document names are tuples### One-sentence description
General Meeting document names are tuples instead of strings
### Current behaviour
![2018-03-24_1214x723](/uploads/ae7e22bb48fccbe23cfb94d17c959abc/2018-03-24_1214x723.png)
### Expected behaviour
General...### One-sentence description
General Meeting document names are tuples instead of strings
### Current behaviour
![2018-03-24_1214x723](/uploads/ae7e22bb48fccbe23cfb94d17c959abc/2018-03-24_1214x723.png)
### Expected behaviour
General Meeting document names are shown as strings.
### Steps to reproduce
1. Go to the [documents page](https://thalia.nu/documents/)
2. Observe general meeting document names.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/589Documents tests fail to close a file handle.2018-02-21T19:14:33+01:00Thom WiggersDocuments tests fail to close a file handle.### One-sentence description
Documents tests fail to close a file handle.
### Current behaviour
```
./home/thom/git/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/django/db/models/query.py:195: ResourceWarning: unclos...### One-sentence description
Documents tests fail to close a file handle.
### Current behaviour
```
./home/thom/git/thalia/concrexit/.tox/py36-django20/lib/python3.6/site-packages/django/db/models/query.py:195: ResourceWarning: unclosed file <_io.FileIO name='/home/thom/git/thalia/concrexit/website/media/documents/file_nl_CwarPQj.pdf' mode='rb' closefd=True>
```
### Expected behaviour
No warning
### Steps to reproduce
1. toxThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/519Make documents bilingual2018-02-21T19:14:33+01:00Gijs HendriksenMake documents bilingual### One-sentence description
Make it so documents can be uploaded in both Dutch and English, and display one according to the user's language preference
### Desired behaviour
Since the association will gradually produce more documents i...### One-sentence description
Make it so documents can be uploaded in both Dutch and English, and display one according to the user's language preference
### Desired behaviour
Since the association will gradually produce more documents in both Dutch and English, they should get a place on the website. In my opinion, the best way to do it is to have two fields for each document to upload one of both languages. Then, upon loading the `documents` page, the documents in the right language are loaded. If the corresponding language is not available for a certain document, it could fall back to the other language.Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/268Voorkom dat ALV-stukken nonces in de naam krijgen2018-02-21T19:14:32+01:00Joost Rijneveldjoost@joostrijneveld.nlVoorkom dat ALV-stukken nonces in de naam krijgenWe hebben de documentenmigratie natuurlijk twee keer uitgevoerd, waardoor alle bestanden dubbel zijn. In het bijzonder zorgt dit ervoor dat alle bestanden die we nu aanbieden zo'n lelijke nonce in de naam hebben. Dat ziet er niet uit.
W...We hebben de documentenmigratie natuurlijk twee keer uitgevoerd, waardoor alle bestanden dubbel zijn. In het bijzonder zorgt dit ervoor dat alle bestanden die we nu aanbieden zo'n lelijke nonce in de naam hebben. Dat ziet er niet uit.
Wellicht in combinatie met #16https://gitlab.science.ru.nl/thalia/concrexit/-/issues/328ALV-documenten-viewer default op 2017-2018 in februari2017-12-10T21:29:44+01:00Joost Rijneveldjoost@joostrijneveld.nlALV-documenten-viewer default op 2017-2018 in februariHet nieuwe collegejaar is nog niet begonnen, maar de documenten-viewer geeft al wel aan dat er in dat jaar nog geen ALV's hebben plaatsgevonden. Dat lijkt een beetje te enthousiast. Wellicht gebruik maken van de functies rondom 'welk col...Het nieuwe collegejaar is nog niet begonnen, maar de documenten-viewer geeft al wel aan dat er in dat jaar nog geen ALV's hebben plaatsgevonden. Dat lijkt een beetje te enthousiast. Wellicht gebruik maken van de functies rondom 'welk collegejaar is het' ipv 'welk jaar is het'https://gitlab.science.ru.nl/thalia/concrexit/-/issues/3492017-2018 ALV is het standaard geselecteerde collegejaar voor ALVs in Documenten2017-12-10T21:25:23+01:00Milan van Stiphout2017-2018 ALV is het standaard geselecteerde collegejaar voor ALVs in DocumentenTerwijl we nog in 2016-2017 zitten.Terwijl we nog in 2016-2017 zitten.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/460Documents: 2011-2012 is not directly reachable2017-12-10T21:10:48+01:00Gerdriaan MulderDocuments: 2011-2012 is not directly reachable### One-sentence description
The documents page should switch to the year 2011-2012 when it is selected from the drop-down box.
### Current behaviour
The documents page does not switch to the year 2011-2012 when it is selected from the ...### One-sentence description
The documents page should switch to the year 2011-2012 when it is selected from the drop-down box.
### Current behaviour
The documents page does not switch to the year 2011-2012 when it is selected from the drop-down box.
### Expected behaviour
The documents page switches to the year 2011-2012 when it is selected from the drop-down box.
### Steps to reproduce
1. Log in
2. Go to the `/documents/` page (e.g. Association -> Documents).
3. Navigate to "General meetings"
4. Click on `2011-2012` (a dropdown box appears)
5. Click on `2011-2012` in the dropdown box
6. Nothing happens.
Alternatively, replace step 5 by clicking on another item (e.g. `2010-2011`) and then execute the original step 4 and 5 again. In that case, step 6 is replaced by the expected behaviour.
Note: the period (i.e. `2011-2012`) is relative to the current period. When we switch to the next year, this period will be `2012-2013`.Joost Rijneveldjoost@joostrijneveld.nlJoost Rijneveldjoost@joostrijneveld.nlhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/131Archivering oude ALV-documenten2017-09-13T19:43:39+02:00Ko StoffelenArchivering oude ALV-documentenEr missen nogal wat oude jaarverslagen e.d. op de website. Die hebben ook nooit op de oude site gestaan, maar misschien is het wel tof om ze ook op de site te archiveren. Dit is wat ik zo nog kan vinden, maar misschien dat @wboumans verd...Er missen nogal wat oude jaarverslagen e.d. op de website. Die hebben ook nooit op de oude site gestaan, maar misschien is het wel tof om ze ook op de site te archiveren. Dit is wat ik zo nog kan vinden, maar misschien dat @wboumans verder komt.
[thalia.tar.gz](/uploads/cddbf945b53940e2b35a38650faec0c6/thalia.tar.gz)