concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-01-08T22:43:53+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/992KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Thalia TechnicieKeyError: 'delete_selected'Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line...Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line 45, in _wrapper
return bound_method(*args, **kwargs)
File "django/utils/decorators.py", line 142, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/options.py", line 1685, in changelist_view
cl = self.get_changelist_instance(request)
File "django/contrib/admin/options.py", line 727, in get_changelist_instance
if self.get_actions(request):
File "events/admin.py", line 205, in get_actions
del actions['delete_selected']
```30Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/941event registration terms and conditions link broken2019-10-24T19:17:38+02:00Nick van Oersevent registration terms and conditions link broken### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/870CSV export does not contain payment values2019-05-15T19:33:27+02:00Job DoesburgCSV export does not contain payment values### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible...### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible in the admin24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/859Event terms has point 6 double2019-04-17T20:30:27+02:00Sébastiaan VersteegEvent terms has point 6 double### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/846Name of programme at registration page is "Informatica" instead of "Computing...2019-04-03T20:10:10+02:00Job DoesburgName of programme at registration page is "Informatica" instead of "Computing Science"### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this conf...### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this confusing since in their opinion they study "Computing Science"
### Current behaviour / Reproducing the bug
Go to the registration page, check out the dropdown menu
### Expected behaviour
Display something like "Informatica (Computing Science)"
P.S: a 'won't fix' would be a pretty good solution here in my opinion but I thought it could be nice to mentionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/563Wijziging contactgegevens Thalia2018-01-28T20:48:57+01:00Jeremy GuijtWijziging contactgegevens Thalia### One-sentence description
De contactgegevens van Thalia veranderen vanaf 23-01-2017, hiervoor moet ook de informatie op de site worden aangepast.
### Desired behaviour
Nieuwe contactgegevens:
Room: M1.0.08
Address: Toernoo...### One-sentence description
De contactgegevens van Thalia veranderen vanaf 23-01-2017, hiervoor moet ook de informatie op de site worden aangepast.
### Desired behaviour
Nieuwe contactgegevens:
Room: M1.0.08
Address: Toernooiveld 212 <br />
6525EC Nijmegen
Telephone: +31 (0)24 365 3498https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1004'All members' in members directory not marked as active2020-02-05T21:18:38+01:00Sébastiaan Versteeg'All members' in members directory not marked as active### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected ...### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected behaviour
1. Go to https://thalia.nu/members/directory/
2. The item is selectedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/998Add information to exam / summary submission2020-03-11T20:14:27+01:00Ward TheunisseAdd information to exam / summary submission<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of ex...<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of exams immediately because there's a review first. This way it is not clear whether the submission was actually performed correctly + people don't know that an submission is manually checked before being published.
### Desired functionality
Inform people whether their submission was succesful and why it isn't immediately visible.
### Suggested implementation
Show a message thanking someone for their submission, also informing them that it will be published after a review.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/981Missing translations in statistics page2020-02-19T23:46:54+01:00Job DoesburgMissing translations in statistics page### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right ch...### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right chart
### Expected behaviour
be translatedMark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/980Thalia Pay process button enabled in payments widget even though TPAY_ENABLED...2020-02-19T21:48:26+01:00Sébastiaan VersteegThalia Pay process button enabled in payments widget even though TPAY_ENABLED=False### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
#...### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
### Expected behaviour
1. I cannot click it
2. If I should be able to click it, it should not crash.Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/979Login page visible when logged-in2020-02-05T21:24:02+01:00Sébastiaan VersteegLogin page visible when logged-in### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page s...### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page should redirect to home or something.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/975/api/v1/token-auth does not return json on login failure2020-02-20T08:45:46+01:00Jelle Besselingjelle@pingiun.com/api/v1/token-auth does not return json on login failure### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expect...### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expected behaviour
Json object should be returnedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/971Missing translations in information check email2020-02-19T21:13:59+01:00Jelle Besselingjelle@pingiun.comMissing translations in information check email### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check ma...### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check mail contains correct translations
<!-- Please write how what happened did not meet your expectations -->Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/963Remove cancelled registrations from personal ICAL feed.2019-11-20T21:39:39+01:00Joren VranckenRemove cancelled registrations from personal ICAL feed.### One-sentence description
Cancelled registrations are included in the personal ICAL feed.
### Expected behaviour
Cancelled registrations are not included in the personal ICAL feed.### One-sentence description
Cancelled registrations are included in the personal ICAL feed.
### Expected behaviour
Cancelled registrations are not included in the personal ICAL feed.Simcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/912get_thumbnail_url crashes when image is missing2019-10-05T13:06:41+02:00Thalia Technicieget_thumbnail_url crashes when image is missingSentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additi...Sentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additional frame(s) were not displayed)
...
File "django/template/library.py", line 214, in render
_dict = self.func(*resolved_args, **resolved_kwargs)
File "activemembers/templatetags/activemembers_cards.py", line 47, in membergroup_member_card
ribbon=ribbon
File "members/templatetags/member_card.py", line 22, in member_card
settings.THUMBNAIL_SIZES['medium'])
File "utils/media/services.py", line 90, in get_thumbnail_url
os.path.getmtime(full_original_path)
File "genericpath.py", line 55, in getmtime
return os.stat(filename).st_mtime
```27Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/902Add membership type and reference count to renewal/registration admin overviews2019-08-28T19:57:42+02:00Sébastiaan VersteegAdd membership type and reference count to renewal/registration admin overviews<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
...<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
Columns in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/884Mailing list for societies contact persons2019-06-26T20:16:31+02:00Luko van der MaasMailing list for societies contact persons### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing...### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing list. (Request from @tvalten)
### Desired functionality
Create a new automatic mailinglist for all heads of the societies. These people are the contact persons.
### Suggested implementation
Look at how the commitee chair mailinglist is done.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/883Changing GM minutes is confusing2019-06-26T20:13:17+02:00Ayala HoeksChanging GM minutes is confusing### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error th...### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error that Minutes are a required field.
### Expected behaviour
I expect to be able to make changes to the information without having to upload minutes.
### Suggested solution
Set the `extra` field of the InlineModelAdmin to 0. https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.InlineModelAdmin.extra
This way the default minutes form will be hidden and a user will be required to add it manually.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/823Date formatting in agenda listview2019-02-13T19:51:08+01:00Leon van den BoogaardDate formatting in agenda listview<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dat...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dates are rendered in the formatting YYYY/MM/DD. Could you change the Dutch version of the output follow the Dutch standard (DD/MM/YYYY).
### Why?
Because it is logical.
### Current implementation
YYYY/MM/DD
### Suggested implementation
DD/MM/YYY22Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/755Split societies from 'Achievements for Thalia' to different header on profile2018-11-14T20:35:09+01:00Sébastiaan VersteegSplit societies from 'Achievements for Thalia' to different header on profile### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https:...### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https://thalia.nu/members/profile/2.
### Expected behaviour
Societies are in a different section, at least not displayed in the previously mentioned section.Thijs de JongThijs de Jong