concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-10-05T13:06:41+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/912get_thumbnail_url crashes when image is missing2019-10-05T13:06:41+02:00Thalia Technicieget_thumbnail_url crashes when image is missingSentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additi...Sentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additional frame(s) were not displayed)
...
File "django/template/library.py", line 214, in render
_dict = self.func(*resolved_args, **resolved_kwargs)
File "activemembers/templatetags/activemembers_cards.py", line 47, in membergroup_member_card
ribbon=ribbon
File "members/templatetags/member_card.py", line 22, in member_card
settings.THUMBNAIL_SIZES['medium'])
File "utils/media/services.py", line 90, in get_thumbnail_url
os.path.getmtime(full_original_path)
File "genericpath.py", line 55, in getmtime
return os.stat(filename).st_mtime
```27Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/884Mailing list for societies contact persons2019-06-26T20:16:31+02:00Luko van der MaasMailing list for societies contact persons### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing...### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing list. (Request from @tvalten)
### Desired functionality
Create a new automatic mailinglist for all heads of the societies. These people are the contact persons.
### Suggested implementation
Look at how the commitee chair mailinglist is done.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/883Changing GM minutes is confusing2019-06-26T20:13:17+02:00Ayala HoeksChanging GM minutes is confusing### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error th...### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error that Minutes are a required field.
### Expected behaviour
I expect to be able to make changes to the information without having to upload minutes.
### Suggested solution
Set the `extra` field of the InlineModelAdmin to 0. https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.InlineModelAdmin.extra
This way the default minutes form will be hidden and a user will be required to add it manually.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/870CSV export does not contain payment values2019-05-15T19:33:27+02:00Job DoesburgCSV export does not contain payment values### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible...### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible in the admin24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/859Event terms has point 6 double2019-04-17T20:30:27+02:00Sébastiaan VersteegEvent terms has point 6 double### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/823Date formatting in agenda listview2019-02-13T19:51:08+01:00Leon van den BoogaardDate formatting in agenda listview<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dat...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dates are rendered in the formatting YYYY/MM/DD. Could you change the Dutch version of the output follow the Dutch standard (DD/MM/YYYY).
### Why?
Because it is logical.
### Current implementation
YYYY/MM/DD
### Suggested implementation
DD/MM/YYY22Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/628Event presence (from admin pages) visible for normal users2018-05-23T19:22:39+02:00Ivar DerksenEvent presence (from admin pages) visible for normal users### One-sentence description
The value of the presence checkbox from the admin event pages should be visible on the event page of the regular website (and maybe the app)
### Desired behaviour
For the orientation barbecue we have to be ...### One-sentence description
The value of the presence checkbox from the admin event pages should be visible on the event page of the regular website (and maybe the app)
### Desired behaviour
For the orientation barbecue we have to be able to take account of all people that are present at the barbecue. This in order to be able to fine people when they registered and did not show up. This was an issue last year. With the high number of people at the barbecue it is very likely that we will not be able to check presence for anyone.
Therefore, inspired by the pizza system from borrels, it would be nice if people can see whether we checked their presence. Then people can come to us and complain if we missed them immediately. Then we can simply say to members, if you are at the barbecue, make sure the light on the website turns green. Otherwise you will get the fine for not being present. (Of course this does not hold for the new first year students)
I think it is just making a field from the database visible on the website, so I think this should not be very complicated.1.16https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1025ValueError: day is out of range for month2020-03-04T20:22:40+01:00Thalia TechnicieValueError: day is out of range for monthSentry Issue: [CONCREXIT-24](https://sentry.io/organizations/thalia/issues/1538288408/?referrer=gitlab_integration)
```
ValueError: day is out of range for month
(11 additional frame(s) were not displayed)
...
File "rest_framework/ser...Sentry Issue: [CONCREXIT-24](https://sentry.io/organizations/thalia/issues/1538288408/?referrer=gitlab_integration)
```
ValueError: day is out of range for month
(11 additional frame(s) were not displayed)
...
File "rest_framework/serializers.py", line 260, in data
self._data = self.to_representation(self.instance)
File "rest_framework/serializers.py", line 529, in to_representation
ret[field.field_name] = field.to_representation(attribute)
File "rest_framework/fields.py", line 1905, in to_representation
return method(value)
File "members/api/serializers.py", line 93, in _achievements
return member_achievements(instance.user)
File "members/services.py", line 72, in member_achievements
earliest = earliest.replace(year=earliest.year + mentor_year.year)
```Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1020Do not use hardcoded colors for calendar API2020-03-04T17:06:42+01:00Job DoesburgDo not use hardcoded colors for calendar API<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Do not use hardcoded colors for calendar API in `website/members/api/serializers.py` r42-49 and `website/events/api/serializers.py`
### Why?
We shouldn't hardcode these things at the API level but provide them using CSS.
### Current implementation
The API provides a `backgroundColor` and `textColor` in the event sources APIs that is used by FullCalendar via https://fullcalendar.io/docs/events-json-feed. Every item in the feed is an event source object: https://fullcalendar.io/docs/event-source-object.
### Suggested implementation
Provide a `className` attribute instead and determine the background color and text color based on the class using CSS.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1017Remove redundant html templates from `/thaliawebsite/templates/singlepages/`2020-03-13T16:29:15+01:00Job DoesburgRemove redundant html templates from `/thaliawebsite/templates/singlepages/`<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove redundant html templates from `/thaliawebsite/templates/singlepages/`
### Why?
They are redundant, since they are also in `/singlepages/templates` and these are the ones that are used.
### Current implementation
It appears as if the translations are still in `/thaliawebsite` though, so it would probably be nice to move these.
### Suggested implementationMarthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1008Show deregistration disclaimer text even if not registered for event2020-02-23T16:53:09+01:00Job DoesburgShow deregistration disclaimer text even if not registered for event### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how ...### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
Currently, the website does not show the deregistration disclaimer if you are not registered. This is undesirable, as it allows users to register for the event, without realising that they cannot deregister without paying a fine.
### Expected behaviour
Always state the disclaimer (just like in the app).
![IMG_753FFE892ACD-1](/uploads/fa6db1596eb92b1e2d5bbaa7a07ae4dd/IMG_753FFE892ACD-1.jpeg)Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1004'All members' in members directory not marked as active2020-02-05T21:18:38+01:00Sébastiaan Versteeg'All members' in members directory not marked as active### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected ...### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected behaviour
1. Go to https://thalia.nu/members/directory/
2. The item is selectedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/998Add information to exam / summary submission2020-03-11T20:14:27+01:00Ward TheunisseAdd information to exam / summary submission<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of ex...<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of exams immediately because there's a review first. This way it is not clear whether the submission was actually performed correctly + people don't know that an submission is manually checked before being published.
### Desired functionality
Inform people whether their submission was succesful and why it isn't immediately visible.
### Suggested implementation
Show a message thanking someone for their submission, also informing them that it will be published after a review.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/985Add link to the G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenAdd link to the G Suite Knowledge Base<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Add link to the [G Suite Knowledge Base](https://gsuite.members.thalia.nu/) in the "for members" menu.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/983Update members translations2020-01-29T21:21:15+01:00Joren VranckenUpdate members translations### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.