concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-10-24T19:17:38+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/941event registration terms and conditions link broken2019-10-24T19:17:38+02:00Nick van Oersevent registration terms and conditions link broken### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/912get_thumbnail_url crashes when image is missing2019-10-05T13:06:41+02:00Thalia Technicieget_thumbnail_url crashes when image is missingSentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additi...Sentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additional frame(s) were not displayed)
...
File "django/template/library.py", line 214, in render
_dict = self.func(*resolved_args, **resolved_kwargs)
File "activemembers/templatetags/activemembers_cards.py", line 47, in membergroup_member_card
ribbon=ribbon
File "members/templatetags/member_card.py", line 22, in member_card
settings.THUMBNAIL_SIZES['medium'])
File "utils/media/services.py", line 90, in get_thumbnail_url
os.path.getmtime(full_original_path)
File "genericpath.py", line 55, in getmtime
return os.stat(filename).st_mtime
```27Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/842Mailing lists api fails without boards2019-10-03T17:23:45+02:00Joren VranckenMailing lists api fails without boards### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/Wouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/850Dataminimisation deletes website profile2019-10-03T16:37:53+02:00Luko van der MaasDataminimisation deletes website profile
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removed
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removedLuna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/914Update placeholder in activemembers2019-10-03T16:37:03+02:00Sébastiaan VersteegUpdate placeholder in activemembers### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we ...### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/778Birthday congratulations push-notification2019-10-02T20:47:38+02:00Job DoesburgBirthday congratulations push-notification<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minu...<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minute ago and it would be fun.
### Desired functionality
Thalia has members. Those members are persons. Persons have a date of birth. Thalia knows this date of birth. Often this day is considered a special day that is celebrated. Thalia loves their members. So let’s congratulate our members at their birthday!
### Suggested implementation
Schedule push notifications for members based on their birthday. When to schedule it exactly is up to you, I think you know best (do it after every reboot for the upcoming week, or just every birthday for the next year, I don’t know what’s optimal).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/911Add descriptions to mailing lists2019-09-25T21:23:43+02:00Sébastiaan VersteegAdd descriptions to mailing lists### One-sentence description
Descriptions for mailing lists
### Motivation
Because we forget what mailing lists are for and this would help with the administration
### Desired functionality
Description field. REQUIRED (because other...### One-sentence description
Descriptions for mailing lists
### Motivation
Because we forget what mailing lists are for and this would help with the administration
### Desired functionality
Description field. REQUIRED (because otherwise people leave it empty)
### Suggested implementation
A TextArea!Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/106Add semi-annual reports to the documents page2019-09-19T16:31:17+02:00Sébastiaan VersteegAdd semi-annual reports to the documents page### One-sentence description
Add semi-annual reports to the documents page
### Desired behaviour
Have it show for each year. The document is currently buried in the GM's.
Easy to do since it can be an annual document category. The doc...### One-sentence description
Add semi-annual reports to the documents page
### Desired behaviour
Have it show for each year. The document is currently buried in the GM's.
Easy to do since it can be an annual document category. The documents page has also been restyled, adding it as another card shouldn't be a problem.
### Suggested implementation
- Add a model for Semi-annual reports
- Add a document card to the documents tab for each year for those reports
- Change the accordion size to `col-md-4` so that this card can fithttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/851Set restraints on start year at user creation2019-09-18T21:29:48+02:00Bart HofmanSet restraints on start year at user creation### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behav...### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behaviour
Make a dropdown and be able to only select actually existing cohortsBart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/924Add the real name of members to profiles2019-09-17T12:10:21+02:00Ward TheunisseAdd the real name of members to profiles/label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add.../label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add the real name of members to profiles.
### Suggested implementation
Some text.
27https://gitlab.science.ru.nl/thalia/concrexit/-/issues/902Add membership type and reference count to renewal/registration admin overviews2019-08-28T19:57:42+02:00Sébastiaan VersteegAdd membership type and reference count to renewal/registration admin overviews<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
...<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
Columns in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/884Mailing list for societies contact persons2019-06-26T20:16:31+02:00Luko van der MaasMailing list for societies contact persons### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing...### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing list. (Request from @tvalten)
### Desired functionality
Create a new automatic mailinglist for all heads of the societies. These people are the contact persons.
### Suggested implementation
Look at how the commitee chair mailinglist is done.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/883Changing GM minutes is confusing2019-06-26T20:13:17+02:00Ayala HoeksChanging GM minutes is confusing### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error th...### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error that Minutes are a required field.
### Expected behaviour
I expect to be able to make changes to the information without having to upload minutes.
### Suggested solution
Set the `extra` field of the InlineModelAdmin to 0. https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.InlineModelAdmin.extra
This way the default minutes form will be hidden and a user will be required to add it manually.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/170Einddatums op vacatures2019-05-28T10:52:08+02:00Thom WiggersEinddatums op vacaturesMet een mailtje aan sponsor? @esijben
- [x] Cronjob instellenMet een mailtje aan sponsor? @esijben
- [x] Cronjob instellenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/870CSV export does not contain payment values2019-05-15T19:33:27+02:00Job DoesburgCSV export does not contain payment values### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible...### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible in the admin24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/859Event terms has point 6 double2019-04-17T20:30:27+02:00Sébastiaan VersteegEvent terms has point 6 double### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once24