concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-06-27T13:47:35+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/884Mailing list for societies contact persons2019-06-26T20:16:31+02:00Luko van der MaasMailing list for societies contact persons### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing...### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing list. (Request from @tvalten)
### Desired functionality
Create a new automatic mailinglist for all heads of the societies. These people are the contact persons.
### Suggested implementation
Look at how the commitee chair mailinglist is done.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/883Changing GM minutes is confusing2019-06-26T20:13:17+02:00Ayala HoeksChanging GM minutes is confusing### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error th...### One-sentence description
It looks like minutes is a required field if you set the 'Members only' checkbox to true.
### Current behaviour / Reproducing the bug
When I want to make a General Meeting 'members only' I get the error that Minutes are a required field.
### Expected behaviour
I expect to be able to make changes to the information without having to upload minutes.
### Suggested solution
Set the `extra` field of the InlineModelAdmin to 0. https://docs.djangoproject.com/en/2.2/ref/contrib/admin/#django.contrib.admin.InlineModelAdmin.extra
This way the default minutes form will be hidden and a user will be required to add it manually.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/870CSV export does not contain payment values2019-05-15T19:33:27+02:00Job DoesburgCSV export does not contain payment values### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible...### One-sentence description
The .csv export of event registrations does not contain payment values
### Current behaviour / Reproducing the bug
Every row is exported as unpaid
### Expected behaviour
Contain the payment value visible in the admin24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/859Event terms has point 6 double2019-04-17T20:30:27+02:00Sébastiaan VersteegEvent terms has point 6 double### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/851Set restraints on start year at user creation2019-09-18T21:29:48+02:00Bart HofmanSet restraints on start year at user creation### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behav...### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behaviour
Make a dropdown and be able to only select actually existing cohortsBart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/850Dataminimisation deletes website profile2019-10-03T16:37:53+02:00Luko van der MaasDataminimisation deletes website profile
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removed
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removedLuna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/849Banner Dimensions Not in Styleguide2019-04-10T20:32:05+02:00Thijs de JongBanner Dimensions Not in Styleguide### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/846Name of programme at registration page is "Informatica" instead of "Computing...2019-04-03T20:10:10+02:00Job DoesburgName of programme at registration page is "Informatica" instead of "Computing Science"### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this conf...### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this confusing since in their opinion they study "Computing Science"
### Current behaviour / Reproducing the bug
Go to the registration page, check out the dropdown menu
### Expected behaviour
Display something like "Informatica (Computing Science)"
P.S: a 'won't fix' would be a pretty good solution here in my opinion but I thought it could be nice to mentionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/842Mailing lists api fails without boards2019-10-03T17:23:45+02:00Joren VranckenMailing lists api fails without boards### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/Wouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/835Use correct language attribute in html tag2019-03-27T19:18:56+01:00Jelle Besselingjelle@pingiun.comUse correct language attribute in html tag<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The `lang` attribute of the root html element is hardcoded to "en", this can be set to the LANGUAGE_CODE
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
The [specification recommends it](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Specifications).
<!-- Please motivate why we should invest into this change -->
### Current implementation
The value is hardcoded to `"en"`
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Set the lang attribute to the current language code
<!-- Provide (a) suggestion(s) for how we could approach this -->Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/834Photo albums not greyed out when outside membership period2019-03-27T19:18:01+01:00Sébastiaan VersteegPhoto albums not greyed out when outside membership period### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos pa...### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos package.
3. All albums are in colours
### Expected behaviour
The albums that the user cannot access should be grayscale.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/828Committee/Society Names on Profile Page Should be Clickable2019-02-13T21:24:43+01:00Thijs de JongCommittee/Society Names on Profile Page Should be Clickable### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievem...### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievements for Thalia. At this moment, if you click on the committees/societies, nothing happens.
### Expected behaviour
When you click on a committee/society underneath the Achievements for Thalia, it sends you to the Page of the corresponding committee/society.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/823Date formatting in agenda listview2019-02-13T19:51:08+01:00Leon van den BoogaardDate formatting in agenda listview<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dat...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dates are rendered in the formatting YYYY/MM/DD. Could you change the Dutch version of the output follow the Dutch standard (DD/MM/YYYY).
### Why?
Because it is logical.
### Current implementation
YYYY/MM/DD
### Suggested implementation
DD/MM/YYY22Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/784No Registration Needed Text is in English2018-11-28T21:02:16+01:00Thijs de JongNo Registration Needed Text is in English### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there ...### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there is no registration (NL), it says the default message in English, where it should be Dutch.
<!-- Please write what is happening and how we could reproduce it, if relevant -->
### Expected behaviour
The given text should be in Dutch.
<!-- Please write how what happened did not meet your expectations -->Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/778Birthday congratulations push-notification2019-10-02T20:47:38+02:00Job DoesburgBirthday congratulations push-notification<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minu...<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minute ago and it would be fun.
### Desired functionality
Thalia has members. Those members are persons. Persons have a date of birth. Thalia knows this date of birth. Often this day is considered a special day that is celebrated. Thalia loves their members. So let’s congratulate our members at their birthday!
### Suggested implementation
Schedule push notifications for members based on their birthday. When to schedule it exactly is up to you, I think you know best (do it after every reboot for the upcoming week, or just every birthday for the next year, I don’t know what’s optimal).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/763Sister Association page also contains brother associations2018-11-14T22:00:14+01:00Joren VranckenSister Association page also contains brother associations### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -...### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Go to [Sister Association page](https://thalia.nu/sister-associations)
2. Observe the brother associations (and one foundation).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
The page is called something like "Brother and Sister Associations" or "Links" (with links to all affiliated organisations like sister associations, the USR and Ninja).Thijs de JongThijs de Jong