concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2017-12-10T21:10:48+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/460Documents: 2011-2012 is not directly reachable2017-12-10T21:10:48+01:00Gerdriaan MulderDocuments: 2011-2012 is not directly reachable### One-sentence description
The documents page should switch to the year 2011-2012 when it is selected from the drop-down box.
### Current behaviour
The documents page does not switch to the year 2011-2012 when it is selected from the ...### One-sentence description
The documents page should switch to the year 2011-2012 when it is selected from the drop-down box.
### Current behaviour
The documents page does not switch to the year 2011-2012 when it is selected from the drop-down box.
### Expected behaviour
The documents page switches to the year 2011-2012 when it is selected from the drop-down box.
### Steps to reproduce
1. Log in
2. Go to the `/documents/` page (e.g. Association -> Documents).
3. Navigate to "General meetings"
4. Click on `2011-2012` (a dropdown box appears)
5. Click on `2011-2012` in the dropdown box
6. Nothing happens.
Alternatively, replace step 5 by clicking on another item (e.g. `2010-2011`) and then execute the original step 4 and 5 again. In that case, step 6 is replaced by the expected behaviour.
Note: the period (i.e. `2011-2012`) is relative to the current period. When we switch to the next year, this period will be `2012-2013`.Joost Rijneveldjoost@joostrijneveld.nlJoost Rijneveldjoost@joostrijneveld.nlhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1020Do not use hardcoded colors for calendar API2020-03-04T17:06:42+01:00Job DoesburgDo not use hardcoded colors for calendar API<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Do not use hardcoded colors for calendar API in `website/members/api/serializers.py` r42-49 and `website/events/api/serializers.py`
### Why?
We shouldn't hardcode these things at the API level but provide them using CSS.
### Current implementation
The API provides a `backgroundColor` and `textColor` in the event sources APIs that is used by FullCalendar via https://fullcalendar.io/docs/events-json-feed. Every item in the feed is an event source object: https://fullcalendar.io/docs/event-source-object.
### Suggested implementation
Provide a `className` attribute instead and determine the background color and text color based on the class using CSS.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/686Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Sébastiaan VersteegDutch translation in membership notification email incorrect### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sen...### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sendmembershipnotification`.Thijs de JongThijs de Jong2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/170Einddatums op vacatures2019-05-28T10:52:08+02:00Thom WiggersEinddatums op vacaturesMet een mailtje aan sponsor? @esijben
- [x] Cronjob instellenMet een mailtje aan sponsor? @esijben
- [x] Cronjob instellenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/345Ergens een duidelijke verwijzing naar de issuetracker plaatsen2017-05-24T22:07:45+02:00Luuk ScholtenErgens een duidelijke verwijzing naar de issuetracker plaatsenAldus NiekAldus Niekhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/919Event information is public2020-01-23T11:31:49+01:00Thomas Klein BretelerEvent information is publicEvent information is public
### Current behaviour / Reproducing the bug
Everyone on the internet can see the location and number of registration of events. Partners etc can follow the status and that might be undesirable.
You can chec...Event information is public
### Current behaviour / Reproducing the bug
Everyone on the internet can see the location and number of registration of events. Partners etc can follow the status and that might be undesirable.
You can check this by opening an event in incognito mode.
### Expected behaviour
Information should be only visible for members.Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/628Event presence (from admin pages) visible for normal users2018-05-23T19:22:39+02:00Ivar DerksenEvent presence (from admin pages) visible for normal users### One-sentence description
The value of the presence checkbox from the admin event pages should be visible on the event page of the regular website (and maybe the app)
### Desired behaviour
For the orientation barbecue we have to be ...### One-sentence description
The value of the presence checkbox from the admin event pages should be visible on the event page of the regular website (and maybe the app)
### Desired behaviour
For the orientation barbecue we have to be able to take account of all people that are present at the barbecue. This in order to be able to fine people when they registered and did not show up. This was an issue last year. With the high number of people at the barbecue it is very likely that we will not be able to check presence for anyone.
Therefore, inspired by the pizza system from borrels, it would be nice if people can see whether we checked their presence. Then people can come to us and complain if we missed them immediately. Then we can simply say to members, if you are at the barbecue, make sure the light on the website turns green. Otherwise you will get the fine for not being present. (Of course this does not hold for the new first year students)
I think it is just making a field from the database visible on the website, so I think this should not be very complicated.1.16https://gitlab.science.ru.nl/thalia/concrexit/-/issues/941event registration terms and conditions link broken2019-10-24T19:17:38+02:00Nick van Oersevent registration terms and conditions link broken### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/859Event terms has point 6 double2019-04-17T20:30:27+02:00Sébastiaan VersteegEvent terms has point 6 double### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once### One-sentence description
Event terms has point 6 double
### Current behaviour / Reproducing the bug
The text is shown twice
### Expected behaviour
Just once24https://gitlab.science.ru.nl/thalia/concrexit/-/issues/514Explain / warn about committeememberships in admin2018-01-08T13:24:45+01:00Joost Rijneveldjoost@joostrijneveld.nlExplain / warn about committeememberships in adminSince #84 has been closed, it may be useful to add some text to the CommitteeMembership pages (perhaps above the `add` and `edit` forms) that explains how these work. In particular, the board should be instructed not to _edit existing ob...Since #84 has been closed, it may be useful to add some text to the CommitteeMembership pages (perhaps above the `add` and `edit` forms) that explains how these work. In particular, the board should be instructed not to _edit existing objects_ when chairs change, but _create new objects_. #84 was created because people were tempted to edit history, while they shouldn't.
Similar to #4761.12Bram in 't ZandtBram in 't Zandthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/258exporteren events2018-11-25T01:45:59+01:00Kirsten Kingmaexporteren eventsde events worden nu via een standaard excel ge-exporteerd die niet overeenkomt met de info die ik nodig heb in mij afwezigheidsboekhouding. Kan de kolom present achter email? en ook alleen de te late afmeldingen ipv alle afmeldingen? And...de events worden nu via een standaard excel ge-exporteerd die niet overeenkomt met de info die ik nodig heb in mij afwezigheidsboekhouding. Kan de kolom present achter email? en ook alleen de te late afmeldingen ipv alle afmeldingen? Anders is het erg verwarrend en kan ik de verkeerde mensen factureren.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/301Foto's die stuk zijn fixen2017-12-10T21:11:33+01:00Thom WiggersFoto's die stuk zijn fixen* [ ] `2015-07-03-eos-feest/album_20150703_EOS_feestIMG_1513.JPG`
* [ ] `2015-07-03-eos-feest/album_20150703_EOS_feestIMG_1505.JPG`
* [ ] `2015-07-03-eos-feest/album_20150703_EOS_feestIMG_1642.JPG`* [ ] `2015-07-03-eos-feest/album_20150703_EOS_feestIMG_1513.JPG`
* [ ] `2015-07-03-eos-feest/album_20150703_EOS_feestIMG_1505.JPG`
* [ ] `2015-07-03-eos-feest/album_20150703_EOS_feestIMG_1642.JPG`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/365Functie in bestuur in profielpagina2017-04-21T19:46:32+02:00Joren VranckenFunctie in bestuur in profielpaginaOp dit moment staat er bij (oud-)bestuursleden alleen in welk jaar ze bestuur zijn (geweest). Ik zie hier graag ook hun functie in dat bestuur bij.Op dit moment staat er bij (oud-)bestuursleden alleen in welk jaar ze bestuur zijn (geweest). Ik zie hier graag ook hun functie in dat bestuur bij.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/362Gebruikers filteren toegang evenementen / borrels2018-11-25T01:45:46+01:00Kirsten KingmaGebruikers filteren toegang evenementen / borrelsBeste Technicie,
Kunnen jullie bij het filteren van de gebruikers ook een optie maken voor de filter dat gebruikers niet meer naar evenementen en/of borrels mogen?
Dat is erg handig voor mijn overzicht want dan weet ik precies wie waar ...Beste Technicie,
Kunnen jullie bij het filteren van de gebruikers ook een optie maken voor de filter dat gebruikers niet meer naar evenementen en/of borrels mogen?
Dat is erg handig voor mijn overzicht want dan weet ik precies wie waar naar toe mag.
Alvast bedankt!https://gitlab.science.ru.nl/thalia/concrexit/-/issues/912get_thumbnail_url crashes when image is missing2019-10-05T13:06:41+02:00Thalia Technicieget_thumbnail_url crashes when image is missingSentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additi...Sentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additional frame(s) were not displayed)
...
File "django/template/library.py", line 214, in render
_dict = self.func(*resolved_args, **resolved_kwargs)
File "activemembers/templatetags/activemembers_cards.py", line 47, in membergroup_member_card
ribbon=ribbon
File "members/templatetags/member_card.py", line 22, in member_card
settings.THUMBNAIL_SIZES['medium'])
File "utils/media/services.py", line 90, in get_thumbnail_url
os.path.getmtime(full_original_path)
File "genericpath.py", line 55, in getmtime
return os.stat(filename).st_mtime
```27Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/508Header fields in event export are not being translated2017-12-10T21:12:06+01:00Bram in 't ZandtHeader fields in event export are not being translated### One-sentence description
If you export an event the headers of the export are not translated whereas some of the fields in the export are.
### Why?
Some fields are now in English while others are in Dutch. This looks messy.
### Cur...### One-sentence description
If you export an event the headers of the export are not translated whereas some of the fields in the export are.
### Why?
Some fields are now in English while others are in Dutch. This looks messy.
### Current implementation
Header fields in the export are not translated.
### Desired implementation
Header fields are also translated depending on the chosen language.Bram in 't ZandtBram in 't Zandthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/41Hide 'for members' submenu for non-members2017-12-10T21:25:35+01:00Joost Rijneveldjoost@joostrijneveld.nlHide 'for members' submenu for non-membersIf you're not logged in, this menu can be omitted.If you're not logged in, this menu can be omitted.LaunchWietse KuipersWietse Kuipershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/108Huisstijlbijbel naar website halen2016-11-02T22:34:57+01:00Lennart JansenHuisstijlbijbel naar website halenEvi, Kirsten, Lennart en Sébastiaan kwamen tot de conclusie dat [de huisstijlbijbel](https://thalia.nu/wiki/doku.php?id=huisstijlcommissie:huisstijlbijbel) te ver staat weggestopt terwijl ie gewoon voor iedereen toegankelijk moet zijn.Evi, Kirsten, Lennart en Sébastiaan kwamen tot de conclusie dat [de huisstijlbijbel](https://thalia.nu/wiki/doku.php?id=huisstijlcommissie:huisstijlbijbel) te ver staat weggestopt terwijl ie gewoon voor iedereen toegankelijk moet zijn.Sébastiaan VersteegSébastiaan Versteeg