concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-04-10T22:11:45+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/849Banner Dimensions Not in Styleguide2019-04-10T20:32:05+02:00Thijs de JongBanner Dimensions Not in Styleguide### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/846Name of programme at registration page is "Informatica" instead of "Computing...2019-04-03T20:10:10+02:00Job DoesburgName of programme at registration page is "Informatica" instead of "Computing Science"### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this conf...### One-sentence description
While registering as a member, the type of programme gives the option "Informatica" and "Informatiekunde", while the official name of the Bachelor is currently "Computing Science". Some sjaars find this confusing since in their opinion they study "Computing Science"
### Current behaviour / Reproducing the bug
Go to the registration page, check out the dropdown menu
### Expected behaviour
Display something like "Informatica (Computing Science)"
P.S: a 'won't fix' would be a pretty good solution here in my opinion but I thought it could be nice to mentionhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/321Write newsletter HTML to database on sending2019-03-27T20:38:47+01:00Joost Rijneveldjoost@joostrijneveld.nlWrite newsletter HTML to database on sending### One-sentence description
Write newsletter HTML to database or static document after sending
### Why?
To make sure it stays the same over time.
### Current implementation
It's generated when the web preview is opened
### Desired...### One-sentence description
Write newsletter HTML to database or static document after sending
### Why?
To make sure it stays the same over time.
### Current implementation
It's generated when the web preview is opened
### Desired implementation
Save the email to the database and serve that HTML
---
De sortering is anders (dat is misschien opgelost met #179), maar bovendien bevat de online versie een extra stukje tekst onderaan; (_"Is this email not in your preferred language? [..] in the language you selected."_)
Ik stel voor die tekst een paar letterpuntjes kleiner te maken (en misschien iets minder langdradig te maken door de laatste zin weg te laten), en dan ook in de nieuwsbrief mee te sturen.
Verder lijkt er inconsistentie te zitten tussen de boete-bedragen; in de mail van week 6 die ik ontving wordt expliciet een boete van 5 euro genoemd bij het symposium, maar dat is in de online-versie niet terug te vinden.
**Essentie van het verhaal:** ik weet niet goed hoe die online preview tot stand komt, maar het lijkt me belangrijk om 'm te "bevriezen" zodra de nieuwsbrief daadwerkelijk verstuurd is, door gewoon ergens wat statische HTML weg te schrijven. Dan voorkom je dit soort gedoe fundamenteel, ipv door de individuele dingen te moeten tackelen.Michiel KraanMichiel Kraanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/835Use correct language attribute in html tag2019-03-27T19:18:56+01:00Jelle Besselingjelle@pingiun.comUse correct language attribute in html tag<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The `lang` attribute of the root html element is hardcoded to "en", this can be set to the LANGUAGE_CODE
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
The [specification recommends it](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Specifications).
<!-- Please motivate why we should invest into this change -->
### Current implementation
The value is hardcoded to `"en"`
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Set the lang attribute to the current language code
<!-- Provide (a) suggestion(s) for how we could approach this -->Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/834Photo albums not greyed out when outside membership period2019-03-27T19:18:01+01:00Sébastiaan VersteegPhoto albums not greyed out when outside membership period### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos pa...### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos package.
3. All albums are in colours
### Expected behaviour
The albums that the user cannot access should be grayscale.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/478Add BooleanField that toggles public display of MemberGroup members2019-02-20T20:20:09+01:00Sébastiaan VersteegAdd BooleanField that toggles public display of MemberGroup members### One-sentence description
Add BooleanField that toggles public display of MemberGroup members
### Why?
Because some nicknames are weird. And we've got sponsors and other externals to care about.
Plus: external people don't need to k...### One-sentence description
Add BooleanField that toggles public display of MemberGroup members
### Why?
Because some nicknames are weird. And we've got sponsors and other externals to care about.
Plus: external people don't need to know names and they can't even see profiles.
### Current implementation
Show members on board/committee/society pages
### Desired implementation
Do not show members on board/committee/society pages when you're not authenticated and the added field is checked/non-checked. Better to explicitly check the field for public display probably.Tobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/366Statistieken kopjes aantal leden2019-02-19T19:41:00+01:00Joren VranckenStatistieken kopjes aantal ledenOp de statistieken pagina staan het aantal leden exclusief begunstigers als "Leden per jaar" en inclusief begunstigers als "Aantal leden per jaar". Dit is niet heel duidelijk.Op de statistieken pagina staan het aantal leden exclusief begunstigers als "Leden per jaar" en inclusief begunstigers als "Aantal leden per jaar". Dit is niet heel duidelijk.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/828Committee/Society Names on Profile Page Should be Clickable2019-02-13T21:24:43+01:00Thijs de JongCommittee/Society Names on Profile Page Should be Clickable### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievem...### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievements for Thalia. At this moment, if you click on the committees/societies, nothing happens.
### Expected behaviour
When you click on a committee/society underneath the Achievements for Thalia, it sends you to the Page of the corresponding committee/society.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/823Date formatting in agenda listview2019-02-13T19:51:08+01:00Leon van den BoogaardDate formatting in agenda listview<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dat...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The event dates are rendered in the formatting YYYY/MM/DD. Could you change the Dutch version of the output follow the Dutch standard (DD/MM/YYYY).
### Why?
Because it is logical.
### Current implementation
YYYY/MM/DD
### Suggested implementation
DD/MM/YYY22Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/818Remove SECRET_KEY from production.py2019-02-07T16:26:12+01:00Jelle Besselingjelle@pingiun.comRemove SECRET_KEY from production.py<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove defaul...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove default SECRET_KEY value from production.py settings
### Why?
The SECRET_KEY should always be set in production.py, so it is a better idea to crash when it isn't set, than to use a default nonsecure key.
### Current implementation
A default key is set in production.py. (https://gitlab.science.ru.nl/thalia/concrexit/blob/23b79eb4461ac082a94d7a0c4318c0a848743c67/website/thaliawebsite/settings/production.py#L29)
### Suggested implementation
```python
SECRET_KEY = os.environ.get('DJANGO_SECRET')
```
or, the following, which throws an IndexError when the key isn't present
```python
SECRET_KEY = os.environ.environ['DJANGO_SECRET']
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/688Make 'oudbesturen' an automatic mailinglist2018-12-12T22:33:06+01:00Sébastiaan VersteegMake 'oudbesturen' an automatic mailinglist### One-sentence description
### Desired behaviour
Since all `boardxxyy@thalia.nu` mailinglists are automatically generated (https://gitlab.science.ru.nl/thalia/concrexit/commit/00d99502b2eb58d70ca30dd800432112a67b5ea5) we also want `o...### One-sentence description
### Desired behaviour
Since all `boardxxyy@thalia.nu` mailinglists are automatically generated (https://gitlab.science.ru.nl/thalia/concrexit/commit/00d99502b2eb58d70ca30dd800432112a67b5ea5) we also want `oudbesturen`/`oldboard` to be automatically generated as well to prevent more work.Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/784No Registration Needed Text is in English2018-11-28T21:02:16+01:00Thijs de JongNo Registration Needed Text is in English### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there ...### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there is no registration (NL), it says the default message in English, where it should be Dutch.
<!-- Please write what is happening and how we could reproduce it, if relevant -->
### Expected behaviour
The given text should be in Dutch.
<!-- Please write how what happened did not meet your expectations -->Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/703Prevent manual creation of automatically generated mailinglists2018-11-28T17:49:15+01:00Sébastiaan VersteegPrevent manual creation of automatically generated mailinglists### One-sentence description
Prevent manual creation of automatically generated mailinglists
### Desired behaviour
We have a lot of automatically created mailinglists, but it is still possible to create mailinglists with the same name...### One-sentence description
Prevent manual creation of automatically generated mailinglists
### Desired behaviour
We have a lot of automatically created mailinglists, but it is still possible to create mailinglists with the same name in the backend. This should be prevented.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/171Opmerkingenveld vacatures2018-11-25T01:46:08+01:00Thom WiggersOpmerkingenveld vacaturesHandig voor de extern.Handig voor de extern.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/186thumbnails respecteren rotatie niet.2018-11-25T01:46:05+01:00Thom Wiggersthumbnails respecteren rotatie niet.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/191Admin login doet logout2018-11-25T01:46:05+01:00Sébastiaan VersteegAdmin login doet logouthttp://example.com/login/?next=/admin/logout/
Niet handig.
1. Login
2. Logout
3. Ga naar de login pagina
4. Login
5. Haha geen loginhttp://example.com/login/?next=/admin/logout/
Niet handig.
1. Login
2. Logout
3. Ga naar de login pagina
4. Login
5. Haha geen loginJoren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/202Taal-knop subtieler plaatsen (bij mobiele weergave)2018-11-25T01:46:03+01:00Lennart JansenTaal-knop subtieler plaatsen (bij mobiele weergave)"English" dan wel "Nederlands" verbergt op dit moment een deel van het Thalia-logo in de mobiele weergave.
Sowieso valt deze knop erg (in mijn opzicht: te veel) op. Misschien verplaatsen naar persoonlijke instellingen?"English" dan wel "Nederlands" verbergt op dit moment een deel van het Thalia-logo in de mobiele weergave.
Sowieso valt deze knop erg (in mijn opzicht: te veel) op. Misschien verplaatsen naar persoonlijke instellingen?Sébastiaan VersteegSébastiaan Versteeg