concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-02-13T21:24:43+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/828Committee/Society Names on Profile Page Should be Clickable2019-02-13T21:24:43+01:00Thijs de JongCommittee/Society Names on Profile Page Should be Clickable### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievem...### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievements for Thalia. At this moment, if you click on the committees/societies, nothing happens.
### Expected behaviour
When you click on a committee/society underneath the Achievements for Thalia, it sends you to the Page of the corresponding committee/society.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/818Remove SECRET_KEY from production.py2019-02-07T16:26:12+01:00Jelle Besselingjelle@pingiun.comRemove SECRET_KEY from production.py<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove defaul...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove default SECRET_KEY value from production.py settings
### Why?
The SECRET_KEY should always be set in production.py, so it is a better idea to crash when it isn't set, than to use a default nonsecure key.
### Current implementation
A default key is set in production.py. (https://gitlab.science.ru.nl/thalia/concrexit/blob/23b79eb4461ac082a94d7a0c4318c0a848743c67/website/thaliawebsite/settings/production.py#L29)
### Suggested implementation
```python
SECRET_KEY = os.environ.get('DJANGO_SECRET')
```
or, the following, which throws an IndexError when the key isn't present
```python
SECRET_KEY = os.environ.environ['DJANGO_SECRET']
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/784No Registration Needed Text is in English2018-11-28T21:02:16+01:00Thijs de JongNo Registration Needed Text is in English### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there ...### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there is no registration (NL), it says the default message in English, where it should be Dutch.
<!-- Please write what is happening and how we could reproduce it, if relevant -->
### Expected behaviour
The given text should be in Dutch.
<!-- Please write how what happened did not meet your expectations -->Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/778Birthday congratulations push-notification2019-10-02T20:47:38+02:00Job DoesburgBirthday congratulations push-notification<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minu...<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minute ago and it would be fun.
### Desired functionality
Thalia has members. Those members are persons. Persons have a date of birth. Thalia knows this date of birth. Often this day is considered a special day that is celebrated. Thalia loves their members. So let’s congratulate our members at their birthday!
### Suggested implementation
Schedule push notifications for members based on their birthday. When to schedule it exactly is up to you, I think you know best (do it after every reboot for the upcoming week, or just every birthday for the next year, I don’t know what’s optimal).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/765Remind people to fill in full descriptions in both languages in the event bac...2018-11-14T21:53:23+01:00Gijs HendriksenRemind people to fill in full descriptions in both languages in the event backend### One-sentence description
Add a reminder to the event description fields that people need to fill in the descriptions in both languages.
### Motivation
Some Dutch-only events have an English description "This event is in Dutch", wi...### One-sentence description
Add a reminder to the event description fields that people need to fill in the descriptions in both languages.
### Motivation
Some Dutch-only events have an English description "This event is in Dutch", without the actual Dutch description. This forces people to change their language to Dutch if they want to see the description.
See also ThaliApp#84.
### Desired functionality
A small notice at the description input fields, with something along the lines of "Don't forget to include a full description in both languages!".Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/763Sister Association page also contains brother associations2018-11-14T22:00:14+01:00Joren VranckenSister Association page also contains brother associations### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -...### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Go to [Sister Association page](https://thalia.nu/sister-associations)
2. Observe the brother associations (and one foundation).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
The page is called something like "Brother and Sister Associations" or "Links" (with links to all affiliated organisations like sister associations, the USR and Ninja).Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/755Split societies from 'Achievements for Thalia' to different header on profile2018-11-14T20:35:09+01:00Sébastiaan VersteegSplit societies from 'Achievements for Thalia' to different header on profile### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https:...### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https://thalia.nu/members/profile/2.
### Expected behaviour
Societies are in a different section, at least not displayed in the previously mentioned section.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/749Member list category benefactors2018-10-31T18:46:02+01:00Job DoesburgMember list category benefactors<!--
You want something new.
-->
### One-sentence description
Add benefactors as category to member list.
### Motivation
Currently it's inconsistent. There is a category 'honorary members' and even 'old members' but no 'benefacto...<!--
You want something new.
-->
### One-sentence description
Add benefactors as category to member list.
### Motivation
Currently it's inconsistent. There is a category 'honorary members' and even 'old members' but no 'benefactors' whereas it really is a separate group Thalians.
### Desired functionality
Also have a tab 'benefactors' at the members list page.
### Suggested implementation
I think this is quite clear.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/739Change dropdown menu in front-end for user registration/enrollment with amount2018-11-14T21:53:41+01:00Job DoesburgChange dropdown menu in front-end for user registration/enrollment with amount<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the price of membership type in the dropdown menu of front-end registration page.
### Why?
People are lazy. They don't read the whole text and only fill in the form. They select 'study membership' and when they want to pay, they see it is more expensive. That's annoying because you have to change data afterwards (which can't be done a.t.m. after approval).
### Current implementation
The dropdown menu only shows 'one year membership' and 'study membership'
### Suggested implementation
The dropdown menu shows 'one year membership (€ 7,50)' and 'study membership (€ 30,00)'Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/715Add note to phone number about reachability2018-10-22T18:52:34+02:00Job DoesburgAdd note to phone number about reachability### One-sentence description
We would like to add a note on the website contact page that we can be reached by phone or in person in the board room on weekdays between 12:15 and 13:30 (or more often if you are lucky). Maybe you can figur...### One-sentence description
We would like to add a note on the website contact page that we can be reached by phone or in person in the board room on weekdays between 12:15 and 13:30 (or more often if you are lucky). Maybe you can figure out a nice way of mentioning this, otherwise we'll think with you ;)
### Why?
So people know when to reach us
### Current implementation
There is no note on the contactpage of the site
### Desired implementation
There is a note on the contactpage of the sitehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/707Add descriptions to push notification categories2018-09-19T20:17:56+02:00Gijs HendriksenAdd descriptions to push notification categories### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these ...### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these names don't make it clear what kind of push notifications are sent through in this category. Thus, it would be useful to add an explanation of each of the categories.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/703Prevent manual creation of automatically generated mailinglists2018-11-28T17:49:15+01:00Sébastiaan VersteegPrevent manual creation of automatically generated mailinglists### One-sentence description
Prevent manual creation of automatically generated mailinglists
### Desired behaviour
We have a lot of automatically created mailinglists, but it is still possible to create mailinglists with the same name...### One-sentence description
Prevent manual creation of automatically generated mailinglists
### Desired behaviour
We have a lot of automatically created mailinglists, but it is still possible to create mailinglists with the same name in the backend. This should be prevented.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/692Remove voicemailbox from contact page2018-10-18T11:31:31+02:00Job DoesburgRemove voicemailbox from contact page### One-sentence description
Remove voicemailbox from contact page
### Desired behaviour
The voicemailbox phone number isn't really a thing anymore, so it can be removed from the website.### One-sentence description
Remove voicemailbox from contact page
### Desired behaviour
The voicemailbox phone number isn't really a thing anymore, so it can be removed from the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/688Make 'oudbesturen' an automatic mailinglist2018-12-12T22:33:06+01:00Sébastiaan VersteegMake 'oudbesturen' an automatic mailinglist### One-sentence description
### Desired behaviour
Since all `boardxxyy@thalia.nu` mailinglists are automatically generated (https://gitlab.science.ru.nl/thalia/concrexit/commit/00d99502b2eb58d70ca30dd800432112a67b5ea5) we also want `o...### One-sentence description
### Desired behaviour
Since all `boardxxyy@thalia.nu` mailinglists are automatically generated (https://gitlab.science.ru.nl/thalia/concrexit/commit/00d99502b2eb58d70ca30dd800432112a67b5ea5) we also want `oudbesturen`/`oldboard` to be automatically generated as well to prevent more work.Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/686Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Sébastiaan VersteegDutch translation in membership notification email incorrect### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sen...### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sendmembershipnotification`.Thijs de JongThijs de Jong2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/672Use pipenv instead of requirements.txt2018-08-15T15:06:16+02:00Thom WiggersUse pipenv instead of requirements.txt### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfil...### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfile.lock`.
https://github.com/pypa/pipenvThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/640Add filter to committee membership admin for active memberships2018-06-13T20:28:03+02:00Sébastiaan VersteegAdd filter to committee membership admin for active memberships### One-sentence description
Add filter to committee membership admin for active memberships
### Desired behaviour
Have the ability to filter between active, non-active and all committee memberships. (Active = no end date)### One-sentence description
Add filter to committee membership admin for active memberships
### Desired behaviour
Have the ability to filter between active, non-active and all committee memberships. (Active = no end date)Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/596Text wrapping events list view on small viewports is flawed2018-03-15T13:49:12+01:00Leon van den BoogaardText wrapping events list view on small viewports is flawed### One-sentence description
Text wrapping events list view on small viewports is flawed
### Current behaviour
![Screenshot_20180301-124855](/uploads/e201fb62c72e66ff6d4e9d38c67d44a1/Screenshot_20180301-124855.png)
### Expected behav...### One-sentence description
Text wrapping events list view on small viewports is flawed
### Current behaviour
![Screenshot_20180301-124855](/uploads/e201fb62c72e66ff6d4e9d38c67d44a1/Screenshot_20180301-124855.png)
### Expected behaviour
Be able to see the complete text
### Steps to reproduce
1. Go to thalia.nu/events
2. Enable the list view
3. Decrease your viewport
Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/593Warn the organiser when the maximum number of participants of an event is cha...2020-01-29T18:43:19+01:00Lennart JansenWarn the organiser when the maximum number of participants of an event is changed### One-sentence description
https://gitlab.science.ru.nl/thalia/
### Current behaviour
People on the waiting list don't get any notification and thus cannot know that their status changed.
### Expected behaviour
The organiser shoul...### One-sentence description
https://gitlab.science.ru.nl/thalia/
### Current behaviour
People on the waiting list don't get any notification and thus cannot know that their status changed.
### Expected behaviour
The organiser should do a follow-up.
### Steps to reproduce
1. Create an event
2. Enable x registrations
3. Register at least x+1 people
4. Change the number of registrations to x+1
5. See that the person x+1 didn't get an email notificationMario TsatsevMario Tsatsev