concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-25T01:45:46+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/323"Iedereen aanwezig"-knop zet ook afmeldingen op aanwezig2018-11-25T01:45:46+01:00Tom Nies"Iedereen aanwezig"-knop zet ook afmeldingen op aanwezigBij de lijst met aanmeldingen voor een evenement (op de admin pagina) is er de knop "Zet iedereen op betaald en present". Hele handige knop, maar het zet ook mensen die zich afgemeld hebben op aanwezig en betaald. Mensen die zich afgemel...Bij de lijst met aanmeldingen voor een evenement (op de admin pagina) is er de knop "Zet iedereen op betaald en present". Hele handige knop, maar het zet ook mensen die zich afgemeld hebben op aanwezig en betaald. Mensen die zich afgemeld hebben zijn natuurlijk niet aanwezig, dus eigenlijk zouden alleen de leden met een registratie aanwezig en betaald gemeld moeten worden.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/58Improve statistics2020-02-19T21:11:58+01:00Thom WiggersImprove statistics### One-sentence description
Improve statistics
### Changed behaviour
After merging !46 (ref #9), we could improve the statistics page.
Suggestions:
- Add statistics about event attendance sorted by event type (from #389)
- Pizza char...### One-sentence description
Improve statistics
### Changed behaviour
After merging !46 (ref #9), we could improve the statistics page.
Suggestions:
- Add statistics about event attendance sorted by event type (from #389)
- Pizza chart. Showing percentages of everything > 5% with a max of 10 and everything else is 'other'
- Top 10 memberships of committees
- Percentage of active members compared to non-active members
- Bar chart with number of members per committees.
- Events heatmap with number of events per week
Also, some header on the page are unclear. As mentioned in #366.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/430Include Oswald in Style guide2018-02-07T19:48:39+01:00Thom WiggersInclude Oswald in Style guideWe should use oswald for cases where we need to distribute the font files, such as the app and the website
https://gitlab.science.ru.nl/thalia/ThaliApp/tree/master/www/fonts/oswaldWe should use oswald for cases where we need to distribute the font files, such as the app and the website
https://gitlab.science.ru.nl/thalia/ThaliApp/tree/master/www/fonts/oswald1.14Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/992KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Thalia TechnicieKeyError: 'delete_selected'Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line...Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line 45, in _wrapper
return bound_method(*args, **kwargs)
File "django/utils/decorators.py", line 142, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/options.py", line 1685, in changelist_view
cl = self.get_changelist_instance(request)
File "django/contrib/admin/options.py", line 727, in get_changelist_instance
if self.get_actions(request):
File "events/admin.py", line 205, in get_actions
del actions['delete_selected']
```30Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/369Ledenlijst2018-11-25T01:45:51+01:00Joren VranckenLedenlijstBij de ledenlijst staat het volgende stukje:
> Wel eens op zoek naar de naam van die persoon die je altijd in de gangen ziet lopen? Of alleen naar het e-mailadres van een klasgenoot? Of misschien wil je wel het telefoonnummer van iema...Bij de ledenlijst staat het volgende stukje:
> Wel eens op zoek naar de naam van die persoon die je altijd in de gangen ziet lopen? Of alleen naar het e-mailadres van een klasgenoot? Of misschien wil je wel het telefoonnummer van iemand weten die je echt dringend wil spreken. Er bestaat een grote kans dat die persoon lid van Thalia is, en dus is opgenomen in de onderstaande ledenlijst.
Gezien dat medestudenten geen klasgenoten zijn, we geen telefoonnummers tonen en geen e-mailadressen tonen, mag dit stukje aangepast worden.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/322leden zichtbaar voor niet-leden2018-11-25T01:45:46+01:00Kirsten Kingmaleden zichtbaar voor niet-ledenNiet-leden kunnen ook de namen en profielfoto's van leden zien, dit lijkt me niet de bedoeling ivm privacy?
---
Hijack van Luuk:
We gaan dit fixen door de ledenlijst achter een inlogmuur te plaatsen.Niet-leden kunnen ook de namen en profielfoto's van leden zien, dit lijkt me niet de bedoeling ivm privacy?
---
Hijack van Luuk:
We gaan dit fixen door de ledenlijst achter een inlogmuur te plaatsen.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/304Lijstweergave evenementen klopt niet2018-11-25T01:45:57+01:00Sébastiaan VersteegLijstweergave evenementen klopt nietGa naar https://thalia.nu/events/ en selecteer 'lijst'. De volgorde van deze lijst is niet op datum en dat is niet echt handig.Ga naar https://thalia.nu/events/ en selecteer 'lijst'. De volgorde van deze lijst is niet op datum en dat is niet echt handig.Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/456Link in event queue email not clickable2017-08-29T15:37:29+02:00Sébastiaan VersteegLink in event queue email not clickable### One-sentence description
Link in event queue email not clickable.
### Current behaviour
Link not clickable.
![Screen_Shot_2017-06-20_at_13.55.43](/uploads/57b2ed577d5e5f4c3ed0044643e1ac74/Screen_Shot_2017-06-20_at_13.55.4...### One-sentence description
Link in event queue email not clickable.
### Current behaviour
Link not clickable.
![Screen_Shot_2017-06-20_at_13.55.43](/uploads/57b2ed577d5e5f4c3ed0044643e1ac74/Screen_Shot_2017-06-20_at_13.55.43.png)
### Expected behaviour
Clickable link.
### Steps to reproduce
1. Get an email that you're allowed into an event.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/299Link to source in footer2018-11-25T01:45:48+01:00Thom WiggersLink to source in footerAs discussed in !302 it would be nice to provide a link from the site to this repository.As discussed in !302 it would be nice to provide a link from the site to this repository.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/979Login page visible when logged-in2020-02-05T21:24:02+01:00Sébastiaan VersteegLogin page visible when logged-in### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page s...### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page should redirect to home or something.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/884Mailing list for societies contact persons2019-06-26T20:16:31+02:00Luko van der MaasMailing list for societies contact persons### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing...### One-sentence description
Create an automatic mailinglist for all contactpersons of the societies.
### Motivation
When the contact person of a society changes it is a lot of double work for the new intern to also update the mailing list. (Request from @tvalten)
### Desired functionality
Create a new automatic mailinglist for all heads of the societies. These people are the contact persons.
### Suggested implementation
Look at how the commitee chair mailinglist is done.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/842Mailing lists api fails without boards2019-10-03T17:23:45+02:00Joren VranckenMailing lists api fails without boards### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/Wouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/293Make CONTRIBUTING.md2018-09-12T19:43:10+02:00Wietse KuipersMake CONTRIBUTING.mdThe repository currently does not have contributing guidelinesThe repository currently does not have contributing guidelineshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/379Make event.organiser NOT NULL2017-12-10T21:23:58+01:00Thom WiggersMake event.organiser NOT NULLNow that every event has an organiser, the field should be set to NOT NULL. This would also allow a relaxation of the constraint checking we're doing in various places (see !431 !440)Now that every event has an organiser, the field should be set to NOT NULL. This would also allow a relaxation of the constraint checking we're doing in various places (see !431 !440)Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/688Make 'oudbesturen' an automatic mailinglist2018-12-12T22:33:06+01:00Sébastiaan VersteegMake 'oudbesturen' an automatic mailinglist### One-sentence description
### Desired behaviour
Since all `boardxxyy@thalia.nu` mailinglists are automatically generated (https://gitlab.science.ru.nl/thalia/concrexit/commit/00d99502b2eb58d70ca30dd800432112a67b5ea5) we also want `o...### One-sentence description
### Desired behaviour
Since all `boardxxyy@thalia.nu` mailinglists are automatically generated (https://gitlab.science.ru.nl/thalia/concrexit/commit/00d99502b2eb58d70ca30dd800432112a67b5ea5) we also want `oudbesturen`/`oldboard` to be automatically generated as well to prevent more work.Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/749Member list category benefactors2018-10-31T18:46:02+01:00Job DoesburgMember list category benefactors<!--
You want something new.
-->
### One-sentence description
Add benefactors as category to member list.
### Motivation
Currently it's inconsistent. There is a category 'honorary members' and even 'old members' but no 'benefacto...<!--
You want something new.
-->
### One-sentence description
Add benefactors as category to member list.
### Motivation
Currently it's inconsistent. There is a category 'honorary members' and even 'old members' but no 'benefactors' whereas it really is a separate group Thalians.
### Desired functionality
Also have a tab 'benefactors' at the members list page.
### Suggested implementation
I think this is quite clear.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/503Members with no membership are 'Former member' on profile2017-09-23T13:40:29+02:00Joost Rijneveldjoost@joostrijneveld.nlMembers with no membership are 'Former member' on profileCurrently users that do not have a membership at all are marked as `Former member` on their profile. Perhaps it's more accurate to describe those as `Unknown membership history`, given that we are now able to distinguish actual 'former m...Currently users that do not have a membership at all are marked as `Former member` on their profile. Perhaps it's more accurate to describe those as `Unknown membership history`, given that we are now able to distinguish actual 'former members' from e.g. 'former supporters' based on the existence of expired Membership objects.1.11Bram in 't ZandtBram in 't Zandthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/7Merchandise2017-12-10T21:25:34+01:00Joost Rijneveldjoost@joostrijneveld.nlMerchandiseIdeas: create a single model that has an ImageField (see documents application for similar FileField), do not bother with thumbnails but simply render this image. For multilingual description fields, use `description_en` and `description...Ideas: create a single model that has an ImageField (see documents application for similar FileField), do not bother with thumbnails but simply render this image. For multilingual description fields, use `description_en` and `description_nl` ("Explicit is better than implicit")Launchhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/971Missing translations in information check email2020-02-19T21:13:59+01:00Jelle Besselingjelle@pingiun.comMissing translations in information check email### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check ma...### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check mail contains correct translations
<!-- Please write how what happened did not meet your expectations -->Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/981Missing translations in statistics page2020-02-19T23:46:54+01:00Job DoesburgMissing translations in statistics page### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right ch...### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right chart
### Expected behaviour
be translatedMark BouteMark Boute