concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-10-18T11:31:31+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/692Remove voicemailbox from contact page2018-10-18T11:31:31+02:00Job DoesburgRemove voicemailbox from contact page### One-sentence description
Remove voicemailbox from contact page
### Desired behaviour
The voicemailbox phone number isn't really a thing anymore, so it can be removed from the website.### One-sentence description
Remove voicemailbox from contact page
### Desired behaviour
The voicemailbox phone number isn't really a thing anymore, so it can be removed from the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/358Repareer indicatie voor aanmeldstatus2018-11-25T01:45:55+01:00Lennart JansenRepareer indicatie voor aanmeldstatusIn !371 gaat 't mis op de hoofdpagina als je (na aanmelding) afgemeld bent voor een evenement. Het bolletje zou rood moeten zijn, maar is nog steeds groen.
#123 is dus nog niet helemaal af.In !371 gaat 't mis op de hoofdpagina als je (na aanmelding) afgemeld bent voor een evenement. Het bolletje zou rood moeten zijn, maar is nog steeds groen.
#123 is dus nog niet helemaal af.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/721Report correct membership status / history on renewal page2018-10-18T11:30:19+02:00Joost Rijneveldjoost@joostrijneveld.nlReport correct membership status / history on renewal page### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
...### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the _last_ membership (since it's not my _current_ membership), or display _all_ historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
### Current behaviour
```
## MEMBERSHIP INFORMATION
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Active: no
You're a supporter. Contact the board to renew your membership.
```
### Expected behaviour
```
## MEMBERSHIP INFORMATION
### Current membership:
No active membership. Contact the board to renew your membership.
### Former memberships:
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Membership type: Supporter
Since: Sept. 1, 2016
Until: Sept. 1, 2017
[..]
```
### Steps to reproduce
1. Don't have an active membership
2. Go to https://thalia.nu/registration/renew/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/447Send queue mail wordt verzonden als iemand op de wachtrij zich afmeldt2017-07-05T19:24:09+02:00Sietse MoorenSend queue mail wordt verzonden als iemand op de wachtrij zich afmeldt### One-sentence description
Send queue mail wordt verzonden als iemand op de wachtrij zich afmeldt
### Current behaviour
Als iemand in de wachtrij zichzelf er vanaf haalt wordt `_send_queue_mail` nog steeds uitgevoerd
### Expe...### One-sentence description
Send queue mail wordt verzonden als iemand op de wachtrij zich afmeldt
### Current behaviour
Als iemand in de wachtrij zichzelf er vanaf haalt wordt `_send_queue_mail` nog steeds uitgevoerd
### Expected behaviour
Als iemand in de wachtrij zichzelf er vanaf haalt wordt er geen mail verstuurd
### Steps to reproduce
1. Maak een event met max participants
2. Voeg aantal registrations toe
3. Cancel registration in de frontend van een van de gebruikers
4. Zie verzonden mail
### Original text
Je krijgt een mail dat je in de wachtlijst stond maar nu mag gaan. Als je vervolgens naar de link gaat die in de mail staat sta je nog steeds in de wachtrij. Wat moet ik nu geloven.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/851Set restraints on start year at user creation2019-09-18T21:29:48+02:00Bart HofmanSet restraints on start year at user creation### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behav...### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behaviour
Make a dropdown and be able to only select actually existing cohortsBart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/568Set Thalia's theme colour on the address bar2018-03-28T20:19:05+02:00Thom WiggersSet Thalia's theme colour on the address bar### One-sentence description
Set Thalia's theme colour: https://developers.google.com/web/tools/lighthouse/audits/address-bar### One-sentence description
Set Thalia's theme colour: https://developers.google.com/web/tools/lighthouse/audits/address-barhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1008Show deregistration disclaimer text even if not registered for event2020-02-23T16:53:09+01:00Job DoesburgShow deregistration disclaimer text even if not registered for event### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how ...### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
Currently, the website does not show the deregistration disclaimer if you are not registered. This is undesirable, as it allows users to register for the event, without realising that they cannot deregister without paying a fine.
### Expected behaviour
Always state the disclaimer (just like in the app).
![IMG_753FFE892ACD-1](/uploads/fa6db1596eb92b1e2d5bbaa7a07ae4dd/IMG_753FFE892ACD-1.jpeg)Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/763Sister Association page also contains brother associations2018-11-14T22:00:14+01:00Joren VranckenSister Association page also contains brother associations### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -...### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Go to [Sister Association page](https://thalia.nu/sister-associations)
2. Observe the brother associations (and one foundation).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
The page is called something like "Brother and Sister Associations" or "Links" (with links to all affiliated organisations like sister associations, the USR and Ninja).Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/755Split societies from 'Achievements for Thalia' to different header on profile2018-11-14T20:35:09+01:00Sébastiaan VersteegSplit societies from 'Achievements for Thalia' to different header on profile### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https:...### One-sentence description
Split societies from 'Achievements for Thalia' to different header on profile
### Current behaviour / Reproducing the bug
Societies are in the 'Achievements for Thalia' section on user profiles. See https://thalia.nu/members/profile/2.
### Expected behaviour
Societies are in a different section, at least not displayed in the previously mentioned section.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/520Sponsorpagina geeft tekst niet goed weer2017-10-12T12:04:48+02:00Niek JanssenSponsorpagina geeft tekst niet goed weerOp de sponsorpagina (https://thalia.nu/career/) staat bij topicus een niet goed geformatteerde tekst.
- Er staan random & nbsp;'s in
- Een subkop staat er, zonder spatie, in
Als je op 'lees meer' klikt staat het er wel goed.
Verder ...Op de sponsorpagina (https://thalia.nu/career/) staat bij topicus een niet goed geformatteerde tekst.
- Er staan random & nbsp;'s in
- Een subkop staat er, zonder spatie, in
Als je op 'lees meer' klikt staat het er wel goed.
Verder nog een random sidenote: ik vind dat je vrij snel over onze hoofdsponsor heen scrollt. Misschien een zwarte rand om het hele topicus-blok heen?1.11https://gitlab.science.ru.nl/thalia/concrexit/-/issues/9Statistics2017-12-10T21:25:34+01:00Joost Rijneveldjoost@joostrijneveld.nlStatisticsLaunchKoen van IngenKoen van Ingenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/950Statistics names are shown wrong2019-11-20T21:16:14+01:00Thijs de JongStatistics names are shown wrong### One-sentence description
The statistics for ``number of members per committee`` shows the names wrong.
### Current behaviour / Reproducing the bug
The statistics for ``number of members per committee`` shows names of the committee u...### One-sentence description
The statistics for ``number of members per committee`` shows the names wrong.
### Current behaviour / Reproducing the bug
The statistics for ``number of members per committee`` shows names of the committee underneath the bars, but not underneath every bar. Only per 2 bars, and when there are more committees, there are less and less committee names.
### Expected behaviour
Every bar has a name underneath it.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/366Statistieken kopjes aantal leden2019-02-19T19:41:00+01:00Joren VranckenStatistieken kopjes aantal ledenOp de statistieken pagina staan het aantal leden exclusief begunstigers als "Leden per jaar" en inclusief begunstigers als "Aantal leden per jaar". Dit is niet heel duidelijk.Op de statistieken pagina staan het aantal leden exclusief begunstigers als "Leden per jaar" en inclusief begunstigers als "Aantal leden per jaar". Dit is niet heel duidelijk.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/695Styleguide documents via Google Drive2018-10-18T11:30:19+02:00Job DoesburgStyleguide documents via Google Drive### One-sentence description
Styleguide documents via Google Drive
### Why?
We want to replace the styleguide downloads by a URL to a subfolder in our drive so new files are always directly available and up-to-date.
### Current imple...### One-sentence description
Styleguide documents via Google Drive
### Why?
We want to replace the styleguide downloads by a URL to a subfolder in our drive so new files are always directly available and up-to-date.
### Current implementation
Files are hosted from the Thalia servers
### Desired implementation
Google Drive folders that can be accessed by members
19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/314Styleguide downloads contain __MACOSX folders2018-11-25T01:45:51+01:00Wietse KuipersStyleguide downloads contain __MACOSX foldersThis doesn't seem neccesaryThis doesn't seem neccesaryWietse KuipersWietse Kuipershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/202Taal-knop subtieler plaatsen (bij mobiele weergave)2018-11-25T01:46:03+01:00Lennart JansenTaal-knop subtieler plaatsen (bij mobiele weergave)"English" dan wel "Nederlands" verbergt op dit moment een deel van het Thalia-logo in de mobiele weergave.
Sowieso valt deze knop erg (in mijn opzicht: te veel) op. Misschien verplaatsen naar persoonlijke instellingen?"English" dan wel "Nederlands" verbergt op dit moment een deel van het Thalia-logo in de mobiele weergave.
Sowieso valt deze knop erg (in mijn opzicht: te veel) op. Misschien verplaatsen naar persoonlijke instellingen?Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/596Text wrapping events list view on small viewports is flawed2018-03-15T13:49:12+01:00Leon van den BoogaardText wrapping events list view on small viewports is flawed### One-sentence description
Text wrapping events list view on small viewports is flawed
### Current behaviour
![Screenshot_20180301-124855](/uploads/e201fb62c72e66ff6d4e9d38c67d44a1/Screenshot_20180301-124855.png)
### Expected behav...### One-sentence description
Text wrapping events list view on small viewports is flawed
### Current behaviour
![Screenshot_20180301-124855](/uploads/e201fb62c72e66ff6d4e9d38c67d44a1/Screenshot_20180301-124855.png)
### Expected behaviour
Be able to see the complete text
### Steps to reproduce
1. Go to thalia.nu/events
2. Enable the list view
3. Decrease your viewport
Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/3Thabloid2017-12-10T21:25:34+01:00Joost Rijneveldjoost@joostrijneveld.nlThabloid- [x] let the user upload a PDF
- [x] serve it back to users (maybe through 'sendfile' for consistent naming, see documents app)
- [x] display a thumbnail
- [x] ideally cut it up into JPGs
- [ ] and use a fancy viewer if there's time (...- [x] let the user upload a PDF
- [x] serve it back to users (maybe through 'sendfile' for consistent naming, see documents app)
- [x] display a thumbnail
- [x] ideally cut it up into JPGs
- [ ] and use a fancy viewer if there's time (alternatively: outsource this to a new issue).
For the thumbnail, see conclusions that come out of #2 (potentially a dependency that is able to turn the uploaded PDF into a JPG front cover).LaunchJoost Rijneveldjoost@joostrijneveld.nlJoost Rijneveldjoost@joostrijneveld.nlhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/980Thalia Pay process button enabled in payments widget even though TPAY_ENABLED...2020-02-19T21:48:26+01:00Sébastiaan VersteegThalia Pay process button enabled in payments widget even though TPAY_ENABLED=False### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
#...### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
### Expected behaviour
1. I cannot click it
2. If I should be able to click it, it should not crash.Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/186thumbnails respecteren rotatie niet.2018-11-25T01:46:05+01:00Thom Wiggersthumbnails respecteren rotatie niet.