concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-09-17T12:10:21+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/924Add the real name of members to profiles2019-09-17T12:10:21+02:00Ward TheunisseAdd the real name of members to profiles/label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add.../label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add the real name of members to profiles.
### Suggested implementation
Some text.
27https://gitlab.science.ru.nl/thalia/concrexit/-/issues/941event registration terms and conditions link broken2019-10-24T19:17:38+02:00Nick van Oersevent registration terms and conditions link broken### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/950Statistics names are shown wrong2019-11-20T21:16:14+01:00Thijs de JongStatistics names are shown wrong### One-sentence description
The statistics for ``number of members per committee`` shows the names wrong.
### Current behaviour / Reproducing the bug
The statistics for ``number of members per committee`` shows names of the committee u...### One-sentence description
The statistics for ``number of members per committee`` shows the names wrong.
### Current behaviour / Reproducing the bug
The statistics for ``number of members per committee`` shows names of the committee underneath the bars, but not underneath every bar. Only per 2 bars, and when there are more committees, there are less and less committee names.
### Expected behaviour
Every bar has a name underneath it.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/959API authentication returns 400 when providing the wrong credentials2019-11-06T20:58:05+01:00Gijs HendriksenAPI authentication returns 400 when providing the wrong credentials<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
The API `/token-auth/` returns a 400 status code when the user passed incorrect credentials, which makes it unclear why the request was denied.
### Why?
<!-- Please motivate why we should invest into this change -->
To make use of the correct HTTP status code, which could clarify the reason an authentication request was denied.
### Current implementation
<!-- If relevant, describe how it's done currently -->
`/token-auth/` returns a 400 when providing incorrect credentials
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->
`/token-auth/` returns a 401(?) when providing incorrect credentialsSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1008Show deregistration disclaimer text even if not registered for event2020-02-23T16:53:09+01:00Job DoesburgShow deregistration disclaimer text even if not registered for event### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how ...### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
Currently, the website does not show the deregistration disclaimer if you are not registered. This is undesirable, as it allows users to register for the event, without realising that they cannot deregister without paying a fine.
### Expected behaviour
Always state the disclaimer (just like in the app).
![IMG_753FFE892ACD-1](/uploads/fa6db1596eb92b1e2d5bbaa7a07ae4dd/IMG_753FFE892ACD-1.jpeg)Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/963Remove cancelled registrations from personal ICAL feed.2019-11-20T21:39:39+01:00Joren VranckenRemove cancelled registrations from personal ICAL feed.### One-sentence description
Cancelled registrations are included in the personal ICAL feed.
### Expected behaviour
Cancelled registrations are not included in the personal ICAL feed.### One-sentence description
Cancelled registrations are included in the personal ICAL feed.
### Expected behaviour
Cancelled registrations are not included in the personal ICAL feed.Simcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/971Missing translations in information check email2020-02-19T21:13:59+01:00Jelle Besselingjelle@pingiun.comMissing translations in information check email### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check ma...### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check mail contains correct translations
<!-- Please write how what happened did not meet your expectations -->Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/975/api/v1/token-auth does not return json on login failure2020-02-20T08:45:46+01:00Jelle Besselingjelle@pingiun.com/api/v1/token-auth does not return json on login failure### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expect...### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expected behaviour
Json object should be returnedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/979Login page visible when logged-in2020-02-05T21:24:02+01:00Sébastiaan VersteegLogin page visible when logged-in### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page s...### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page should redirect to home or something.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/980Thalia Pay process button enabled in payments widget even though TPAY_ENABLED...2020-02-19T21:48:26+01:00Sébastiaan VersteegThalia Pay process button enabled in payments widget even though TPAY_ENABLED=False### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
#...### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
### Expected behaviour
1. I cannot click it
2. If I should be able to click it, it should not crash.Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/981Missing translations in statistics page2020-02-19T23:46:54+01:00Job DoesburgMissing translations in statistics page### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right ch...### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right chart
### Expected behaviour
be translatedMark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/983Update members translations2020-01-29T21:21:15+01:00Joren VranckenUpdate members translations### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/985Add link to the G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenAdd link to the G Suite Knowledge Base<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Add link to the [G Suite Knowledge Base](https://gsuite.members.thalia.nu/) in the "for members" menu.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/992KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Thalia TechnicieKeyError: 'delete_selected'Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line...Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line 45, in _wrapper
return bound_method(*args, **kwargs)
File "django/utils/decorators.py", line 142, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/options.py", line 1685, in changelist_view
cl = self.get_changelist_instance(request)
File "django/contrib/admin/options.py", line 727, in get_changelist_instance
if self.get_actions(request):
File "events/admin.py", line 205, in get_actions
del actions['delete_selected']
```30Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/998Add information to exam / summary submission2020-03-11T20:14:27+01:00Ward TheunisseAdd information to exam / summary submission<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of ex...<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of exams immediately because there's a review first. This way it is not clear whether the submission was actually performed correctly + people don't know that an submission is manually checked before being published.
### Desired functionality
Inform people whether their submission was succesful and why it isn't immediately visible.
### Suggested implementation
Show a message thanking someone for their submission, also informing them that it will be published after a review.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1004'All members' in members directory not marked as active2020-02-05T21:18:38+01:00Sébastiaan Versteeg'All members' in members directory not marked as active### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected ...### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected behaviour
1. Go to https://thalia.nu/members/directory/
2. The item is selectedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1017Remove redundant html templates from `/thaliawebsite/templates/singlepages/`2020-03-13T16:29:15+01:00Job DoesburgRemove redundant html templates from `/thaliawebsite/templates/singlepages/`<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove redundant html templates from `/thaliawebsite/templates/singlepages/`
### Why?
They are redundant, since they are also in `/singlepages/templates` and these are the ones that are used.
### Current implementation
It appears as if the translations are still in `/thaliawebsite` though, so it would probably be nice to move these.
### Suggested implementationMarthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1020Do not use hardcoded colors for calendar API2020-03-04T17:06:42+01:00Job DoesburgDo not use hardcoded colors for calendar API<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Do not use hardcoded colors for calendar API in `website/members/api/serializers.py` r42-49 and `website/events/api/serializers.py`
### Why?
We shouldn't hardcode these things at the API level but provide them using CSS.
### Current implementation
The API provides a `backgroundColor` and `textColor` in the event sources APIs that is used by FullCalendar via https://fullcalendar.io/docs/events-json-feed. Every item in the feed is an event source object: https://fullcalendar.io/docs/event-source-object.
### Suggested implementation
Provide a `className` attribute instead and determine the background color and text color based on the class using CSS.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1025ValueError: day is out of range for month2020-03-04T20:22:40+01:00Thalia TechnicieValueError: day is out of range for monthSentry Issue: [CONCREXIT-24](https://sentry.io/organizations/thalia/issues/1538288408/?referrer=gitlab_integration)
```
ValueError: day is out of range for month
(11 additional frame(s) were not displayed)
...
File "rest_framework/ser...Sentry Issue: [CONCREXIT-24](https://sentry.io/organizations/thalia/issues/1538288408/?referrer=gitlab_integration)
```
ValueError: day is out of range for month
(11 additional frame(s) were not displayed)
...
File "rest_framework/serializers.py", line 260, in data
self._data = self.to_representation(self.instance)
File "rest_framework/serializers.py", line 529, in to_representation
ret[field.field_name] = field.to_representation(attribute)
File "rest_framework/fields.py", line 1905, in to_representation
return method(value)
File "members/api/serializers.py", line 93, in _achievements
return member_achievements(instance.user)
File "members/services.py", line 72, in member_achievements
earliest = earliest.replace(year=earliest.year + mentor_year.year)
```Marie SimonMarie Simon