concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-23T16:53:09+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1008Show deregistration disclaimer text even if not registered for event2020-02-23T16:53:09+01:00Job DoesburgShow deregistration disclaimer text even if not registered for event### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how ...### One-sentence description
The text stating you cannot deregister without paying a fine is not visible if you are not registered for the event.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
Currently, the website does not show the deregistration disclaimer if you are not registered. This is undesirable, as it allows users to register for the event, without realising that they cannot deregister without paying a fine.
### Expected behaviour
Always state the disclaimer (just like in the app).
![IMG_753FFE892ACD-1](/uploads/fa6db1596eb92b1e2d5bbaa7a07ae4dd/IMG_753FFE892ACD-1.jpeg)Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1004'All members' in members directory not marked as active2020-02-05T21:18:38+01:00Sébastiaan Versteeg'All members' in members directory not marked as active### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected ...### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected behaviour
1. Go to https://thalia.nu/members/directory/
2. The item is selectedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/998Add information to exam / summary submission2020-03-11T20:14:27+01:00Ward TheunisseAdd information to exam / summary submission<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of ex...<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of exams immediately because there's a review first. This way it is not clear whether the submission was actually performed correctly + people don't know that an submission is manually checked before being published.
### Desired functionality
Inform people whether their submission was succesful and why it isn't immediately visible.
### Suggested implementation
Show a message thanking someone for their submission, also informing them that it will be published after a review.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/992KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Thalia TechnicieKeyError: 'delete_selected'Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line...Sentry Issue: [CONCREXIT-1S](https://sentry.io/organizations/thalia/issues/1399281021/?referrer=gitlab_integration)
```
KeyError: 'delete_selected'
(7 additional frame(s) were not displayed)
...
File "django/utils/decorators.py", line 45, in _wrapper
return bound_method(*args, **kwargs)
File "django/utils/decorators.py", line 142, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/options.py", line 1685, in changelist_view
cl = self.get_changelist_instance(request)
File "django/contrib/admin/options.py", line 727, in get_changelist_instance
if self.get_actions(request):
File "events/admin.py", line 205, in get_actions
del actions['delete_selected']
```30Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/985Add link to the G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenAdd link to the G Suite Knowledge Base<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Add link to the [G Suite Knowledge Base](https://gsuite.members.thalia.nu/) in the "for members" menu.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/983Update members translations2020-01-29T21:21:15+01:00Joren VranckenUpdate members translations### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/981Missing translations in statistics page2020-02-19T23:46:54+01:00Job DoesburgMissing translations in statistics page### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right ch...### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right chart
### Expected behaviour
be translatedMark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/980Thalia Pay process button enabled in payments widget even though TPAY_ENABLED...2020-02-19T21:48:26+01:00Sébastiaan VersteegThalia Pay process button enabled in payments widget even though TPAY_ENABLED=False### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
#...### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
### Expected behaviour
1. I cannot click it
2. If I should be able to click it, it should not crash.Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/979Login page visible when logged-in2020-02-05T21:24:02+01:00Sébastiaan VersteegLogin page visible when logged-in### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page s...### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page should redirect to home or something.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/975/api/v1/token-auth does not return json on login failure2020-02-20T08:45:46+01:00Jelle Besselingjelle@pingiun.com/api/v1/token-auth does not return json on login failure### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expect...### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expected behaviour
Json object should be returnedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/963Remove cancelled registrations from personal ICAL feed.2019-11-20T21:39:39+01:00Joren VranckenRemove cancelled registrations from personal ICAL feed.### One-sentence description
Cancelled registrations are included in the personal ICAL feed.
### Expected behaviour
Cancelled registrations are not included in the personal ICAL feed.### One-sentence description
Cancelled registrations are included in the personal ICAL feed.
### Expected behaviour
Cancelled registrations are not included in the personal ICAL feed.Simcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/959API authentication returns 400 when providing the wrong credentials2019-11-06T20:58:05+01:00Gijs HendriksenAPI authentication returns 400 when providing the wrong credentials<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
The API `/token-auth/` returns a 400 status code when the user passed incorrect credentials, which makes it unclear why the request was denied.
### Why?
<!-- Please motivate why we should invest into this change -->
To make use of the correct HTTP status code, which could clarify the reason an authentication request was denied.
### Current implementation
<!-- If relevant, describe how it's done currently -->
`/token-auth/` returns a 400 when providing incorrect credentials
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->
`/token-auth/` returns a 401(?) when providing incorrect credentialsSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/941event registration terms and conditions link broken2019-10-24T19:17:38+02:00Nick van Oersevent registration terms and conditions link broken### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions### One-sentence description
event registration terms and conditions link
### Current behaviour / Reproducing the bug
redirect to event itself
### Expected behaviour
redirect to event registration terms and conditions28https://gitlab.science.ru.nl/thalia/concrexit/-/issues/919Event information is public2020-01-23T11:31:49+01:00Thomas Klein BretelerEvent information is publicEvent information is public
### Current behaviour / Reproducing the bug
Everyone on the internet can see the location and number of registration of events. Partners etc can follow the status and that might be undesirable.
You can chec...Event information is public
### Current behaviour / Reproducing the bug
Everyone on the internet can see the location and number of registration of events. Partners etc can follow the status and that might be undesirable.
You can check this by opening an event in incognito mode.
### Expected behaviour
Information should be only visible for members.Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/914Update placeholder in activemembers2019-10-03T16:37:03+02:00Sébastiaan VersteegUpdate placeholder in activemembers### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we ...### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/912get_thumbnail_url crashes when image is missing2019-10-05T13:06:41+02:00Thalia Technicieget_thumbnail_url crashes when image is missingSentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additi...Sentry Issue: [CONCREXIT-Q](https://sentry.io/organizations/thalia/issues/1204599417/?referrer=gitlab_integration)
```
FileNotFoundError: [Errno 2] No such file or directory: '/concrexit/media/public/avatars/bestuursfoto.jpg'
(26 additional frame(s) were not displayed)
...
File "django/template/library.py", line 214, in render
_dict = self.func(*resolved_args, **resolved_kwargs)
File "activemembers/templatetags/activemembers_cards.py", line 47, in membergroup_member_card
ribbon=ribbon
File "members/templatetags/member_card.py", line 22, in member_card
settings.THUMBNAIL_SIZES['medium'])
File "utils/media/services.py", line 90, in get_thumbnail_url
os.path.getmtime(full_original_path)
File "genericpath.py", line 55, in getmtime
return os.stat(filename).st_mtime
```27Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/902Add membership type and reference count to renewal/registration admin overviews2019-08-28T19:57:42+02:00Sébastiaan VersteegAdd membership type and reference count to renewal/registration admin overviews<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
...<!--
You want something new.
-->
### One-sentence description
Add membership type and reference count to renewal/registration admin overviews
### Motivation
Useful while managing a lot of renewals and
### Desired functionality
Columns in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeg