concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-09-18T20:57:20+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/650Use the Mailman REST api to push mailinglist changes2019-09-18T20:57:20+02:00Jelle Besselingjelle@pingiun.comUse the Mailman REST api to push mailinglist changes### One-sentence description
Use the Mailman REST api to push mailinglist changes
### Why?
A new mailinglist sync will make for a more robust implementation
### Current implementation
The current syncmailinglist.py is a hacky script whic...### One-sentence description
Use the Mailman REST api to push mailinglist changes
### Why?
A new mailinglist sync will make for a more robust implementation
### Current implementation
The current syncmailinglist.py is a hacky script which always pulls all the mailing lists from the website. It runs on an interval so it does not always reflect the latest mailinglists.
### Desired implementation
Concrexit knows when a mailing list changes and can thus automatically update Mailman via REST api (which has official python bindings). With Celery this can be done in a seperate task to catch any errors. The new REST api is available in Mailman 3, and as we're currently running Mailman 2 I also created a related issue in https://gitlab.science.ru.nl/thalia/serverconfig/issues/204https://gitlab.science.ru.nl/thalia/concrexit/-/issues/649Automatic generation of board email addresses2018-07-11T20:17:47+02:00Sébastiaan VersteegAutomatic generation of board email addresses### One-sentence description
Automatic generation of board email addresses
### Desired behaviour
Currently we create a mailinglist for every board every single year, however we could just generate them automatically based on the Board...### One-sentence description
Automatic generation of board email addresses
### Desired behaviour
Currently we create a mailinglist for every board every single year, however we could just generate them automatically based on the Board models.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/646Only show events you're registered for in ical feed2018-06-13T22:00:16+02:00Kirsten KingmaOnly show events you're registered for in ical feed### One-sentence description
Only show events you're registered for in ical feed.
### Desired behaviour
Provide the option to download a personalized ical feed which only shows events you're registered for and events for which there i...### One-sentence description
Only show events you're registered for in ical feed.
### Desired behaviour
Provide the option to download a personalized ical feed which only shows events you're registered for and events for which there is no registration. Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/643Reference to privacy policy2018-06-01T18:51:37+02:00Joren VranckenReference to privacy policy### One-sentence description
Make it easy to find the privacy policy on the website.
### Desired behaviour
At the moment our privacy policy can be found at https://thalia.nu/privacy-policy/.
There is no direct link to this on the homepa...### One-sentence description
Make it easy to find the privacy policy on the website.
### Desired behaviour
At the moment our privacy policy can be found at https://thalia.nu/privacy-policy/.
There is no direct link to this on the homepage (or via the menu).
It would be nice to have a link to the privacy policy in the footer.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/641It is unclear if the year field on documents in the backend refers to the fir...2018-06-13T22:01:01+02:00Joren VranckenIt is unclear if the year field on documents in the backend refers to the first or last year of the academic year.### One-sentence description
It is unclear if the year field on documents in the backend refers to the first or last year for that document.
### Why?
A document for an academic year has two years (e.g. the policy document for 2017-2018)...### One-sentence description
It is unclear if the year field on documents in the backend refers to the first or last year for that document.
### Why?
A document for an academic year has two years (e.g. the policy document for 2017-2018).
### Current implementation
It is possible to select only one year.
### Desired implementation
It is possible to select the academic year for documents.Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/640Add filter to committee membership admin for active memberships2018-06-13T20:28:03+02:00Sébastiaan VersteegAdd filter to committee membership admin for active memberships### One-sentence description
Add filter to committee membership admin for active memberships
### Desired behaviour
Have the ability to filter between active, non-active and all committee memberships. (Active = no end date)### One-sentence description
Add filter to committee membership admin for active memberships
### Desired behaviour
Have the ability to filter between active, non-active and all committee memberships. (Active = no end date)Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/636Add deeplinking functionality to push notifications2018-09-19T19:11:02+02:00Sébastiaan VersteegAdd deeplinking functionality to push notifications### One-sentence description
Add deeplinking functionality to push notifications
### Desired behaviour
We should have a way of adding a payload to notifications so that the app can open the right screen when they're pressed.### One-sentence description
Add deeplinking functionality to push notifications
### Desired behaviour
We should have a way of adding a payload to notifications so that the app can open the right screen when they're pressed.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/633Change language in backend2018-05-16T19:49:26+02:00Joren VranckenChange language in backend### One-sentence description
Add the possibility to change the language in the backend.
### Why?
It is not possible to change the language in the backend.
### Current implementation
It is only possible to change the language in the fro...### One-sentence description
Add the possibility to change the language in the backend.
### Why?
It is not possible to change the language in the backend.
### Current implementation
It is only possible to change the language in the frontend.
If you want to change the language in the backend, you have to first go to the frontend and change the language there and then go back to the backend.
### Desired implementation
A button to switch the language in the backend, similar to the one in the frontend.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/632Thalia Pay2019-10-03T16:58:43+02:00Aucke BosThalia PayThis is the general overview issue for Thalia Pay. The work has been split in multiple subissues that all begin with 'Thalia Pay'
### One-sentence description
Members can pay for things by keeping a tab using their account.
### Desire...This is the general overview issue for Thalia Pay. The work has been split in multiple subissues that all begin with 'Thalia Pay'
### One-sentence description
Members can pay for things by keeping a tab using their account.
### Desired behaviour
A member has a virtual wallet with a maximum balance of 0 euro. This wallet can be used to pay for things.
Once a member registers for an event or orders a pizza an option will appear to pay using the wallet. Such a payment is registered in the ~payments app. The amount of the payment will be deducted from the wallet.
At the end of the month all the payments of that month will be collected by direct debit.
Before these direct debits can take place we need to collect information from members:
- Bank account
- Initials and last name of the bank account holder
- The member has to sign a SEPA mandate
Then the treasurer has to be able to create an export that contains all the information for a direct debit. The overview only has to contain members that made a payment. It should have the following fields:
- Relationnumber
- First name
- Last name
- IBAN
- Initials + last name of holder
- Amount
- Overview of all payments in this row
The treasurer will send a mail before the direct debit will be executed. But an overview in the frontend of the website would be desirable.
---
## What has been done
- The Payment model introduced in !533 was moved to it's own app in !704.
- The event payments were refactored to use the Payment model in !1112.
- We're syncing member information and mandates to Conscribo, first introduced in !1132.
- The pizza payments were refactored to use the Payment model in !1225.
- We added digital SEPA mandates in !1241.
- We added a user-facing payment overview in !1350.
## What we should do next
Mostly taken from https://gitlab.science.ru.nl/thalia/concrexit/issues/632#note_74956 and responses.
1. Add a direct debit payment method to the payment model. (#930)
2. Export payment batches for ING (the bank). (#931)
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit.
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.
3. Export financial information that can be imported to Conscribo.
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.
4. We should investigate how we are going to notify members of an upcoming direct debit.
- Could be on export noted in (1).
5. Add an option to ~events for users to mark their registration as paid using direct debit.
- Do not forget the app.
- Needs check for a valid mandate.
6. Add an option to ~pizzas for users to mark their order as paid using direct debit.
- See (5).Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/629generate statistics about downloads and uploads for the summaries and tests2018-05-22T16:25:47+02:00Luko van der Maasgenerate statistics about downloads and uploads for the summaries and tests### One-sentence description
Create statistics for downloads and uploads for the summaries and tests
### Desired behaviour
Create some sort of report for the educatie about statistics for downloads and uploads for summaries and tests### One-sentence description
Create statistics for downloads and uploads for the summaries and tests
### Desired behaviour
Create some sort of report for the educatie about statistics for downloads and uploads for summaries and testsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/626Display order of documents2018-05-28T12:50:46+02:00Gerdriaan MulderDisplay order of documents### One-sentence description
The display order of the documents can be configured.
### Desired behaviour
At the moment, there does not seem to be a logical order in the documents page. For example, the document "Huishoudelijk Reglement ...### One-sentence description
The display order of the documents can be configured.
### Desired behaviour
At the moment, there does not seem to be a logical order in the documents page. For example, the document "Huishoudelijk Reglement (26-08-2014)" is mentioned earlier than the more recent document "Huishoudelijk Reglement (04-10-2017)". This is confusing.
What I would like to see is that a more recent document is shown earlier on when multiple versions of that document exist.
It is also acceptable if an admin can configure this (ideally, the "Statuten" and "Huishoudelijk Reglement" would be mentioned first, before all other documents).Jeremy GuijtJeremy Guijthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/623Typo on registration renewal page2018-04-13T16:30:06+02:00Sébastiaan VersteegTypo on registration renewal pagehttps://thalia.nu/registration/renew/
> Laat het ons dat alsjeblieft weten door een mail te sturen naar info@thalia.nu.https://thalia.nu/registration/renew/
> Laat het ons dat alsjeblieft weten door een mail te sturen naar info@thalia.nu.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/621Prevent double course files2018-04-05T17:35:12+02:00Sébastiaan VersteegPrevent double course files### One-sentence description
Prevent double course files
### Desired behaviour
When uploading PDF's for the education section on the website we could compare some kind of hash with a value that we save in the model to prevent duplicat...### One-sentence description
Prevent double course files
### Desired behaviour
When uploading PDF's for the education section on the website we could compare some kind of hash with a value that we save in the model to prevent duplicate files.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/619Word "Notulen" on the documents page is not translated2018-03-31T21:14:39+02:00Luko van der MaasWord "Notulen" on the documents page is not translated### One-sentence description
At the general meeting section, the button "notulen" is dutch on the English website
### Current behaviour
At the general meeting section, the button "notulen" is dutch on the English website
### Expected b...### One-sentence description
At the general meeting section, the button "notulen" is dutch on the English website
### Current behaviour
At the general meeting section, the button "notulen" is dutch on the English website
### Expected behaviour
At the general meeting section, the button that downloads the minutes should say "minutes" on the English website
### Steps to reproduce
1. Tell the website to use English
2. Go to /documents/
3. Find the general meeting section
4. See that the button is in dutch.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/617Include email, phone number in Event registrations overview2018-03-28T20:34:41+02:00Thom WiggersInclude email, phone number in Event registrations overview### One-sentence description
Currently, you can get this information through the export. It'd be convenient to also have an email link, and a phone number.
### Desired behaviour
![image](/uploads/4252264171ada10f3f95c1e3f0591d57/image...### One-sentence description
Currently, you can get this information through the export. It'd be convenient to also have an email link, and a phone number.
### Desired behaviour
![image](/uploads/4252264171ada10f3f95c1e3f0591d57/image.png)
Don't display everything inline, because a) it makes the tables unwieldy, and b) it may result in data leaks.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/616Sort cancellations by cancel date2018-03-28T19:48:00+02:00Thom WiggersSort cancellations by cancel date### One-sentence description
They're currently sorted by registration date, but that's not really relevant.
![image](/uploads/9a956360e09423d16ab2175df9450949/image.png)
### Desired behaviour
Sort by cancellation date### One-sentence description
They're currently sorted by registration date, but that's not really relevant.
![image](/uploads/9a956360e09423d16ab2175df9450949/image.png)
### Desired behaviour
Sort by cancellation dateThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/615No max length for user description.2018-03-21T20:25:21+01:00Jelte SmitsNo max length for user description.### One-sentence description
There is no maximum length for the user description
### Current behaviour
No error is given when making the user description insanely long
### Expected behaviour
It should give an error when trying to make ...### One-sentence description
There is no maximum length for the user description
### Current behaviour
No error is given when making the user description insanely long
### Expected behaviour
It should give an error when trying to make a user description with more than *x* characters.
### Steps to reproduce
Just try itThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/613Build Docker container in CI2018-04-05T17:24:09+02:00Thom WiggersBuild Docker container in CI### One-sentence description
Build docker for Thalia in CI
### Why?
We now have CI runners that can do it
### Current implementation
We're not doing it
### Desired implementation
Do it.### One-sentence description
Build docker for Thalia in CI
### Why?
We now have CI runners that can do it
### Current implementation
We're not doing it
### Desired implementation
Do it.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/610Uploading GIF as profile image triggers OSError2018-03-19T16:43:48+01:00Sébastiaan VersteegUploading GIF as profile image triggers OSError### One-sentence description
Uploading GIF as profile image triggers OSError
### Current behaviour
Error!
### Expected behaviour
No error.
### Steps to reproduce
1. Go to your profile in the frontend
2. Edit it
3. Upload a GIF as ...### One-sentence description
Uploading GIF as profile image triggers OSError
### Current behaviour
Error!
### Expected behaviour
No error.
### Steps to reproduce
1. Go to your profile in the frontend
2. Edit it
3. Upload a GIF as image
4. CRASH!Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/609Creating an event without specifying time crashes the request2018-03-28T19:48:00+02:00Sébastiaan VersteegCreating an event without specifying time crashes the request### One-sentence description
Creating an event without specifying time crashes the request
### Current behaviour
Crash
### Expected behaviour
Nice error message
### Steps to reproduce
1. Create a new event, only specify the _date_...### One-sentence description
Creating an event without specifying time crashes the request
### Current behaviour
Crash
### Expected behaviour
Nice error message
### Steps to reproduce
1. Create a new event, only specify the _date_ and no _time_ for the start/end of the event.
2. SaveLuko van der MaasLuko van der Maas