concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-11-27T19:49:54+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/945Synchronise activemembers with G Suite2019-11-27T19:49:54+01:00Sébastiaan VersteegSynchronise activemembers with G Suite<!--
You want something new.
-->
### One-sentence description
Synchronise activemembers with G Suite
### Motivation
Because then we can migrate to Google Drive instead of Thalia Cloud.
### Desired functionality
Sync of member e...<!--
You want something new.
-->
### One-sentence description
Synchronise activemembers with G Suite
### Motivation
Because then we can migrate to Google Drive instead of Thalia Cloud.
### Desired functionality
Sync of member email addresses according to the `is_staff` status.
### Suggested implementation
Use signals to find out when users are changed
- They get `is_staff` = create account
- `is_staff` removed = remove account
- username is changed and they are `is_staff` = update accountSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/942Remove utf-8 coding2019-11-06T21:09:27+01:00Jelle Besselingjelle@pingiun.comRemove utf-8 coding<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Some files contain the line `# -*- coding: utf-8 -*-`, but this is not needed
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
In Python 3 the default encoding of source files is utf-8, and editors will auto detect the encoding.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Some files contain the line `# -*- coding: utf-8 -*-`
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Remove all `# -*- coding: utf-8 -*-` lines
<!-- Provide (a) suggestion(s) for how we could approach this -->Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/937Create HTML version of information check email2019-11-13T21:58:58+01:00Sébastiaan VersteegCreate HTML version of information check email### One-sentence description
Create HTML version of information check email
### Motivation
It's formatting in the text version is bad.
### Desired functionality
Have the data nicely formatted.
### Suggested implementation
Use a ta...### One-sentence description
Create HTML version of information check email
### Motivation
It's formatting in the text version is bad.
### Desired functionality
Have the data nicely formatted.
### Suggested implementation
Use a table or something.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/936Suggest registration time at event creation2019-10-24T22:19:23+02:00Jelle Besselingjelle@pingiun.comSuggest registration time at event creation<!--
You want something new.
-->
### One-sentence description
I would like to show event organisers to not open registration at 13:37 but at 12:30.
### Motivation
Event organisers often open registrations at 13:37, but this is a ti...<!--
You want something new.
-->
### One-sentence description
I would like to show event organisers to not open registration at 13:37 but at 12:30.
### Motivation
Event organisers often open registrations at 13:37, but this is a time when many people have lectures, so a suggestion text at this field would help with that.
### Desired functionality
Help text at registration opening time.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
### Suggested implementation
Have a help text at event creation registration time that reads "Prefer opening times at which people don't have lectures, so 12:30 instead of 13:37"
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/933Thalia Pay: Add an option to events for users to mark their registration as p...2019-11-06T19:31:19+01:00Sébastiaan VersteegThalia Pay: Add an option to events for users to mark their registration as paid using direct debit.Subtask of #632, partially blocked by #930.
### One-sentence description
Add an option to events for users to mark their registration as paid using direct debit.
### Motivation
Because we want Thalia Pay (#632).
### Desired function...Subtask of #632, partially blocked by #930.
### One-sentence description
Add an option to events for users to mark their registration as paid using direct debit.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Payment option on the user side.
### Suggested implementation
Have a button on the event page that has the user confirm their payment or redirect to information about direct debits. Also provide the API for the app!Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/930Thalia Pay: Add a direct debit payment method to the payment model2019-11-06T19:31:20+01:00Sébastiaan VersteegThalia Pay: Add a direct debit payment method to the payment modelSubtask of #632
### One-sentence description
Add a direct debit payment method to the payment model
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
The Payment model should have an option to ...Subtask of #632
### One-sentence description
Add a direct debit payment method to the payment model
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
The Payment model should have an option to mark it as paid using direct debit.
### Suggested implementation
Just like the other payment methods.Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/929Not enough room for footer on small screens2019-10-16T19:03:51+02:00Simcha van CollemNot enough room for footer on small screens### One-sentence description
The social icons are only half shown because there is not enough room
### Current behaviour / Reproducing the bug
The footer looks like this when opened on my phone
![IMG_20191002_200711](/uploads/93d59a0e3...### One-sentence description
The social icons are only half shown because there is not enough room
### Current behaviour / Reproducing the bug
The footer looks like this when opened on my phone
![IMG_20191002_200711](/uploads/93d59a0e31c0152ad9fa79186f840361/IMG_20191002_200711.jpg)
### Expected behaviour
The icons should completely showJob DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/926English version of partner profile2019-10-03T16:43:11+02:00Thomas Klein BretelerEnglish version of partner profile### One sentence description
Partner profiles do not have an English description field
### Motivation
Because we're an international association
### Desired functionality
An English description field in the site administration for p...### One sentence description
Partner profiles do not have an English description field
### Motivation
Because we're an international association
### Desired functionality
An English description field in the site administration for partner pages so that we can publish both English and Dutch version of the partners profile.
### Suggested implementation
Just like with the general event forms both an English and Dutch field
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/924Add the real name of members to profiles2019-09-17T12:10:21+02:00Ward TheunisseAdd the real name of members to profiles/label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add.../label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add the real name of members to profiles.
### Suggested implementation
Some text.
27https://gitlab.science.ru.nl/thalia/concrexit/-/issues/922Receive the newsletter in the app2020-02-05T22:31:42+01:00Sébastiaan VersteegReceive the newsletter in the app### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.Mario TsatsevMario Tsatsevhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/914Update placeholder in activemembers2019-10-03T16:37:03+02:00Sébastiaan VersteegUpdate placeholder in activemembers### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we ...### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/913Double occurrence of Society in public profile2019-09-04T13:04:48+02:00Julian van der HorstDouble occurrence of Society in public profile### One-sentence description
In a public profile of a user him/her being in a society shows in achievements and in Societies.
### Current behavior / Reproducing the bug
1. Go to a public profile of a member of a society
2. See that th...### One-sentence description
In a public profile of a user him/her being in a society shows in achievements and in Societies.
### Current behavior / Reproducing the bug
1. Go to a public profile of a member of a society
2. See that the society achievement appears double
### Expected behavior
The occurrence of the society should only be shown once, namely in the societies tabhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/911Add descriptions to mailing lists2019-09-25T21:23:43+02:00Sébastiaan VersteegAdd descriptions to mailing lists### One-sentence description
Descriptions for mailing lists
### Motivation
Because we forget what mailing lists are for and this would help with the administration
### Desired functionality
Description field. REQUIRED (because other...### One-sentence description
Descriptions for mailing lists
### Motivation
Because we forget what mailing lists are for and this would help with the administration
### Desired functionality
Description field. REQUIRED (because otherwise people leave it empty)
### Suggested implementation
A TextArea!Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/879Update fullcalendar to v42019-06-20T14:16:37+02:00Sébastiaan VersteegUpdate fullcalendar to v4### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v3### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v326Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/878Remove 'Set all registered to present and paid'2019-08-28T18:56:23+02:00Sébastiaan VersteegRemove 'Set all registered to present and paid'<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove 'Set all registered to present and paid'
### Why?
1. It's broken
2. It assumes that there is one option for the payment which there is not anymore.
### Current implementation
Some.
### Suggested implementation
None.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/877Remove vacancy expiration mails2020-02-04T14:40:33+01:00Joren VranckenRemove vacancy expiration mails<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Remove vacancy expiration mails.
### Why?
<!-- Please motivate why we should invest into this change -->
The vacancy expiration mails are a bit feature creep. They are not really helpful, because the commissioner of external affairs has their own administration with expiration dates (including the vacancies). Furthermore, the emails also don't help because they arrive either too late or too soon. Some partners have a lot longer negotiating time than one month, while others can be handled within a few days.
Besides that, it is also a bit weird that we are only sending mails about vacancies. What about the partner profiles? Why are we not tracking expiration dates for those?
### Suggested implementation
I suggest we remove this functionality altogether which will result in less code to maintain and less useless emails to be sent.26Sébastiaan VersteegSébastiaan Versteeg