concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-07T19:14:40+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/700Alphabetically order Miscellaneous Association Documents2018-11-07T19:14:40+01:00Sébastiaan VersteegAlphabetically order Miscellaneous Association Documents### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically19Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/697Change mentions of 'supporter' to 'benefactor'2018-10-18T11:31:34+02:00Sébastiaan VersteegChange mentions of 'supporter' to 'benefactor'### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use ...### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use several different names for the 'begunstiger' membership type.
### Desired implementation
Always use 'benefactor' as translation.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/694Replace main photo header by slider2018-10-22T08:52:10+02:00Sébastiaan VersteegReplace main photo header by slider### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/679Make it possible to correct an acception or rejection in registrations2018-10-18T11:30:37+02:00Sébastiaan VersteegMake it possible to correct an acception or rejection in registrations### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to corr...### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to correct this. For example if it was a mistake or if the payment object was not created.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/924Add the real name of members to profiles2019-09-17T12:10:21+02:00Ward TheunisseAdd the real name of members to profiles/label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add.../label ~feature ~"priority: low"
<!--
You want something new.
-->
### One-sentence description
Add the real name of members to profiles
### Motivation
Because you cannot see who someone really is.
### Desired functionality
Add the real name of members to profiles.
### Suggested implementation
Some text.
27https://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/879Update fullcalendar to v42019-06-20T14:16:37+02:00Sébastiaan VersteegUpdate fullcalendar to v4### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v3### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v326Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/877Remove vacancy expiration mails2020-02-04T14:40:33+01:00Joren VranckenRemove vacancy expiration mails<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Remove vacancy expiration mails.
### Why?
<!-- Please motivate why we should invest into this change -->
The vacancy expiration mails are a bit feature creep. They are not really helpful, because the commissioner of external affairs has their own administration with expiration dates (including the vacancies). Furthermore, the emails also don't help because they arrive either too late or too soon. Some partners have a lot longer negotiating time than one month, while others can be handled within a few days.
Besides that, it is also a bit weird that we are only sending mails about vacancies. What about the partner profiles? Why are we not tracking expiration dates for those?
### Suggested implementation
I suggest we remove this functionality altogether which will result in less code to maintain and less useless emails to be sent.26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/869Improve categories2019-08-28T20:01:52+02:00Sébastiaan VersteegImprove categories### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
...### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
- Party
- Other
### Suggested implementation
- Alumni (old: Alumni)
- Education (old: Workshop + Lunch Lecture)
- Career (some workshops should go here, manual intervention)
- Leisure (old: Drinks + Party, now also: paintball + lasertag etc)
- Association Affairs (old: GM, now also: SNIC info meeting, board interest meetings) (Verenigingszaken)
- Other (old: Other + Activity)
Important: this requires migrations to changes the categories of existing events to the new ones!26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/858Log to disk in production2019-04-15T11:01:31+02:00Joren VranckenLog to disk in production### One-sentence description
<!-- What do you want? -->
In production log to `/concrexit/log/django.log`.
### Motivation
<!-- Why should we care? -->
Extra logging.### One-sentence description
<!-- What do you want? -->
In production log to `/concrexit/log/django.log`.
### Motivation
<!-- Why should we care? -->
Extra logging.24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/840Use the payments app to register pizza payments2019-04-17T20:16:34+02:00Sébastiaan VersteegUse the payments app to register pizza payments<!--
You want something new.
-->
### One-sentence description
Use the payments app to register pizza payments
### Motivation
Because of #632
### Desired functionality
Use the payments app to register pizza payments
### Suggest...<!--
You want something new.
-->
### One-sentence description
Use the payments app to register pizza payments
### Motivation
Because of #632
### Desired functionality
Use the payments app to register pizza payments
### Suggested implementation
Save payment in a payment object of the payments app.24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/777Automatic notification after uploading a new photo album2019-05-09T13:08:23+02:00Sébastiaan VersteegAutomatic notification after uploading a new photo album### One-sentence description
Automatic notification after uploading a new photo album
### Motivation
So that people are up-to-date and know when new photos are available.
### Desired functionality
Send a notification to all members ...### One-sentence description
Automatic notification after uploading a new photo album
### Motivation
So that people are up-to-date and know when new photos are available.
### Desired functionality
Send a notification to all members roughly one hour after make the photos available (= uploading+not hidden).24Tobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/775Members are shown according to cohort2019-01-05T19:11:06+01:00Thijs de JongMembers are shown according to cohort<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current wa...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current way of displaying members when you select all members, is by showing them on cohort order, while this should change to alphabetical order.
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
It is more clear when it is sorted on alphabetical order, instead of first sorted on Cohort order and then alphabetical order.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Currently, it is sorted on Cohort order, and then Alphabetical order, when selecting 'all members'.
https://thalia.nu/members/
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
When selecting 'all members', it should be sorted Alphabetically immediately.
<!-- Provide (a) suggestion(s) for how we could approach this -->21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/768Export email addresses of selected members2018-11-14T11:19:22+01:00Sébastiaan VersteegExport email addresses of selected members### One-sentence description
Export email addresses of selected members
### Motivation
So that they can easily be contacted. Normally we would use mailing lists but some people are not part of those (anymore).
### Desired functionali...### One-sentence description
Export email addresses of selected members
### Motivation
So that they can easily be contacted. Normally we would use mailing lists but some people are not part of those (anymore).
### Desired functionality
Have the possibility to export email addresses of users from the admin
### Suggested implementation
Add an action to do this export20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/767Filter for former members2018-11-14T11:15:49+01:00Rico te WechelFilter for former members### One-sentence description
Apply filter on former members in the backend user list.
### Motivation
For the alumni committee, but perhaps in the future also for other parties and/or occasions, this would be a nice feature to easily rea...### One-sentence description
Apply filter on former members in the backend user list.
### Motivation
For the alumni committee, but perhaps in the future also for other parties and/or occasions, this would be a nice feature to easily reach our former members. In case of the alumni committee: We want to email them with invitations for our events.
### Desired functionality
In the backend, under users, I want to be able to apply a filter on former members. Currently this is only possible for members, benefactors and honorary members. After I applied the filter on the users I want to export their mailadresses. I haven't seen this option under 'desired action'. Should I make a new issue for this, or is there another way to achieve this?20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/759Move the events admin views to the admin model2018-11-29T00:04:37+01:00Sébastiaan VersteegMove the events admin views to the admin model### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the a...### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the admin.
### Suggested implementation
Override the url config of the model admin used for events to add our custom views. Just like here: https://docs.djangoproject.com/en/2.1/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_urls20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jong