concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-23T16:30:42+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1019Move business logic of notifications out of models2020-02-23T16:30:42+01:00Sébastiaan VersteegMove business logic of notifications out of models<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Move business logic of notifications out of models
### Why?
Clean up the models
### Current implementation
Code in the models (mostly events)
### Suggested implementation
Use signalsSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1003Create more kinds of fixtures2020-02-19T22:57:03+01:00Job DoesburgCreate more kinds of fixtures<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should b...<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should be created for courses. But also maybe for photos and albums, documents, payments, registrations?, etc...
### Suggested implementationSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/987Make it clear when members are not allowed to go to events2020-02-19T21:47:45+01:00Jelle Besselingjelle@pingiun.comMake it clear when members are not allowed to go to events### One-sentence description
Make it clearer for members when they cannot go to events.
### Motivation
Sometimes members miss the email that tells them they are banned from events (because they forgot to pay their fines). This causes co...### One-sentence description
Make it clearer for members when they cannot go to events.
### Motivation
Sometimes members miss the email that tells them they are banned from events (because they forgot to pay their fines). This causes confusion when they cannot register for events.
### Desired functionality
Better information on the website when registrations are not allowed.
### Suggested implementation
A banner at the top of the site that clearly states when people are banned from something, and to contact the treasurer for more information.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/976Use html email template for all emails we send2020-02-19T21:13:30+01:00Job DoesburgUse html email template for all emails we send### One-sentence description
Use html email template for all emails we send
### Why?
It looks nice
### Current implementation
We only send plaintext mails, except for the information check emails
### Suggested implementation
Use t...### One-sentence description
Use html email template for all emails we send
### Why?
It looks nice
### Current implementation
We only send plaintext mails, except for the information check emails
### Suggested implementation
Use the information check email templatehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/986Automatically send email with G Suite calendar id invite to member on joining...2020-02-19T20:27:12+01:00Job DoesburgAutomatically send email with G Suite calendar id invite to member on joining committee<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -→
Automatically send email with G Suite calendar id invite to member on joining committee
### Motivation
<!-- Why should we care? -->
To prev...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -→
Automatically send email with G Suite calendar id invite to member on joining committee
### Motivation
<!-- Why should we care? -->
To prevent ourselves from explaining this over and over
### Desired functionality
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
If a members joins a committee they will receive an email from Thalia stating 'hey you have joined committee x, fun times, here you also have the calendar stream for this committee'
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
Probably we will need to introduce a field in the active member group model that contains the id for their calendar. And then we can use that one to send an email to the new membershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/970Update to Django 32020-02-19T20:02:34+01:00Joren VranckenUpdate to Django 3### Description
<!-- Please motivate why we should invest into this change -->
Django 3 has been [released](https://docs.djangoproject.com/en/3.0/releases/3.0/).### Description
<!-- Please motivate why we should invest into this change -->
Django 3 has been [released](https://docs.djangoproject.com/en/3.0/releases/3.0/).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/985Add link to the G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenAdd link to the G Suite Knowledge Base<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Add link to the [G Suite Knowledge Base](https://gsuite.members.thalia.nu/) in the "for members" menu.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1012Export payment batch per topic / event2020-02-12T20:42:04+01:00Job DoesburgExport payment batch per topic / event### One-sentence description
Export payment batch per topic / event
### Motivation
Required for bookkeeping of Thalia Pay
### Desired functionality
Use the `payment_topic` from Payments, provided by `Payable` models
### Suggested i...### One-sentence description
Export payment batch per topic / event
### Motivation
Required for bookkeeping of Thalia Pay
### Desired functionality
Use the `payment_topic` from Payments, provided by `Payable` models
### Suggested implementation
Extend #932 with a second way of exportinghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/932Thalia Pay: Export financial information that can be imported to Conscribo2020-02-12T20:41:09+01:00Sébastiaan VersteegThalia Pay: Export financial information that can be imported to Conscribo### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment informati...### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment information that can be imported in Conscribo. We currently have an export option but the use format cannot be used with Conscribo. If we add the format Conscribo wants the work to process direct debits (which might be a lot) will be decreased a lot.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1009Improve tests for Payments app2020-02-12T20:39:44+01:00Luko van der MaasImprove tests for Payments app### One-sentence description
A lot of tests for payments are either not consistent or do some weird stuff.
### Why?
Better tests helps stability### One-sentence description
A lot of tests for payments are either not consistent or do some weird stuff.
### Why?
Better tests helps stabilitySébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/931Thalia Pay: Export payment batches for ING2020-02-12T20:39:14+01:00Sébastiaan VersteegThalia Pay: Export payment batches for INGSubtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the ...Subtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the right format. These batches can be used to execute a direct debit batch.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit (#930).
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/922Receive the newsletter in the app2020-02-05T22:31:42+01:00Sébastiaan VersteegReceive the newsletter in the app### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.Mario TsatsevMario Tsatsevhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1006Miscellaneous annual files on document page2020-02-04T16:04:53+01:00Nick van OersMiscellaneous annual files on document page
<!--
You want something new.
-->
### One-sentence description
The ability to add more yearly files on the document page.
### Motivation
Normally things like the half year report are added as GM documents, but now we want to add ...
<!--
You want something new.
-->
### One-sentence description
The ability to add more yearly files on the document page.
### Motivation
Normally things like the half year report are added as GM documents, but now we want to add yearly documents that are not necessarily discussed at a GM. We want to add a report from the societies on how well everything worked that year, as the society rules state that they should publish this.
<!-- Why should we care? -->
### Desired functionality
A new section underneath the GMs, where miscellaneous or other documents can be added.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
### Suggested implementation
See picture in the comments.
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/877Remove vacancy expiration mails2020-02-04T14:40:33+01:00Joren VranckenRemove vacancy expiration mails<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Remove vacancy expiration mails.
### Why?
<!-- Please motivate why we should invest into this change -->
The vacancy expiration mails are a bit feature creep. They are not really helpful, because the commissioner of external affairs has their own administration with expiration dates (including the vacancies). Furthermore, the emails also don't help because they arrive either too late or too soon. Some partners have a lot longer negotiating time than one month, while others can be handled within a few days.
Besides that, it is also a bit weird that we are only sending mails about vacancies. What about the partner profiles? Why are we not tracking expiration dates for those?
### Suggested implementation
I suggest we remove this functionality altogether which will result in less code to maintain and less useless emails to be sent.26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1007Expiration date on partner pages2020-02-04T14:40:33+01:00Jen Dusseljeejendusseljee@gmail.comExpiration date on partner pages<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Can you add a functionality to set an expiration date on profile pages of partners.
### Motivation
<!-- Why should we care? -->
Because it ...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Can you add a functionality to set an expiration date on profile pages of partners.
### Motivation
<!-- Why should we care? -->
Because it is pretty annoying to have to memorise the duration of all contracts. It would be way easier to just be able to set an expiration date when the contract enters.
### Desired functionality
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
An extra date field in the admin page when editing/creating a partner page. When this date has passed, the profile page should automatically be set to inactive (maybe send a mail to extern@ to let the extern know when this happens).
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
-https://gitlab.science.ru.nl/thalia/concrexit/-/issues/983Update members translations2020-01-29T21:21:15+01:00Joren VranckenUpdate members translations### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/593Warn the organiser when the maximum number of participants of an event is cha...2020-01-29T18:43:19+01:00Lennart JansenWarn the organiser when the maximum number of participants of an event is changed### One-sentence description
https://gitlab.science.ru.nl/thalia/
### Current behaviour
People on the waiting list don't get any notification and thus cannot know that their status changed.
### Expected behaviour
The organiser shoul...### One-sentence description
https://gitlab.science.ru.nl/thalia/
### Current behaviour
People on the waiting list don't get any notification and thus cannot know that their status changed.
### Expected behaviour
The organiser should do a follow-up.
### Steps to reproduce
1. Create an event
2. Enable x registrations
3. Register at least x+1 people
4. Change the number of registrations to x+1
5. See that the person x+1 didn't get an email notificationMario TsatsevMario Tsatsevhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1000Internet required to run tests2020-01-26T22:07:58+01:00Joren VranckenInternet required to run tests### Description
Internet required to run tests, because [`activemembers/signals.py` always initializes the G Suite API](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/signals.py#L15). This is not (and sho...### Description
Internet required to run tests, because [`activemembers/signals.py` always initializes the G Suite API](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/signals.py#L15). This is not (and should not be) always necessary (e.g. when running tests).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/997Review url is not clear from CI logs2020-01-23T19:48:00+01:00Joren VranckenReview url is not clear from CI logs### One-sentence description
Review Host url is not clear from CI logs.
### Current implementation
The username and password are shown to the user, but not the url to the review environment.### One-sentence description
Review Host url is not clear from CI logs.
### Current implementation
The username and password are shown to the user, but not the url to the review environment.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/994Improve messages for exam/summary upload2020-01-21T09:03:42+01:00Sébastiaan VersteegImprove messages for exam/summary upload### One-sentence description
Improve messages for exam/summary upload
### Why?
They're unclear?. It does not say that the exam will be added to the approval queue. And that causes confusion because people often upload the document ag...### One-sentence description
Improve messages for exam/summary upload
### Why?
They're unclear?. It does not say that the exam will be added to the approval queue. And that causes confusion because people often upload the document again.
Edit: I did not get any messages at all.
(Maybe we could even make the approval queue crowd sourced so that everyone can approve documents that are not their own? Although that may not work because you can get money for summaries)