concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-08-28T20:01:52+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/869Improve categories2019-08-28T20:01:52+02:00Sébastiaan VersteegImprove categories### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
...### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
- Party
- Other
### Suggested implementation
- Alumni (old: Alumni)
- Education (old: Workshop + Lunch Lecture)
- Career (some workshops should go here, manual intervention)
- Leisure (old: Drinks + Party, now also: paintball + lasertag etc)
- Association Affairs (old: GM, now also: SNIC info meeting, board interest meetings) (Verenigingszaken)
- Other (old: Other + Activity)
Important: this requires migrations to changes the categories of existing events to the new ones!26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/867Revisit urls schemes2019-10-09T19:02:39+02:00Sébastiaan VersteegRevisit urls schemes### One-sentence description
Revisit urls schemes
### Why?
It's currently a bit messy and not consistent.
### Current implementation
We have one central urls.py for our application in thaliawebsite which decides the namespacing of a...### One-sentence description
Revisit urls schemes
### Why?
It's currently a bit messy and not consistent.
### Current implementation
We have one central urls.py for our application in thaliawebsite which decides the namespacing of all the modules.
### Suggested implementation
The central urls.py only includes the urls.py files of all the packages. These packages are then allowed to fill in their url schemes how they see fit. This allows us to re-use the same namespace in multiple modules and follow the way our menu is structured to decide the full url of a page.
All urls used in the django admin and implemented via the central urls.py (like push notifications and newsletters) should be implemented using the ModelAdmin's `get_urls` method like it was done in registrations and payments.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/866Investigate event saving error2019-05-15T20:44:39+02:00Sébastiaan VersteegInvestigate event saving error### One-sentence description
Something goes wrong during the saving of events.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/380
### Expected behaviour
No Sentry errors### One-sentence description
Something goes wrong during the saving of events.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/380
### Expected behaviour
No Sentry errorshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/863Large events on mobile closes automatically2019-06-26T20:14:06+02:00Joren VranckenLarge events on mobile closes automatically### One-sentence description
<!-- What breaks -->
Large events on mobile closes automatically.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Ste...### One-sentence description
<!-- What breaks -->
Large events on mobile closes automatically.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to [the event page](https://thalia.nu/events).
2. Click on BIT-event.
3. Scroll down to "the go to the evenpage"-button.
4. Observe that the information card closes.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/858Log to disk in production2019-04-15T11:01:31+02:00Joren VranckenLog to disk in production### One-sentence description
<!-- What do you want? -->
In production log to `/concrexit/log/django.log`.
### Motivation
<!-- Why should we care? -->
Extra logging.### One-sentence description
<!-- What do you want? -->
In production log to `/concrexit/log/django.log`.
### Motivation
<!-- Why should we care? -->
Extra logging.24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/857Make end date of board membership more explicit on board page2019-08-28T20:11:23+02:00Job DoesburgMake end date of board membership more explicit on board page### One-sentence description
On a board page of a board where board members changed roles of terminated the board early, that is unclear.
### Current behaviour / Reproducing the bug
Check for example the page of board 17-18. Currentl...### One-sentence description
On a board page of a board where board members changed roles of terminated the board early, that is unclear.
### Current behaviour / Reproducing the bug
Check for example the page of board 17-18. Currently the roles are indicated in the role name ("chair until xxxxxxxx"). Of course you would want it as just "chair" since it otherwise is also weird for achievements.
### Expected behaviour
In case people switched roles or quit early: show all roles including dates, or only the most recent one including dates. If a person quit the board early, it could also be greyed out possibly.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/854Error messaging fix2019-04-10T22:11:45+02:00Bart HofmanError messaging fixWrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hie...Wrong error code when permission denied
### Current behaviour / Reproducing the bug
1. user with only event change permissions
2. Try to change a registration of an event
3. errors "Correct the error below" or "Corrigeer de fouten hieronder"
### Expected behaviour
1. user with only event change permissions
2. Try to change a registration of an event
3. errors specific error message that fits the error23https://gitlab.science.ru.nl/thalia/concrexit/-/issues/851Set restraints on start year at user creation2019-09-18T21:29:48+02:00Bart HofmanSet restraints on start year at user creation### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behav...### One-sentence description
When creating a new user you can set the start year any number you want.
### Current behaviour / Reproducing the bug
As admin "create new user" and set as start year any number you wish
### Expected behaviour
Make a dropdown and be able to only select actually existing cohortsBart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/850Dataminimisation deletes website profile2019-10-03T16:37:53+02:00Luko van der MaasDataminimisation deletes website profile
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removed
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removedLuna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/849Banner Dimensions Not in Styleguide2019-04-10T20:32:05+02:00Thijs de JongBanner Dimensions Not in Styleguide### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.### One-sentence description
### Current behaviour
The banner dimensions are not shown at the current page of the styleguide.
### Expected behaviour
Implement the banner dimensions on the styleguide page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/842Mailing lists api fails without boards2019-10-03T17:23:45+02:00Joren VranckenMailing lists api fails without boards### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/### One-sentence description
<!-- What breaks -->
Mailing lists api fails without boards.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit-beta/issues/449/Wouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/840Use the payments app to register pizza payments2019-04-17T20:16:34+02:00Sébastiaan VersteegUse the payments app to register pizza payments<!--
You want something new.
-->
### One-sentence description
Use the payments app to register pizza payments
### Motivation
Because of #632
### Desired functionality
Use the payments app to register pizza payments
### Suggest...<!--
You want something new.
-->
### One-sentence description
Use the payments app to register pizza payments
### Motivation
Because of #632
### Desired functionality
Use the payments app to register pizza payments
### Suggested implementation
Save payment in a payment object of the payments app.24Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/837Select all event participants for push notifications2019-05-22T20:50:30+02:00Job DoesburgSelect all event participants for push notifications### One-sentence description
Easily send a push notification to everyone registered for an event.
### Motivation
We don't want to bother every person with each push notification. But we do sometimes want to send a push notification ...### One-sentence description
Easily send a push notification to everyone registered for an event.
### Motivation
We don't want to bother every person with each push notification. But we do sometimes want to send a push notification to members about a certain event (such as change of location). But selecting all members by hand is not ideal either.
### Desired functionality
The ability to send a push notification to everyone registered for an event.
### Suggested implementation
Either the possibility to make event-specific push notifications (and maybe even give the event organizer permissions to send those).
But the easier way would probably be some new selection filter thingy when adding users to a message, where you can filter on participants for a specific event.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/836Show which members are organizing an event2019-04-12T18:42:12+02:00Joren VranckenShow which members are organizing an event<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
(Optionally) show which members are organizing an event.
### Motivation
<!-- Why should we care? -->
It is not always clear which specific...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
(Optionally) show which members are organizing an event.
### Motivation
<!-- Why should we care? -->
It is not always clear which specific members of a committee (or the board) are organising an event. When people need to contact the organisers they first need to ask around who is actually organising the event. That is why it would be better to have it on the page itself.Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/835Use correct language attribute in html tag2019-03-27T19:18:56+01:00Jelle Besselingjelle@pingiun.comUse correct language attribute in html tag<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The `lang` attribute of the root html element is hardcoded to "en", this can be set to the LANGUAGE_CODE
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
The [specification recommends it](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Specifications).
<!-- Please motivate why we should invest into this change -->
### Current implementation
The value is hardcoded to `"en"`
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Set the lang attribute to the current language code
<!-- Provide (a) suggestion(s) for how we could approach this -->Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/834Photo albums not greyed out when outside membership period2019-03-27T19:18:01+01:00Sébastiaan VersteegPhoto albums not greyed out when outside membership period### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos pa...### One-sentence description
Photo albums not greyed out when outside membership periode
### Current behaviour / Reproducing the bug
1. Create a user with a membership that has a start and end date before today.
2. Go to the photos package.
3. All albums are in colours
### Expected behaviour
The albums that the user cannot access should be grayscale.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/833Replace custom validate_file_extension with built-in FileExtensionValidator2019-03-27T20:30:47+01:00Joren VranckenReplace custom validate_file_extension with built-in FileExtensionValidator<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Replace custom `validate_file_extension` with built-in [`FileExtensionValidator`](https://docs.djangoproject.com/en/2.1/ref/validators/#fileextensionvalidator).
### Why?
<!-- Please motivate why we should invest into this change -->
Less custom code to maintain.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/831Run collectstatic, migrate and compress in entrypoint2019-02-22T17:20:30+01:00Joren VranckenRun collectstatic, migrate and compress in entrypoint<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Run `collectstatic`, `migrate` and `compress` in the Docker entrypoints.
### Why?
<!-- Please motivate why we should invest into this change -->
At the moment they need to be run manually. In #serverconfig we have a bit of [a hacky script](https://gitlab.science.ru.nl/thalia/serverconfig/blob/master/roles/concrexit/templates/migrate.sh.j2) that runs the (using a none production entrypoint) commands.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/830Add committee chair group to NextCloud API2019-02-17T14:54:46+01:00Sébastiaan VersteegAdd committee chair group to NextCloud API<!--
You want something new.
-->
### One-sentence description
Add committee chair group to NextCloud API
### Motivation
So that there can be a shared folder for committee chairs for cvo minutes etc.
### Desired functionality
Extr...<!--
You want something new.
-->
### One-sentence description
Add committee chair group to NextCloud API
### Motivation
So that there can be a shared folder for committee chairs for cvo minutes etc.
### Desired functionality
Extra automatic group
### Suggested implementation
Like boards and adminsSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/828Committee/Society Names on Profile Page Should be Clickable2019-02-13T21:24:43+01:00Thijs de JongCommittee/Society Names on Profile Page Should be Clickable### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievem...### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievements for Thalia. At this moment, if you click on the committees/societies, nothing happens.
### Expected behaviour
When you click on a committee/society underneath the Achievements for Thalia, it sends you to the Page of the corresponding committee/society.