concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-11-27T19:49:54+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/945Synchronise activemembers with G Suite2019-11-27T19:49:54+01:00Sébastiaan VersteegSynchronise activemembers with G Suite<!--
You want something new.
-->
### One-sentence description
Synchronise activemembers with G Suite
### Motivation
Because then we can migrate to Google Drive instead of Thalia Cloud.
### Desired functionality
Sync of member e...<!--
You want something new.
-->
### One-sentence description
Synchronise activemembers with G Suite
### Motivation
Because then we can migrate to Google Drive instead of Thalia Cloud.
### Desired functionality
Sync of member email addresses according to the `is_staff` status.
### Suggested implementation
Use signals to find out when users are changed
- They get `is_staff` = create account
- `is_staff` removed = remove account
- username is changed and they are `is_staff` = update accountSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/944Thalia Pay: also enable late-cancellation fines to happen with Thalia Pay2019-11-27T17:00:39+01:00Job DoesburgThalia Pay: also enable late-cancellation fines to happen with Thalia Pay### One-sentence description
Also enable late-cancellation fines to happen with Thalia Pay
### Motivation
Because it is weird to do let this happen via invoices if people normally can pay with Thalia Pay
### Desired functionality
Cu...### One-sentence description
Also enable late-cancellation fines to happen with Thalia Pay
### Motivation
Because it is weird to do let this happen via invoices if people normally can pay with Thalia Pay
### Desired functionality
Currently if somebody wants has said to pay with Thalia Pay, but cancels, we delete the payment.
After the event, the treasurer should be able to determine the real amount of the fine and have some action available to add TPAY payments for everyone that was too late and deserves a fine (now we will probably need to reopen #821 heheheheh)
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/943Thalia Pay: Only allow revocation of mandates if all payments were processed2020-03-09T17:59:50+01:00Job DoesburgThalia Pay: Only allow revocation of mandates if all payments were processed### One-sentence description
Only allow revocation of mandates if all Thalia Pay payments were processed (the batch were all payments are in should be processed)
### Motivation
Because legally from the moment a mandate is revoked, we ...### One-sentence description
Only allow revocation of mandates if all Thalia Pay payments were processed (the batch were all payments are in should be processed)
### Motivation
Because legally from the moment a mandate is revoked, we cannot use it anymore. And users of course cannot revoke their mandate if they still have open amounts (or actually they can, but then the treasurer should be notified of this and discuss with that person he/she should pay another way - I suggest we do not add that flow in the website).
### Desired functionality
When a user tries to revoke a mandate, but there are still Thalia Pay payments in batches that are not fully processed yet, the user should receive a message that he/she should contact the board by email to revoke the mandate because there are still open amounts to be paid.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/942Remove utf-8 coding2019-11-06T21:09:27+01:00Jelle Besselingjelle@pingiun.comRemove utf-8 coding<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Some files contain the line `# -*- coding: utf-8 -*-`, but this is not needed
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
In Python 3 the default encoding of source files is utf-8, and editors will auto detect the encoding.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Some files contain the line `# -*- coding: utf-8 -*-`
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Remove all `# -*- coding: utf-8 -*-` lines
<!-- Provide (a) suggestion(s) for how we could approach this -->Luna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/939Thalia Pay: Add an option to membership renewals to pay with Thalia Pay2020-03-12T00:18:27+01:00Job DoesburgThalia Pay: Add an option to membership renewals to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals to pay with Thalia Pay
### Motivation
Because everyone wants to pay their contribution remotely via Thalia Pay and not come to a ...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals to pay with Thalia Pay
### Motivation
Because everyone wants to pay their contribution remotely via Thalia Pay and not come to a bbq
### Desired functionality
Just a 'Pay with Thalia Pay' button while requesting membership renewal (if a bank account is added, otherwise show a message that if they do add a bank account they can pay with Thalia Pay).
### Suggested implementationJob DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/938Thalia Pay: Add an option to membership registrations to pay with Thalia Pay2019-11-27T17:01:11+01:00Job DoesburgThalia Pay: Add an option to membership registrations to pay with Thalia Pay<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functiona...<!--
You want something new.
-->
### One-sentence description
Add an option to membership renewals and registrations to pay with Thalia Pay
### Motivation
Everyone wants to do this via Thalia Pay remotely!
### Desired functionality
During registration (or after registration is approved, which is easier to build but less user friendly) people should have the possibility to immediately add a bank account and select payment via Thalia Pay.
### Suggested implementationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/937Create HTML version of information check email2019-11-13T21:58:58+01:00Sébastiaan VersteegCreate HTML version of information check email### One-sentence description
Create HTML version of information check email
### Motivation
It's formatting in the text version is bad.
### Desired functionality
Have the data nicely formatted.
### Suggested implementation
Use a ta...### One-sentence description
Create HTML version of information check email
### Motivation
It's formatting in the text version is bad.
### Desired functionality
Have the data nicely formatted.
### Suggested implementation
Use a table or something.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/936Suggest registration time at event creation2019-10-24T22:19:23+02:00Jelle Besselingjelle@pingiun.comSuggest registration time at event creation<!--
You want something new.
-->
### One-sentence description
I would like to show event organisers to not open registration at 13:37 but at 12:30.
### Motivation
Event organisers often open registrations at 13:37, but this is a ti...<!--
You want something new.
-->
### One-sentence description
I would like to show event organisers to not open registration at 13:37 but at 12:30.
### Motivation
Event organisers often open registrations at 13:37, but this is a time when many people have lectures, so a suggestion text at this field would help with that.
### Desired functionality
Help text at registration opening time.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
### Suggested implementation
Have a help text at event creation registration time that reads "Prefer opening times at which people don't have lectures, so 12:30 instead of 13:37"
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/933Thalia Pay: Add an option to events for users to mark their registration as p...2019-11-06T19:31:19+01:00Sébastiaan VersteegThalia Pay: Add an option to events for users to mark their registration as paid using direct debit.Subtask of #632, partially blocked by #930.
### One-sentence description
Add an option to events for users to mark their registration as paid using direct debit.
### Motivation
Because we want Thalia Pay (#632).
### Desired function...Subtask of #632, partially blocked by #930.
### One-sentence description
Add an option to events for users to mark their registration as paid using direct debit.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Payment option on the user side.
### Suggested implementation
Have a button on the event page that has the user confirm their payment or redirect to information about direct debits. Also provide the API for the app!Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/932Thalia Pay: Export financial information that can be imported to Conscribo2020-02-12T20:41:09+01:00Sébastiaan VersteegThalia Pay: Export financial information that can be imported to Conscribo### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment informati...### One-sentence description
Export financial information that can be imported to Conscribo
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
Have an option to export financial payment information that can be imported in Conscribo. We currently have an export option but the use format cannot be used with Conscribo. If we add the format Conscribo wants the work to process direct debits (which might be a lot) will be decreased a lot.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/931Thalia Pay: Export payment batches for ING2020-02-12T20:39:14+01:00Sébastiaan VersteegThalia Pay: Export payment batches for INGSubtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the ...Subtask of #632, partially blocked by #930.
### One-sentence description
Export payment batches for ING for #632.
### Motivation
Because we want Thalia Pay (#632).
### Desired functionality
Export option for payment batches in the right format. These batches can be used to execute a direct debit batch.
### Suggested implementation
- Need to determine the format with the treasurer.
- We can do this by adding extra payment actions to the ~payments admin that only exports payments marked for direct-debit (#930).
- The selection for which time the payments are exported can already be selected using Django's built-in date filter.
- The mandate 'last used' field should be updated upon export of the payments.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/930Thalia Pay: Add a direct debit payment method to the payment model2019-11-06T19:31:20+01:00Sébastiaan VersteegThalia Pay: Add a direct debit payment method to the payment modelSubtask of #632
### One-sentence description
Add a direct debit payment method to the payment model
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
The Payment model should have an option to ...Subtask of #632
### One-sentence description
Add a direct debit payment method to the payment model
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
The Payment model should have an option to mark it as paid using direct debit.
### Suggested implementation
Just like the other payment methods.Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/926English version of partner profile2019-10-03T16:43:11+02:00Thomas Klein BretelerEnglish version of partner profile### One sentence description
Partner profiles do not have an English description field
### Motivation
Because we're an international association
### Desired functionality
An English description field in the site administration for p...### One sentence description
Partner profiles do not have an English description field
### Motivation
Because we're an international association
### Desired functionality
An English description field in the site administration for partner pages so that we can publish both English and Dutch version of the partners profile.
### Suggested implementation
Just like with the general event forms both an English and Dutch field
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/922Receive the newsletter in the app2020-02-05T22:31:42+01:00Sébastiaan VersteegReceive the newsletter in the app### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.Mario TsatsevMario Tsatsevhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/920Guest registration for events2019-10-30T22:17:14+01:00Thomas Klein BretelerGuest registration for events<!--
You want something new.
-->
### One-sentence description
Guest registration for events
### Motivation
Workshops have bad visitor numbers. So as solution we have asked the R&VO (R&BO) coordinator to invite non-Thalia members....<!--
You want something new.
-->
### One-sentence description
Guest registration for events
### Motivation
Workshops have bad visitor numbers. So as solution we have asked the R&VO (R&BO) coordinator to invite non-Thalia members. There is however no easy way for them to register.
### Desired functionality
Add an option to make non-member registration possible.
### Suggested implementation
Create a form that creates a non-member registration for someone with an email confirmation.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/914Update placeholder in activemembers2019-10-03T16:37:03+02:00Sébastiaan VersteegUpdate placeholder in activemembers### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we ...### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/913Double occurrence of Society in public profile2019-09-04T13:04:48+02:00Julian van der HorstDouble occurrence of Society in public profile### One-sentence description
In a public profile of a user him/her being in a society shows in achievements and in Societies.
### Current behavior / Reproducing the bug
1. Go to a public profile of a member of a society
2. See that th...### One-sentence description
In a public profile of a user him/her being in a society shows in achievements and in Societies.
### Current behavior / Reproducing the bug
1. Go to a public profile of a member of a society
2. See that the society achievement appears double
### Expected behavior
The occurrence of the society should only be shown once, namely in the societies tabhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeg