concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-10-23T21:40:59+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/821Ability to mark too-late unregistration as 'valid reason'2019-10-23T21:40:59+02:00Job DoesburgAbility to mark too-late unregistration as 'valid reason'<!--
You want something new.
-->
### One-sentence description
The ability to mark too-late unregistration as 'valid reason'
### Motivation
Currently there is a separate sheet where we register the fines for absence at activities...<!--
You want something new.
-->
### One-sentence description
The ability to mark too-late unregistration as 'valid reason'
### Motivation
Currently there is a separate sheet where we register the fines for absence at activities or unregistering after the deadline. Sometimes people have a valid reason for this. It would be nice to mark this on the website as well, so a separate administration is unnecessary.
### Desired functionality
For people that unregistered too late or were not present during an activity, it should be able to mark their absence as 'valid reason'.
### Suggested implementation
A checkbox or something?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/820Event specific banner/slides2019-11-20T22:07:14+01:00Job DoesburgEvent specific banner/slides<!--
You want something new.
-->
### One-sentence description
Event specific banner/slides.
### Motivation
It is awesome and the standaard images get boring
### Desired functionality
For an event it should be possible to add a s...<!--
You want something new.
-->
### One-sentence description
Event specific banner/slides.
### Motivation
It is awesome and the standaard images get boring
### Desired functionality
For an event it should be possible to add a slide, just as now possible for the front page. If the slide is added for an event, it might also be nice to automatically show it on the front page
### Suggested implementation
Something like documents per event, but for slides I guess.
I honestly have no idea how much work it is but it seems niceLuc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/818Remove SECRET_KEY from production.py2019-02-07T16:26:12+01:00Jelle Besselingjelle@pingiun.comRemove SECRET_KEY from production.py<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove defaul...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove default SECRET_KEY value from production.py settings
### Why?
The SECRET_KEY should always be set in production.py, so it is a better idea to crash when it isn't set, than to use a default nonsecure key.
### Current implementation
A default key is set in production.py. (https://gitlab.science.ru.nl/thalia/concrexit/blob/23b79eb4461ac082a94d7a0c4318c0a848743c67/website/thaliawebsite/settings/production.py#L29)
### Suggested implementation
```python
SECRET_KEY = os.environ.get('DJANGO_SECRET')
```
or, the following, which throws an IndexError when the key isn't present
```python
SECRET_KEY = os.environ.environ['DJANGO_SECRET']
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/817Add shoe size2019-02-06T19:24:18+01:00Tobias van der WerffAdd shoe size<!--
You want something new.
-->
### One-sentence description
Add shoe size to user profiles
### Desired behaviour
We would like to know the shoe size of our members so that we can reserve shoes at the bowling alley and skiing re...<!--
You want something new.
-->
### One-sentence description
Add shoe size to user profiles
### Desired behaviour
We would like to know the shoe size of our members so that we can reserve shoes at the bowling alley and skiing resort without asking for the same information each year.
However, the sizes should be restricted to values between 39 and 47, since there are no smaller/larger shoes at those places. Since not everyone might have a size in this range the field can be empty.
We want to edit the field on the member edit page in the admin and show the shoe size on the public user profiles.
### Suggested implementation
New fieldTobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/815Export registrations to csv2019-02-15T11:09:48+01:00Job DoesburgExport registrations to csv<!--
You want something new.
-->
### One-sentence description
Export of registrations to csv (the registrations of members for Thalia)
### Motivation
To check Thalia's bookkeeping with the Thalia administration it would be nice t...<!--
You want something new.
-->
### One-sentence description
Export of registrations to csv (the registrations of members for Thalia)
### Motivation
To check Thalia's bookkeeping with the Thalia administration it would be nice to export the registrations.
### Desired functionality
The csv should contain at least: name of the person, type of membership/registration, amount, date of payment, payment method.
This way it is possible to compare the cash register or bank transactions to the registrations at the website.
This is also related to a third payment option (#813).
### Suggested implementation
Just as for the users (where one can download .csv's), a button 'download registrations'.Sébastiaan VersteegSébastiaan Versteeg2019-02-13https://gitlab.science.ru.nl/thalia/concrexit/-/issues/813'Wire transfer' as third payment option for admins2019-02-06T20:39:16+01:00Job Doesburg'Wire transfer' as third payment option for admins<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
A third payme...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
A third payment option 'other' only for admins
### Why?
Sometimes things are not being paid in cash nor pin/debit card. It occurs that people pay via wire transfer of something is settled (? google translate says this is the word, verrekenen) with something else or just something else financially interesting happens. This happens often for benefactors (with wire transfers) but occasionally with events too (when people do not pay at the activity but upfront). For clarity it would be nice to be able to register this correctly in the Thalia website. It is especially useful to check the bookkeeping because the 'other' payments are interesting.
Because only the board should do these kind of payments, this option should only be available for people with board permissions.
### Current implementation
There are 2 options for payments.
### Suggested implementation
A third option for payments, that can only be used by board members.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/811Add field for BIC values of bank accounts2019-01-25T13:07:56+01:00Sébastiaan VersteegAdd field for BIC values of bank accounts<!--
You want something new.
-->
### One-sentence description
Add field for BIC values of bank accounts
### Motivation
International students may want to use foreign bank accounts
### Desired functionality
Add field for BIC val...<!--
You want something new.
-->
### One-sentence description
Add field for BIC values of bank accounts
### Motivation
International students may want to use foreign bank accounts
### Desired functionality
Add field for BIC values of bank accounts
### Suggested implementation
Just a non-required fieldhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/808Switching language redirects to calendar of current week2019-06-20T14:16:36+02:00Joren VranckenSwitching language redirects to calendar of current week### One-sentence description
<!-- What breaks -->
Because the calendar date is set by using an anchor (`#`), switching the language redirects to the events page without the date.
### Current behaviour / Reproducing the bug
<!-- Pleas...### One-sentence description
<!-- What breaks -->
Because the calendar date is set by using an anchor (`#`), switching the language redirects to the events page without the date.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to the [calendar](https://thalia.nu/events/).
2. Observe the calendar is on the current week.
2. Go to a specific week.
3. Switch language.
4. Redirect to current week (this may redirect to the homepage if #806 is not fixed yet).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
When switching the language, the calendar does not reset to the current week.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/799Weird text in email after moving from waiting list after unregistration deadl...2019-01-05T19:09:56+01:00Job DoesburgWeird text in email after moving from waiting list after unregistration deadline has passed.<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Members recei...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Members receive a weird email when they move from the waiting list when someone unregistered after the deadline
### Why?
Currently people receive a text saying that if they want, they can unregister via the website until some moment in the past. This is weird. It would be nice to say that 'the unregistration deadline has passed. However if you're not able to come, please contact somebody from the committee or the board asap'.
### Current implementation
An email is sent to people moving from the waiting list, saying that if they want they can unregister until a moment in the past
### Suggested implementation
After the unregistration deadline has passed, mention that they should contact the organizing committee or board.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/798latest docker tag is not a stable build2018-12-14T16:43:03+01:00Joren Vranckenlatest docker tag is not a stable build<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
The `latest` docker tag should be a stable build.
### Why?
<!-- Please motivate why we should invest into this change -->
The `latest` docker tag is the last pushed commit to any MR. It is better if `latest` is the last stable build (last git tag).
### Current implementation
<!-- If relevant, describe how it's done currently -->
The `latest` docker tag is the last pushed commit.
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->
Only push to `latest` if a git tag is build.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/796Add date search for photo albums2018-12-12T22:17:38+01:00Sébastiaan VersteegAdd date search for photo albums### One-sentence description
Add date search for photo albums
### Motivation
Make it easy to search for photos on a certain day
### Desired functionality
Make it possible to search for date### One-sentence description
Add date search for photo albums
### Motivation
Make it easy to search for photos on a certain day
### Desired functionality
Make it possible to search for datehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/790Conscribo sync Thalia members2019-01-23T21:11:16+01:00Job DoesburgConscribo sync Thalia members<!--
You want something new.
-->
### One-sentence description
Synchronise Thalia members (and benefactors and honorary members) with Conscribo relation management.
### Motivation
Now when sending an invoice to a member, we must c...<!--
You want something new.
-->
### One-sentence description
Synchronise Thalia members (and benefactors and honorary members) with Conscribo relation management.
### Motivation
Now when sending an invoice to a member, we must check whether the email-address and other data is still up to date in Conscribo and for new members we must copy everything by hand to Conscribo. Conscribo has an (somewhat limited but existing) API for this purpose.
Since the wallet-issue is a long-term thing, it might be nice to implement this part of synchronization already.
### Desired functionality
In Conscribo I can add a relation-group type "Member" and add all desirable fields to it. This would include: name, email, address and maybe bank account things (sepa mandates possibly as well, but not really important since hardly anyone uses it and it is administered by hand anyway currently).
Conscribo, according to their awesome documentation, then updates or adds that contact. Then in Conscribo I can add reimbursements or invoices to all members without copying data by hand, and have them up-to-date always.
### Suggested implementation
Every now and then (every night? every week? every update?) the thalia server contacts Conscribo and sends edited members.
For privacy, we do have a data processing agreement with Conscribo. Removing members from Conscribo is also possible, except for when they have invoices linked to them; then you can only archive them. However since then that member is part of the financial administration of Thalia, this is not a real problem privacy wise.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/784No Registration Needed Text is in English2018-11-28T21:02:16+01:00Thijs de JongNo Registration Needed Text is in English### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there ...### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there is no registration (NL), it says the default message in English, where it should be Dutch.
<!-- Please write what is happening and how we could reproduce it, if relevant -->
### Expected behaviour
The given text should be in Dutch.
<!-- Please write how what happened did not meet your expectations -->Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/781Page Alignment incorrect2018-11-21T19:32:57+01:00Thijs de JongPage Alignment incorrect### One-sentence description
The bottom does not reach the bottom of the screen at some pages.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
When, for instance, on this page;https://thalia.nu/education/courses/72/
You...### One-sentence description
The bottom does not reach the bottom of the screen at some pages.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
When, for instance, on this page;https://thalia.nu/education/courses/72/
You can see that the purple block at the bottom does not reach the bottom of your screen (unless your screen is smaller)
![Page_Alignment](/uploads/dffd9dc6bfc82d46aa23e960b6f3d268/Page_Alignment.png)
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
### Expected behaviour
For the purple block to touch the lower bound of the screen.
<!-- Please write how what happened did not meet your expectations -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/777Automatic notification after uploading a new photo album2019-05-09T13:08:23+02:00Sébastiaan VersteegAutomatic notification after uploading a new photo album### One-sentence description
Automatic notification after uploading a new photo album
### Motivation
So that people are up-to-date and know when new photos are available.
### Desired functionality
Send a notification to all members ...### One-sentence description
Automatic notification after uploading a new photo album
### Motivation
So that people are up-to-date and know when new photos are available.
### Desired functionality
Send a notification to all members roughly one hour after make the photos available (= uploading+not hidden).24Tobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/776Automatic notification before end of pizza ordering2019-01-17T13:09:05+01:00Sébastiaan VersteegAutomatic notification before end of pizza ordering### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left ...### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left to order your pizzas. If the pizza event is attached to an event with registrations only registered members will get the notification, instead of everyone.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/775Members are shown according to cohort2019-01-05T19:11:06+01:00Thijs de JongMembers are shown according to cohort<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current wa...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current way of displaying members when you select all members, is by showing them on cohort order, while this should change to alphabetical order.
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
It is more clear when it is sorted on alphabetical order, instead of first sorted on Cohort order and then alphabetical order.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Currently, it is sorted on Cohort order, and then Alphabetical order, when selecting 'all members'.
https://thalia.nu/members/
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
When selecting 'all members', it should be sorted Alphabetically immediately.
<!-- Provide (a) suggestion(s) for how we could approach this -->21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/772Adding photo albums or flavour text to alumni page2019-09-12T07:51:28+02:00Thom WiggersAdding photo albums or flavour text to alumni pageThe following discussion from !1055 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/1055#note_59971): (+3 comments)
> This doesn't contain the photo album th...The following discussion from !1055 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/1055#note_59971): (+3 comments)
> This doesn't contain the photo album that the committee wanted to show here. What are we going to do about that?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/769One automatically mailinglist for all old boards2018-11-12T12:53:40+01:00Joren VranckenOne automatically mailinglist for all old boards<!--
You want something new.
-->
Iris does not have access to Gitlab. She asked me to submit this issue.
### One-sentence description
<!-- What do you want? -->
Automatically generated mailinglist for all old boards.
### Motivati...<!--
You want something new.
-->
Iris does not have access to Gitlab. She asked me to submit this issue.
### One-sentence description
<!-- What do you want? -->
Automatically generated mailinglist for all old boards.
### Motivation
If the board needs to reach every old board, they need to send an email to many mailinglists. If there was one mailinglist, that task would be easier and less error-prone. It would be great if this list is generated automatically.
<!-- Why should we care? -->
### Suggested implementation
Automatically add a moderated archived mailinglist, like `activemembers`.
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/768Export email addresses of selected members2018-11-14T11:19:22+01:00Sébastiaan VersteegExport email addresses of selected members### One-sentence description
Export email addresses of selected members
### Motivation
So that they can easily be contacted. Normally we would use mailing lists but some people are not part of those (anymore).
### Desired functionali...### One-sentence description
Export email addresses of selected members
### Motivation
So that they can easily be contacted. Normally we would use mailing lists but some people are not part of those (anymore).
### Desired functionality
Have the possibility to export email addresses of users from the admin
### Suggested implementation
Add an action to do this export20Sébastiaan VersteegSébastiaan Versteeg